My EA Gift to Traders | Page 42 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #821
  • Edited Mar 13, 2015 2:32am Mar 12, 2015 6:36pm | Edited Mar 13, 2015 2:32am
Quoting nobby911
Hi Dave From what i have found out it appears that you enter the spread in points as in 20 for 2 pips etc . Strategy Tester as of MT4 build 509 now enables you to fix the spread by setting the value in points in the small Spread: field on the right just above Optimization. 25 points as an example means 2.5 pips. also if the data used is exported to MT4 using Tickstory (dukascopy data) the spread is set at the point of export and to change it you need to use the tickstory tool MT4 data editor. I wondered why changing the spread in MT4 wasn't making...
Yes you are correct in saying that the MT4 setting for manual spread of 2 pips should be 20. I did some back testing based on Broker spread and nominated spread and confirmed this. This will make a difference in back testing where tick data has not been imported and the broker spread is not available such as over weekends.
  • #822
  • Edited 5:47pm Mar 13, 2015 5:32pm | Edited 5:47pm
Quoting Dave_C
{quote} Insert this line at 1058 and recompile PrevPrice = 0;
Hi Dave,

Volume is working now - many thanks.

Please note, though, that I had to make a small additional edit to your code to make the volume filter work correctly for bearish candles. I changed process sell volume from this:

//+------------------------------------------------------------------+
//| Process Sell Volume |
//+------------------------------------------------------------------+
void ProcessSellVolume()
{
if (Close[1] < Close[2] && Volume[1] < Volume[2] && CurrPrice != PrevPrice)
{
SellVolumeReturnValue = 1;
PrevPrice = CurrPrice;
}
}

To this:


//+------------------------------------------------------------------+
//| Process Sell Volume |
//+------------------------------------------------------------------+
void ProcessSellVolume()
{
if (Close[1] < Close[2] && Volume[1] > Volume[2] && CurrPrice != PrevPrice)
{
SellVolumeReturnValue = 1;
PrevPrice = CurrPrice;
}
}

Regards,
drofwarc
  • #823
  • Mar 13, 2015 5:52pm Mar 13, 2015 5:52pm
Quoting drofwarc
{quote} Hi Dave, Volume is working now - many thanks. Please note, though, that I had to make a small additional edit to your code to make the volume filter work correctly for bearish candles. I changed process sell volume from this: //+------------------------------------------------------------------+ //| Process Sell Volume | //+------------------------------------------------------------------+ void ProcessSellVolume() { if (Close[1] < Close[2] && Volume[1] < Volume[2] && CurrPrice != PrevPrice) { SellVolumeReturnValue = 1; PrevPrice = CurrPrice;...
Yes I see your point. Will do a general update on Monday. Following some other ideas over the weekend.

In fact I'm enclosing an update now as I'd like anybody to comment on the Bollinger Bands which I had also to make a small change to and on back testing, particularly optimising the BBPeriod=20 from 10 to 30 step 1 and the BBDeviations=2 optimising from 1 to 4 step .1, I am getting some great results on the 60 min chart.
Attached File(s)
File Type: ex4 TradersGift_update.ex4   149 KB | 245 downloads
File Type: mq4 TradersGift_update.mq4   101 KB | 359 downloads
  • #824
  • Mar 13, 2015 6:15pm Mar 13, 2015 6:15pm
Disappointing end to the week for Traders Concept.

Week1 (+- 100) - breakeven
Week2 (+- 150) - minus 150 (Mon +150, Tue +150, Wed -150, Thu -150, Fri -150)

Next week I propose +-200 and the following week trade continuously.

I'm concerned that in closing all trades out each day at the target, continuity is being lost and on each subsequent day new setups have to be established. Also on most days the result has been established before the end of the Asian trading day.

Do you think it is more appropriate to try for +-300 or possibly just allow the 21 EA's to trade continuously from next week given good results of 2 of the 3 included strategies?
  • #825
  • Mar 13, 2015 7:28pm Mar 13, 2015 7:28pm
Quoting Dave_C
Disappointing end to the week for Traders Concept. Week1 (+- 100) - breakeven Week2 (+- 150) - minus 150 (Mon +150, Tue +150, Wed -150, Thu -150, Fri -150) Next week I propose +-200 and the following week trade continuously. I'm concerned that in closing all trades out each day at the target, continuity is being lost and on each subsequent day new setups have to be established. Also on most days the result has been established before the end of the Asian trading day. Do you think it is more appropriate to try for +-300 or possibly just allow the...
I may have missed something you wrote earlier, but I don't understand your reason for stopping the EA after reaching a profit target. How do you determine your profit target? What's your reason for stopping?

I frequently use time of day to limit when I take trades, but I don't close open trades for any reason except that my take profit or stop has been hit.

I'm not suggesting you don't have a good reason. It's just that my approach, when I'm searching for an edge, is to look for strategies that work all the time (during the hours I've identified). So if I were to stop trading, I would limit my potential profits, not improve them.
  • #826
  • Mar 13, 2015 8:38pm Mar 13, 2015 8:38pm
Quoting drofwarc
{quote} I may have missed something you wrote earlier, but I don't understand your reason for stopping the EA after reaching a profit target. How do you determine your profit target? What's your reason for stopping? I frequently use time of day to limit when I take trades, but I don't close open trades for any reason except that my take profit or stop has been hit. I'm not suggesting you don't have a good reason. It's just that my approach, when I'm searching for an edge, is to look for strategies that work all the time (during the hours I've identified)....
It's just the ebb and flow of your account equity during the day. Think of it as closing down for the day when you reach your profit target. Cannot back test for an appropriate figure easily.
  • #827
  • Mar 13, 2015 9:17pm Mar 13, 2015 9:17pm
Quoting Dave_C
{quote} It's just the ebb and flow of your account equity during the day. Think of it as closing down for the day when you reach your profit target. Cannot back test for an appropriate figure easily.
From a technical perspective, what are you seeking to exploit?
  • #828
  • Mar 13, 2015 9:24pm Mar 13, 2015 9:24pm
Quoting drofwarc
{quote} From a technical perspective, what are you seeking to exploit?
The majority of the strategies giving a daily profit figure but as I mentioned, on a daily basis few of the 21 are getting started.
  • #829
  • Mar 14, 2015 7:29pm Mar 14, 2015 7:29pm
Dave,
Thanks for a great tool. I am beginning to explore it. I believe I found a bug in OpenBuyOrder()
The line:
if (StopLoss == 0 && BuyPriceEMACrossReturnValue == 1) StopLoss = (Close[0]-Low[2]) * PointValue;
I believe it should be
if (StopLoss == 0 && BuyPriceEMACrossReturnValue == 1) StopLossPrice = (Close[0]-Low[2]) ;

There is a similar issue in OpenSellOrder() which should have
if (StopLoss == 0 && SellPriceEMACrossReturnValue == 1) StopLossPrice = (High[2]-Close[0]) ;

I don't think you meant to replace the input integer StopLoss in Pips with what turns out to be 0,
but rather meant to compute the new StopLossPrice.

By the way, in sorting out the code I found the name PointValue (=0.0001 for EURUSD) to be confusing. A more
clear name would be PipSize, analogous to TickSize from MarketInfo which is 0.00001 for 5 digit and 0.0001 for 4 digit brokers.
The code uses this variable to convert input quantities stated in Pips into the actual price domain.

Also, I can not figure out what is being computed by CurrProfitTarget in various places. It does not appear to me to
end up being a price, yet that is the way it is used later by comparing with OrderOpenPrice and it is sometimes computed
using OrderOpenPrice and sometimes using OrderOpenProfit. Is there some errors in these?


The use of the term PointValue gave me trouble for a while because I thought it referred to the value of a Point==TickSize = 0.00001 in a 5 digit broker.
I think using the term "Value" in the name of some Pip quantity should be the dollar value of 1 lot moving 1 Pip or $10 in a 5 digit standard account with lot size =100000. Using PipSize for your 0.0001 quantity would make what it is more clear.

This brings me to another point. After testing for a while on a 5 digit standard account, I tried using a 5-digit "mini" account which
has 1 lotsize = 10000 and minimum lot size and lot step of 0.1 lots, and a Pip is worth $1 for 1 lot

Problems! I am reworking SetWager() and CheckOrderModify() where these account paramarters make a difference. Currently you have hardwired lotsize of 100000 and pip dollar value 10, but I am modifying the code to use values from MarketInfo to adapt to broker pecularities. I think I have found all the places in the code which require modification, but am still testing to see if I have everything before dumping in on you.

Again, Thanks for all the hard work!
  • #830
  • Mar 15, 2015 3:29pm Mar 15, 2015 3:29pm
Quoting TRay
Dave, Thanks for a great tool. I am beginning to explore it. I believe I found a bug in OpenBuyOrder() The line: if (StopLoss == 0 && BuyPriceEMACrossReturnValue == 1) StopLoss = (Close[0]-Low[2]) * PointValue; I believe it should be if (StopLoss == 0 && BuyPriceEMACrossReturnValue == 1) StopLossPrice = (Close[0]-Low[2]) ; There is a similar issue in OpenSellOrder() which should have if (StopLoss == 0 && SellPriceEMACrossReturnValue == 1) StopLossPrice = (High[2]-Close[0]) ; I don't think you meant to replace the input integer StopLoss in Pips with...
Whilst I appreciate your in interest in my coding, some of your assumptions are way off the mark and I will address them individually.

1. The interest in the StopLoss being set by Low[2] is virtually redundant and was a throw back to an earlier system which has now evolved and in actual fact to be technically correct, the code is corrected by simply replacing a "/" instead of a "*". The variable StopLossPrice is a price level not as you would suggest, a price difference.

2. The choice of variable naming is my choice as author of the EA. If you want a variable to be any other name, that is your individual choice but hardly worthy of mention. PointValue is both meaningful and logical since it replaces the erroneous Point function. You are being confused yourself by referencing pips. Calculations using PointValue are mathematically correct.

3. There is absolutely no mention in my coding of OrderOpenProfit, so your assumptions are misleading. If you meant OrderProfit() and OrderOpenPrice(), they are 2 completely different functions so would never be used as a substitute for each other anyway.

4. The statement "Currently you have hardwired lotsize of 100000 and pip dollar value 10, but I am modifying the code to use values from MarketInfo to adapt to broker pecularities." is both incorrect and misleading. LotSize is my own variable and is nominated by the User. Pip dollar value is your own confusing terminology. I do not need to reference the function MarketInfo.

As it appears that English is your second language, and because some of your grammar may have confused the issue, I can assure you that "dumping in on you" would not be an appropriate course of action.

You can make your own modifications to suit your own personal use but please be careful because it appears that some of your assumptions are going to lead you into trouble.
  • #831
  • Edited 5:19pm Mar 15, 2015 5:08pm | Edited 5:19pm
Hello Dave,

by the way, I run EA with news setting only and I think there is some bug.
EA is opening every time 4 the same pending orders 2 buystop and 2 sellstop (some times EA don't set stop loss - but I already saw you solved it)
besides EA see as news every midnight and open pending orders a few sec after (GTM 00:00)
my settings:
Attached Image


by the way my idea
I think there is one thing which is important for news strategy - expiry time in pending orders (eg. in minutes)
by the way have a question,

what kind of news EA "listen"? all or "high impact", "medium .."?


edit:
forgot 2nd screen
Attached Image (click to enlarge)
Click to Enlarge Name: double.png Size: 6 KB
  • #832
  • Mar 15, 2015 5:31pm Mar 15, 2015 5:31pm
Quoting Dave_C
Disappointing end to the week for Traders Concept. Week1 (+- 100) - breakeven Week2 (+- 150) - minus 150 (Mon +150, Tue +150, Wed -150, Thu -150, Fri -150) Next week I propose +-200 and the following week trade continuously. I'm concerned that in closing all trades out each day at the target, continuity is being lost and on each subsequent day new setups have to be established. Also on most days the result has been established before the end of the Asian trading day. Do you think it is more appropriate to try for +-300 or possibly just allow the...

Hi Dave.

Is it possible to just add 1 feature please.

A reversal of signal feature. Just so when all conditions are met for a buy, we can select to " Reverse Signal " True or False, and instead of buying, it will sell instead of buying and vise versa.

Regards

Walter
  • #833
  • Mar 15, 2015 5:31pm Mar 15, 2015 5:31pm
Quoting micello
Hello Dave, by the way, I run EA with news setting only and I think there is some bug. EA is opening every time 4 the same pending orders 2 buystop and 2 sellstop (some times EA don't set stop loss - but I already saw you solved it) besides EA see as news every midnight and open pending orders a few sec after (GTM 00:00) my settings: {image} by the way my idea I think there is one thing which is important for news strategy - expiry time in pending orders (eg. in minutes) by the way have a question, what kind of news EA "listen"? all or "high...
Looking at your panel above, it is always better if you post your .set file (as .txt to allow you to upload) because I can then review your settings. What I do see are a straddle trade to be placed at 00:15 and a continuous straddle which is placed immediately. So I can see that you would have 4 pending orders. Perhaps if you detail what you are actually requiring and a copy of your set file, I will be in a position to help you.

Regarding expiry time, no there is no input for that. If it is a news straddle that you are requiring, it was left out intentionally because you would be monitoring the trade anyway.

The decision to place a straddle trade is personal and I would never attempt to code relating on impact.
  • #834
  • Mar 15, 2015 5:33pm Mar 15, 2015 5:33pm
Quoting WalterLea
{quote} Hi Dave. Is it possible to just add 1 feature please. A reversal of signal feature. Just so when all conditions are met for a buy, we can select to " Reverse Signal " True or False, and instead of buying, it will sell instead of buying and vise versa. Regards Walter
Edit: Sorry I misinterpreted your request. I now understand that you want to adopt a contrarian approach to a trade. Is that correct? Please PM me.
  • #835
  • Mar 15, 2015 5:35pm Mar 15, 2015 5:35pm
Thank you...
  • #836
  • Mar 15, 2015 5:52pm Mar 15, 2015 5:52pm
Quoting Dave_C
{quote} Looking at your panel above, it is always better if you post your .set file (as .txt to allow you to upload) because I can then review your settings. What I do see are a straddle trade to be placed at 00:15 and a continuous straddle which is placed immediately. So I can see that you would have 4 pending orders. Perhaps if you detail what you are actually requiring and a copy of your set file, I will be in a position to help you. Regarding expiry time, no there is no input for that. If it is a news straddle that you are requiring, it was...
the setting
Attached File(s)
File Type: txt setting_news.txt   4 KB | 239 downloads
  • #837
  • Mar 15, 2015 6:04pm Mar 15, 2015 6:04pm
Quoting micello
{quote} the setting {file}
You have both types of straddle enabled. If you just require just a news straddle at 00:15 mt4 time, just set the news or time of day straddle.

You can fix your set by changing UseContinuousStraddle = 1 to UseContinuousStraddle = 0
  • #838
  • Mar 15, 2015 10:37pm Mar 15, 2015 10:37pm
Dave,

I apologize. The term "dumping in" (which carries a negative criticism tone) was a typo. I meant "dumping it" (in the computer usage sense of dumping meaning to transfer a file). I had considered sending it or posting it ("it" being a file with changes). I am glad I did not post "it". English is my first language; spell-checking and typo-checking is not always my forte. I have been a programmer since 1963 and would never make a negative criticism of anyone posting code for public scrutiny. My comments were not intended as negative personal criticisms of you but in the spirit of your opening post "welcome any constructive criticism".

I stand corrected on the StopLoss issue. At least I was correct that there was an error.

On the use of PointValue: of course it is mathematically correct. My comments come strictly from my own personal view. Yes I meant OrderProfit. I still curious about CurrProfitTarget. It seems like a good way to try to increase profits, just unclear why it is computed the way it is.

My reference to LOTSIZE hardwired at 100000 of base currency was in reference to the quantity given by MarketInfo(Symbol(),MODE_LOTSIZE) which is the amount of base currency controlled by 1 lot, not your input parameter LotSize for a fixed value for the Wager. It influences things such as the base currency value of a 1 pip move by 1 lot, which you do have hardwired as the number 10 in a few places where it governs computation of Wager and changing stoplosses. For a broker using 1 lot = 10000 of base currency, the number is 1 instead of 10. Those places with the explicit 10 units of base currency can be replaced by MarketInfo(Symbol(),MODE_LOTSIZE)*PointValue. The reason I did not post the changes is that I am not sure I have identified all the locations where the 10 occurs, as sometimes it is implicitly embedded in another number. Also when the wager is normalized with NormalizeDouble, one needs to change the 2's to 1's because of the lot stepsize difference with these non-standard accounts.

I know that you have folks requesting changes to your code for new and different trading strategies that you may choose to resist, but I am pointing out this issue as a simple one to consider change\ing so that you do not get folks complaining that the code does not work on their broker should they have non-standard accounts. This issue is suggested not as a criticism of you but rather in the spirit of trying to help. You can make them or not. Anyone who happens to try the program on non-standard accounts can be aware that they should make some code changes on their own.

Again, I thank you for the Gift and I applaud your making it available and your continuing work on it.
  • #839
  • Mar 16, 2015 12:56am Mar 16, 2015 12:56am
Quoting TRay
Dave, I apologize. The term "dumping in" (which carries a negative criticism tone) was a typo. I meant "dumping it" (in the computer usage sense of dumping meaning to transfer a file). I had considered sending it or posting it ("it" being a file with changes). I am glad I did not post "it". English is my first language; spell-checking and typo-checking is not always my forte. I have been a programmer since 1963 and would never make a negative criticism of anyone posting code for public scrutiny. My comments were not intended as negative personal...
Thank you for your explanation.

When I am considering the percentage increase of CurrentProfitTarget, I use Wager / Close[0] * .005 / PointValue to represent 5% of the value of the investment. This is both efficient and mathematically correct.

Whether an account is Standard or Micro, PointSize is the same value and does not need to the use MarketInfo function and therefore nobody will have a problem or have a need to make code changes of their own. As I mentioned in my previous post to you, your interpretation of PointSize is the problem you have. At no stage do I need to revert to any reference to units of base currency.

If for your own use, you are confused, then it is your prerogative to rename the variables but be very careful if you believe that PointValue or Wager have anything to do with any analogy of units of Base Currency. All my inputs are expressed in Pips, so there is no confusion.
  • #840
  • Edited 1:49am Mar 16, 2015 1:28am | Edited 1:49am
I have posted an update to Post #1 incorporating some small fixes.

1. Change to Volume interpretation
2. Update to Bollinger Bands.
3. Fix for StopLoss being determined automatically in the event that StopLoss is left at 0 with EMACross.

Traders Concept closed with a profit $150 very early today (because I forgot to change it to $200 in the absence of any feedback), so I reinstated it with the +- 200 as originally proposed and it has closed again with the profit of $200. Early in the trading day but $350 for the day is OK and will wait until tomorrow. Post #824 refers
1 trader viewing now