My EA Gift to Traders | Page 33 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #641
  • Feb 23, 2015 12:55pm Feb 23, 2015 12:55pm
Hi Dave

Still testing away and was wondering about the trailing stoploss would it be possible to gradually reduce the stoploss as we move into profit i have seen a fair few trades which were in good profits to then collapse to break even.
I have no idea if this would help as i haven't a clue to how i would test this idea.
  • #642
  • Edited 1:55pm Feb 23, 2015 1:35pm | Edited 1:55pm
Quoting Shawn29
Hey, just wanted to say thanks Dave C for the awesome EA. Sorry i can't really contribute more as I'm still pretty much a newbie to all this. One thing i can contribute though is set files i test out. So for my first one i have a EUR/USD 60 min that put out some nice numbers for Dec 2014 to present. I try not to back test to far since the markets are always changing and 1 method is never going to give you good results 100% of the time. Currently messing around with USD/JPY now I'll be sure to post any good findings. Edit: Just wanted to add that...
Shawn, I had a look at your set file and there seems to be some strange inputs (Fig.1). I have tidied them up (Fig. 2) and enhanced them (Fig.3).

It's an interesting concept using MACD main zero cross with a divergence filter. The performance can enhanced by the use of some extra inputs and I have enclosed 2 set files, one which tidies up your inputs (ext _2) and the second which enhances your strategies. (ext _3)
Attached Images
Attached File(s)
File Type: txt EURUSD MACD 60min Test Dec2014-Feb2015_2.txt   13 KB | 182 downloads
File Type: txt EURUSD MACD 60min Test Dec2014-Feb2015_3.txt   13 KB | 219 downloads
  • #643
  • Edited 2:19pm Feb 23, 2015 1:48pm | Edited 2:19pm
Quoting nobby911
Hi Dave Still testing away and was wondering about the trailing stoploss would it be possible to gradually reduce the stoploss as we move into profit i have seen a fair few trades which were in good profits to then collapse to break even. I have no idea if this would help as i haven't a clue to how i would test this idea.
When the set stop loss to breakeven is set, the trailing stop loss is deactivated until the profit is beyond the value of the trailing stop loss. In other words the worst scenario will be breakeven (I've added a couple of dollars intentionally).

The answer for you may lie in the StopLossMultiplier and the MinPipGain, which basically implies - I'm sitting here waiting for a good trade and until I get that good trade, I'll take the break evens and low profits but steadily increase my wager.

Nevertheless your idea has merit and if my interpretation is correct, just like the trailing stop loss being moved at every 5% increase in profit, maybe it can be decreased by 5% in value at the same time. I'll have a look at it.

EDIT - A quick back test optimization of 0% to 10% decrease in SL value per 5% increase in profit, suggests a 1% to 2 % decrease per step
Attached Image (click to enlarge)
Click to Enlarge Name: 2015-02-24 06_13_41-Tester.jpg Size: 291 KB
Attached Image
  • #644
  • Feb 23, 2015 4:52pm Feb 23, 2015 4:52pm
Blimey Dave that was quick work, do you think it would prove useful/profitable
  • #645
  • Feb 23, 2015 9:21pm Feb 23, 2015 9:21pm
When you have a situation of an EA opening a trade every time an indicator gives such an indication, from an automation point of view each trade has to be managed just like yourself opening up simultaneous trades. At what point in your scenario, do you end each trade? With the stoploss. Do you continue to open up new trades until all of your available margin is used? I see your point here but I can simply run the simulator with a large enough balance to avoid problems associated with multiple open trades. When you have used your available margin you then have to start ignoring trades anyway. Not an issue since I can use a large starting demo balance. Do you then start selling so you can open up extra trades. Not an issue What happens when a major news event turns against you? I'm testing on historical data, so not an issue.

Hi Dave,

I was out of pocket for a while due to work. I have some time now and responded in red to your questions above.

We obviously look at things differently. I see value in being able to evaluate a strategy based on taking every trade for the reasons I outlined in my earlier post, and would use this function if it were available.

I've brought it up for you to consider, and now it's for you to decide whether you see merit in it.

Over to you and all the best,
drofwarc
  • #646
  • Feb 24, 2015 12:05am Feb 24, 2015 12:05am
dave please check this settings and image .trade is not open though all trade open condition is ok look all rsi bellow level 50 so short trade should open...i want 3 rsi cross from bellow open buy and opposite short in any time frame
Attached Image (click to enlarge)
Click to Enlarge Name: trader gift prob.png Size: 120 KB
Say something meaningful or Silence!!
  • #647
  • Edited 1:48am Feb 24, 2015 1:03am | Edited 1:48am
Quoting classy
dave please check this settings and image .trade is not open though all trade open condition is ok look all rsi bellow level 50 so short trade should open...i want 3 rsi cross from bellow open buy and opposite short in any time frame {image}
On looking at the code, I see an error relating with the PrevPrice variable in that I need extra PrevPrice2 & 3 variables. Until I correct this in the next build, could you kindly substitute the following code in the matching place.

//+------------------------------------------------------------------+
//| Process Buy RSI Cross |
//+------------------------------------------------------------------+
void ProcessBuyRSICross()
{
if (CurrRSI >= RSIBottomLevel && PrevRSI < RSIBottomLevel
&& PrevPrice != CurrPrice && CurrentBarPass == 1)
{
BuyRSIReturnValue = 1;
BuyBarCross = Shift;
PrevPrice = CurrPrice;
}
if (CurrRSI2 >= RSIBottomLevel2 && PrevRSI2 < RSIBottomLevel2 && RSIPeriods2 != 0
&& PrevPrice2 != CurrPrice && CurrentBarPass == 1)
{
BuyRSIReturnValue2 = 1;
BuyBarCross = Shift;
PrevPrice2 = CurrPrice;
}
if (CurrRSI3 >= RSIBottomLevel3 && PrevRSI3 < RSIBottomLevel3 && RSIPeriods3 != 0
&& PrevPrice3 != CurrPrice && CurrentBarPass == 1)
{
BuyRSIReturnValue3 = 1;
BuyBarCross = Shift;
PrevPrice3 = CurrPrice;
}
}
//+------------------------------------------------------------------+
//| Process Sell RSI Cross |
//+------------------------------------------------------------------+
void ProcessSellRSICross()
{
if (CurrRSI <= RSITopLevel && PrevRSI > RSITopLevel
&& PrevPrice != CurrPrice && CurrentBarPass == 1)
{
SellRSIReturnValue = 1;
SellBarCross = Shift;
PrevPrice = CurrPrice;
}
if (CurrRSI2 <= RSITopLevel2 && PrevRSI2 > RSITopLevel2 && RSIPeriods2 != 0
&& PrevPrice2 != CurrPrice && CurrentBarPass == 1)
{
SellRSIReturnValue2 = 1;
SellBarCross = Shift;
PrevPrice2 = CurrPrice;
}
if (CurrRSI3 <= RSITopLevel3 && PrevRSI3 > RSITopLevel3 && RSIPeriods3 != 0
&& PrevPrice3 != CurrPrice && CurrentBarPass == 1)
{
SellRSIReturnValue3 = 1;
SellBarCross = Shift;
PrevPrice3 = CurrPrice;
}
}

You will also have declare these variables by inserting the following 2 lines at line 356
double PrevPrice2;
double PrevPrice3;

and recompile

EDIT I'm not at my computer at the moment, but you will also have to zero these 2 adfitional variables where the CalcRSI function is called similarly as PrevPrice = 0 (do a ctrl-f to find the phrase)
  • #648
  • Feb 24, 2015 1:12am Feb 24, 2015 1:12am
Quoting drofwarc
When you have a situation of an EA opening a trade every time an indicator gives such an indication, from an automation point of view each trade has to be managed just like yourself opening up simultaneous trades. At what point in your scenario, do you end each trade? With the stoploss. Do you continue to open up new trades until all of your available margin is used? I see your point here but I can simply run the simulator with a large enough balance to avoid problems associated with multiple open trades. When you have used your available margin...
Unfortunately the major problem is that this is simply a major rewrite and I would not undertake this out of curiousity.

I am concerned by the statement "run the simulator with a large enough balance to avoid problems associated with multiple open trades" because you are pointing to an unrealistic scenario and the EA was never designed with this in mind.
  • #649
  • Edited 1:40am Feb 24, 2015 1:13am | Edited 1:40am
Quoting nobby911
Blimey Dave that was quick work, do you think it would prove useful/profitable
It may be depending on further confirmation!
  • #650
  • Feb 24, 2015 4:03am Feb 24, 2015 4:03am
Quoting Dave_C
{quote} On looking at the code, I see an error relating with the PrevPrice variable in that I need extra PrevPrice2 & 3 variables. Until I correct this in the next build, could you kindly substitute the following code in the matching place. //+------------------------------------------------------------------+ //| Process Buy RSI Cross | //+------------------------------------------------------------------+ void ProcessBuyRSICross() { if (CurrRSI >= RSIBottomLevel && PrevRSI < RSIBottomLevel && PrevPrice != CurrPrice && CurrentBarPass == 1) { BuyRSIReturnValue...
dave many many thanks for quick response.i appreciate your selfless efforts.i salute and pray for you.i told you earlier i have no coding/programming knowledge .. itried but total mess i surrender it is not my cup of tea .lol .no problem take time .it will be great if you correct it when you have time.
Say something meaningful or Silence!!
  • #651
  • Feb 24, 2015 4:36am Feb 24, 2015 4:36am
Quoting classy
{quote} dave many many thanks for quick response.i appreciate your selfless efforts.i salute and pray for you.i told you earlier i have no coding/programming knowledge .. itried but total mess i surrender it is not my cup of tea .lol .no problem take time .it will be great if you correct it when you have time.
Try this
Attached File(s)
File Type: ex4 TradersGift_classy.ex4   146 KB | 205 downloads
File Type: mq4 TradersGift_classy.mq4   99 KB | 248 downloads
  • #652
  • Feb 24, 2015 6:29am Feb 24, 2015 6:29am
Quoting Dave_C
{quote} Try this {file} {file}
thanks dave ..you are rock...i will give feedback.God bless you.
Say something meaningful or Silence!!
  • #653
  • Feb 24, 2015 8:19am Feb 24, 2015 8:19am
Quoting Dave_C
{quote} Try this {file} {file}
just giving you feedback.....sorry dave still trade is not open see rsi level.......ea smiling......ea settings ..but .....thanks
Attached Image (click to enlarge)
Click to Enlarge Name: traders gift classy.png Size: 74 KB
Say something meaningful or Silence!!
  • #654
  • Feb 24, 2015 8:30am Feb 24, 2015 8:30am
Quoting classy
{quote} just giving you feedback.....sorry dave still trade is not open see rsi level.......ea smiling......ea settings ..but .....thanks {image}
dave 1 trade open. sorry...... i will test/check more and inform you.thanks
Say something meaningful or Silence!!
  • #655
  • Feb 24, 2015 11:11am Feb 24, 2015 11:11am
Quoting Dave_C
{quote} When the set stop loss to breakeven is set, the trailing stop loss is deactivated until the profit is beyond the value of the trailing stop loss. In other words the worst scenario will be breakeven (I've added a couple of dollars intentionally). The answer for you may lie in the StopLossMultiplier and the MinPipGain, which basically implies - I'm sitting here waiting for a good trade and until I get that good trade, I'll take the break evens and low profits but steadily increase my wager. Nevertheless your idea has merit and if my interpretation...
Dave, just for my clarification to make the trailing stop active for the entire trade the "set stop loss to breakeven" is set at 0 correct? I do like this concept of a decreased trailing as i had two trades move in that direction.

Thanks
Max
forex forex forex
  • #656
  • Edited Feb 25, 2015 4:44am Feb 24, 2015 1:34pm | Edited Feb 25, 2015 4:44am
Edit: Removed the config since it was flawed as Dave pointed out. It was pretty much just going with the flow, so I got lucky was all.
I'm currently running some new tests, trying out RSI and Stoch for this one, will post any good findings.
  • #657
  • Feb 24, 2015 3:19pm Feb 24, 2015 3:19pm
Quoting classy
{quote} just giving you feedback.....sorry dave still trade is not open see rsi level.......ea smiling......ea settings ..but .....thanks {image}
The chances of the 3 RSI crosses occurring within 1 bar are very slim. You need to expand the RSIMaxBarsAgo setting out to at least 5.
  • #658
  • Edited 3:57pm Feb 24, 2015 3:40pm | Edited 3:57pm
Quoting Shawn29
{quote} Tested those out, ext_3 worked best with the MACD settings i had in the original. Anyways been working on a USDJPY set for a while now haven't really come up with anything that great. Didn't follow any strategy here just throwing stuff at the wall and seeing what sticks. Below is a screenshot from last night and this morning running the config below, however I was manually closing the trades when I would check on it every few hours. I think with some tweaks to the closing and stoploss this might be a bit better for full auto. As it is now...
I looked at your inputs and noticed you had MACD set a 12,19,1. That means the signal line is the same as the MACD line.

After you complete your optimization you need to double click the set of results that you wish to use, to transfer them into the inputs. I would consider the 60min chart as a better alternative for MACD alone.
  • #659
  • Edited 4:19pm Feb 24, 2015 4:07pm | Edited 4:19pm
Quoting swimmax
{quote} Dave, just for my clarification to make the trailing stop active for the entire trade the "set stop loss to breakeven" is set at 0 correct? I do like this concept of a decreased trailing as i had two trades move in that direction. Thanks Max
Yes provided UseTrailingStopLoss = 1 which is the default anyway.

SetStopLossToBreakEven = 0 disables any breakeven setting (default). If that number is 10 for example, Stop Loss will be set to breakeven at +10 pips. As long as the UseTrailingStopLoss is set to 1, the trailing stop loss will kick back in when the profit gain in pips is equivalent to Stop Loss value.

The EA at Post #651 does include the decreased trailing stop concept and will most likely go to Post #1 after some more confirmation of its value. It is the bottom most input. One other undocumented change is the erasure of all objects (including trade lines) on chart exit or deinit of the EA, so if you are using the Tester trade chart, you will need to set the PanelVisibleOnExit to 1 which also keeps trade lines visible.
  • #660
  • Feb 25, 2015 2:08am Feb 25, 2015 2:08am
Dave until today i was away from my PC to send set files as you had asked i only had access by mobile. As soon as i get home i will upload set files.

+1 to make trailing stop adjustable and when to be triggered and the step for the trail. Just my suggestion.
3 traders viewing now