My EA Gift to Traders | Page 29 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #561
  • Feb 17, 2015 11:10am Feb 17, 2015 11:10am
Quoting nobby911
hi dave I did update the CloseTrade last time. I just did it again but this time i turned off auto trading (didnt do that last time) updated the CloseTrade EA Deleted the dummy trade and then restarted autotrading and all worked fine {image}
Thanks for the feedback Nobby. You shouldn't need to disable trading. Possibly a restart may be required to clear the system.

I like your news feed. Any hints?
  • #562
  • Feb 17, 2015 11:15am Feb 17, 2015 11:15am
Dave,

could we institute a call to turn off live trading (i.e. stop new trades) say on Friday at 4pm EST. I noticed the spreads where very large trying to close out the week.

something like

if(DayOfWeek()==5) and if(TimeofDay() ==1900){return(0);} //the EA will not execute when the dayofweek is friday and time is 15:00 (GMT +2).


Your thoughts I am writing from my phone and not near the computer until tonight. Or does the EA take this into account for larger volumes and volatility.
forex forex forex
  • #563
  • Feb 17, 2015 11:21am Feb 17, 2015 11:21am
Quoting swimmax
Dave, could we institute a call to turn off live trading (i.e. stop new trades) say on Friday at 4pm EST. I noticed the spreads where very large trying to close out the week. something like if(DayOfWeek()==5) and if(TimeofDay() ==1900){return(0);} //the EA will not execute when the dayofweek is friday and time is 15:00 (GMT +2). Your thoughts I am writing from my phone and not near the computer until tonight. Or does the EA take this into account for larger volumes and volatility.
It's not a bad idea and feel free to do that for yourself.

At this stage I'm in consolidation mode to try and get the number of revisions stabilised and rebuild a confidence level with the EA however if the demand justifies the change, I will listen.
  • #564
  • Feb 17, 2015 11:44am Feb 17, 2015 11:44am
Quoting Dave_C
{quote} Just make sure if you are using previous settings that the MaxSpread setting is at least 5. I have enclosed a set file as txt which works this end. Check your journal for a clue and advise me what it is, if there is an error. Maybe you don't have the data for the back test. {image} {image} {image} {file}
Hi Dave,

I ran the .set file you provided on open prices, as you did, and it didn't work. Then I changed the symbol in the code from XAU to GOLD and reran it. Success! (Remember, I'm using Dukascopy data and TickStory requires the symbol XAUUSD be "mapped" to GOLD when importing the data into MT4).

However, then I changed the settings from open prices to every tick (and changed the .set file to the required timeframe) - and it didn't work. Again, without changing any other settings, if I flip the symbol to a currency pair, the EA works. It's only when I try to test on GOLD that it's not working.

I've attached a pic of my journal. You'll see that a single trade has been opened but then it says, "tester cannot calculate prices."

drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: GOLD.png Size: 60 KB
  • #565
  • Feb 17, 2015 12:17pm Feb 17, 2015 12:17pm
Quoting drofwarc
{quote} Hi Dave, I ran the .set file you provided on open prices, as you did, and it didn't work. Then I changed the symbol in the code from XAU to GOLD and reran it. Success! (Remember, I'm using Dukascopy data and TickStory requires the symbol XAUUSD be "mapped" to GOLD when importing the data into MT4). However, then I changed the settings from open prices to every tick (and changed the .set file to the required timeframe) - and it didn't work. Again, without changing any other settings, if I flip the symbol to a currency pair, the EA works....
I re-ran the test using tick data (albeit simulated because I have no actual tick data for gold) and had no problems. Can you try it without your tick data feed?
The problem may be in your .fxt file.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2015-02-18 04_15_41-Tester.jpg Size: 46 KB
Click to Enlarge Name: 2015-02-18 04_15_57-914382_ GlobalPrime-Live - [AUDUSD,M1].jpg Size: 185 KB
  • #566
  • Feb 17, 2015 12:58pm Feb 17, 2015 12:58pm
Quoting Dave_C
{quote} It's not a bad idea and feel free to do that for yourself. At this stage I'm in consolidation mode to try and get the number of revisions stabilised and rebuild a confidence level with the EA however if the demand justifies the change, I will listen.
understood, I will work on it and give an update.
forex forex forex
  • #567
  • Feb 17, 2015 1:30pm Feb 17, 2015 1:30pm
Quoting Dave_C
{quote} I re-ran the test using tick data (albeit simulated because I have no actual tick data for gold) and had no problems. Can you try it without your tick data feed? The problem may be in your .fxt file. {image} {image}
I re-ran the test using my FXPro demo and it worked, so there must be a problem with my Dukascopy data. I'll import a new batch and try it again.

By the way, FXPro also uses "GOLD" as its symbol. Good thing I ran into that already with Dukascopy or I would have been stumped. The test failed on the my first try. Then I changed the symbol and it worked.

Just a thought: you might want to include both lines below in your future updates. (Same for silver)

else if(StringFind(Symbol(),"XAU") > (-1)) PointValue = .1;
else if(StringFind(Symbol(),"GOLD") > (-1)) PointValue = .1;

drofwarc
  • #568
  • Feb 17, 2015 1:43pm Feb 17, 2015 1:43pm
Quoting drofwarc
{quote} I re-ran the test using my FXPro demo and it worked, so there must be a problem with my Dukascopy data. I'll import a new batch and try it again. By the way, FXPro also uses "GOLD" as its symbol. Good thing I ran into that already with Dukascopy or I would have been stumped. The test failed on the my first try. Then I changed the symbol and it worked. Just a thought: you might want to include both lines below in your future updates. (Same for silver) else if(StringFind(Symbol(),"XAU") > (-1)) PointValue = .1; else if(StringFind(Symbol(),"GOLD")...
I'll include that in my next build.
  • #569
  • Feb 17, 2015 5:37pm Feb 17, 2015 5:37pm
Hi Dave,

I'm still plugging away at my gold tick-data issue, but I noticed that the "every tick" testing problem on candlestick trades you worked on earlier is still present on the 15 minute chart. (I don't usually look at the 15 minutes, so I didn't catch it at the time.) The H1 timeframe is working correctly and H4 seems to be correct as well.

In the attached image, notice the arrow pointing to a trade that opens near the top of the candle wick... that trade should have been opened at the opening of the bar (or possibly cancelled due to the fact that there was a trade already in progress). If you remember, that's what was happening before.

The trade logic I used is as follows:

For short trades: if (C1>O1)&&(C<O)
For long trades: if (C1<O1)&&(C>O)

Set file is attached.

Kind regards,
drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: 15_Min_Every_Tick.png Size: 56 KB
Attached File(s)
File Type: txt Basic 50-50.txt   13 KB | 199 downloads
  • #570
  • Feb 17, 2015 6:27pm Feb 17, 2015 6:27pm
Quoting drofwarc
Hi Dave, I'm still plugging away at my gold tick-data issue, but I noticed that the "every tick" testing problem on candlestick trades you worked on earlier is still present on the 15 minute chart. (I don't usually look at the 15 minutes, so I didn't catch it at the time.) The H1 timeframe is working correctly and H4 seems to be correct as well. In the attached image, notice the arrow pointing to a trade that opens near the top of the candle wick... that trade should have been opened at the opening of the bar (or possibly cancelled due to the fact...
The probable answer is that you have nominated a 60 minute chart in your inputs and you are testing on a 15 minute chart.

I notice you are using candlesticks alone & I don't see that candlestick logic in the EA so I presume it is your own logic. I'm not sure that candlestick recognition alone is a good idea on 15 minute charts.

It's also important that the C & O variables point to the 1 bar ago value and the C1 & O1 variables point to the 2 bar ago value. Make sure you pass the correct bars to your logic by way of ShiftVal parameter.

CalcCandleSticks(int ShiftVal)

if(candlePatternYourPattern(ShiftVal)== true) CandleSticksBuySignal = 1;
Attached Image (click to enlarge)
Click to Enlarge Name: 2015-02-18 10_28_02-http___www.forexfactory.com_attachment.php_attachmentid=1613407&d=1424216212.jpg Size: 73 KB
Attached Image
  • #571
  • Edited 7:21pm Feb 17, 2015 6:52pm | Edited 7:21pm
Quoting Dave_C
{quote} The probable answer is that you have nominated a 60 minute chart in your inputs and you are testing on a 15 minute chart. I notice you are using candlesticks alone & I don't see that candlestick logic in the EA so I presume it is your own logic. I'm not sure that candlestick recognition alone is a good idea on 15 minute charts. It's also important that the C & O variables point to the 1 bar ago value and the C1 & O1 variables point to the 2 bar ago value. Make sure you pass the correct bars to your logic by way of ShiftVal parameter. CalcCandleSticks(int...
One other point, the candlestick pattern recognition was only ever written to process OHLC of bars. Since the every tick model treats each tick as a bar, you cannot really perform this function without reconstructing the bar code for the particular time frame.

A rewrite of the code for candlestick recognition would be required whereby

for example C1 = Close[ShiftV+1]
would become C1 = iClose(Symbol(),ReqTimeFrame,ShiftV+1);

I having a look at it now
  • #572
  • Feb 17, 2015 7:45pm Feb 17, 2015 7:45pm
Quoting Dave_C
{quote} One other point, the candlestick pattern recognition was only ever written to process OHLC of bars. Since the every tick model treats each tick as a bar, you cannot really perform this function without reconstructing the bar code for the particular time frame. A rewrite of the code for candlestick recognition would be required whereby for example C1 = Close[ShiftV+1] would become C1 = iClose(Symbol(),ReqTimeFrame,ShiftV+1); I having a look at it now
I was wondering about that.
  • #573
  • Feb 17, 2015 7:58pm Feb 17, 2015 7:58pm
Quoting Dave_C
{quote} The probable answer is that you have nominated a 60 minute chart in your inputs and you are testing on a 15 minute chart. I notice you are using candlesticks alone & I don't see that candlestick logic in the EA so I presume it is your own logic. I'm not sure that candlestick recognition alone is a good idea on 15 minute charts. It's also important that the C & O variables point to the 1 bar ago value and the C1 & O1 variables point to the 2 bar ago value. Make sure you pass the correct bars to your logic by way of ShiftVal parameter. CalcCandleSticks(int...
I've checked and rechecked to ensure that I have nominated a 15 minute chart and am testing on a 15 minute chart. The problem is still there. Pictures provided to illustrate. (Also, apologies for sending the wrong .set file last time. I have two trading platforms with similar setups and grabbed the .set file from the wrong platform.)

I wonder if the problem can be traced to this segment of code. I notice that your treatment of the different timeframes is not consistent, but understanding it is above my pay grade...

CurrentBarPass = 0;
if (ReqTimeFrame == 1440 && TimeDay(TimeCurrent()) != CurrentDay) CurrentBarPass = 1;
if ((ReqTimeFrame == 240 && TimeHour(TimeCurrent())/4 != CurrentHour /4) || (TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
if (ReqTimeFrame == 60 && (TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
if (ReqTimeFrame == 30 && (MathRound(TimeMinute(TimeCurrent()/30)) != MathRound(CurrentMinute/30) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
if (ReqTimeFrame == 15 && (MathRound(TimeMinute(TimeCurrent()/15)) != MathRound(CurrentMinute/15) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
if (ReqTimeFrame == 5 && (MathRound(TimeMinute(TimeCurrent()/5)) != MathRound(CurrentMinute/5) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
if (ReqTimeFrame == 1 && (TimeMinute(TimeCurrent()) != CurrentMinute || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;
}

Kind regards,
drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: 15_Min_Every_Tick2.png Size: 46 KB
Attached Image
Attached File(s)
File Type: txt Basic 50-50_2.txt   13 KB | 226 downloads
  • #574
  • Edited 11:02pm Feb 17, 2015 9:46pm | Edited 11:02pm
Quoting drofwarc
{quote} I've checked and rechecked to ensure that I have nominated a 15 minute chart and am testing on a 15 minute chart. The problem is still there. Pictures provided to illustrate. (Also, apologies for sending the wrong .set file last time. I have two trading platforms with similar setups and grabbed the .set file from the wrong platform.) I wonder if the problem can be traced to this segment of code. I notice that your treatment of the different timeframes is not consistent, but understanding it is above my pay grade}
I have done a rework of the candlesticks code.

Also there was a problem with the code that you mentioned & it is related to the 30 min, 15 min & 5 min calculations.

enclosed is the original code (15 min as an example)
if (ReqTimeFrame == 15 && (MathRound(TimeMinute(TimeCurrent()/15)) != MathRound(CurrentMinute/15) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;

here is the corrected code
if (ReqTimeFrame == 15 && (MathRound(TimeMinute(TimeCurrent())/15) != MathRound(CurrentMinute/15) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1;

This is why program errors can be difficult to trace. The change is the moving of the bracket here -
TimeMinute(TimeCurrent())/15)

I have enclosed an amended EA for you to review and to try out your own logic for candlestick formations. For anybody else reading this thread, it only affects back testing using the every tick model on the 30 min, 15 min and 5 min charts and candlestick recognition.

EDIT - I've tidied up the candlestick code considerably but would still like some input.
Attached File(s)
File Type: mq4 TradersGift_CandleSticks.mq4   93 KB | 316 downloads
File Type: ex4 TradersGift_CandleSticks.ex4   137 KB | 267 downloads
  • #575
  • Feb 17, 2015 11:42pm Feb 17, 2015 11:42pm
Quoting Dave_C
{quote} I have done a rework of the candlesticks code. Also there was a problem with the code that you mentioned & it is related to the 30 min, 15 min & 5 min calculations. enclosed is the original code (15 min as an example) if (ReqTimeFrame == 15 && (MathRound(TimeMinute(TimeCurrent()/15)) != MathRound(CurrentMinute/15) || TimeHour(TimeCurrent())!= CurrentHour || TimeDay(TimeCurrent()) != CurrentDay)) CurrentBarPass = 1; here is the corrected code if (ReqTimeFrame == 15 && (MathRound(TimeMinute(TimeCurrent())/15) != MathRound(CurrentMinute/15)...
Hi Dave,

I gave it the candlestick module a quick try on H1 and it worked, but I haven't yet moved down to the lower timeframes.

I'll have some time tomorrow to run some tests,

drofwarc
  • #576
  • Feb 18, 2015 12:10am Feb 18, 2015 12:10am
Dave,

Just wanted to give you an update on my tick data issue with GOLD. I solved it! As you know, I use Dukascopy tick data sourced via Tickstory. When I first tried to test GOLD using your EA, nothing happened. After a bit of digging, I discovered a couple of threads on the Tickstory forum that helped me get sorted.

During the export to MT4 process, it's necessary to make two parameter changes (above and beyond the standard parameter selections you must make for ordinary currency pairs). Once you've loaded the Tickstory Lite program and downloaded your GOLD data, select the Gold symbol by right clicking it and select "Export to MT4."

Next select the Metatrader Info tab.

Now you're ready to make your first parameter change. Enter "GOLD" (without the quotes) in the "Map to" field. You need to do this because Dukascopy refers to gold as XAUUSD while Tickstory refers to it as GOLD.

The second parameter change is to enter the number "1" in the field labelled P. Calc mode. Just delete the 0 that's there and type in a 1. That's the hard part over with.

Now click the "Data export" tab and make your other setting selections as you would for any currency pair. Then click OK and you're done.

I hope this helps the next person trying to test Tickstory gold data using your EA.

drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: Export_to_MT4.png Size: 43 KB
  • #577
  • Feb 18, 2015 12:23am Feb 18, 2015 12:23am
Quoting drofwarc
Dave, Just wanted to give you an update on my tick data issue with GOLD. I solved it! As you know, I use Dukascopy tick data sourced via Tickstory. When I first tried to test GOLD using your EA, nothing happened. After a bit of digging, I discovered a couple of threads on the Tickstory forum that helped me get sorted. During the export to MT4 process, it's necessary to make two parameter changes (above and beyond the standard parameter selections you must make for ordinary currency pairs). Once you've loaded the Tickstory Lite program and downloaded...
Thanks for the info. I'll add a reference at Post #1.
  • #578
  • Feb 18, 2015 1:55am Feb 18, 2015 1:55am
SCALING

Dear Dave ,

This post is related only for the Money managment for scaling concept as you had requested.

I will describe with detailed example so it easy and readable for scaling IN.

Numbers will represent orders. (Nothing about entries will be mentioned , as this is not what we are considered about at present)

1. Lest say conditions for entry has been fulfilled and a Buy order is opened . SL 2% of equity TP 4% of equity .

Scenario A
SL is hit . order has been closed.

Scenarion B
2. Now if price moves in our favour half of our TP distance (2 %) .Then we open new buy order with reduced lot with a multiple factor of 0.7- 0.8 (most optimal multiplier according to my testing) . And SL for the first order is moved to +1% and the second's order SL is placed at 1% risk. So the SL will be placed in the middle of the orders. TP for both orders is readjusted in order to achieve TP of 4% , we actually since adding new position we will need smaller move in order to close in profit.

WE NEVER ADD TO A LOSING POSITION ACCORDING TO MY EXAMPLE AND INSTEAD OF INCREASING LOT WE DECREASE IT.


In scaling OUT concept you can just start the same way and when you have reached 2% in your favour move SL to breakeven and take half postion of the table. But consider that you will need bigger move with the rest postion to achieve your initial TP of 4%. I am sure you are good at calculations so need to explain it furthemore WHY .

I hope it is in the spirit and direction that you want Dave to workaround such MM.

Alex
  • #579
  • Feb 18, 2015 4:20am Feb 18, 2015 4:20am
Quoting Dave_C
{quote} Thanks for the feedback Nobby. You shouldn't need to disable trading. Possibly a restart may be required to clear the system. I like your news feed. Any hints?
Hi Dave do you want me to attach my news feed indi's for you
  • #580
  • Feb 18, 2015 5:48am Feb 18, 2015 5:48am
Quoting nobby911
{quote} Hi Dave do you want me to attach my news feed indi's for you
Yes that would be great if that's OK.
4 traders viewing now