My EA Gift to Traders | Page 28 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #541
  • Feb 16, 2015 12:53am Feb 16, 2015 12:53am
Quoting rkkgs
{quote} Dear Dave_c i want trader gift ea : revese TRADE : ture/false
True
Attached Image (click to enlarge)
Click to Enlarge Name: 2015-02-16 16_51_32-914382_ GlobalPrime-Live.jpg Size: 165 KB
  • #542
  • Feb 16, 2015 1:13am Feb 16, 2015 1:13am
Quoting Dave_C
{quote} I used the above .set on AUDUSD and EURUSD on 15 mins every tick back test and found no problems. Can you show me the front page of the strategy tester ie. the page where you select the model for back test. {image} {image}
As soon as i get home i will upload a printscreen.
  • #543
  • Feb 16, 2015 9:56am Feb 16, 2015 9:56am
Quoting alex8585
{quote} As soon as i get home i will upload a printscreen.
Alex, if you say you are having problems but then walk away when I try to help, that is not fair to me or the readers of this post. I have been very consistent in my approach to support. If anybody has an issue, that is my issue also, but it doesn't help anybody if you leave the matter up in the air.

Regards
Dave
  • #544
  • Feb 16, 2015 9:58am Feb 16, 2015 9:58am
Quoting Dave_C
{quote} True {image}
ok... thank you thank you very much
  • #545
  • Feb 16, 2015 10:32am Feb 16, 2015 10:32am
Quoting Dave_C
{quote} Alex, if you say you are having problems but then walk away when I try to help, that is not fair to me or the readers of this post. I have been very consistent in my approach to support. If anybody has an issue, that is my issue also, but it doesn't help anybody if you leave the matter up in the air. Regards Dave
Dear Dave ,

I arrived home just before 5 minutes . I am not that who gonna leave this way. But you have to understand that i have also full time job and there i don't have access to my PC in order to send all the needed print screens.

I run the test again , and i am including both print screens with the journal and the tester and the set file. Please be informed that that i have reset the settings and applied only EMAevent in order to make sure that none of the filters or strategies are the reason for the issue.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 151 KB
Click to Enlarge Name: Screenshot2.png Size: 158 KB
Attached File(s)
File Type: txt error set.txt   13 KB | 215 downloads
  • #546
  • Edited 4:31pm Feb 16, 2015 2:20pm | Edited 4:31pm
Quoting alex8585
{quote} Dear Dave , I arrived home just before 5 minutes . I am not that who gonna leave this way. But you have to understand that i have also full time job and there i don't have access to my PC in order to send all the needed print screens. I run the test again , and i am including both print screens with the journal and the tester and the set file. Please be informed that that i have reset the settings and applied only EMAevent in order to make sure that none of the filters or strategies are the reason for the issue. {image} {image} {file}
Alex, I have set up my system to look exactly like yours and downloaded the ex4 from Post #1 and used the error set.txt you enclosed and I have a normal set of results and no errors as you detail so there are only 2 possibilities as I see it.

1. The TradersGift.ex4 that you and I are using are different.
2. There is a problem with your data.

Sorry I can't be of any more assistance unless you can review the actual transaction that caused the error. I have uploaded the download from Post #1 just to be sure we are using the same ex4.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2015-02-17 06_07_47-914382_ GlobalPrime-Live - [AUDUSD,M15].jpg Size: 238 KB
Click to Enlarge Name: 2015-02-17 06_09_59-914382_ GlobalPrime-Live - [AUDUSD,M15].jpg Size: 270 KB
Attached File(s)
File Type: ex4 TradersGift.ex4   141 KB | 200 downloads
  • #547
  • Feb 16, 2015 2:51pm Feb 16, 2015 2:51pm
Quoting Dave_C
{quote} Alex, I have set up my system to look exactly like yours and downloaded the ex4 from Post #1 and used the error_set.txt you enclosed and I have a normal set of results and no errors as you detail so there are only 2 possibilities as I see it. 1. The TradersGift.ex4 that you and I are using are different. 2. There is a problem with your data. Sorry I can't be of any more assistance unless you can review the actual transaction that caused the error. I have uploaded the download from Post #1 just to be sure we are using the same ex4. {image}...
Dave ,

You are right it shows that there is error in data but have no idea how to solve this since in tester i pre ss F2 and re download data and the issue persists. But when i run previous EA versions it is opening normally orders. Tried another EA also opens normally orders.

Since we have so big time difference i will google this matter tomorrow as soon as i have to wake in 6 hours to go for work.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 167 KB
  • #548
  • Feb 16, 2015 3:13pm Feb 16, 2015 3:13pm
Quoting alex8585
{quote} Dave , You are right it shows that there is error in data but have no idea how to solve this since in tester i pre ss F2 and re download data and the issue persists. But when i run previous EA versions it is opening normally orders. Tried another EA also opens normally orders. Since we have so big time difference i will google this matter tomorrow as soon as i have to wake in 6 hours to go for work. {image}
The only significant change recently that was made that could cause the error, was a complete rewrite of the bar handling technique to allow for every tick back testing. As I have explained in Post #1, the EA was explicitly written to use the model "...... EA's that explicitly control bar opening". Because MT4 treats every tick as a bar, I had to do the rewrite for tick by tick back testing.

You may care to use the model "...... EA's that explicitly control bar opening".
  • #549
  • Feb 16, 2015 3:33pm Feb 16, 2015 3:33pm
Just a reminder to all about Trade Explorer at the top of the page. This Trade Explorer was only activated at start of trade this week and incorporates all the elements of TradersGift Trading Concept Post #339 with the new presets.

There are 3 strategies optimized for the 7 major currency pairs - 21 strategies in total. The set of strategies have only 2 common values - initial wager is set at 1.5% of equity and StopLossMultiplier is set at 1.2. That will allow a sequence of 16 consecutive trades that don't meet the minimum pip gain criteria which is approximately 50% of take profit. The risk:reward ratio is different in each scenario.

The 3 individual strategies -

Continuous straddle (1 min charts)
RSI (15 min)
MACD (15 min)

can be viewed independently by clicking on my profile. Be aware that the open dots represent trades in progress and yesterday being a Bank Holiday in the US produced a directionless market.
  • #550
  • Feb 16, 2015 8:03pm Feb 16, 2015 8:03pm
Hi Dave,

I'm trying to run a backtest on Gold and find that the EA doesn't take any trades. I've tried both the every tick method and open prices. The version I'm using is the most recent you've posted. The EA with my .set file works fine on currency pairs. Then I switch the symbol to Gold and it doesn't work. I hope this isn't a major issue to correct.

Kind regards,
drofwarc
  • #551
  • Edited 10:14pm Feb 16, 2015 9:28pm | Edited 10:14pm
Quoting drofwarc
Hi Dave, I'm trying to run a backtest on Gold and find that the EA doesn't take any trades. I've tried both the every tick method and open prices. The version I'm using is the most recent you've posted. The EA with my .set file works fine on currency pairs. Then I switch the symbol to Gold and it doesn't work. I hope this isn't a major issue to correct. Kind regards, drofwarc
It's probably the PointValue. I will have a look.

Some things are meant to happen. Quite by accident, when I was testing out your solution, I encountered the problem that Alex has been having (OrderModify error 4051) and a quick look suggests it is a problem with MaxSpread setting because as soon as I set it to 5 to account for the XAU spread, the OrderModify error disappeared. I'm going to now have a good look at that.

Luckily your fix appears quite simple and could you insert the the following line at line 584 and recompile

else if(StringFind(Symbol(),"XAU") > (-1)) PointValue = .1;

Alter your max spread to 5

If you need silver you'll need another similar line with PointValue of .01

EDIT: Update now at Post #1
  • #552
  • Edited 10:56pm Feb 16, 2015 10:08pm | Edited 10:56pm
I have now had to change the code again, having discovered the real reason for Alex's problems for the OrderModify error 4051.

In my previous posts, you will recall that I was unable to re-create his problems relating to this error. The error lay in the size of the MaxSpread which defaulted to 2. The spread at my broker was less than 2 therefore no problem and I suspect that the spread was greater than 2 with his broker. No trades were being made and the code should have prevented the order modify function at that point but it wasn't. Hence the error 4051. I have amended the code to fix that oversight.

I have now taken the default value of MaxSpread out to 5 to account for such differences and to allow for gold and silver whose point values have now also been included in the code. This should preclude non trades because of the default maximum spread setting.

New download at Post #1. Trading Strategy Concept zip file also amended for new EA.

Just remember, if you wish to reduce the allowable spread for trading, MaxSpread will have to be altered.
  • #553
  • Edited Feb 17, 2015 12:38am Feb 16, 2015 11:38pm | Edited Feb 17, 2015 12:38am
Excellent! You're the best!

EDIT: Hey, Dave, nothing's changed, you're still the best -- but the EA isn't working yet on gold, at least for me. I've loaded the new EA, with maxspread set to 5 and tried it with two different feeds. Note that one of my feeds is Dukascopy data via TickStory. I mention this because TickStory requires that XAUUSD be "mapped" to "GOLD" in the setup prior to downloading. I tried changing "XAU" to "GOLD" in your code, but that didn't help. However, I also use FXPro data via a demo platform and that's not working either. Again, if I switch the symbol to a currency pair, the EA works fine.
  • #554
  • Feb 17, 2015 1:15am Feb 17, 2015 1:15am
Quoting drofwarc
Excellent! You're the best! EDIT: Hey, Dave, nothing's changed, you're still the best -- but the EA isn't working yet on gold, at least for me. I've loaded the new EA, with maxspread set to 5 and tried it with two different feeds. Note that one of my feeds is Dukascopy data via TickStory. I mention this because TickStory requires that XAUUSD be "mapped" to "GOLD" in the setup prior to downloading. I tried changing "XAU" to "GOLD" in your code, but that didn't help. However, I also use FXPro data via a demo platform and that's not working either....
Just make sure if you are using previous settings that the MaxSpread setting is at least 5. I have enclosed a set file as txt which works this end.
Check your journal for a clue and advise me what it is, if there is an error. Maybe you don't have the data for the back test.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2015-02-17 17_13_06-914382_ GlobalPrime-Live.jpg Size: 67 KB
Click to Enlarge Name: 2015-02-17 17_13_23-Tester.jpg Size: 132 KB
Click to Enlarge Name: 2015-02-17 17_13_38-914382_ GlobalPrime-Live.jpg Size: 94 KB
Attached File(s)
File Type: txt XAU.txt   13 KB | 250 downloads
  • #555
  • Feb 17, 2015 1:17am Feb 17, 2015 1:17am
Quoting Dave_C
I have now had to change the code again, having discovered the real reason for Alex's problems for the OrderModify error 4051. In my previous posts, you will recall that I was unable to re-create his problems relating to this error. The error lay in the size of the MaxSpread which defaulted to 2. The spread at my broker was less than 2 therefore no problem and I suspect that the spread was greater than 2 with his broker. No trades were being made and the code should have prevented the order modify function at that point but it wasn't. Hence the...
Dave i am at work at present and in google i had found something relating to sp-read or slippage could have been the cause . But as i can see you already found the error as soon as i get home will download EA and make retest and will come back to you.

Anyway thanks for your effort.
  • #556
  • Feb 17, 2015 6:04am Feb 17, 2015 6:04am
Hi dave

Just hit today's Loss Target and dummy trade place all ok.

But seeing as i am testing i thought i would change the CloseTrade EA to my current equity balance delete the dummy aud trade and continue testing but all that happens is it keeps placing all the pending orders and then immediately deleting them over and over.

Is there any way of resetting the close EA as if its a new day.
  • #557
  • Feb 17, 2015 8:12am Feb 17, 2015 8:12am
Good morning from vacation, (it's ski week here in the states)

I just checked my trades and i have been playing with the SL and TP. I am trying to follow Dave's rules on the Trailing Stop loss and working out good backtesting.

Dave, I need to do more work on the backtesting this new system, i am still on an older build.

this is a live account with just a few dollars in it

Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 40 KB


cheers everyone
forex forex forex
  • #558
  • Feb 17, 2015 9:51am Feb 17, 2015 9:51am
Quoting alex8585
{quote} Dave i am at work at present and in google i had found something relating to sp-read or slippage could have been the cause . But as i can see you already found the error as soon as i get home will download EA and make retest and will come back to you. Anyway thanks for your effort.
Dave issue solved orders are opened normally
  • #559
  • Feb 17, 2015 10:37am Feb 17, 2015 10:37am
Quoting nobby911
Hi dave Just hit today's Loss Target and dummy trade place all ok. But seeing as i am testing i thought i would change the CloseTrade EA to my current equity balance delete the dummy aud trade and continue testing but all that happens is it keeps placing all the pending orders and then immediately deleting them over and over. Is there any way of resetting the close EA as if its a new day.
It's most important that you set the new input parameters on the CloseTrades EA before you delete the dummy buy limit.

Make sure that the input reflects the current balance and the SL and TP dollar or euro values required.
  • #560
  • Feb 17, 2015 10:51am Feb 17, 2015 10:51am
hi dave

I did update the CloseTrade last time.

I just did it again but this time i turned off

auto trading (didnt do that last time)
updated the CloseTrade EA
Deleted the dummy trade and then restarted autotrading

and all worked fine
Attached Image (click to enlarge)
Click to Enlarge Name: Image2.png Size: 72 KB
4 traders viewing now