My EA Gift to Traders | Page 20 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #381
  • Feb 6, 2015 8:19pm Feb 6, 2015 8:19pm
Quoting Dave_C
{quote} I don't know what timeframe you are using or what chart, but with the .set file that you sent me with the EURUSD 60 mins chart, all looked OK from this end. Can you use the same .set file with the same chart at your end and indicate where you see the problem. I have also included a test EA for advisory S/R, Pivot & Fib alerts. Just set trading mode=3 {image} {file} {file}
Dave,

I'm very sorry to have misled you but the issue of multiple trades is not gone. Initially, I looked only at the EU and it seemed fine. But then I looked at other pairs and saw it was still present. I should have checked other pairs before reporting back. My .set file has a large TP and Stop (50 pips each), so it can mask the problem in a slow market or on lower time frames. The additional trades only seem to open after the open trade has hit its TP. I'm running the EA on the H4 timeframe.

I checked the UseTimeOfDay function and it works fine now.

Also, the trade data is no longer being deleted.

Many thanks for this.

drofwarc

EDIT: Also, the trades ARE opening at the start of the new bar as they should. I believe the GMT shift is wrong on the price data in one of my platforms and that misled me. I imported the data into this platform from your files and may have got the shift wrong. I'm checking this now to be certain and will update you.
  • #382
  • Feb 6, 2015 9:58pm Feb 6, 2015 9:58pm
Hi Dave,

The problem I was having with the bar offset (trades opening on the wrong bar) is associated with an MT4 platform I have loaded with Tickstory data. Hopefully I can figure it out because I downloaded a huge amount of data. Anyway, this barshift issue is not present in the data I downloaded from page 1 of your thread or from my own broker's data.

I will look at the test alerts tomorrow when I get some time.

Kind regards,
drofwarc
  • #383
  • Feb 7, 2015 12:00am Feb 7, 2015 12:00am
not working on renko 5 pip brick chart. please help me. i am using 5/30 ema crossover.
  • #384
  • Feb 7, 2015 4:23am Feb 7, 2015 4:23am
Dear Dave ,

I can see that you have removed from the last build the position feature from EMAPrice i am totally sure that you had the reason for that and you already have the answer for that question. My thought was just to set EMA cross with a combination of short ema 1 and a long ema of 200 and look back period to 50 bars and will get the same results correct ?

Also thank you for sharing you strategy i can see how many hours and days have been spent. The only question that is regarding the second EA Close Trades. I assume lets say i open five different charts with different pairs i need also to open another extra chart with this EA in order to monitor the equity for closing the trades on all the rest charts. If you could explain a little it would be much appreciated .

Also one thing that i have mentioned that when Breakeven is activated and StoplossMulti . After one position is stopped out by sl but positive thanks to Breakeven next order is opened from the start risk equity instead of multiplying the lot. Because as soon as it does this you realize that R:R 1:2 is not fulfilled by far and the R is much lower. If any further explanation needed please let me know.

The last thing that i want to say that this EA is already profitable and no need to add anything more it already has too many features (it is better to optimize the existent instead of adding any new). Thank you for your overall effort.
At this point as you already know the style of my trading and don't think it would be any use of sending any other set file as i am not going to explore any further combinations because i really believe that according to all the combinations you have sent there is no need to continue in that direction in my opinion.

As soon as i would like to stay here and continue helping you , i would like your next thoughts about how we can contribute and ONLY ADD from now on to your thread , because i believe we have taken too much and it is time to GIVE.

Waiting for your propositions.

Alex

Alex
  • #385
  • Feb 7, 2015 10:50am Feb 7, 2015 10:50am
Quoting piplover143
not working on renko 5 pip brick chart. please help me. i am using 5/30 ema crossover.
How can you expect me to help you with the information you provide. You need to provide much more detail. Please do some homework before you post.
  • #386
  • Edited 12:15pm Feb 7, 2015 11:53am | Edited 12:15pm
quote=alex8585, I can see that you have removed from the last build the position feature from EMAPrice i am totally sure that you had the reason for that and you already have the answer for that question. My thought was just to set EMA cross with a combination of short ema 1 and a long ema of 200 and look back period to 50 bars and will get the same results correct ? Alex Alex[/quote]

Hello Alex. It was a programming error. I'm dealing with 2248 lines of code and as you know a misplaced ". "instead of a "," can cause havoc. It was caused by missing some code relating to trading on the same bar with PriceEMA cross. The code will not go to Post #1 until it is right. You are going to notice a drastic reduction in the number of builds from now on. So the fix is dual and has been updated below.

1. Not trading on UsePriceEMAEvent.
2. Multiple positions being opened on same bar for PriceEmaCross

quote: Also thank you for sharing you strategy I can see how many hours and days have been spent. The only question that is regarding the second EA Close Trades. I assume lets say i open five different charts with different pairs i need also to open another extra chart with this EA in order to monitor the equity for closing the trades on all the rest charts. If you could explain a little it would be much appreciated.

The profile included sets up all the charts with all the parameters. There are 22 charts in total. 3 strategies x 7 currency pairs plus 1 chart to plot equity and manage the close trades scenario. The concept is that your total equity is going to cycle and because you have 21 optimised strategies, the overall strategy is that this is a set and forget for the trading day. Once you reach your target for the day, the close trades EA steps in, closes all positions and disables any further trading until such time as you set up new parameters for the close trade EA and delete the dummy buy limit. (the dummy buy limit places a signal to the Traders Gift EA to stop trading on all charts).

I'm still having some issues with the close trades EA and have to wait until start of trade on Monday for test further. The problem I have relates to deleting all pending stop buys and stop sells. The microsecond I delete all pendings, TradersGift step back in and creates new ones (because the dummy buy limit takes about 3 microseconds to get into place). I going to have to introduce a delay loop before the pending trades are closed.

quote: Also one thing that i have mentioned that when Breakeven is activated and StoplossMulti . After one position is stopped out by sl but positive thanks to Breakeven next order is opened from the start risk equity instead of multiplying the lot. Because as soon as it does this you realize that R:R 1:2 is not fulfilled by far and the R is much lower. If any further explanation needed please let me know.

I understand what you mean. Look at it this way. This was a trade that could have been destined for the risk side of risk : reward. Back testing is not conclusive, in that if you remove the breakeven concept, some pairs perform better, some worse even though the mix of optimised values can be completely different. I can include code to treat such trades as losing trades and will report back, but I'm concerned that the cap on losing trades will cut in. I have seen progressions as long as 17 losses in my back testing.

quote: The last thing that i want to say that this EA is already profitable and no need to add anything more it already has too many features (it is better to optimize the existent instead of adding any new.

Anybody who programs for others knows that the list of requests is endless and I am very sensitive to this fact. (you know that from my PM's). There have been nuisance diversions along the way. eg. Close trades on TDI, Triple RSI, MACD on signal line crossing 0. At this stage, I totally agree with you. Now is the time to get the code right and talk about what can be achieved. Having said that, CandleStick recognition can be improved but nobody has come forward to help, in spite of requests.

Money Management will be my next emphasis and I envisage more sophisticated profit handling. ie. phased scaling of positions.

The update below is not a general update but addresses more recent issues of a couple of worthy contributors. Do not download unless you are willing to provide feedback.
Attached File(s)
File Type: ex4 TradersGift.ex4   139 KB | 229 downloads
File Type: mq4 TradersGift.mq4   91 KB | 233 downloads
  • #387
  • Feb 7, 2015 11:57am Feb 7, 2015 11:57am
Quoting drofwarc
Hi Dave, The problem I was having with the bar offset (trades opening on the wrong bar) is associated with an MT4 platform I have loaded with Tickstory data. Hopefully I can figure it out because I downloaded a huge amount of data. Anyway, this barshift issue is not present in the data I downloaded from page 1 of your thread or from my own broker's data. I will look at the test alerts tomorrow when I get some time. Kind regards, drofwarc
Please hold off for the moment as the code is still a little general. It might be best if you PM me with your email address and I will send you an email with the updated code as an attachment. The download above addresses some further issues of yours.
  • #388
  • Feb 7, 2015 12:23pm Feb 7, 2015 12:23pm
I totally understand that the code is not simple and i admire your courage , me personally would have gave up far before. So i will wait patiently for the fixes.

Unfortunately i don't trade at all any candlestick pattern and can't help you here.
What is related to the Money management i am here to help and will provide you with some concepts that are on testing stage and no meaningful results are achieved but if your are interested i can share and we can evaluate them all together on this thread. If you believe it is out of topic please delete this part.

Best of luck
  • #389
  • Feb 7, 2015 1:17pm Feb 7, 2015 1:17pm
Quoting alex8585
I totally understand that the code is not simple and i admire your courage , me personally would have gave up far before. So i will wait patiently for the fixes. Unfortunately i don't trade at all any candlestick pattern and can't help you here. What is related to the Money management i am here to help and will provide you with some concepts that are on testing stage and no meaningful results are achieved but if your are interested i can share and we can evaluate them all together on this thread. If you believe it is out of topic please delete this...
My first back test treating BreakEven as a loss (using StopLossMultiplier) suggests your idea is spot on. To give it a try just add -5 to the code at lines 1184, 1233, 1272 (from the download above). You can see on the top graph however that the consecutive loss sequence reached the limit right at the end of the graph.

so AccountEquity() becomes AccountEquity()-5
Attached Image(s) (click to enlarge)
Click to Enlarge Name: TG_AUD_1_Nov2014_Dec2014_Cont_Straddle_TreatBreakEvenAsLoss_Graph.jpg Size: 152 KB
Click to Enlarge Name: TG_AUD_1_Nov2014_Dec2014_Cont_Straddle_TreatBreakEvenAsProfit_Graph.jpg Size: 158 KB
  • #390
  • Feb 7, 2015 1:19pm Feb 7, 2015 1:19pm
Quoting Dave_C
{quote}The download above addresses some further issues of yours.
Thanks for the updated EA. I've just checked it and see that you've eliminated the issue of multiple trades on a bar. Many thanks! However, there's still an ongoing problem with trades opening when the should not. See the attached image. I think what's happening is that when a trade closes at its TP on a tradable bar (i.e., the previous bar gave a trading signal), then the EA opens a new trade at the same level that the previous trade closed. Obviously we don't want this as price has already moved away from our desired opening price.
Attached Image (click to enlarge)
Click to Enlarge Name: Incorrect buy signal.PNG Size: 15 KB
  • #391
  • Edited 3:03pm Feb 7, 2015 2:22pm | Edited 3:03pm
Quoting drofwarc
{quote} Thanks for the updated EA. I've just checked it and see that you've eliminated the issue of multiple trades on a bar. Many thanks! However, there's still an ongoing problem with trades opening when the should not. See the attached image. I think what's happening is that when a trade closes at its TP on a tradable bar (i.e., the previous bar gave a trading signal), then the EA opens a new trade at the same level that the previous trade closed. Obviously we don't want this as price has already moved away from our desired opening price. {image}...
I hear what you are saying but the code prevents that from happening and I can't reproduce it. Whenever you have a specific problem like this, it really helps if you can send me the .set. The closest I could get using the .set you last sent me in an attempt to reproduce the behaviour you describe is in the chart below.

(you must use the EA from post #386 because it fixed a number of problems).

It hasn't gone to post #1 because I saw you were online and you were raising all these issues (which I sincerely appreciate). As soon as you are happy, it will go to Post #1. The problem is that when you raise issues and people read the post and there is no response, everybody is in limbo. The EA has become very complicated trying to cater for everybody's whims and you can see from Post #386, the concern.

Please if you make a post saying there is a problem, be sure you have read at least the last couple of pages.
Attached Image (click to enlarge)
Click to Enlarge Name: AUDUSD,H4.jpg Size: 64 KB
  • #392
  • Feb 7, 2015 2:51pm Feb 7, 2015 2:51pm
Quoting Dave_C
{quote} My first back test treating BreakEven as a loss (using StopLossMultiplier) suggests your idea is spot on. To give it a try just add -5 to the code at lines 1184, 1233, 1272 (from the download above). You can see on the top graph however that the consecutive loss sequence reached the limit right at the end of the graph. so AccountEquity() becomes AccountEquity()-5 {image} {image}
Back to testing will come tomorrow with some results
  • #393
  • Feb 7, 2015 3:05pm Feb 7, 2015 3:05pm
Hi Dave
Hopefully you will be fine..
i mention some issues today a few hours ago.. but you didn't reply me...
trailing stop on JPY pairs is working good but if market move 10 pips in profit then in JPY pairs order modified by 100 times,
its mean in 1 pip movement order modified by 10 times...
reply me
  • #394
  • Edited 4:29pm Feb 7, 2015 3:54pm | Edited 4:29pm
Quoting alex8585
{quote} Back to testing will come tomorrow with some results
Alex has raised quite a significant issue. If the StopLossMultiplier is being used and the the TakeProfit multiplier is also being used, ie. for Risk:Reward, at what point do we allow the wager to be increased. He suggested BreakEven should be treated the same as a loss and my back testing appears to support that issue. Just for fun, I took the $5 buffer that I suggested in Post #389 out to $100 (an arbitary figure). BreakEven is programmed to give you a couple of $ profit and that is why I originally suggested $5. Even better results were achieved using $100.

Having achieved that, I set about considering what would be a reasonable proposition and have settled on this scenario.

If the TakeProfit is set at 100pips for example and the profit from a trade is less than half that (ie. 50 pips) due to TrailingStop or BreakEven, increase the wager sequence as with a losing trade.

I invite your input on this post. I have enclosed the comparative equity graph as from Post #389

note the size of the wager (green bars) progressively increasing as less than 50% of Take Profit is being achieved
the dip in the graph is where the sequence of losses hit the 20% limit.
Attached Image (click to enlarge)
Click to Enlarge Name: TG_AUD_1_Nov2014_Dec2014_Cont_Straddle_Treat50pcOfTakeProfitAsLoss_Graph.jpg Size: 146 KB
  • #395
  • Feb 7, 2015 4:31pm Feb 7, 2015 4:31pm
Quoting piplover143
not working on renko 5 pip brick chart. please help me. i am using 5/30 ema crossover.
Is it meant to work on offline charts?
why don't you use it on the M1 chart instead?
Have a nice day
  • #396
  • Feb 7, 2015 4:51pm Feb 7, 2015 4:51pm
Quoting billv
{quote} Is it meant to work on offline charts? why don't you use it on the M1 chart instead?
Yes it will work on Renko charts. A couple of posts - refer Post #269 & Post #284
  • #397
  • Feb 7, 2015 5:29pm Feb 7, 2015 5:29pm
Quoting Dave_C
{quote} I hear what you are saying but the code prevents that from happening and I can't reproduce it. Whenever you have a specific problem like this, it really helps if you can send me the .set. The closest I could get using the .set you last sent me in an attempt to reproduce the behaviour you describe is in the chart below. (you must use the EA from post #386 because it fixed a number of problems). It hasn't gone to post #1 because I saw you were online and you were raising all these issues (which I sincerely appreciate). As soon as you are happy,...
Hi Dave,

Didn't mean to leave you hanging. I'm back now and will run another test to see if I can replicate the problem. Just to be clear, though, I did download the new EA from post #386 and used it in my last round of tests.

drofwarc
  • #398
  • Feb 7, 2015 6:13pm Feb 7, 2015 6:13pm
Quoting Dave_C
{quote} I hear what you are saying but the code prevents that from happening and I can't reproduce it. Whenever you have a specific problem like this, it really helps if you can send me the .set. The closest I could get using the .set you last sent me in an attempt to reproduce the behaviour you describe is in the chart below. (you must use the EA from post #386 because it fixed a number of problems).{image}
The attached chart is of the EURUSD on H1. I used the PriceEMAEvent strategy with a 50 pip stop and a 50 pip TP. My .set file is attached.

On the chart, I've pointed out two trades that should not have opened but did.

The first example happened on Feb 4. A prior sell trade had been opened that prevented the sell trade from activating at the open of the bar. Effectively, this sell trade was disqualified. However, once the prior trade closed at its TP, the disqualified sell trade opened right about the end of the bar.

The second example happened on Feb 6. A prior sell trade had been opened that prevented the buy trade from activating. Effectively, this buy trade was disqualified. However, once the prior trade closed at its TP, the disqualified buy trade opened about two thirds of the way down the bar.

I hope this is clear and look forward to your reply.

drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: Incorrect buy and sell trades.PNG Size: 56 KB
Attached File(s)
File Type: txt EMA_Price_Event.txt   12 KB | 174 downloads
  • #399
  • Edited 8:04pm Feb 7, 2015 7:08pm | Edited 8:04pm
Quoting drofwarc
{quote} The attached chart is of the EURUSD on H1. I used the PriceEMAEvent strategy with a 50 pip stop and a 50 pip TP. My .set file is attached. On the chart, I've pointed out two trades that should not have opened but did. The first example happened on Feb 4. A prior sell trade had been opened that prevented the sell trade from activating at the open of the bar. Effectively, this sell trade was disqualified. However, once the prior trade closed at its TP, the disqualified sell trade opened right about the end of the bar. The second example happened...
I guess take profit happened before candle close and EA took information from previous candle and opened buy here. I had similar problem with other EA.
EA can not think...
  • #400
  • Edited 7:47pm Feb 7, 2015 7:27pm | Edited 7:47pm
Quoting drofwarc
{quote} The attached chart is of the EURUSD on H1. I used the PriceEMAEvent strategy with a 50 pip stop and a 50 pip TP. My .set file is attached. On the chart, I've pointed out two trades that should not have opened but did. The first example happened on Feb 4. A prior sell trade had been opened that prevented the sell trade from activating at the open of the bar. Effectively, this sell trade was disqualified. However, once the prior trade closed at its TP, the disqualified sell trade opened right about the end of the bar. The second example happened...
I have reproduced your chart as closely as possible on my platform and have no such problem. The only thing I can deduce is that the EA you are using is an older version so could you please check very carefully that you are using the EA from Post #386 which is re-enclosed below and that it has been placed in the correct directory.

You also indicated a sell trigger and a buy trigger. They are not triggers because a trade is still on. Your set file has a TradeClosureMode of 0. If you had wanted those signals to be triggered, you would need TradeClosureMode of 1.

Could somebody else please check on their platform, my results, and this will serve as a verification.
Attached Image (click to enlarge)
Click to Enlarge Name: EURUSD,H1.jpg Size: 98 KB
Attached File(s)
File Type: txt EMA_Price_Event.txt   12 KB | 206 downloads
File Type: mq4 TradersGift.mq4   91 KB | 221 downloads
File Type: ex4 TradersGift.ex4   139 KB | 188 downloads
1 trader viewing now