My EA Gift to Traders | Page 19 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #361
  • Feb 6, 2015 8:27am Feb 6, 2015 8:27am
HI Dave yes all was working fine then all of a sudden it didnt set the TP or SL and left orphaned pending orders i shall stop it all and restart as it seems to of some how got out of sych
  • #362
  • Feb 6, 2015 8:42am Feb 6, 2015 8:42am
Quoting nobby911
HI Dave yes all was working fine then all of a sudden it didnt set the TP or SL and left orphaned pending orders i shall stop it all and restart as it seems to of some how got out of sych
When the CloseTrades EA activates, it should cancel ALL trades including pending trades. At that point it places a dummy buy limit to prevent any further trading and that should be the only pending trade showing. Maybe the orphaned trade to which you were referring, was that dummy buy limit.
  • #363
  • Feb 6, 2015 8:54am Feb 6, 2015 8:54am
Hi Dave
i see what you mean about the dummy order which is there as a pending audusd Buy Limit which means the close EA partially worked because as you can see there is a dummy order but there is still a live order and also another pending order which should have been deleted once the close EA was activated and placed the dummy order
Hope i am explaining this clearly

Attached Image (click to enlarge)
Click to Enlarge Name: USDJPY.png Size: 20 KB
  • #364
  • Feb 6, 2015 9:12am Feb 6, 2015 9:12am
Quoting nobby911
Hi Dave i see what you mean about the dummy order which is there as a pending audusd Buy Limit which means the close EA partially worked because as you can see there is a dummy order but there is still a live order and also another pending order which should have been deleted once the close EA was activated and placed the dummy order Hope i am explaining this clearly {image}
I can see your point. Tried it myself and 1 pending trade was left. I'll look into this more closely and may not be able to get back to you until later in the day because it is 1.10 am here.
  • #365
  • Feb 6, 2015 9:21am Feb 6, 2015 9:21am
Thanks Dave

Was struggling to explain myself but a least i knew what i meant its 15:20 here so kids will be home shortly.. speak later
  • #366
  • Feb 6, 2015 9:33am Feb 6, 2015 9:33am
taking the good with the bad today, more good than bad
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 39 KB

one of the losses was a trade since yesterday that i manually closed
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot2.png Size: 37 KB


Here are the strategies used today, everything on the chart is what i am using

Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot3.png Size: 27 KB


thanks Dave for these the best was the GU with the RSI because it would atleast give me profit (though small) on each trade on the SL
forex forex forex
  • #367
  • Edited 3:42pm Feb 6, 2015 11:25am | Edited 3:42pm
Hi Dave,

Many thanks for the continuing improvements and updates.

Yesterday, I tried the EA using the "Every tick" method for the first time, and I find that it sometimes takes multiple trades on a bar. This seems to happen when the bar is longer than the take profit.

If I switch to the "Open prices only" method, the EA functions as expected.

I've attached an image of a test run using the Price EMA Event strategy. My set file is attached.

I apologize in advance if I'm just missing something simple.

Separately, I notice that when using the newest version of the EA in Visual mode, the EA deletes the trade information from the screen at the end of the test run. That is, you can see the buy and sell icons and dotted lines during the test, but they vanish after the test completes.

Again, perhaps I'm missing something in the settings, but I've looked and can't see anything.

Hope this is helpful feedback and look forward to your reply,

drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: Multiple_trades.png Size: 72 KB
Attached File(s)
File Type: txt EMA_Price_Event.txt   12 KB | 162 downloads
  • #368
  • Edited 4:12pm Feb 6, 2015 2:11pm | Edited 4:12pm
Quoting Dave_C
{quote} I can see your point. Tried it myself and 1 pending trade was left. I'll look into this more closely and may not be able to get back to you until later in the day because it is 1.10 am here.
EDIT - still working on this but will have to wait until market open for further testing.
  • #369
  • Edited 3:14pm Feb 6, 2015 2:40pm | Edited 3:14pm
Quoting drofwarc
Hi Dave, Many thanks for the continuing improvements and updates. Yesterday, I tried the EA using the "Every tick" method for the first time, and I find that it sometimes takes multiple trades on a bar. This seems to happen when the bar is longer than the take profit. If I switch to "Open prices only" method, the EA functions as expected. I've attached an image of a test run using the Price EMA Event strategy. My set file is attached. I apologize in advance if I'm just missing something simple. Separately, I notice that when using the newest version...
The explanation regarding the extra trades on a bar longer than the TP, is that a new trade will opened if there are no open trades. In the case you mention, the TP has been fulfilled and the same conditions still exist so a new trade is opened.

Regarding the missing dotted lines, just comment out line 548 like this when back testing (recompile)
//ObjectsDeleteAll();

As the EA is deactivated, the purpose of this code is to delete the info box from the chart. In my next build, I will individually delete each of the info components separately to fix the problem.
  • #370
  • Feb 6, 2015 3:35pm Feb 6, 2015 3:35pm
Quoting Dave_C
{quote} The explanation regarding the extra trades on a bar longer than the TP, is that a new trade will opened if there are no open trades. In the case you mention, the TP has been fulfilled and the same conditions still exist so a new trade is opened.
Thanks for the explanation. I wonder, is there a way to prevent these additional trades from happening? From the standpoint of the trade logic I'm testing, I would open only one trade following a signal. Then I would stand aside until I received another signal.
  • #371
  • Edited 4:08pm Feb 6, 2015 3:52pm | Edited 4:08pm
Quoting drofwarc
{quote} Thanks for the explanation. I wonder, is there a way to prevent these additional trades from happening? From the standpoint of the trade logic I'm testing, I would open only one trade following a signal. Then I would stand aside until I received another signal.
I'll have a think about that. At the moment, the overriding logic is that if a signal occurs from the previous bar and there are no open trades, a trade confirmation can be given. I have a think about overriding that. Possibly there could be other ramifications which I'll have to work through.
  • #372
  • Feb 6, 2015 4:08pm Feb 6, 2015 4:08pm
Hi Dave,

I'm having trouble with the UseTimeofDay feature. Attached is an image of an H1 chart with trading limited to between 1 AM and 8 AM. As you can see, trades are occurring throughout the day. I've also included an image of my parameters in the preset file so that you can trouble shoot. Is there something in the settings that I'm missing?

regards,
drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: UseTimeofDay.png Size: 33 KB
Attached Image
  • #373
  • Feb 6, 2015 4:17pm Feb 6, 2015 4:17pm
Quoting drofwarc
Hi Dave, I'm having trouble with the UseTimeofDay feature. Attached is an image of an H1 chart with trading limited to between 1 AM and 8 AM. As you can see, trades are occurring throughout the day. I've also included an image of my parameters in the preset file so that you can trouble shoot. Is there something in the settings that I'm missing? regards, drofwarc {image} {image}
I need to know what your strategy and filter settings are. Can you send me your .set file as .txt
  • #374
  • Feb 6, 2015 4:22pm Feb 6, 2015 4:22pm
Quoting Dave_C
{quote} I'll have a think about that. At the moment, the overriding logic is that if a signal occurs from the previous bar and there are no open trades, a trade confirmation can be given. I have a think about overriding that. Possibly there could be other ramifications which I'll have to work through.
Hi Dave.

I believe it would make a lot of sense to add this ability to the EA. For my part, all my strategies involve taking one trade per signal and then waiting for the next signal, so it's actually a necessity. Thanks in advance for at least considering it.

drofwarc
  • #375
  • Feb 6, 2015 4:26pm Feb 6, 2015 4:26pm
Quoting Dave_C
{quote} I need to know what your strategy and filter settings are. Can you send me your .set file as .txt
.Set file attached.
Attached File(s)
File Type: txt EMA_Price_Event.txt   12 KB | 143 downloads
  • #376
  • Feb 6, 2015 5:15pm Feb 6, 2015 5:15pm
Hi Dave,

I have another thought to run by you. My trading focus is primarily price action. I'm looking for price to break S&R levels, and in my testing, I'd like to take every signal that I get. Currently, the EA only opens a new trade if there is not an existing trade open. Is it possible to add the option for the EA to take every signal? I definitely think other traders would find this useful as well - and not just for testing but for live trading. When using the EA in advisory or discretionary mode, it would be useful to receive a prompt at every occurrence of a signal, and not miss signals because a trade is already open.

By the way, if I'm asking too much (or if what I'm asking for is not even be possible) just say so. I know just enough about coding to be dangerous, and most of my experience is with indicators.

drofwarc
  • #377
  • Edited 5:43pm Feb 6, 2015 5:28pm | Edited 5:43pm
Quoting drofwarc
{quote} .Set file attached. {file}
I think I have addressed all your issues. Could you give the enclosed EA a try and get back to me.

Edit: I just noticed your last post and I will think about it. Having just finished coding to cancel signals on the same bar and now your request for all signals regardless, it's getting a bit rich. I just need some free time.
Attached File(s)
File Type: ex4 TradersGift.ex4   139 KB | 175 downloads
File Type: mq4 TradersGift.mq4   91 KB | 180 downloads
  • #378
  • Feb 6, 2015 6:43pm Feb 6, 2015 6:43pm
Quoting Dave_C
{quote} I think I have addressed all your issues. Could you give the enclosed EA a try and get back to me. Edit: I just noticed your last post and I will think about it. Having just finished coding to cancel signals on the same bar and now your request for all signals regardless, it's getting a bit rich. I just need some free time. {file} {file}
Hi Dave,

I completely understand what you're saying and don't want to take advantage of you. However, I'm trying to use the EA and I'm noticing aspects of its operation that I figure you'd want to know about. I do hope I'm adding some value for you.

With regards to the version you just posted, the issue of multiple singles is gone, but the trades are being taken at the close of the bar, rather than the open. Please see the attached image.

Edit: The first arrow points to a clear example of a trade that opened at the close of the candle, rather than the open. The second arrow points to a bar with two trade signals. This is the only bar that I've seen with two signals and it's the last bar on the chart, which I'm sure has meaning for you in terms of the code.

kind regards,
drofwarc
Attached Image (click to enlarge)
Click to Enlarge Name: Trades_on_wrong_bar.png Size: 14 KB
  • #379
  • Feb 6, 2015 7:39pm Feb 6, 2015 7:39pm
Quoting drofwarc
{quote} Hi Dave, I completely understand what you're saying and don't want to take advantage of you. However, I'm trying to use the EA and I'm noticing aspects of its operation that I figure you'd want to know about. I do hope I'm adding some value for you. With regards to the version you just posted, the issue of multiple singles is gone, but the trades are being taken at the close of the bar, rather than the open. Please see the attached image. Edit: The first arrow points to a clear example of a trade that opened at the close of the candle, rather...
OK. I'll look into that now.
  • #380
  • Edited 8:19pm Feb 6, 2015 7:54pm | Edited 8:19pm
Quoting drofwarc
{quote} Hi Dave, I completely understand what you're saying and don't want to take advantage of you. However, I'm trying to use the EA and I'm noticing aspects of its operation that I figure you'd want to know about. I do hope I'm adding some value for you. With regards to the version you just posted, the issue of multiple singles is gone, but the trades are being taken at the close of the bar, rather than the open. Please see the attached image. Edit: The first arrow points to a clear example of a trade that opened at the close of the candle, rather...
I don't know what timeframe you are using or what chart, but with the .set file that you sent me with the EURUSD 60 mins chart, all looked OK from this end.

Can you use the same .set file with the same chart at your end and indicate where you see the problem.

I have also included a test EA for advisory S/R, Pivot & Fib alerts. Just set trading mode=3

Edit - New upload (fixed on screen message)
Attached Image (click to enlarge)
Click to Enlarge Name: Trades EUR_60.jpg Size: 143 KB
Attached File(s)
File Type: ex4 TradersGift_TestAlerts.ex4   147 KB | 164 downloads
File Type: mq4 TradersGift_TestAlerts.mq4   94 KB | 200 downloads
1 trader viewing now