My EA Gift to Traders | Page 14 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #261
  • Feb 2, 2015 12:36pm Feb 2, 2015 12:36pm
I think what Donatas is trying to describe is called EQUITY MANAGER. ie ,IF equity hits X% in PROFIT/DRAWDOWN then the ea should CLOSE ALL OPENED POSITIONS. I personally think it will be a great addition if Dave could consider this suggestion.Dave is a great man and he has given to all of us one of the bests Gifts.Thanks Dave
  • #262
  • Edited 5:08pm Feb 2, 2015 1:17pm | Edited 5:08pm
Quoting triumph
I think what Donatas is trying to describe is called EQUITY MANAGER. ie ,IF equity hits X% in PROFIT/DRAWDOWN then the ea should CLOSE ALL OPENED POSITIONS. I personally think it will be a great addition if Dave could consider this suggestion.Dave is a great man and he has given to all of us one of the bests Gifts.Thanks Dave
The problem with the request is that you need a starting position and it would have to be on a currency by currency basis if you are specifying pips. The request could be fulfilled if starting position was an equity value and closing position was a particular $profit or $loss.

There are already EA's which close all positions for an account. Sometimes people appear from nowhere, add no meaningful input, and having not done any homework make personal requests!

The code is simple.

extern int StartingEquity = 0;
extern int ProfitTarget = 0;
extern int LossTarget = 0;
int res;

void start()
{
//Check for Target
if (StartingEquity > 0 && (((AccountEquity() - StartingEquity) >= ProfitTarget) || (StartingEquity - AccountEquity() )>= LossTarget))
{
for(int i = OrdersTotal()-1; i >= 0; i--)
{
if(OrderType == OP_BUY ) res=OrderClose(OrderTicket(),OrderLots(),Bid,1,Red);
if(OrderType == OP_SELL ) res=OrderClose(OrderTicket(),OrderLots(),Ask,1,Red);
}
}
}
Attached File(s)
File Type: ex4 CloseTrades.ex4   5 KB | 178 downloads
File Type: mq4 CloseTrades.mq4   1 KB | 231 downloads
  • #263
  • Feb 2, 2015 2:59pm Feb 2, 2015 2:59pm
Thanks Dave. i love the simplicity of this GIFT and would love it to remain this simple.if it would not compromise the essence of this thread, can i share my one month results and the settings that i used on a demo account?more than 50% roi
  • #264
  • Feb 2, 2015 9:11pm Feb 2, 2015 9:11pm
2 pairs what time fram both set and both pairs?

and set file name _1 and _60 ?


Attached Image (click to enlarge)
Click to Enlarge Name: SET FILES.jpg Size: 33 KB



Quoting Dave_C
{quote} In your previous posts, you predominately mentioned Price and/or EMA cross and STOC. I would have to agree with your comments regarding any sort of back test holding up with these combinations. In fact any type of optimization using EMA's as the primary strategy will fall over on its own. My experience is that RSI is one of the most reliable indicators. Like you mention in your post, looking at R:R ratios and on optimizations, rejecting the most profitable combinations if the R:R ratio is less than 1. Not a big fan of trade reversals of...
  • #265
  • Feb 2, 2015 9:13pm Feb 2, 2015 9:13pm
Hi Dave,

Amazing EA! Thank you so much for making it freely available to the community. Over the past few days, I've been familiarizing myself with the code and its operation, my goal being to test a variety of candlestick patterns. In the course of this, I think I've encountered a problem with the results generated by the candle patterns. To simplify things, I created a basic reversal pattern as follows:

For short trades: if (C1>O1)&&(C<O)
For long trades: if (C1<O1)&&(C>O)

To test it, I commented out the other candlestick patterns and just ran this pattern. Your code successfully identifies many of the reversals that occur, but it also misses some legitimate patterns and occasionally makes trades when the pattern doesn't occur.

Would you mind taking a look to see if you get the same results? I've attached a couple of images with arrows that point to examples of the trades I've described.

I've also attached a copy of the modified EA that I used to test the reversal trades.

With regards to the trades that are missed, I'm wondering if this may be intentional to prevent a new trade from opening when a trade already exists. But then I also see occasions when new trades are opened while prior trades are still active. So I'm confused.

I hope you find this comment in the spirit of your thread.

Kind regards,
drofwarc
Attached Images
Attached File(s)
File Type: mq4 TradersGift_test.mq4   83 KB | 249 downloads
  • #266
  • Edited Feb 3, 2015 8:16am Feb 2, 2015 9:42pm | Edited Feb 3, 2015 8:16am
Quoting drofwarc
Hi Dave, Amazing EA! Thank you so much for making it freely available to the community. Over the past few days, I've been familiarizing myself with the code and its operation, my goal being to test a variety of candlestick patterns. In the course of this, I think I've encountered a problem with the results generated by the candle patterns. To simplify things, I created a basic reversal pattern as follows: For short trades: if (C1>O1)&&(C<O) For long trades: if (C1<O1)&&(C>O) To test it, I commented out the other candlestick patterns and just ran...
That's a great post and very stimulating and hopefully others can add to this. I recognize that the candlestick recognition can be improved.

To answer your question about patterns being missed.

There are 2 possibilities
1. A trade is already open. (Only one trade at a time per chart)
2. The pattern detection code was incorrect. I will look at your code shortly and respond.

In the meantime I have reproduced Post #91 and would ask you to consider contributing in this regard.


Post #91
I'm in the process of revamping the CandleStick signals because I would like to explore buy and sell signals by just using the filters.

eg. Buy if CandleStick gives a bullish signal within the last x bars and there is divergence with the last x bars and a price is close to a fib point. (you can set a fib point as a price point for a straddle trade)

So my idea for candlesticks is to process 4 candlesticks( possibly more) and to have the following variables starting with candlestick 1 being the last completed bar.

CandleStick1OverallLength
CandleStick1BodyLength
CandleStick1LowerWickLength
CandleStick1UpperWickLength
CandleStick1OpenValue
CandleStick1HighValue
CandleStick1LowValue
CandleStick1CloseValue ......... up to Candlestick4 +

So the pseudo code for bullish doji might be

If CandleStick2BodyLength < .00002 and CandleStick1BodyLength > .0002 and CandleStick3BodyLength > .0002 and CandleStick3LowValue > CandleStick2LowValue and CandleStick1LowValue > CandleStick2LowValue - GIVE A BUY SIGNAL

If you can give me some ideas that would help

Rather than rewrite the variables just copy and paste from above
  • #267
  • Feb 2, 2015 10:02pm Feb 2, 2015 10:02pm
I have just uploaded a new build of the EA. This does not correct any errors but adds a cosmetic improvement and additional inputs for the ADX filter.

You can now nominate the ADXPeriods and the ADXLevel. There are 2 ways of interpreting the ADX.

1. ADX crossover of the nominated ADX level - Cross up for buy and down for sell. (The ADXMaxBarsAgo can be expanded from the default value of 1) UseADX = 1
2. ADX Value being above the ADX level for both buy and sell. UseADX = 2

Download from Post #1 (Help file also updated)
Attached Image(s) (click to enlarge)
Click to Enlarge Name: Inputs.jpg Size: 288 KB
Click to Enlarge Name: Inputs2.jpg Size: 286 KB
  • #268
  • Feb 2, 2015 10:06pm Feb 2, 2015 10:06pm
Quoting rkkgs
2 pairs what time fram both set and both pairs? and set file name _1 and _60 ? {image} {quote}
??????

_1 = 1min
_60 = 60min

Previously explained in the thread!
  • #269
  • Feb 2, 2015 10:12pm Feb 2, 2015 10:12pm
I had a query regarding the use of Renko Charts.

You can attached the TradersGift EA to the offline Renko chart (File ,Open Offlne) which is created by placing the enclosed EA on a 1 minute chart. You need to keep the 1 minute chart active so that the Renko chart updates in real time.
Attached File(s)
File Type: ex4 RenkoLiveCharts_v4.ex4   11 KB | 221 downloads
File Type: mq4 RenkoLiveCharts_v4.mq4   18 KB | 233 downloads
  • #270
  • Feb 2, 2015 11:09pm Feb 2, 2015 11:09pm
Quoting drofwarc
Hi Dave, Amazing EA! Thank you so much for making it freely available to the community. Over the past few days, I've been familiarizing myself with the code and its operation, my goal being to test a variety of candlestick patterns. In the course of this, I think I've encountered a problem with the results generated by the candle patterns. To simplify things, I created a basic reversal pattern as follows: For short trades: if (C1>O1)&&(C<O) For long trades: if (C1<O1)&&(C>O)
I looked at your code. It appears to be incorrect.

for example the following line -
if ((C1>O1)&&(C<O))

in pseudo code that means

if (the Close Price 2 bars ago is greater than the open price 2 bars ago) and (the close price 1 bar ago is less than open price 1 bar ago)

send a signal for a sell which is obviously the wrong way around.

Then I replaced your code with the original code for the same patterns and the EA functioned correctly (with only 1 trade at a time)
  • #271
  • Feb 2, 2015 11:57pm Feb 2, 2015 11:57pm
Quoting Dave_C
{quote} I looked at your code. It appears to be incorrect. for example the following line - if ((C1>O1)&&(C<O)) in pseudo code that means if (the Close Price 2 bars ago is greater than the open price 2 bars ago) and (the close price 1 bar ago is less than open price 1 bar ago) send a signal for a sell which is obviously the wrong way around. Then I replaced your code with the original code for the same patterns and the EA functioned correctly (with only 1 trade at a time)
Hi Dave,

Thanks for the fast response. I look forward to contributing to your thread.

With regards to the code I sent, I'm a bit too tired to think straight, but I don't understand how it's incorrect. The particular code you referenced was my code for a short trade - and as you say, it should send a sell signal. But as I show in my example, sometimes it results in sell signals that are not expected.

Maybe the issue is the number of bars back...

In pseudo code, for a short trade, I want the close price 1 bar ago (not 2 bars ago) to be greater than the open price 1 bar ago, and the close price of the current bar (not 1 bar ago) to be less than the open price of the current bar. The trade should be triggered at the close of the current bar.

I hope that's clear.

Perhaps it would be easiest if you post the code that you have found works for this particular signal in your indicator.

Kind regards,
drofwarc
  • #272
  • Edited 12:57am Feb 3, 2015 12:09am | Edited 12:57am
Quoting drofwarc
{quote} Hi Dave, Thanks for the fast response. I look forward to contributing to your thread. With regards to the code I sent, I'm a bit too tired to think straight, but I don't understand how it's incorrect. The particular code you referenced was my code for a short trade - and as you say, it should send a sell signal. But as I show in my example, sometimes it results in sell signals that are not expected. Maybe the issue is the number of bars back... In pseudo code, for a short trade, I want the close price 1 bar ago (not 2 bars ago) to be greater...
I appreciate your response. I had thought after I had posted that the naming of the variables might cause a problem. C1 & O1 refers to 2 bars ago, C & O refer to 1 bar ago. If you want to interpret the current bar (which may not be finished) use MaxBarsAgo=0 (you should never trigger a trade before the end of the bar and that is why I use MaxBarsAgo=1).

I would never recommend this as any back test using this setting is impossible to back test since you cannot use the model "Open Prices ...." which makes back testing almost impossible so that is why I default the setting MaxBarsAgo to 1.
Attached File(s)
File Type: mq4 TradersGift_test.mq4   83 KB | 181 downloads
  • #273
  • Feb 3, 2015 12:36am Feb 3, 2015 12:36am
Quoting Dave_C
I had a query regarding the use of Renko Charts. You can attached the TradersGift EA to the offline Renko chart (File ,Open Offlne) which is created by placing the enclosed EA on a 1 minute chart. You need to keep the 1 minute chart active so that the Renko chart updates in real time. {file} {file}
Dear Dave ,

As soon as i get home i will continue testing with Renko bars. Sorry for the question but i can't check it now on my own. Is there also added to EA any conditions that can be set in order to take trades according to renko bars.
If not i can provide you with the concept that i have introduced you with specified conditions.

I am jusy writting you now because we have very big time difference and probably when i get home you will be already away. Waiting for your advice.
  • #274
  • Edited 8:46am Feb 3, 2015 12:53am | Edited 8:46am
Quoting alex8585
{quote} Dear Dave , As soon as i get home i will continue testing with Renko bars. Sorry for the question but i can't check it now on my own. Is there also added to EA any conditions that can be set in order to take trades according to renko bars. If not i can provide you with the concept that i have introduced you with specified conditions. I am jusy writting you now because we have very big time difference and probably when i get home you will be already away. Waiting for your advice.
If you attach the TradersGift EA to your Renko Bars chart, all calculations will be calculated on the Renko Bars.
(edit - notice the classic divergence on the RSI)
Attached Image (click to enlarge)
Click to Enlarge Name: Renko.jpg Size: 93 KB
  • #275
  • Feb 3, 2015 2:26am Feb 3, 2015 2:26am
Dear Dave,
Could you share your RSI 15 min presets?
  • #276
  • Feb 3, 2015 6:52am Feb 3, 2015 6:52am
Dave
waiting for presets file for rsi 15 mins.
  • #277
  • Feb 3, 2015 8:12am Feb 3, 2015 8:12am
Quoting anuj20jain
Dave waiting for presets file for rsi 15 mins.
Enclosed
Attached File(s)
File Type: zip TG_15_RSI_SLMultiplier_TWMultiplier.zip   21 KB | 282 downloads
  • #278
  • Feb 3, 2015 8:57am Feb 3, 2015 8:57am
Dave,

The Candlestick Filter worked well this morning on the move by EU i had a short on and it closed it early. I put this filter in before the start of the morning US session.

With the Support and Resistance Filter, what are you calculating this off of? Daily hi and low or is it a deviation level? Would you say daily high and low from the day before is a good level followed by weekly open etc.
forex forex forex
  • #279
  • Feb 3, 2015 9:47am Feb 3, 2015 9:47am
Quoting Dave_C
{quote} I appreciate your response. I had thought after I had posted that the naming of the variables might cause a problem. C1 & O1 refers to 2 bars ago, C & O refer to 1 bar ago. If you want to interpret the current bar (which may not be finished) use MaxBarsAgo=0 (you should never trigger a trade before the end of the bar and that is why I use MaxBarsAgo=1). I would never recommend this as any back test using this setting is impossible to back test since you cannot use the model "Open Prices ...." which makes back testing almost impossible so...
Hi Dave,

Yes, I understand the problem with using the current bar in calculations. That's why I added that the trade should be taken after the close of the current bar. So we're saying the same thing.

The reason I simplified the trade logic from your original bearish engulfing candle to a basic reversal candle was to make it easier to eyeball the chart to make sure the EA was indeed functioning as intended. Again, there's no reason why the reversal code I wrote would result in the sell that occurs on Oct. 31 in the chart example I provided. Something's not right.

By the way, you'll notice the white arrows on the chart. They're plotted by an indicator with the exact same trade logic. The arrow appears on the trigger candle at the close of the candle. This indicator is very simple and works exactly as intended. Your EA is wonderful with all that it can accomplish, but it's too complicated for me to figure out what part of the code is interfering with the trade logic.

I hope I've made myself clear.

Kind regards,
drofwarc
  • #280
  • Feb 3, 2015 10:00am Feb 3, 2015 10:00am
Hi Dave,

Another thing I found when testing the reversal candle code is that the time filter is not working. The attached image shows my settings. Activating the filter has no impact on the EAs' behavior.
Attached Image (click to enlarge)
Click to Enlarge Name: Trading_hours.png Size: 8 KB
2 traders viewing now