Please help a noob - order closing issue | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

NoOb in need of help! 25 replies

Pls help noob calling simple DLL 4 replies

noob/noob-like question about ROI in forex 2 replies

Noob needs help ... 1 reply

NOOB question, plz help 3 replies

Attachments: Please help a noob - order closing issue
Exit Attachments

Please help a noob - order closing issue

  • #1
  • First Post: Jan 10, 2015 1:13am Jan 10, 2015 1:13am
Hi

Why is this not working if I may ask:

The EA works when I have only the profit side of things but when I add the loss side as well it opens and closes the orders immediately after opening the pending orders that it places.I just want the EA to close all order when a certain profit or loss level is reached.....

(Please bear in mind I only started coding about a month ago.Also how do I add code in that funny window here at FF and not in the main post.)



In the Global area I declare :


"
double initaite_equity=0;
"


In the "init" I declare :

"
initaite_equity=AccountEquity();

"




Then in the OnTick:

if(Enable_Total_Profit==true)
{
if(AccountEquity()-initaite_equity>=Total_Profit)
{
Print("The Desired_Profit reached as total profit is at : "+Total_Profit);
CloseAll();
}

if(Enable_Total_Profit==true)
{
if (initaite_equity)-(AccountEquity()>=Total_Loss);
Print("Max Loss reaced at : "+Total_Loss);
CloseAll();
}


}









Thank you for your time

Rooi
We miss 100% of the shots we don't take
  • #2
  • Jan 10, 2015 1:21am Jan 10, 2015 1:21am
You have weird parenthesis in the loss part of the code ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Jan 10, 2015 1:57am Jan 10, 2015 1:57am
Not sure what you mean FerruFx

This better.....

















if(Enable_Total_Profit==true)
{
if(AccountEquity()-initaite_equity>=Total_Profit)
{
Print("The Desired_Profit reached as total profit is at : "+Total_Profit);
CloseAll();
}



}



if(Enable_Total_Profit==true)
{
if (initaite_equity -(AccountEquity())>=Total_Loss);
}
Print("Max Loss reaced at : "+Total_Loss);
CloseAll();
}


}


But just to check my statement for the loss side with an account size of say $5000
if Total_Loss== 30
if (initaite_equity -(AccountEquity())>=Total_Loss);

if (5000 - 4969.99) >= 30
Close()

Thats right isnt it?


Thank for your time

Rooi
We miss 100% of the shots we don't take
  • #4
  • Jan 10, 2015 2:09am Jan 10, 2015 2:09am
It should be fine ...

You still have parenthesis around (AccountEquity()) ... which isn't needed.
MT4/MT5 EAs/Indicators/Alerts coder
  • #5
  • Jan 10, 2015 2:17am Jan 10, 2015 2:17am
I see.

Thank you very much FerruFx

Rooi
We miss 100% of the shots we don't take
  • #6
  • Jan 10, 2015 2:21am Jan 10, 2015 2:21am
You're welcome.
MT4/MT5 EAs/Indicators/Alerts coder
  • #7
  • Jan 10, 2015 2:26am Jan 10, 2015 2:26am
Hi Ferru, quick question. When I have multiple instances of the same indicator in one window eg, multiple stochastics, it only shows the values of the first stoch I add, and not the others. How do I turn this feature on? or maybe I turned it off unknowingly?
In other news: A ranger was trapped between a bull and a bear
  • #8
  • Jan 10, 2015 2:26am Jan 10, 2015 2:26am
Quoting FerruFx
It should be fine ... You still have parenthesis around (AccountEquity()) ... which isn't needed.

The Master speaketh........


You are an amazing guy FF, bless you!
It's hard. Can be painful. But I love this world, this Forex world.....
  • #9
  • Jan 10, 2015 2:31am Jan 10, 2015 2:31am
Quoting digiff
Hi Ferru, quick question. When I have multiple instances of the same indicator in one window eg, multiple stochastics, it only shows the values of the first stoch I add, and not the others. How do I turn this feature on? or maybe I turned it off unknowingly?
To be frank, I don't know. It seems to be a bug in the recent builds ... It's displaying perfectly both values in the (great old) 509 build.
MT4/MT5 EAs/Indicators/Alerts coder
  • #10
  • Jan 10, 2015 2:32am Jan 10, 2015 2:32am
Quoting leozayed
{quote} The Master speaketh........ You are an amazing guy FF, bless you!
MT4/MT5 EAs/Indicators/Alerts coder
  • #11
  • Jan 10, 2015 2:36am Jan 10, 2015 2:36am
Quoting FerruFx
{quote} To be frank, I don't know. It seems to be a bug in the recent builds ... It's displaying perfectly both values in the (great old) 509 build.
Thanks for clearing that up. I thought it was happening only on my mt4. I tried turning on and off a few things, like object descriptions etc, but nothing works. Anyway, not a big issue.
In other news: A ranger was trapped between a bull and a bear
  • #12
  • Jan 10, 2015 3:18am Jan 10, 2015 3:18am
Quoting Rooi
Hi Why is this not working if I may ask: The EA works when I have only the profit side of things but when I add the loss side as well it opens and closes the orders immediately after opening the pending orders that it places.I just want the EA to close all order when a certain profit or loss level is reached..... (Please bear in mind I only started coding about a month ago.Also how do I add code in that funny window here at FF and not in the main post.) In the Global area I declare : " double initaite_equity=0; " In the "init" I declare : " initaite_equity=AccountEquity();...
Hi Rooi,

I am not good in coding but I am using one EA for myself and I am attaching here. I just used that EA to close all positions when it reaches certain amount of equity; You can try.
Attached File(s)
File Type: ex4 close all orders equity DD% profitfarmer.ex4   11 KB | 366 downloads
Love for all; Hatred for none.
  • #13
  • Jan 10, 2015 3:58am Jan 10, 2015 3:58am
Quoting aahmad29
{quote} Hi Rooi, I am not good in coding but I am using one EA for myself and I am attaching here. I just used that EA to close all positions when it reaches certain amount of equity; You can try. {file}
Hi aahmad.

Thanks for the EA.Will see how I can use it.

By the way.Nice work with your trading journal and trading so far this year.Hope it continues for the rest of the year but I'm sure it will

All the best

Rooi
We miss 100% of the shots we don't take
  • #14
  • Last Post: Jul 5, 2016 4:00am Jul 5, 2016 4:00am
Quoting aahmad29
{quote} Hi Rooi, I am not good in coding but I am using one EA for myself and I am attaching here. I just used that EA to close all positions when it reaches certain amount of equity; You can try. {file}
I tried this EA on my live account but it closes all opened orders, but when i try on demo it works correctly, do you have the mql of this EA for check about this error
Failure is not failure if you learn from it...
0 traders viewing now