Code help needed please - Order select | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Signaling a change in "select/unselect" an Object into an Indic. code 10 replies

Help please with code - pending order cannot open 3 replies

Please help me code a simple order based EA 3 replies

2 simple lines of code needed, please help 18 replies

Please help me select a Broker that meets my requirements 5 replies

Attachments: Code help needed please - Order select
Exit Attachments

Code help needed please - Order select

  • #1
  • First Post: Dec 17, 2014 5:53am Dec 17, 2014 5:53am
Times must be bad if I cannot see the wood for the trees!
The following code should give me data about the open position for the chart pair BUT I get data for a different chart pair... why??
On the GBP chart the comment gives correctly the chart pair but the order symbol and data are for AUD ... how can that be when it should not enter the "if(OrderSymbol() == Symbol()) " section ??

PRIZE to whoever answers correctly first .... Free day off from trading on Christmas day :-)
Happy Christmas everyone.

Inserted Code
void UpdateOpenTrades()             
 {
   int c, mOrdTotal;
   bool mOp;
   mOrdTotal = OrdersTotal();
      for(c = mOrdTotal - 1; c >= 0; c--)
       {
         mOp = OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
         if(OrderSymbol() == Symbol()) && OrderMagicNumber() == mMagicN)
           {
             if(OrderType() == OP_BUY || OrderType() == OP_SELL)
              {
                DelPending();
               
Comment(Symbol(), "  ", OrderSymbol(), "  ", OrderType(), "  ", DoubleToStr(OrderLots(), 2));  

                if(OrderType() == OP_BUY)
                  mTradeData[0] = 1;
                else
                  mTradeData[0] = 2;
                mTradeData[1] = OrderOpenTime();
                mTradeData[2] = OrderTicket();
                mTradeData[5] = NormalizeDouble(OrderLots(), mLotSizeDigits);
                if(iTime(NULL, 1440, 0) > OrderOpenTime())
                  {
                    if(TimeDayOfWeek(iTime(NULL, 1440, 0)) != 1)
                      {
                        mTradeData[3] = iHigh(NULL, 1440, 1);
                        mTradeData[4] = iLow(NULL, 1440, 1);
                      }
                    else
                      {
                        mTradeData[3] = iHigh(NULL, 1440, 2);
                        mTradeData[4] = iLow(NULL, 1440, 2);
                      }
                  }
                if(mTradeData[0] == 1)
                  {
                    mTradeData[6] = NormalizeDouble(OrderOpenPrice() - OrderStopLoss(), mLotSizeDigits);
                  }
                else
                  {
                    mTradeData[6] = NormalizeDouble(OrderStopLoss() - OrderOpenPrice(), mLotSizeDigits);
                  }
                mOpenUpdated = true;
              }   // if BUY/SELL
            }     // if Symb
         
           if(mOp != true) 
            { 
              int mError = GetLastError(); 
              Alert(Symbol(), " Error UpdateOpen = ", ErrorDescription(mError)); 
            }
       }    // for c
      
   return;
 }

TIA.
M.
If you think I'm mad, I must be mad
  • #2
  • Dec 17, 2014 6:50am Dec 17, 2014 6:50am
OK I win the prize and get to have the day off on the 25th ..........

The call to "DelPending()"; was checking orders and in so doing cycled through until the last order and, therefore giving the data for that order. Obviously that call needs to be in a different place.

I must be getting old and or slow :-(

M.
Attached Image
If you think I'm mad, I must be mad
  • #3
  • Dec 17, 2014 7:10am Dec 17, 2014 7:10am
You have a right parenthesis which isn't needed in the below:

Inserted Code
if(OrderSymbol() == Symbol()) && OrderMagicNumber() == mMagicN)

And be sure to not make an OrderSelect(...) call inside your initial OrderSelect(...).
MT4/MT5 EAs/Indicators/Alerts coder
  • #4
  • Dec 17, 2014 7:14am Dec 17, 2014 7:14am
Hi Ferru,
Thanks for response, your talent always respected.
Right about the ')' but that wasn't the issue (well spotted).

Yes it was the 2nd call withing the first orderselect .... but for the life of me I could not see that for a v long time!!!

Thanks again,
M.

EDIT:
And the next prize ( a day off from trading on NEW Years Day) goes to the person who can tell me how many times I was insistent that MT4 must be at fault! ;-)
If you think I'm mad, I must be mad
  • #5
  • Last Post: Dec 17, 2014 7:17am Dec 17, 2014 7:17am
MT4/MT5 EAs/Indicators/Alerts coder
0 traders viewing now