This code is making me crazy

Why would this code:

//+------------------------------------------------------------------+
//| Crear_subdirectorio.mq4 |
//| Copyright 2014, MetaQuotes Software Corp. |
//| http://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2014, MetaQuotes Software Corp."
#property link "http://www.mql5.com"
#property version "1.00"
#property strict
#property script_show_inputs
input string nombre="PRUEBA.txt";
//+------------------------------------------------------------------+
//| Script program start function |
//+------------------------------------------------------------------+
void OnStart()
{
int handle;
//---
ResetLastError();
if(handle=FileOpen(nombre,FILE_READ)!=INVALID_HANDLE)
//Se ha abierto correctament
{
Alert("Open Succesfully");
Alert("Pointer is: ", FileTell(handle));

while(!FileIsLineEnding(handle))
{
FileReadString(handle);
}

FileClose(handle);
Alert("Last Error= ", GetLastError());
}
else
Alert("File not open and last error was= ", GetLastError());


}
//+------------------------------------------------------------------+

Work sometimes, sometimes work one time and the time I try it doesnt work....

Now is not reading anything and give no errors...

The file is ok and in the right place...

help!

I'm only guessing, as I haven't done any MT4 coding since build 509.

Also not sure whether your code is MQL4 or MQL5, as there appears to be references to both in your code.

You've opened your file without explicitly specifying FILE_BIN or FILE_CSV. FileIsLineEnding is designed to work with CSV (text) files only. If the MT4 compiler/runtime defaults to FILE_BIN, this could potentially cause unpredictable results with FileIsLineEnding. Hence you could try explicitly specifying FILE_CSV, to avoid any possible ambiguity.

Also not sure if you must explicitly specify a line terminator (e.g. CR and/or LF), after build 600.

Like I said, just my best guess. I can't see anything else obviously wrong, except that ResetLastError() was invalid prior to MT4 build 600.

Hello there!

Thank you for your answer, the code is mixed because after 600+ lots of things between mt4 and mt5 have been mixed. http://docs.mql4.com/

I think you could be right, but somehow the code started working with FileLineisEnding(), now I have managed to make it work with FileisEnding. Also in my last code I forgot to Print the result of FileRead -_-.

Here is the new code and see if I can find a way of reading lines with text, I suppose I need to find the character of change of line for txt files.

Greetings

Belikewater


//+------------------------------------ ------------------------------+
//| Crear_subdirectorio.mq4 |
//| Copyright 2014, MetaQuotes Software Corp. |
//| http://www.mql5.com |
//+------------------------------------ ------------------------------+
#property copyright "Copyright 2014, MetaQuotes Software Corp."
#property link "http://www.mql5.com"
#property version "1.00"
#property strict
#property script_show_inputs
input string nombre="datos.txt";
//+------------------------------------ ------------------------------+
//| Script program start function |
//+------------------------------------ ------------------------------+
void OnStart()
{
int handle;
//---
Alert("---------------------------");
ResetLastError();
if(handle=FileOpen(nombre,FILE_READ)!=INVALID_HANDLE)
//Se ha abierto correctament
{
Alert("Open Succesfully");
Alert("Pointer is: ", FileTell(handle));

while(!FileIsEnding(handle))
{
Alert(FileReadString(handle));
}

Alert("Pointer is 2: ", FileTell(handle));
FileClose(handle);
Alert("Last Error= ", GetLastError());
}
else
Alert("File not open and last error was= ", GetLastError());
}
//+------------------------------------ ------------------------------+

Ok!! Finally I understand what is happening.

Seems like (dont know why) the pointer starts pointing to an end of line. If I put Alert(FireIsLineEnding(handle)); at the start is returns TRUE! seems like we have to play with this. Interesting.

RESOLVED!

BeLikeWater

Excellent!

I copied your original code and had similar results, so I changed it to the code below:


I have run it a few times and it works as expected. Perhaps you can adapt this to suit your needs?...

OD