Order delete error 4108 (with 2 open orders) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA error message (0) no error 6 replies

MT4 EA error- when placing trade getting error 0 rate on ask 3 replies

problem with pending order throwing error 130 on order send 2 replies

script to "close open orders" and "open opposite orders" 3 replies

EA failed to update stop error 0/4108 2 replies

Order delete error 4108 (with 2 open orders)

  • #1
  • First Post: Oct 30, 2014 8:05am Oct 30, 2014 8:05am
Ei there programming guring wish you could help me with this code. Im using this one to close the open orders, it does work when I have only 1 trade open, but when I have 2 trades it only close one, and gives the "Order delete error 4108". Anyone has an idea of what to do?


for (int i=1; i<=OrdersTotal(); i++) //Cycle for all orders..
{ //displayed in the terminal
if(OrderSelect(i-1,SELECT_BY_POS)==true)//If there is the next one
{
Alert("HA ENTRADO OrderTicket 0 ", OrderTicket());
if (OrderType()==OP_BUY)
{OrderClose(OrderTicket(),OrderLots(),Bid,25);}
if (OrderType()==OP_SELL)
{OrderClose(OrderTicket(),OrderLots(),Ask,25);}

}
}
Greetings, BeLikewater
  • #2
  • Oct 30, 2014 8:36am Oct 30, 2014 8:36am
Your loop is wrong. Try this instead :

Inserted Code
for(int i = OrdersTotal()-1; i >= 0; i--) {
 if(!OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) continue;
...
...
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Oct 30, 2014 8:42am Oct 30, 2014 8:42am
The issue is that you need to count down your orders and not count up, where you were using i++, FerruFX rightly identifies i--.
" check out The Traders Outpost "
  • #4
  • Oct 30, 2014 8:51am Oct 30, 2014 8:51am
Quoting RedLineFred
The issue is that you need to count down your orders and not count up, where you were using i++, FerruFX rightly identifies i--.
Exactly. Because if you close the #1 before #2, the #2 become #1 and can't be close because the #1 were closed previously. That's just a basic explanation but to understand how it works.
MT4/MT5 EAs/Indicators/Alerts coder
  • #5
  • Oct 30, 2014 9:17am Oct 30, 2014 9:17am
BTW this was masterfully explained in a great article on MQL few years back by a great contributor ... and if I am not mistaken, it was by RaptorUK.
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Oct 30, 2014 9:29am Oct 30, 2014 9:29am
Thank you Ferrux. This is awesome. Im just a newbie in the programming community, but now what I do mostly its to program my ideas. I will read that tutorial. Thank you.
Greetings, BeLikewater
  • #7
  • Last Post: Oct 30, 2014 9:37am Oct 30, 2014 9:37am
Quoting BeLikeWater
Thank you Ferrux. This is awesome. Im just a newbie in the programming community, but now what I do mostly its to program my ideas. I will read that tutorial. Thank you.
You're welcome.
MT4/MT5 EAs/Indicators/Alerts coder
0 traders viewing now