Help Fix Bug in Daily-Weekly-Monthly Hi-Low indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MT4 indicator to display yearly, monthly, & weekly high/low data 6 replies

Need Help for Weekly Monthly High Low Indicator 8 replies

Price below/above daily/weekly/monthly open indicator 13 replies

cTrader Monthly, Weekly High-Low Indicator 0 replies

Monthly/Weekly High/Low & 50% line indicator 4 replies

Attachments: Help Fix Bug in Daily-Weekly-Monthly Hi-Low indicator
Exit Attachments

Help Fix Bug in Daily-Weekly-Monthly Hi-Low indicator

  • #1
  • First Post: Oct 19, 2014 8:28pm Oct 19, 2014 8:28pm
Daily-Weekly-Monthly Hi-Low.mq4 is usuful indicator which many people use. However, I found a bug in this indicator which doesn't allow to draw shapes in my chart. Not only shapes, it also removes displays of certain indicator. For example, please see attached picture. In the left chart, I didn't include Daily-Weekly-Monthly Hi-Low, while in right chart, I inculded Daily-Weekly-Monthly Hi-Low. Then I included II_SupDemMOD indicator and draw a blue rectangle in both charts. As a result, the right chart (which contains Daily-Weekly-Monthly Hi-Low) doesn't display either blue rentagle or II_SupDemMOD. I remember this issue happend after I upgraded my MT4 to the new build early this year. Could anyone please fix this bug in Daily-Weekly-Monthly Hi-Low.mq4? Thanks.
Attached Image (click to enlarge)
Click to Enlarge Name: 2014-10-20_09-57-01.png Size: 36 KB
Attached File(s)
File Type: mq4 Daily-Weekly-Monthly Hi-Low.mq4   20 KB | 1,160 downloads
File Type: ex4 II_SupDemMOD.ex4   20 KB | 801 downloads
Simplicity is the ultimate sophistication - Leonardo da Vinci
  • #2
  • Edited Oct 20, 2014 1:36am Oct 19, 2014 10:42pm | Edited Oct 20, 2014 1:36am
Quoting heispark
Daily-Weekly-Monthly Hi-Low.mq4 is usuful indicator which many people use. However, I found a bug in this indicator which doesn't allow to draw shapes in my chart. Not only shapes, it also removes displays of certain indicator. For example, please see attached picture. In the left chart, I didn't include Daily-Weekly-Monthly Hi-Low, while in right chart, I inculded Daily-Weekly-Monthly Hi-Low. Then I included II_SupDemMOD indicator and draw a blue rectangle in both charts. As a result, the right chart (which contains Daily-Weekly-Monthly Hi-Low)...
Hi,
Its not a bug as you put it is just very badly written code ( I refer to my code not the original authors code ), I used an existing indicator as a code base and added my modifications to it back in 2006, I guess we all had to start somewhere.
Probably the best thing to do would be to totally rewrite it however at the moment I do not have the spare time to do that.

I managed to do a quick fix of the object delete issues so this should resolve your problems.
Attached File(s)
File Type: ex4 Daily-Weekly-Monthly Hi-Low nmc.ex4   41 KB | 1,364 downloads
Trade what you see not what you hope
  • #3
  • Oct 19, 2014 11:01pm Oct 19, 2014 11:01pm
Quoting cja
{quote} Hi, Its not a bug as you put it is just very badly written code ( I refer to my code not the original authors code ), I used an existing indicator as a code base and added my modifications to it back in 2006, I guess we all had to start somewhere. Probably the best thing to do would be to totally rewrite it however at the moment I do not have the spare time to do that.
Thank you for you feedback. Then can you sugget any possible replacement which has smilar feature? I made a broad research but couldn't find anything fit my demand except this indicator... I really liked this indicator and as far as I know many people still use this....
Simplicity is the ultimate sophistication - Leonardo da Vinci
  • #4
  • Edited 3:54am Oct 20, 2014 1:17am | Edited 3:54am
Somebody helped me finding better alternative....
My problem solved!
Attached File(s)
File Type: ex4 Daily-Weekly-Monthly Hi-Low4.ex4   26 KB | 1,403 downloads
Simplicity is the ultimate sophistication - Leonardo da Vinci
  • #5
  • Oct 20, 2014 3:41am Oct 20, 2014 3:41am
Quoting cja
{quote} Hi, Its not a bug as you put it is just very badly written code ( I refer to my code not the original authors code ), I used an existing indicator as a code base and added my modifications to it back in 2006, I guess we all had to start somewhere. Probably the best thing to do would be to totally rewrite it however at the moment I do not have the spare time to do that. I managed to do a quick fix of the object delete issues so this should resolve your problems. {file}
Surprise, Surprise, Surprise!! I even didn't expect I would be helped so quickly. The issue's perfectly fixed in this new version. CJA, you're my super hero. I even don't know how to thank you.
Thank you so~so much. I owe you much.

Regards,
Simplicity is the ultimate sophistication - Leonardo da Vinci
  • #6
  • Last Post: Aug 24, 2019 9:21pm Aug 24, 2019 9:21pm
Quoting heispark
Somebody helped me finding better alternative.... My problem solved! {file}
Bump to an old thread...

This one is a great indicator! The only problem is I do not see that shift of label option is working??

In fact, I would love for someone to add the option in inputs True/False to show the labels.

If anyone has the mql4 file can do this it would be greatly appreciated or just share the mql4 & I'll get it done.

Thanks in advance.

I am attaching the indi
Attached File(s)
File Type: ex4 Daily-Weekly-Monthly Hi-Low4.ex4   26 KB | 427 downloads
Find The Pain Points On Your Chart & Trade Off Those Levels
0 traders viewing now