Change the period on this indicator please

Hi Can someone please do me a favor by change the default period from 4H, 1H, 5m to MN, W1 and D1?
Is it possible to leave column so that we can change the alert period to other?

Thanks!

just do a find and replace and recompile....

Hi Max,I tried that, but too many error appear....don't know where I am doing wrong?...

//+------------------------------------------------------------------+
//| 3 Ducks Alert.mq4 |
//| yantz |
//| [email protected] |
//| This is a multi-symbol indicator for |
//| Andy's 3 Ducks System. It can monitor |
//| 1 or more symbols and can be set with |
//| an alert. |
//+------------------------------------------------------------------+
#property copyright "yantz"
#property link "[email protected]"
#property indicator_chart_window
#property indicator_buffers 1
#property indicator_color1 SeaGreen
extern string allsymbol = "EURUSD,GBPUSD,AUDUSD,NZDUSD,USDJPY,USDCAD,USDCHF,AUDJPY,EURJPY,GBPJPY,CADJPY,EURGBP,EURAUD,EURCAD,#CLG4,XAUUSD"; // all symbols, comma separated
extern bool SetAlert = True;
int NumOfPairs = 0;
double CrossUp[], alertTag;
int init()
{ SetIndexStyle(0, DRAW_ARROW, EMPTY,1);
SetIndexArrow(0, 234);
SetIndexBuffer(0, CrossUp);
bool symcntend = False; // count the number of symbols listed
while (!symcntend)
{ string thissymbol = StringSplit(allsymbol, ",", NumOfPairs);
if (thissymbol == "") symcntend = True;
else NumOfPairs++;
}
ObjectCreate("InfoSection",OBJ_LABEL,0,0,0);
ObjectSet("InfoSection",OBJPROP_XDISTANCE,4);
ObjectSet("InfoSection",OBJPROP_YDISTANCE,20);
ObjectSetText("InfoSection","Symbol - MN - W1 - D1",8,"Arial",White);
for (int j=0;j<NumOfPairs;j++)
{ int startheight = 30;
thissymbol = StringSplit(allsymbol, ",", j); // split the symbols list
ObjectCreate("symbol"+j,OBJ_LABEL,0,0,0);
ObjectSet("symbol"+j,OBJPROP_XDISTANCE,4);
ObjectSet("symbol"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectSetText("symbol"+j,thissymbol,8,"Arial",White);
ObjectCreate("MN"+j,OBJ_LABEL,0,0,0);
ObjectSet("MN"+j,OBJPROP_XDISTANCE,60);
ObjectSet("MN"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectCreate("w1"+j,OBJ_LABEL,0,0,0);
ObjectSet("w1"+j,OBJPROP_XDISTANCE,90);
ObjectSet("w1"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectCreate("d1"+j,OBJ_LABEL,0,0,0);
ObjectSet("d1"+j,OBJPROP_XDISTANCE,120);
ObjectSet("d1"+j,OBJPROP_YDISTANCE,startheight+j*15);
}
return(0);
}
int deinit()
{ ObjectDelete("InfoSection");
for (int j=0;j<10;j++)
{ ObjectDelete("symbol"+j);
ObjectDelete("MN"+j);
ObjectDelete("w1"+j);
ObjectDelete("d1"+j);
}
return(0);
}
int start()
{ string MNtxt, w1txt, d1txt;
color MNclr, w1clr, d1clr;

for (int i=0;i<NumOfPairs;i++)
{ string thissymbol = StringSplit(allsymbol, ",", i); // split the symbols list
double sma60mn = iMA(thissymbol,PERIOD_MN,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60w1 = iMA(thissymbol,PERIOD_w1,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60d11 = iMA(thissymbol,PERIOD_d1,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60d12 = iMA(thissymbol,PERIOD_d1,60,0,MODE_SMA,PRICE_CLOSE,1);

if (iClose(thissymbol,PERIOD_MN,0) > sma60MN)
{ MNtxt = "bull";
MNclr = Green;
}
else
{ MNtxt = "bear";
MNclr = Red;
}
if (iClose(thissymbol,PERIOD_w1,0) > sma60w1)
{ w1txt = "bull";
w1clr = Green;
}
else
{ w1txt = "bear";
w1clr = Red;
}
if (iClose(thissymbol,PERIOD_d1,0) > sma60d11)
{ d1txt = "bull";
d1clr = Green;
}
else
{ d1txt = "bear";
d1clr = Red;
}
ObjectSetText("MN"+i,MNtxt,8,"Arial",MNclr);
ObjectSetText("w1"+i,w1txt,8,"Arial",w1clr);
ObjectSetText("d1"+i,d1txt,8,"Arial",d1clr);
if (SetAlert && alertTag != iTime(thissymbol,PERIOD_d1,0))
{ if (MNtxt == "bull" && w1txt == "bull" && d1txt == "bull" && iHigh(thissymbol,PERIOD_d1,1) < sma60d12)
{ Alert("Bull trend on all 3 TF for ",thissymbol);
alertTag = iTime(thissymbol,PERIOD_d1,0);
}
else if (MNtxt == "bear" && w1txt == "bear" && d1txt == "bear" && iLow(thissymbol,PERIOD_d1,1) > sma60d12)
{ Alert("Bear trend on all 3 TF for ",thissymbol);
alertTag = iTime(thissymbol,PERIOD_d1,0);
}
}
}
CrossUp[0] = 0;
return(0);
}
string StringSplit(string input,string sep, int index) // split string function by irusow1 from http://www.metaquotes.com
{ int count=0, oldpos=0, pos=StringFind(input,sep,0);
while(pos>=0&&count<=index)
{ if(count==index)
{ if(pos==oldpos) return("");
else return(StringSubstr(input,oldpos,pos-oldpos));
}
oldpos=pos+StringLen(sep);
pos=StringFind(input,sep,oldpos);
count++;
}
if(count==index) return(StringSubstr(input,oldpos));
return("");
}

That is because the code won't compile before you make any changes
I had a look at the code and spotted some errors due to reserved words being used in the old code. They probably weren't reserved when the indicator was written.

I have just made changes so that it will compile, but not really looked at the logic of the code or changed the timeframes. No time, I'm afraid.
Check that this code does as expected and then you can try MaxDoom's suggestion

very nice indicator, if the option is made to chose time frame as requested it will be awesome.

Thanks Gumrai!
I find and replace the timeframes to the one I wish...and it looks as below:


//+------------------------------------------------------------------+
//| 3 Ducks Alert.mq4 |
//| This is a multi-symbol indicator for |
//| Andy's 3 Ducks System. It can monitor |
//| 1 or more symbols and can be set with |
//| an alert.
//| Modified By GumRai | |
//+------------------------------------------------------------------+
#property copyright ""
#property link ""
#property indicator_chart_window
#property indicator_buffers 1
#property indicator_color1 SeaGreen
extern string allsymbol = "EURUSD,GBPUSD,AUDUSD,NZDUSD,USDJPY,USDCAD,USDCHF,AUDJPY,EURJPY,GBPJPY,CADJPY,EURGBP,EURAUD,EURCAD,#CLG4,XAUUSD"; // all symbols, comma separated
extern bool SetAlert = True;
int NumOfPairs = 0;
string Pairs[];
double CrossUp[], alertTag;
int init()
{ SetIndexStyle(0, DRAW_ARROW, EMPTY,1);
SetIndexArrow(0, 234);
SetIndexBuffer(0, CrossUp);
NumOfPairs=StringSplit(allsymbol,StringGetCharacter(",",0),Pairs);

ObjectCreate("InfoSection",OBJ_LABEL,0,0,0);
ObjectSet("InfoSection",OBJPROP_XDISTANCE,4);
ObjectSet("InfoSection",OBJPROP_YDISTANCE,20);
color col=ChartGetInteger(0,CHART_COLOR_FOREGROUND,0);
ObjectSetText("InfoSection","Symbol - MN - W1 - D1",8,"Arial",col);
for (int j=0;j<NumOfPairs;j++)
{ int startheight = 30;
string thissymbol = Pairs[j];
ObjectCreate("symbol"+j,OBJ_LABEL,0,0,0);
ObjectSet("symbol"+j,OBJPROP_XDISTANCE,4);
ObjectSet("symbol"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectSetText("symbol"+j,thissymbol,8,"Arial",col);
ObjectCreate("MN"+j,OBJ_LABEL,0,0,0);
ObjectSet("MN"+j,OBJPROP_XDISTANCE,60);
ObjectSet("MN"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectCreate("W1"+j,OBJ_LABEL,0,0,0);
ObjectSet("W1"+j,OBJPROP_XDISTANCE,90);
ObjectSet("W1"+j,OBJPROP_YDISTANCE,startheight+j*15);
ObjectCreate("D1"+j,OBJ_LABEL,0,0,0);
ObjectSet("D1"+j,OBJPROP_XDISTANCE,120);
ObjectSet("D1"+j,OBJPROP_YDISTANCE,startheight+j*15);
}
return(0);
}
int deinit()
{ ObjectDelete("InfoSection");
for (int j=0;j<NumOfPairs;j++)
{ ObjectDelete("symbol"+j);
ObjectDelete("MN"+j);
ObjectDelete("W1"+j);
ObjectDelete("D1"+j);
}
return(0);
}
int start()
{ string MNtxt, W1txt, D1txt;
color MNclr, W1clr, D1clr;

for (int i=0;i<NumOfPairs;i++)
{ string thissymbol = Pairs[i];
double sma60MN = iMA(thissymbol,PERIOD_MN,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60W1 = iMA(thissymbol,PERIOD_W1,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60D11 = iMA(thissymbol,PERIOD_D1,60,0,MODE_SMA,PRICE_CLOSE,0);
double sma60D12 = iMA(thissymbol,PERIOD_D1,60,0,MODE_SMA,PRICE_CLOSE,1);

if (iClose(thissymbol,PERIOD_MN,0) > sma60MN)
{ MNtxt = "bull";
MNclr = Green;
}
else
{ MNtxt = "bear";
MNclr = Red;
}
if (iClose(thissymbol,PERIOD_W1,0) > sma60W1)
{ W1txt = "bull";
W1clr = Green;
}
else
{ W1txt = "bear";
W1clr = Red;
}
if (iClose(thissymbol,PERIOD_D1,0) > sma60D11)
{ D1txt = "bull";
D1clr = Green;
}
else
{ D1txt = "bear";
D1clr = Red;
}
ObjectSetText("MN"+i,MNtxt,8,"Arial",MNclr);
ObjectSetText("W1"+i,W1txt,8,"Arial",W1clr);
ObjectSetText("D1"+i,D1txt,8,"Arial",D1clr);
if (SetAlert && alertTag != iTime(thissymbol,PERIOD_D1,0))
{ if (MNtxt == "bull" && W1txt == "bull" && D1txt == "bull" && iHigh(thissymbol,PERIOD_D1,1) < sma60D12)
{ Alert("Bull trend on all 3 TF for ",thissymbol);
alertTag = iTime(thissymbol,PERIOD_D1,0);
}
else if (MNtxt == "bear" && W1txt == "bear" && D1txt == "bear" && iLow(thissymbol,PERIOD_D1,1) > sma60D12)
{ Alert("Bear trend on all 3 TF for ",thissymbol);
alertTag = iTime(thissymbol,PERIOD_D1,0);
}
}
}
CrossUp[0] = 0;
return(0);
}

After compiled, the error message was :
'PERIOD_MN' - undeclared identifier 3 Ducks Alert v1.11.mq4 71 37

'PERIOD_MN' - undeclared identifier 3 Ducks Alert v1.11.mq4 71 37 PERIOD_MN does not exist it should be PERIOD_MN1.

Thanks cja, finally I got it done!
Here I attached for those who are interested in this indicator.

It is the 3 duck's system indi, but I just change the Period from M5, H1,H4 to MN1, W1 and D1 to suite my trading style

Hi,
I had a play with the code and rewrote it so you can select the timeframes in what ever sequence you want or how many you want. I have not put in an Alert and probably will not have the time to do so.

Brilliant