What is the code line to check if there is an existing trade? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

SL and TP trend line EA - altering existing code 15 replies

Code To Check If There Are Consecutive Sell or Buy Candles 1 reply

Creating trend line alert for my existing indicator 0 replies

Need Help please : Check code on Divergence Indicator 4 replies

Can somebody check my code??? 3 replies

What is the code line to check if there is an existing trade?

  • #1
  • First Post: Jul 23, 2014 12:20am Jul 23, 2014 12:20am
Hello, What is the code line in expert adviser (MT4) to check if there is an existing trade?
So the additional trade can be entered with expert adviser.
I need a sample code.
Please advice the thread or link.

Kind Regards,
Adilius
  • #2
  • Jul 23, 2014 1:30am Jul 23, 2014 1:30am
Quoting Adilius07
Hello, What is the code line in expert adviser (MT4) to check if there is an existing trade?
you should not only check if (OrdersTotal()==1 && rsi<level) opentrade, when counting open trades it makes more sense to filter by magicnumber (and symbol) ...

google (eg mql4 + count open trades) or forumsearch should give you lots answers ...
PM me with coding requests and I'll probably put you on my ignore list
  • #3
  • Jul 23, 2014 1:36am Jul 23, 2014 1:36am
Quoting fxdaytrader_
{quote} you should not only check if (OrdersTotal()==1 && rsi<level) opentrade, when counting open trades it makes more sense to filter by magicnumber (and symbol) ... google (eg mql4 + count open trades) or forumsearch should give you lots answers ...
Thank you Fx, I will copy what you said and try to understand it better. Yes I need to search more
  • #4
  • Jul 24, 2014 4:40am Jul 24, 2014 4:40am
Inserted Code
 
 
int open_trades(int ctype = 0, int magic = 0)
{
   int mttype = signal_to_mql(ctype);
  
   int ret = 0;
  
    for(int j=0;j<OrdersTotal();j++)
    {
        if(OrderSelect(j,SELECT_BY_POS,MODE_TRADES)==false)
            continue;
      
      if(OrderSymbol() != Symbol()) continue;
      
      if(magic == 0 || OrderMagicNumber() == magic)
      {
          if(ctype == 0)
             ret += 1;
          else
          {
             if(ctype == +1 && (OrderType() == OP_BUY || OrderType() == OP_BUYLIMIT || OrderType() == OP_BUYSTOP))
               ret += 1;
             if(ctype == -1 && (OrderType() == OP_SELL || OrderType() == OP_SELLLIMIT || OrderType() == OP_SELLSTOP))
               ret += 1;
         }
         }
    }
   return ret;
}
int signal_to_mql(int sig)
{
   if(sig == -1) return (OP_SELL);
   if(sig == +1) return (OP_BUY);
   return (0);
}

ctype == 0 for both, -1 for shorts, +1 for longs
magic == 0 for all, otherwise it filters accordingly.


More of these functions can be found in my algotrading framework, DATFRA. You can find it here: http://www.forexfactory.com/showthread.php?p=7595120

After the first startup of the tool, it will download my MQL Library

-Darwin

PS: remove the line "if(OrderSymbol() != Symbol()) continue;" if you want to count the open trades for ALL pairs, not just the current!
  • #5
  • Last Post: Jul 24, 2014 10:37am Jul 24, 2014 10:37am
Quoting Darwin-FX
int open_trades(int ctype = 0, int magic = 0) { int mttype = signal_to_mql(ctype); int ret = 0; for(int j=0;j<OrdersTotal();j++) { if(OrderSelect(j,SELECT_BY_POS,MODE_TRADES)==false) continue; if(OrderSymbol() != Symbol()) continue; if(magic == 0 || OrderMagicNumber() == magic) { if(ctype == 0) ret += 1; else { if(ctype == +1 && (OrderType() == OP_BUY || OrderType() == OP_BUYLIMIT || OrderType() == OP_BUYSTOP)) ret += 1; if(ctype == -1 && (OrderType() == OP_SELL || OrderType() == OP_SELLLIMIT || OrderType() == OP_SELLSTOP)) ret += 1; } } } return...

Hello Darwin, thank you very very much! I need to work with the code and understand it. I am not a programmer but I can do it. Thank you so much. Now I have something to work with.
0 traders viewing now