Indicator showing dots rather than lines

Hi All,
The indicator with code below is supposed to draw and identify S/R lines but I can only see dots. What could be wrong? See attached pic too.

//+------------------------------------------------------------------+
//| KG Support & Resistance.mq4 |
//| Copyright 2007, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//| modify by frantacech |
//+------------------------------------------------------------------+
#property copyright "Kang_Gun"
#property link "http://www.free-knowledge.com"
string Revision = "Revision 2";
//-------------------------------------------------------------------
// Revision 1 = frantacech add allert, email and SR TF options
// Revision 2 = KG speed up the SR level
#property indicator_chart_window
#property indicator_buffers 8
#property indicator_color1 Yellow
#property indicator_color2 Yellow
#property indicator_color3 LimeGreen
#property indicator_color4 LimeGreen
#property indicator_color5 Blue
#property indicator_color6 Blue
#property indicator_color7 Red
#property indicator_color8 Red
//---- input parameters
extern bool AlertPossible = true;
extern bool AlertOnlySound = false;
extern string Sound = "tick.wav";
extern bool SendMailPossible = false;
extern bool ShowM15 = true;
extern bool ShowH1 = true;
extern bool ShowH4 = true;
extern bool ShowD1 = true;

//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
double ExtMapBuffer3[];
double ExtMapBuffer4[];
double ExtMapBuffer5[];
double ExtMapBuffer6[];
double ExtMapBuffer7[];
double ExtMapBuffer8[];
int KG;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
if (ShowM15) {
SetIndexStyle(0,DRAW_ARROW,STYLE_DOT,1,Yellow);
SetIndexDrawBegin(0,KG-1);
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexLabel(0,"Resistance M15");
SetIndexArrow(0, 158);
SetIndexStyle(1,DRAW_ARROW,STYLE_DOT,1,Yellow);
SetIndexDrawBegin(1,KG-1);
SetIndexBuffer(1,ExtMapBuffer2);
SetIndexLabel(1,"Support M15");
SetIndexArrow(1, 158);
}
if (ShowH1) {
SetIndexStyle(2,DRAW_ARROW,STYLE_DOT,1,LimeGreen);
SetIndexDrawBegin(2,KG-1);
SetIndexBuffer(2,ExtMapBuffer3);
SetIndexLabel(2,"Resistance H1");
SetIndexArrow(2, 158);
SetIndexStyle(3,DRAW_ARROW,STYLE_DOT,1,LimeGreen);
SetIndexDrawBegin(3,KG-1);
SetIndexBuffer(3,ExtMapBuffer4);
SetIndexLabel(3,"Support H1");
SetIndexArrow(3, 158);
}
if (ShowH4) {
SetIndexStyle(4,DRAW_ARROW,STYLE_DOT,1,Blue);
SetIndexDrawBegin(4,KG-1);
SetIndexBuffer(4,ExtMapBuffer5);
SetIndexLabel(4,"Resistance H4");
SetIndexArrow(4, 158);
SetIndexStyle(5,DRAW_ARROW,STYLE_DOT,1,Blue);
SetIndexDrawBegin(5,KG-1);
SetIndexBuffer(5,ExtMapBuffer6);
SetIndexLabel(5,"Support H4");
SetIndexArrow(5, 158);
}
if (ShowD1) {
SetIndexStyle(6,DRAW_ARROW,STYLE_DOT,1,Red);
SetIndexDrawBegin(6,KG-1);
SetIndexBuffer(6,ExtMapBuffer7);
SetIndexLabel(6,"Resistance D1");
SetIndexArrow(6, 158);
SetIndexStyle(7,DRAW_ARROW,STYLE_DOT,1,Red);
SetIndexDrawBegin(7,KG-1);
SetIndexBuffer(7,ExtMapBuffer8);
SetIndexLabel(7,"Support D1");
SetIndexArrow(7, 158);
}
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
return(0);
}
//------------------------------------------------------------------
bool Fractal (string M,int P, int shift)
{
if (Period()>P) return(-1);
P=P/Period();
if (shift<P)return(-1);
if (shift>Bars-P)return(-1);
for (int i=1;i<=P;i++)
{
if (M=="U")
{
if (High[shift+i]>High[shift])return(-1);
if (High[shift-i]>=High[shift])return(-1);
}
if (M=="L")
{
if (Low[shift+i]<Low[shift])return(-1);
if (Low[shift-i]<=Low[shift])return(-1);
}
}
return(1);
}
//------------------------------------------------------------------
int start()
{
int D1=1440, H4=240, H1=60, M15=15;
KG=Bars;
while(KG>=0)
{
if (ShowM15)
{
if (Fractal("U",M15,KG)==1)
{
ExtMapBuffer1[KG]=High[KG];
if (ExtMapBuffer1[KG]==Bid) {MakeAlert("M15 Res", KG); }
}
else {ExtMapBuffer1[KG]=ExtMapBuffer1[KG+1]; if (ExtMapBuffer1[KG]==Bid) {MakeAlert("M15 Res", KG); }}
if (Fractal("L",M15,KG)==1)
{
ExtMapBuffer2[KG]=Low[KG];
if (ExtMapBuffer2[KG]==Bid) {MakeAlert("M15 Sup", KG); }
}
else {ExtMapBuffer2[KG]=ExtMapBuffer2[KG+1]; if (ExtMapBuffer2[KG]==Bid) {MakeAlert("M15 Sup", KG); }}
}
if (ShowH1)
{
if (Fractal("U",H1,KG)==1)
{
ExtMapBuffer3[KG]=High[KG];
if (ExtMapBuffer3[KG]==Bid) {MakeAlert("H1 Res", KG); }
}
else {ExtMapBuffer3[KG]=ExtMapBuffer3[KG+1]; if (ExtMapBuffer3[KG]==Bid) {MakeAlert("H1 Res", KG); }}
if (Fractal("L",H1,KG)==1)
{
ExtMapBuffer4[KG]=Low[KG];
if (ExtMapBuffer4[KG]==Bid) {MakeAlert("H1 Sup", KG); }
}
else {ExtMapBuffer4[KG]=ExtMapBuffer4[KG+1]; if (ExtMapBuffer4[KG]==Bid) {MakeAlert("H1 Sup", KG); }}
}
if (ShowH4)
{
if (Fractal("U",H4,KG)==1)
{
ExtMapBuffer5[KG]=High[KG];
if (ExtMapBuffer5[KG]==Bid) {MakeAlert("H4 Res", KG); }
}
else {ExtMapBuffer5[KG]=ExtMapBuffer5[KG+1]; if (ExtMapBuffer5[KG]==Bid) {MakeAlert("H4 Res", KG); }}
if (Fractal("L",H4,KG)==1)
{
ExtMapBuffer6[KG]=Low[KG];
if (ExtMapBuffer6[KG]==Bid) {MakeAlert("H4 Sup", KG); }
}
else {ExtMapBuffer6[KG]=ExtMapBuffer6[KG+1]; if (ExtMapBuffer6[KG]==Bid) {MakeAlert("H4 Sup", KG); }}
}
if (ShowD1)
{
if (Fractal("U",D1,KG)==1)
{
ExtMapBuffer7[KG]=High[KG];
if (ExtMapBuffer7[KG]==Bid) {MakeAlert("D1 Res", KG); }
}
else {ExtMapBuffer7[KG]=ExtMapBuffer7[KG+1]; if (ExtMapBuffer7[KG]==Bid) {MakeAlert("D1 Res", KG); }}
if (Fractal("L",D1,KG)==1)
{
ExtMapBuffer8[KG]=Low[KG];
if (ExtMapBuffer8[KG]==Bid) {MakeAlert("D1 Sup", KG); }
}
else {ExtMapBuffer8[KG]=ExtMapBuffer8[KG+1]; if (ExtMapBuffer8[KG]==Bid) {MakeAlert("D1 Sup", KG); }}
}
KG--;
}
return(0);
}
//+------------------------------------------------------------------+
datetime AlertTime;
void MakeAlert(string _Notice, int Index)
{
if (Index >= 1) return;
if (AlertTime == iTime(Symbol(), Period(), Index)) return;

AlertTime = iTime(Symbol(), Period(), Index);
string Notice = StringConcatenate("Cross ", Symbol(), " ", _Notice);
if (AlertPossible) {PlaySound(Sound); if (AlertOnlySound==false) {Alert(Notice);}}
if (SendMailPossible) SendMail(Notice, "");
}

No. This indicator is doing what it is supposed to : drawing dots.

Due to the failure of such new build metatrader
See the original

http://www.forexfactory.com/showthre...27#post2217427

Hi FerryFx and PDA , Thanks for your responses. It appears that If you look up PDA's response, you will see that the code is the same code I supplied and yet it used to generate lines. So it must be down to what he suggested which is that there is something wrong with new build MT4, Could there be a fix for this? As in is there a way to amend the code so that it draws lines rather than dots? One other thing, the dots seem to be on all bars whereas in the original case only appropriate lines were drawn. Hope you can help
Kind regards

Again, the code you provided is for drawing dots (arrows) not line.

Dear FerruFx, Thanks for your reply. I have gone into the code and modified it to:SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,1,Yellow);
Now the indicator is drawing continuous lines as shown below. It ought to draw lines only when the logic holds true. Kindly look at the logic and see if you can identify the incriminating line. May it please you to profer a remedy.
Thanks.

In order to know if the indicator is coded correctly, the very first thing is to know the rules ...

I suppose the rules are for the indicator to find fractals and use them as a basis for drawing resistance and support lines. The other aspect is to have the lines from the 3 chosen timeframes displayed on all timeframes. Iguess that is what is contained in this aspect of the code:
//------------------------------------ ------------------------------
int start()
{
int D1=1440, H4=240, H1=60, M15=15;
KG=Bars;
while(KG>=0)
{
if (ShowM15)
{
if (Fractal("U",M15,KG)==1)
{
ExtMapBuffer1[KG]=High[KG];
if (ExtMapBuffer1[KG]==Bid) {MakeAlert("M15 Res", KG); }
}
else {ExtMapBuffer1[KG]=ExtMapBuffer1[KG+1]; if (ExtMapBuffer1[KG]==Bid) {MakeAlert("M15 Res", KG); }}
if (Fractal("L",M15,KG)==1)
{
ExtMapBuffer2[KG]=Low[KG];
if (ExtMapBuffer2[KG]==Bid) {MakeAlert("M15 Sup", KG); }
}
else {ExtMapBuffer2[KG]=ExtMapBuffer2[KG+1]; if (ExtMapBuffer2[KG]==Bid) {MakeAlert("M15 Sup", KG); }}
}
if (ShowH1)
{
if (Fractal("U",H1,KG)==1)
{
ExtMapBuffer3[KG]=High[KG];
if (ExtMapBuffer3[KG]==Bid) {MakeAlert("H1 Res", KG); }
}
else {ExtMapBuffer3[KG]=ExtMapBuffer3[KG+1]; if (ExtMapBuffer3[KG]==Bid) {MakeAlert("H1 Res", KG); }}
if (Fractal("L",H1,KG)==1)
{
ExtMapBuffer4[KG]=Low[KG];
if (ExtMapBuffer4[KG]==Bid) {MakeAlert("H1 Sup", KG); }
}
else {ExtMapBuffer4[KG]=ExtMapBuffer4[KG+1]; if (ExtMapBuffer4[KG]==Bid) {MakeAlert("H1 Sup", KG); }}
}
if (ShowH4)
{
if (Fractal("U",H4,KG)==1)
{
ExtMapBuffer5[KG]=High[KG];
if (ExtMapBuffer5[KG]==Bid) {MakeAlert("H4 Res", KG); }
}
else {ExtMapBuffer5[KG]=ExtMapBuffer5[KG+1]; if (ExtMapBuffer5[KG]==Bid) {MakeAlert("H4 Res", KG); }}
if (Fractal("L",H4,KG)==1)
{
ExtMapBuffer6[KG]=Low[KG];
if (ExtMapBuffer6[KG]==Bid) {MakeAlert("H4 Sup", KG); }
}
else {ExtMapBuffer6[KG]=ExtMapBuffer6[KG+1]; if (ExtMapBuffer6[KG]==Bid) {MakeAlert("H4 Sup", KG); }}
}
if (ShowD1)
{
if (Fractal("U",D1,KG)==1)
{
ExtMapBuffer7[KG]=High[KG];
if (ExtMapBuffer7[KG]==Bid) {MakeAlert("D1 Res", KG); }
}
else {ExtMapBuffer7[KG]=ExtMapBuffer7[KG+1]; if (ExtMapBuffer7[KG]==Bid) {MakeAlert("D1 Res", KG); }}
if (Fractal("L",D1,KG)==1)
{
ExtMapBuffer8[KG]=Low[KG];
if (ExtMapBuffer8[KG]==Bid) {MakeAlert("D1 Sup", KG); }
}
else {ExtMapBuffer8[KG]=ExtMapBuffer8[KG+1]; if (ExtMapBuffer8[KG]==Bid) {MakeAlert("D1 Sup", KG); }}
}
KG--;
}
return(0);
}

Cheers.

I doubt as it isn't doing what you want ...

We can't define the rules based on a wrong code. You must define the exact rules.

hello,
try this, original version, no alert