Open Trades Indicator - Help Needed | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Getting a handle to open trades in the open trade tab 3 replies

Seeking Help for Open & Close Trades On New Bar Open 6 replies

Close all open trades if current total open lotsize exceeds"X" 0 replies

Help Needed: EA to open opposite position of another EA 1 reply

[mt4] Indicator that draws Open price from different TF - help needed 3 replies

Attachments: Open Trades Indicator - Help Needed
Exit Attachments

Open Trades Indicator - Help Needed

  • #1
  • First Post: Jun 24, 2014 7:32am Jun 24, 2014 7:32am
Hi, I need help for this indicator.

This is my code example:
Inserted Code
    int orders = OrdersTotal();
    int a_ticket[];
    ArrayResize( a_ticket, orders );
    for (int cnt=0;cnt<orders;cnt++)
    {
        if ( !OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        a_ticket[cnt]=OrderTicket();   
    
    ObjectCreate("OrderNumber_Label", OBJ_LABEL, 0, 0, 0);
   ObjectSetText("OrderNumber_Label", a_ticket[cnt], 10, "Arial Bold", White);
   ObjectSet("OrderNumber_Label", OBJPROP_CORNER, 0);
   ObjectSet("OrderNumber_Label", OBJPROP_XDISTANCE, 100);
   ObjectSet("OrderNumber_Label", OBJPROP_YDISTANCE, 260);    
    }

But when orders is more than one, in indicator nothing change.
I'm beginer.

Attached Image (click to enlarge)
Click to Enlarge Name: hfyjgyk.PNG Size: 6 KB


This is how indicator look like


PS. Sorry I don't know english well ((
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #2
  • Jun 24, 2014 7:40am Jun 24, 2014 7:40am
You must increase Y distance for each order in the loop ... and of course set a different name for each order.
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Jun 24, 2014 7:45am Jun 24, 2014 7:45am
Thank you for replying FerruFX.

I kwon, but I don't know how? ((
I want to start indicator from 260 Y distance and than I don't know how to increase ((
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #4
  • Jun 24, 2014 8:15am Jun 24, 2014 8:15am
I change order names

Inserted Code
    int orders = OrdersTotal();
    int a_ticket[];
    ArrayResize( a_ticket, orders );
    for (int cnt=0;cnt<orders;cnt++)
    {
        if ( !OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        a_ticket[cnt]=OrderTicket();   
   string OrderNumber = "Ticket Number" +a_ticket[cnt];
    ObjectCreate(OrderNumber, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(OrderNumber, a_ticket[cnt], 10, "Arial Bold", White);
   ObjectSet(OrderNumber, OBJPROP_CORNER, 0);
   ObjectSet(OrderNumber, OBJPROP_XDISTANCE, 100);
   ObjectSet(OrderNumber, OBJPROP_YDISTANCE, 260);    
    }

And now it looks like that
Attached Image


But all tickets is one line
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #5
  • Jun 24, 2014 8:19am Jun 24, 2014 8:19am
Quoting mr-roma
Thank you for replying FerruFX. I kwon, but I don't know how? (( I want to start indicator from 260 Y distance and than I don't know how to increase ((
Before the loop you must define your starting Y ... ie. int y = 260;

Then in the loop (after the object), increase the Y to go below the 1st row ... ie. y += 20;
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Jun 24, 2014 8:27am Jun 24, 2014 8:27am
Ok, I do this, but like that

Inserted Code
string Ydistance = 260 + (5 * orders) * cnt;

Attached Image


Inserted Code
    int orders = OrdersTotal();
    int a_ticket[];
    ArrayResize( a_ticket, orders );
    for (int cnt=0;cnt<orders;cnt++)
    {
        if ( !OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        a_ticket[cnt]=OrderTicket();   
   string OrderNumber = "Ticket Number" +a_ticket[cnt];
   string Ydistance = 260 + (5 * orders) * cnt;
    ObjectCreate(OrderNumber, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(OrderNumber, a_ticket[cnt], 10, "Arial Bold", White);
   ObjectSet(OrderNumber, OBJPROP_CORNER, 0);
   ObjectSet(OrderNumber, OBJPROP_XDISTANCE, 100);
   ObjectSet(OrderNumber, OBJPROP_YDISTANCE, Ydistance);    
    }

But I don't know if this code is good and right

Thank you
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #7
  • Jun 24, 2014 8:53am Jun 24, 2014 8:53am
If it gives you what you are looking for, so fine ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #8
  • Jun 24, 2014 9:40am Jun 24, 2014 9:40am
Quoting mr-roma
Ok, I do this, but like that string Ydistance = 260 + (5 * orders) * cnt;
Why you define a number as string?
As FerruFx already pointed out to you, it should read like so:
Before the loop you define:
int Ydistance = 260, ystep = 20;
Then, within the loop you increment (at the end):
Ydistance += ystep;

Also, what do you need the array for? After selecting an order you can use OrderTicket() as often as you need.
Return To Disorder
  • #9
  • Jun 25, 2014 12:23am Jun 25, 2014 12:23am
Thank you all for help

I have also this problem

Inserted Code
    int tickettype = OrdersTotal();
    int T_ticket[];
    ArrayResize( T_ticket, tickettype );
    for (int tcnt=0;tcnt<tickettype;tcnt++)
    {
        if ( !OrderSelect(tcnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        T_ticket[tcnt]=OrderProfit();   
   string Ordertype = "Ticket Type " +T_ticket[tcnt];
   string Ydistance1 = 263 + (6 * tickettype) * tcnt;
    ObjectCreate(Ordertype, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(Ordertype, T_ticket[tcnt]+" $", 10, "Arial Bold", White);
   ObjectSet(Ordertype, OBJPROP_CORNER, 0);
   ObjectSet(Ordertype, OBJPROP_XDISTANCE, 200);
   ObjectSet(Ordertype, OBJPROP_YDISTANCE, Ydistance1);    
   
    }

This code show all opened ticket profits, but when profits is changing, old profit numbers is not deleting

Attached Image


Can anyone help me?
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #10
  • Jun 25, 2014 12:26am Jun 25, 2014 12:26am
Quoting mr-roma
Thank you all for help I have also this problem int tickettype = OrdersTotal(); int T_ticket[]; ArrayResize( T_ticket, tickettype ); for (int tcnt=0;tcnt<tickettype;tcnt++) { if ( !OrderSelect(tcnt,SELECT_BY_POS,MODE_TRADES) ) continue; T_ticket[tcnt]=OrderProfit(); string Ordertype = "Ticket Type " +T_ticket[tcnt]; string Ydistance1 = 263 + (6 * tickettype) * tcnt; ObjectCreate(Ordertype, OBJ_LABEL, 0, 0, 0); ObjectSetText(Ordertype, T_ticket[tcnt]+" $", 10, "Arial Bold", White); ObjectSet(Ordertype, OBJPROP_CORNER, 0); ObjectSet(Ordertype, OBJPROP_XDISTANCE,...
You must check closed orders and remove their own label on chart.
MT4/MT5 EAs/Indicators/Alerts coder
  • #11
  • Jun 25, 2014 12:32am Jun 25, 2014 12:32am
But this orders in't closed, this all is opened trades and just changing profit price, up or down.

Attached Image
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #12
  • Jun 25, 2014 12:39am Jun 25, 2014 12:39am
Quoting mr-roma
But this orders in't closed, this all is opened trades and just changing profit price, up or down. {image}
Certainly because you are renaming the objects each time without removing the old ones.

You should have a unique name for each row ... so no matter which order is plotted.
MT4/MT5 EAs/Indicators/Alerts coder
  • #13
  • Jun 25, 2014 12:48am Jun 25, 2014 12:48am
Ok, I find problem for this one


Just I delete +T_ticket
Inserted Code
string Ordertype = "Ticket Type " +T_ticket[tcnt];

Inserted Code
string Ordertype = "Ticket Type " +tcnt;

Thank you
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #14
  • Jun 25, 2014 1:30am Jun 25, 2014 1:30am
And can you help me on this FerruFX?

Inserted Code
 
    int ticketOpnp = OrdersTotal();
    int o_ticket[];
    ArrayResize( o_ticket, ticketOpnp );
    for (int ocnt=0;ocnt<ticketOpnp;ocnt++)
    {
        if ( !OrderSelect(ocnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        o_ticket[ocnt]=OrderOpenPrice();   
   string OrderOpnp = "Ticket Open Price " +o_ticket[ocnt];
   string Ydistance2 = 263 + (6 * ticketOpnp) * ocnt;
    ObjectCreate(OrderOpnp, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(OrderOpnp, o_ticket[ocnt], 10, "Arial Bold", White);
   ObjectSet(OrderOpnp, OBJPROP_CORNER, 0);
   ObjectSet(OrderOpnp, OBJPROP_XDISTANCE, 500);
   ObjectSet(OrderOpnp, OBJPROP_YDISTANCE, Ydistance2);    
   
    }

Attached Image
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #15
  • Jun 25, 2014 1:33am Jun 25, 2014 1:33am
You defined the price as an integer ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #16
  • Jun 25, 2014 1:40am Jun 25, 2014 1:40am
Sorry (( can you helpm to do this?

I don't understand well ((
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #17
  • Jun 25, 2014 1:44am Jun 25, 2014 1:44am
No no thank you, I do this

Attached Image


"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #18
  • Jun 25, 2014 1:47am Jun 25, 2014 1:47am
Quoting mr-roma
No no thank you, I do this {image}
MT4/MT5 EAs/Indicators/Alerts coder
  • #19
  • Jun 25, 2014 9:56am Jun 25, 2014 9:56am
Quoting FerruFx
{quote}
FerruFx can you help me on this?

Attached Image


Inserted Code
    int ticketTime = OrdersTotal();
    string tm_ticket;
    //ArrayResize( o_ticket, ticketOpnp );
    for (int tmcnt=0;tmcnt<ticketTime;tmcnt++)
    {
        if ( !OrderSelect(tmcnt,SELECT_BY_POS,MODE_TRADES) ) continue;
        tm_ticket=OrderOpenTime();   
   string Ordertime = "Order Time " +tmcnt;
   string Ydistancetm = 263 + (5 * ticketTime) * tmcnt;
    ObjectCreate(Ordertime, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(Ordertime, tm_ticket, 10, "Arial Bold", White);
   ObjectSet(Ordertime, OBJPROP_CORNER, 0);
   ObjectSet(Ordertime, OBJPROP_XDISTANCE, 185);
   ObjectSet(Ordertime, OBJPROP_YDISTANCE, Ydistancetm);    
   
    }
"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren
  • #20
  • Jun 25, 2014 10:02am Jun 25, 2014 10:02am
Attached Image (click to enlarge)
Click to Enlarge Name: fs.PNG Size: 27 KB
0 traders viewing now