Question about coding money management

#1
First Post: Jun 19, 2014 2:05pm Jun 19, 2014 2:05pm

Thepipster
| Joined May 2012 | Status: Working the mine. | 404 Posts

I need help understanding how to correctly input the right settings to get the results I want for money management.
I need 0.03 lot size for every $100 of account balance, and the EA opens multiple orders to be closed on a equity profit target, which I want to be $35. This is supposed to be setup where the equity profit target goes up as the lot size goes up, not balance. The lot size automatically increases when the account balance increases, and I wanted the equity profit target to be relative to the lot size...so if trading with 0.04 lots, the target would move up to $46.66~. Great for compounding. I don't need to change the coding, unless it's faulty, but need to understand if my settings will work? For example, since I need 0.03 lot size for every $100 of accnt balance, with a target of $35 per 0.03 lot size, this should translate to: if I had $7500 account balance, then 2.25 lots with $2624.xx equity target. Or if accnt balance was $33.33~, then lot size would be 0.01, with $11.66~ target. here's the code:

extern double LotPercent = 3

extern double EquityGainMultiple = 35

\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ blah, blah, blah

int i;
double Step = MarketInfo(Pair,MODE_LOTSTEP);

if(Lots!=0)
LS=Lots;
else
LS = MathCeil((LotPercent/1000)*AccountBalance())*Step;

EquityGain = EquityGainMultiple*100*LS;
double EquityLoss = EquityLossMultiple*100*LS;

thanks

Too close for pips, switching to points.

#2
Last Post: Jun 19, 2014 5:24pm Jun 19, 2014 5:24pm

fxdaytrader_
Joined Jan 2011 | Status: UberTroll | 1,847 Posts

I think it has some flaws (no converting to usd, etc.), but it seems to be better than nothing

->

example call for BUY-trade:

Inserted Code

lots /*TO USE ON ORDERSEND()*/ = CalcLotsAndCheckMargin(Symbol(),OP_BUY,lots,RiskPercentage,ask,sl);

external inputs:

Inserted Code

//
extern string rah="Use risk based lotsize, instead of fixed lots?";
extern string rah1="   if no SL is specified, the script calculates with 30pips";
extern bool   UseLotsPerRiskCalculation=TRUE;
extern double RiskPercentage=2.5;
extern bool   DoFreeMarginCheck          = FALSE;//should check if there is enough free margin to open the trade
extern bool   DoFreeMarginForSlAlsoCheck = FALSE;//checks if there is also enough free margin for a (potentially) SL-hit
//

functions:

Inserted Code

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
//risk/lots calculation stuff:
double CalcLotsAndCheckMargin(string symbol,int type,double lots,double RiskPercentage,double price,double SLprice) {
 
 if (MathAbs(RiskPercentage)>0.000 && UseLotsPerRiskCalculation) lots = CalculateLotSize(symbol,RiskPercentage,lots,price,SLprice);//if using risk-based calculation
 if (DoFreeMarginCheck) lots = FreeMarginCheck(symbol,type,lots,price,SLprice);//do we have enough free margin?
  else if (!DoFreeMarginCheck) lots = NormalizeLots(symbol,lots);
 return(lots);
}
double CalculateLotSize(string symbol,double RiskPercent,double lots,double BidAskPrice,double SLprice) {
   //Calculate the lot size by risk. Code kindly supplied by jmw1970. Nice one jmw (see www.SteveHopwoodForex.com), code adapted/modified by fxdaytrader (e.g. inputs)
      
 
  //mod. - if there is no SLprice specified, the script would work with 50 pips (you can change that, search for the 30 in the code some lines below) ...
  if (SLprice==0) SLprice = BidAskPrice+(30*pips2dbl);
    
   lots = NormalizeLots(symbol,lots);//to normalize and eventually set back to MODE_MINLOTS in case we have to return them now:, fxdaytrader
   if (RiskPercent==0.0) return(lots); //nothing to do ..., fxdaytrader
   if (BidAskPrice == 0.00000 || SLprice == 0.00000) return(lots);//Just in case to prevent occurring strange calculations, fxdaytrader
   
   double FreeMargin = AccountFreeMargin();
    //double TickValue = MarketInfo(symbol,MODE_TICKVALUE) ;
   //fix tickvalue for extremely rare occasion when a change in ticksize leads to a change in tickvalue, source: http://forum.mql4.com/29781, fxdaytrader
   double TickValue = MarketInfo(symbol,MODE_TICKVALUE) * MarketInfo(symbol,MODE_POINT) / MarketInfo(symbol,MODE_TICKSIZE);
   double LotStep = MarketInfo(symbol,MODE_LOTSTEP);
   double SLPts = MathAbs(BidAskPrice - SLprice);
   
   SLPts/= MarketInfo(symbol,MODE_POINT);//No idea why *= factor does not work here, but it doesn't
   
   double Exposure = SLPts * TickValue; // Exposure based on 1 full lot
   double AllowedExposure = (FreeMargin * RiskPercent) / 100;
   
   //int TotalSteps = ((AllowedExposure / Exposure) / LotStep);
   double TotalSteps = ((AllowedExposure / Exposure) / LotStep);//changed to double, fxdaytrader
   double LotSize = TotalSteps * LotStep;
   
   return(NormalizeLots(symbol,LotSize));
}//double CalculateLotSize(string symbol,double RiskPercent,double lots,double BidAskPrice,double SLprice) {
///////////////////////////////////////////////////////////////////////////////
//start freemargincheck
/*
  Usage: before the OrderSend-Command you may set your already calculated lotsize = FreeMarginCheck(string symbol,int ordertype,double lots,double BidAskPrice,double SLprice)
  if there is no SLprice specified, the script would work with 50 pips (you can change that, search for the 30 in the code some lines below) ...
*/
double FreeMarginCheck(string symbol,int ordertype,double lots,double BidAskPrice,double SLprice) { //fxdaytrader
  lots = NormalizeLots(symbol,lots);
  if (CheckAccountFreeMargin(symbol,ordertype,lots)) return(lots);//everything ok
 
  //adjust:
  Print("... not enough money, will try to decrease lotsize of "+DoubleToStr(lots,MarketInfo(symbol,MODE_DIGITS))+" (max. lots: "+DoubleToStr(MarketInfo(symbol,MODE_MAXLOT),MarketInfo(symbol,MODE_DIGITS))+" | min. lots: "+DoubleToStr(MarketInfo(symbol,MODE_MINLOT),MarketInfo(symbol,MODE_DIGITS))+") ...");
  if (SLprice==0.0) {
    //x-digit broker adjust
     int Multiplier = 1;
     double digits=MarketInfo(symbol,MODE_DIGITS);
     if (digits==3 || digits==5) Multiplier = 10;
     if (digits==6) Multiplier = 100;   
     if (digits==7) Multiplier = 1000;
     double pips2dbl = Multiplier*MarketInfo(symbol,MODE_POINT);
    //end x-digit broker adjust
   Print("... no SL specified, will count with 30 pips instead ...");
   SLprice = BidAskPrice+(30*pips2dbl);
  }//if (SLprice==0.0) {
 
  double ls=MarketInfo(symbol,MODE_LOTSTEP);
  while (!CheckAccountFreeMargin(symbol,ordertype,lots))
   {
    //lots = lots - ls;
    lots = NormalizeLots(symbol,lots - ls);
   }//while (!CheckAccountFreeMargin(symbol,ordertype,lots))
 
  if (DoFreeMarginForSlAlsoCheck) {
   Print("... lotsize adjusted to "+DoubleToStr(lots,MarketInfo(symbol,MODE_DIGITS))+", checking for enough free margin for SL now ...");
   lots = NormalizeLots(symbol,CheckMarginAndNormalizeLotSize(symbol,lots,BidAskPrice,SLprice,AccountFreeMargin()));
  }
  Print("... done - lotsize finally adjusted to "+DoubleToStr(lots,MarketInfo(symbol,MODE_DIGITS))+" ...");
 
 return(lots);//everything ok now, hopefully ... ;)
}//double FreeMarginCheck(string symbol,int ordertype,double lots) { //fxdaytrader
bool CheckAccountFreeMargin(string symbol,int ordertype,double lots) {
 if (ordertype==OP_BUYSTOP || ordertype==OP_BUYLIMIT) ordertype=OP_BUY;
 if (ordertype==OP_SELLSTOP || ordertype==OP_SELLLIMIT) ordertype=OP_SELL;
//nice formula/workaround, source/found at http://www.earnforex.com/blog/ordersend-error-134-no-enough-money/, fxdaytrader
  if ( ((AccountStopoutMode()==1) && (AccountFreeMarginCheck(symbol,ordertype,lots) > AccountStopoutLevel()))
  || ( (AccountStopoutMode()==0)  && (((AccountFreeMarginCheck(symbol,ordertype,lots)/AccountEquity())*100) > AccountStopoutLevel()))) return(true);//everything seems to be ok
   else return(false);
}//bool CheckAccountFreeMargin(string symbol,int ordertype,double lots) {
double CheckMarginAndNormalizeLotSize(string symbol,double lots,double BidAskPrice,double SLprice,double accBalance) {
//----
 lots = NormalizeLots(symbol,lots);
 
 double SLpips =(MathAbs(BidAskPrice - SLprice))/ MarketInfo(symbol,MODE_POINT);
   
 double ls = MarketInfo(symbol,MODE_LOTSTEP);
 double MarginRequired = MarketInfo(symbol,MODE_MARGINREQUIRED);
 //double accBalance = AccountFreeMargin();
 // fix tickvalue for extremely rare occasion when a change in ticksize leads to a change in tickvalue, source: http://forum.mql4.com/29781
 double tickValueReliable = MarketInfo(symbol,MODE_TICKVALUE) * MarketInfo(symbol,MODE_POINT) / MarketInfo(symbol,MODE_TICKSIZE);
  //Print("checkMarginAndNormalizeLotSize() - checking free margin (currency="+AccountCurrency()+"): free margin required for "+DoubleToStr(lots,3)+" lots: "+DoubleToStr(lots * MarginRequired,2)+" | for SL: "+DoubleToStr(lots * SLpips * PointValuePerLot(symbol),2)+" = total: "+DoubleToStr(lots * MarginRequired+lots * SLpips * PointValuePerLot(symbol),2)+" | current free margin: "+DoubleToStr(AccountFreeMargin(),2)+"");
  if (accBalance < lots * SLpips * tickValueReliable + lots * MarginRequired)
  //old: if (accBalance < lots * SLpips * PointValuePerLot(symbol) + lots * MarginRequired) // do we have enough money for that trade?
  { // if not, try to decrease lots:  
    if (lots>MarketInfo(symbol,MODE_MAXLOT)) lots=MarketInfo(symbol,MODE_MAXLOT);//saves time ...
   while (accBalance < (lots * SLpips * tickValueReliable) + (lots * MarginRequired))
    {
     lots = lots - ls;
     lots = NormalizeLots(symbol,lots);
    }
  }
//----
 //if (lots <= 0.0) lots = -1;
 if (lots <= 0.0) lots = MarketInfo(symbol,MODE_MINLOT);//return the minimum if everything other fails ...
 return(lots);
}//double CheckMarginAndNormalizeLotSize(string symbol,double lots,double BidAskPrice,double SLprice,double accBalance) {
//end freemargincheck
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////

PM me with coding requests and I'll probably put you on my ignore list

Platform Tech
/
Question about coding money management
Reply to Thread

0 traders viewing now

Options

Similar Threads

Question about coding money management