Logic Question on Trade Exit Code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

help to reveal logic of ex4 code? 1 reply

How to code this logic? 7 replies

LOGIC question 0 replies

Can't find the logic error in this simple code 2 replies

Code or Logic for identifying non retraced movement of X Pips 0 replies

Logic Question on Trade Exit Code

  • #1
  • First Post: Edited 9:14am May 31, 2014 8:45am | Edited 9:14am
Which logical statement is preferable coding?


if (OrderType() == OP_BUY && (iOpen(NULL,1,1) && iClose(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3)) )
result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Red );

or

if (OrderType() == OP_BUY && (iOpen(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3))
&& (iClose(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3)))
result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Red );


I'm using the first one above just fine (at least it compiles and executes trades fine), but was wondering if the second one is better or would execute differently? Any thoughts on the logical differences between the two?
  • #2
  • Edited 6:56pm May 31, 2014 5:43pm | Edited 6:56pm
Quoting Pipologist
Which logical statement is preferable coding? if (OrderType() == OP_BUY && (iOpen(NULL,1,1) && iClose(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3)) ) result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Red ); or if (OrderType() == OP_BUY && (iOpen(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3)) && (iClose(NULL,1,1) < NormalizeDouble(OrderOpenPrice()-StopLoss),3))) result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Red ); I'm using the first one above just fine (at least it compiles and executes trades fine),...
I don't believe that your first one will work properly
Personally, I would do it
Inserted Code
if (OrderType()==OP_BUY && MathMax(iOpen(NULL,1,1),iClose(NULL,1,1))<NormalizeDouble(OrderOpenPrice()-StopLoss,3) )
Please Do Not PM Me With Coding Enquiries
  • #3
  • Jun 1, 2014 6:19am Jun 1, 2014 6:19am
Quoting Gumrai
{quote} I don't believe that your first one will work properly Personally, I would do it if (OrderType()==OP_BUY && MathMax(iOpen(NULL,1,1),iClose(NULL,1,1))<NormalizeDouble(OrderOpenPrice()-StopLoss,3) )

The first one is working in live trading, I'm just not sure yet if it is actually checking for both values before closing, but it's compiling perfectly and closing trades at around suggested prices. I just need it to wait and check for both. I'm trying to eliminate potential erroneous price spikes at just the open or close of the bar which would create havoc with this EA that has multiple open positions.

Your mathmax suggestion looks interesting. I may do some massive copy, repasting and testing with it. On second thought after a minute or two, the mathmax won't do what I want it to do.

I want it to check the values twice in one minute and price has be below above or below on both instances not on just the max instance.

Thanks anyway for the suggestion, I guess have to to try testing with my second version of the code instead to see any differences in exit trades.
  • #4
  • Jun 1, 2014 10:17am Jun 1, 2014 10:17am
why do you use normalizedouble for prices? It is nonsense (why do you want to normalize bid/ask/orderopenprice/ordercloseprice/etc.?), see also http://forum.mql4.com/45425
see also http://forum.mql4.com/45425#564188

if you want to normalize prices you could use the following function:
//Open price for pending order must be adjusted to be a multiple of ticksize, not point, and on metals they are not the same.

Inserted Code
double NormalizePrice(string symbol, double price) {
 if (price==0.00000000) return(0.0);
 double ts = MarketInfo(symbol,MODE_TICKSIZE);
return(MathRound(price/ts)*ts );
}

same for lotsizes:

//Lot size must be adjusted to be a multiple of lotstep, which may not be a power of ten on some brokers
//see also the original function by WHRoeder, http://forum.mql4.com/45425#564188, fxdaytrader
Inserted Code
double NormalizeLots(string symbol, double lots) {
  if (MathAbs(lots)<MarketInfo(symbol,MODE_MINLOT)) return(MarketInfo(symbol,MODE_MINLOT));
  if (MathAbs(lots)>MarketInfo(symbol,MODE_MAXLOT)) return(MarketInfo(symbol,MODE_MAXLOT));
  double ls = MarketInfo(symbol,MODE_LOTSTEP);
  lots=MathRound(lots/ls)*ls;
  return(MathMin(MarketInfo(symbol,MODE_MAXLOT),MathMax(MarketInfo(symbol,MODE_MINLOT),lots))); //check if lots >= min. lots && <= max. lots, fxdaytrader
}//double NormalizeLots(string symbol, double lots) {
PM me with coding requests and I'll probably put you on my ignore list
  • #5
  • Last Post: Jun 1, 2014 7:07pm Jun 1, 2014 7:07pm
Quoting fxdaytrader_
why do you use normalizedouble for prices? It is nonsense (why do you want to normalize bid/ask/orderopenprice/ordercloseprice/etc.?), see also http://forum.mql4.com/45425 {
From I read in the posts I think the suggestion is to normalize before sending orders. There are reasons why I would normalize a price, for example when the price is calculated on price + variable.

I think what you are saying is normalizing the pure bid/ask/price based on the server is redundant. But If the EA calculation of the price is bid/ask/open plus a variable amount with excessive decimal places, normalizing to the equivalent lotsize/lotstep for the broker is the only way to send the order properly.

If I'm mistaken in my logic here, please let me know.
0 traders viewing now