Combining two EAs | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Combining strategies 13 replies

combining two pairs 5 replies

Combining pairs to save pips 5 replies

Combining EA Results 2 replies

Combining the trendline and textlabel in MT 0 replies

Attachments: Combining two EAs
Exit Attachments

Combining two EAs

  • #1
  • First Post: May 15, 2014 12:01pm May 15, 2014 12:01pm
Hallo everyone ,
I just wonder if somebody can make these two EAs as one.
Attached File(s)
File Type: mq4 S1.mq4   10 KB | 428 downloads
File Type: mq4 BreakEven_v2.mq4   6 KB | 411 downloads
  • #2
  • May 15, 2014 7:07pm May 15, 2014 7:07pm
if you do not describe what you exactly want nobody will help you ...

I assume you need the breakeven-function in the s1-EA, ...
by the way, this ea seems to not deal with the pip/point-stuff (depending on broker digits).

do you use it on live account?
PM me with coding requests and I'll probably put you on my ignore list
  • #3
  • May 15, 2014 10:39pm May 15, 2014 10:39pm
Yes if possible i whant the two EAs to get together.
  • #4
  • May 15, 2014 10:41pm May 15, 2014 10:41pm
The S1 EA is what i have fixed based on a programme . But i woyld like to put the breakeven option into it . So simple!
  • #5
  • May 16, 2014 7:08am May 16, 2014 7:08am
pls. see attached, also fixed the pips/point-stuff etc.
Attached File(s)
File Type: ex4 S1 EA mod.ex4   14 KB | 425 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #6
  • May 16, 2014 8:38am May 16, 2014 8:38am
Thanks a lot my friend . I will test it and will provide the results .
  • #7
  • May 16, 2014 8:44am May 16, 2014 8:44am
Please tell me soething . If i use 5 digits broker the setting for thw unit is 10=1pip. Correct?
  • #8
  • May 16, 2014 8:52am May 16, 2014 8:52am
i have implemented digit-detection/adjustment, so 10 pip are 10 pip, regardless if it is a 4 or 5 digit-broker ...

Quoting fskliris
I will test it and will provide the results .
I assume the ea will NOT give good results ...
PM me with coding requests and I'll probably put you on my ignore list
  • #9
  • May 16, 2014 10:40am May 16, 2014 10:40am
Is it possible to post the dwcomblind EA here too! Thanks
  • #10
  • May 16, 2014 10:41am May 16, 2014 10:41am
The MQL4 file i mean . The one you posted is EX4 file .
  • #11
  • May 16, 2014 10:45am May 16, 2014 10:45am
it is not possible because I have deleted both (.ex4 and .mq4) file (because I do not need that ea) ...
PM me with coding requests and I'll probably put you on my ignore list
  • #12
  • May 16, 2014 11:13am May 16, 2014 11:13am
anyway thanks a lot !!
  • #13
  • May 17, 2014 3:47am May 17, 2014 3:47am
Perhaps you can get these two EAs together too. Thanks on advance
Attached File(s)
File Type: mq4 BreakEven_v2.mq4   6 KB | 365 downloads
File Type: ex4 BreakEven_v2.ex4   7 KB | 436 downloads
File Type: ex4 Θ1.ex4   12 KB | 392 downloads
File Type: mq4 Θ1.mq4   10 KB | 380 downloads
  • #14
  • May 17, 2014 4:02am May 17, 2014 4:02am
sorry, I have no interest to do it because I do not want to adjust the pips/points-stuff again (the builder does not deal with it, and I am too lazy to change all "Point" again and again, no).

You can try by yourself using the following functions (see attached file).

call the functions by adding
Inserted Code
TradeManagerBE(Symbol(),MagicNumber);
into the start()-part of you ea. Note that you may adjust the variable "MagicNumber", for example if the magic-numberi nput in you ea is "magic", then you must enter "magic" instead of "Magicnumber" ...

in the header-area you put the external params, etc.
Inserted Code
//
extern string  behi = "---------------------------------------------------------------------";
extern string  BE                            = "----BreakEven settings----";
extern bool    BreakEven                     = FALSE;
extern double  BreakEvenPips                 = 34;
extern double  BreakEvenProfit               = 5;
extern bool    HideBreakEvenStop             = FALSE;
extern double  PipsAwayFromVisualBE          = 50;
extern string  sep1 = "---------------------------------------------------------------------";
extern string  JSL                           = "----JumpingStopLoss settings----";
extern bool    JumpingStop                   = FALSE;
extern double  JumpingStopPips               = 38;
extern bool    AddBEP                        = TRUE; //This adds BreakEvenProfits
extern bool    JumpAfterBreakevenOnly        = TRUE;
extern bool    HideJumpingStop               = FALSE;
extern double  PipsAwayFromVisualJS          = 50;
bool ShowAlerts=false;
bool PrintToJournal=TRUE;
int xMultiplier;
double xpips2dbl;

at the end of the ea you add:

Inserted Code
void TradeManagerBE(string symbol,int magicnumber=0) {
bool FilterBySymbol=TRUE;
bool FilterByMagicNumber=TRUE;
 for (int cnt=OrdersTotal()-1; cnt>=0; cnt--) {
  if (!OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES)) continue;
  if (FilterBySymbol && OrderSymbol()!=symbol) continue;
  if (FilterByMagicNumber && OrderMagicNumber()!=magicnumber) continue;
  if (OrderType()>OP_SELL) continue;//only buy and sell trades
   {
    BrokerDigitAdjust(OrderSymbol());
    if (BreakEven) BreakEvenStopLoss();
    if (JumpingStop) JumpingStopLoss();
   }
  }//for (int cnt=OrdersTotal()-1; cnt>=0; cnt--) {
}
void BreakEvenStopLoss() {// Move stop loss to breakeven, based upon/taken from mptm global ea
double ask = MarketInfo(OrderSymbol(),MODE_ASK);
double bid = MarketInfo(OrderSymbol(),MODE_BID);
   //Check hidden BE for trade closure
   if (HideBreakEvenStop)
   {
      bool TradeClosed = CheckForHiddenStopLossHit(OrderType(), PipsAwayFromVisualBE, OrderStopLoss() );
      if (TradeClosed) return;//Trade has closed, so nothing else to do
   }//if (HideBreakEvenStop)
   bool result;
   if (OrderType()==OP_BUY)
         {
            if (bid >= OrderOpenPrice () + (BreakEvenPips * xpips2dbl) &&
                OrderStopLoss()<OrderOpenPrice())
            {
               while (IsTradeContextBusy()) Sleep(100);
               result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+(BreakEvenProfit * xpips2dbl),OrderTakeProfit(),0,CLR_NONE);
               if (result && ShowAlerts==true) Alert("Breakeven set on ", OrderSymbol(), " ticket no ", OrderTicket());
               if (PrintToJournal) Print("Breakeven set on ", OrderSymbol(), " ticket no ", OrderTicket());
               if (!result)
               {
                  int err=GetLastError();
                  if (ShowAlerts==true) Alert("Setting of breakeven SL ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
                  if (PrintToJournal) Print("Setting of breakeven SL ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
               }//if !result && ShowAlerts)
            }
          }
   if (OrderType()==OP_SELL)
         {
           if (ask <= OrderOpenPrice() - (BreakEvenPips * xpips2dbl) &&
              (OrderStopLoss()>OrderOpenPrice()|| OrderStopLoss()==0))
            {
               while (IsTradeContextBusy()) Sleep(100);
               result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-(BreakEvenProfit * xpips2dbl),OrderTakeProfit(),0,CLR_NONE);
               if (result && ShowAlerts==true) Alert("Breakeven set on ", OrderSymbol(), " ticket no ", OrderTicket());
               if (PrintToJournal) Print("Breakeven set on ", OrderSymbol(), " ticket no ", OrderTicket());
               if (!result && ShowAlerts)
               {
                  err=GetLastError();
                  if (ShowAlerts==true) Alert("Setting of breakeven SL ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
                  if (PrintToJournal) Print("Setting of breakeven SL ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
               }//if !result && ShowAlerts)
            }
         }
} // End BreakevenStopLoss sub
bool CheckForHiddenStopLossHit(int type, double iPipsAboveVisual, double stop ) { //based upon/taken from mptm global ea
   //Reusable code that can be called by any of the stop loss manipulation routines except HiddenStopLoss().
   //Checks to see if the market has hit the hidden sl and attempts to close the trade if so.
   //Returns true if trade closure is successful, else returns false
double ask = MarketInfo(OrderSymbol(),MODE_ASK);
double bid = MarketInfo(OrderSymbol(),MODE_BID);
   //Check buy trade
   if (type == OP_BUY)
   {
      double sl = NormalizePrice(OrderSymbol(),(stop + (iPipsAboveVisual * xpips2dbl)));
      if (bid <= sl)
      {
         while (IsTradeContextBusy()) Sleep(100);
         bool result = OrderClose(OrderTicket(), OrderLots(), bid, 99999, CLR_NONE);//OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 5, CLR_NONE);
         if (result)
         {
            if (ShowAlerts==true) Alert("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket());
         }//if (result)
         else
         {
            int err=GetLastError();
            if (ShowAlerts==true) Alert("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
            if (PrintToJournal) Print("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
         }//else
      }//if (bid <= sl)
   }//if (type = OP_BUY)
   //Check buy trade
   if (type == OP_SELL)
   {
      sl = NormalizePrice(OrderSymbol(),(stop - (iPipsAboveVisual * xpips2dbl)));
      if (ask >= sl)
      {
         while (IsTradeContextBusy()) Sleep(100);
         result = OrderClose(OrderTicket(), OrderLots(), ask, 99999, CLR_NONE);//OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 5, CLR_NONE);
         if (result)
         {
            if (ShowAlerts==true) Alert("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket());
         }//if (result)
         else
         {
            err=GetLastError();
            if (ShowAlerts==true) Alert("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
            if (PrintToJournal) Print("Stop loss hit. Close of ", OrderSymbol(), " ticket no ", OrderTicket()," failed with error (",err,")");
         }//else
      }//if (ask >= sl)
   }//if (type = OP_SELL)
   return(result);
 
}//End bool CheckForHiddenStopLossHit(int type, double iPipsAboveVisual, double stop )
void JumpingStopLoss() {//based upon/taken from mptm global ea
double ask = MarketInfo(OrderSymbol(),MODE_ASK);
double bid = MarketInfo(OrderSymbol(),MODE_BID);
   // Jump sl by pips and at intervals chosen by user .
   // Also carry out partial closure if the user requires this
   // Abort the routine if JumpAfterBreakevenOnly is set to true and be sl is not yet set
   if (JumpAfterBreakevenOnly && OrderType()==OP_BUY)
   {
      if(OrderStopLoss()<OrderOpenPrice()) return(0);
   }
   if (JumpAfterBreakevenOnly && OrderType()==OP_SELL)
   {
      if(OrderStopLoss()>OrderOpenPrice()) return(0);
   }
   double sl=OrderStopLoss(); //Stop loss
   if (OrderType()==OP_BUY)
   {
      //Check hidden js for trade closure
      if (HideJumpingStop)
      {
         bool TradeClosed = CheckForHiddenStopLossHit(OP_BUY, PipsAwayFromVisualJS, OrderStopLoss() );
         if (TradeClosed) return;//Trade has closed, so nothing else to do
      }//if (HideJumpingStop)
      // First check if sl needs setting to breakeven
      if (sl==0 || sl<OrderOpenPrice())
      {
         if (ask >= OrderOpenPrice() + (JumpingStopPips * xpips2dbl))
         {
            sl=OrderOpenPrice();
            if (AddBEP==true) sl=sl+(BreakEvenProfit * xpips2dbl); // If user wants to add a profit to the break even
            while (IsTradeContextBusy()) Sleep(100);
            bool result = OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,CLR_NONE);
            if (result)
            {
               if (ShowAlerts==true) Alert("Jumping stop set at breakeven ",sl, " ", OrderSymbol(), " ticket no ", OrderTicket());
               if (PrintToJournal) Print("Jumping stop set at breakeven :  ", OrderSymbol(), " :  SL ", sl, " :  Ask ", ask);
            }//if (result)
            if (!result)
            {
               int err=GetLastError();
               if (ShowAlerts) Alert(OrderSymbol(), " buy trade. Jumping stop function failed to set SL at breakeven, with error(",err,")");
               if (PrintToJournal) Print(OrderSymbol(), " buy trade. Jumping stop function failed to set SL at breakeven, with error(",err,")");
            }//if (!result)
            return(0);
         }//if (ask >= OrderOpenPrice() + (JumpingStopPips * xpips2dbl))
      } //close if (sl==0 || sl<OrderOpenPrice()
 
      // Increment sl by sl + JumpingStopPips.
      // This will happen when market price >= (sl + JumpingStopPips)
      if (bid>= sl + ((JumpingStopPips*2) * xpips2dbl) && sl>= OrderOpenPrice())
      {
         sl=sl+(JumpingStopPips * xpips2dbl);
         while (IsTradeContextBusy()) Sleep(100);
         result = OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,CLR_NONE);
         if (result)
         {
            if (ShowAlerts==true) Alert("Jumping stop set at ",sl, " ", OrderSymbol(), " ticket no ", OrderTicket());
            if (PrintToJournal) Print("Jumping stop set :  ", OrderSymbol(), " :  SL ", sl, " :  Ask ", ask);
         }//if (result)
         if (!result)
         {
            err=GetLastError();
            if (ShowAlerts) Alert(OrderSymbol(), " buy trade. Jumping stop function failed with error(",err,")");
            if (PrintToJournal) Print(OrderSymbol(), " buy trade. Jumping stop function failed with error(",err,")");
         }//if (!result)
      }// if (bid>= sl + (JumpingStopPips * xpips2dbl) && sl>= OrderOpenPrice())
   }//if (OrderType()==OP_BUY)
   if (OrderType()==OP_SELL)
   {
      //Check hidden js for trade closure
      if (HideJumpingStop)
      {
         TradeClosed = CheckForHiddenStopLossHit(OP_SELL, PipsAwayFromVisualJS, OrderStopLoss() );
         if (TradeClosed) return;//Trade has closed, so nothing else to do
      }//if (HideJumpingStop)
      // First check if sl needs setting to breakeven
      if (sl==0 || sl>OrderOpenPrice())
      {
         if (ask <= OrderOpenPrice() - (JumpingStopPips * xpips2dbl))
         {
            sl = OrderOpenPrice();
            if (AddBEP==true) sl=sl-(BreakEvenProfit * xpips2dbl); // If user wants to add a profit to the break even
            while (IsTradeContextBusy()) Sleep(100);
            result = OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,CLR_NONE);
            if (result)
            {
            }//if (result)
            if (!result)
            {
               err=GetLastError();
               if (ShowAlerts) Alert(OrderSymbol(), " sell trade. Jumping stop function failed to set SL at breakeven, with error(",err,")");
               if (PrintToJournal) Print(OrderSymbol(), " sell trade. Jumping stop function failed to set SL at breakeven, with error(",err,")");
            }//if (!result)
            return(0);
         }//if (ask <= OrderOpenPrice() - (JumpingStopPips * xpips2dbl))
      } // if (sl==0 || sl>OrderOpenPrice()
      // Decrement sl by sl - JumpingStopPips.
      // This will happen when market price <= (sl - JumpingStopPips)
      if (bid<= sl - ((JumpingStopPips*2) * xpips2dbl) && sl<= OrderOpenPrice())
      {
         sl=sl-(JumpingStopPips * xpips2dbl);
         while (IsTradeContextBusy()) Sleep(100);
         result = OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,CLR_NONE);
         if (result)
         {
            if (ShowAlerts==true) Alert("Jumping stop set at ",sl, " ", OrderSymbol(), " ticket no ", OrderTicket());
            if (PrintToJournal) Print("Jumping stop set :  ", OrderSymbol(), " :  SL ", sl, " :  Ask ", ask);
         }//if (result)
         if (!result)
         {
            err=GetLastError();
            if (ShowAlerts) Alert(OrderSymbol(), " sell trade. Jumping stop function failed with error(",err,")");
            if (PrintToJournal) Print(OrderSymbol(), " sell trade. Jumping stop function failed with error(",err,")");
         }//if (!result)
      }// close if (bid>= sl + (JumpingStopPips * xpips2dbl) && sl>= OrderOpenPrice())
   }//if (OrderType()==OP_SELL)
}//End of JumpingStopLoss sub
//Open price for pending order must be adjusted to be a multiple of ticksize, not point, and on metals they are not the same.
//see also http://forum.mql4.com/45425#564188
double NormalizePrice(string symbol, double price) {
 if (price==0.00000000) return(0.0);
 double ts = MarketInfo(symbol,MODE_TICKSIZE);
return(MathRound(price/ts)*ts );
}
void BrokerDigitAdjust(string symbol) {
 xMultiplier = 1;
 int digits = MarketInfo(symbol,MODE_DIGITS);
 if (digits == 3 || digits == 5) xMultiplier = 10;
 if (digits == 6) xMultiplier = 100;  
 if (digits == 7) xMultiplier = 1000;
 xpips2dbl = xMultiplier*MarketInfo(symbol,MODE_POINT);
 //Slippage*=xMultiplier;
}

Note that this code may not compile with the latest mt4 builds, so you may use the old build 509 compiler for that: http://www.forexfactory.com/showthread.php?t=470340
Attached File(s)
File Type: mq4 ~insert BREAKEVEN FUNCTIONS.mq4   14 KB | 366 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #15
  • May 24, 2014 5:12am May 24, 2014 5:12am
Hallo again , I have an idea for an expert advisor and if anyone is able to fix it as an EA is welcome.

The idea is simple , use the indicaor given below and folow the instructions .

Buy----------------> if buy volume is greater than sell volume at the end af the candle .
Sell ---------------> if sell volume is smaller than the buy volume at the end of the candle

You could put trailing stop and breakeven function to lock profits , and you could put the parametre to be able to open only one position at the time or more than one postition ( one per candle if is in the same way ) .

Better use this strategy with renko or range bars .
Many happy pips
Attached File(s)
File Type: mq4 62_VolumeTicksSepa.mq4   3 KB | 347 downloads
  • #16
  • May 24, 2014 5:20am May 24, 2014 5:20am
Please dont forget stoploss and take profit
  • #17
  • May 24, 2014 5:45am May 24, 2014 5:45am
Quoting fskliris
Buy----------------> if buy volume is greater than sell volume at the end af the candle .
Sell ---------------> if sell volume is smaller than the buy volume at the end of the candle
I think you mean SELL if SELL volume is GREATER than buy volume, ...

this idea does not work as you may expect (of course ...)
more I will not do on this ea ...
Attached File(s)
File Type: ex4 SimpleVolumeTrader EA.ex4   28 KB | 449 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #18
  • May 24, 2014 7:40am May 24, 2014 7:40am
Thanks for the quick coding , i am just trying this now !!
  • #19
  • May 24, 2014 7:47am May 24, 2014 7:47am
There simse's to be a probleme . The postions open about 10pips away from entrance point. Could you fix it?
Attached Image (click to enlarge)
Click to Enlarge Name: Image1.png Size: 191 KB
  • #20
  • May 24, 2014 7:58am May 24, 2014 7:58am
Quoting fskliris
The postions open about 10pips away from entrance point. Could you fix it?
I do not know what the problem is (not sure whether it is the spread-setting), in my tester it works (pls. see screenshot).

Nevertheless -> Without additional filters this all makes no sense (except: you want to burn your account).
As I stated above: more I will not do on this ea ... (because I do not want to waste my time, sun is shining now and I'll go have some drinks soon) ...

Maybe somebody else has fun to do this, or ask some paid professional or at mql5.com/en/job
Attached Image (click to enlarge)
Click to Enlarge Name: simplevolumetrader_example_eurusdh1.png Size: 47 KB
PM me with coding requests and I'll probably put you on my ignore list
0 traders viewing now