OrderSelect Warning Fix | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

return value of 'OrderSelect' should be checked - Help Please 7 replies

orderselect problem 1 reply

OrderSelect by comment 5 replies

Can't get OrderSelect() to find order automatically 2 replies

OrderSelect() Index Problem 3 replies

OrderSelect Warning Fix

  • #1
  • First Post: Edited 2:08am May 17, 2014 1:57am | Edited 2:08am
Am getting an OrderSelect warning...Although the EA is compiling and trading and functioning properly, would like to have clean code as much as possible.

I've tried variations of fixing the code, but changes to the code have changed the way the EA closes trades. If any of you masters of MT4 can have a quick look, I'd like to try different approaches to this code, any suggestions?

Inserted Code
void CLOSETRADES()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
    OrderSelect(i, SELECT_BY_POS);
    bool result = false;
    
     {
    
if (OrderMagicNumber() == Magic1)
 
  {  
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
 
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );
  }
 
if (OrderMagicNumber() == Magic2)
 
  {
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
 
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );  
  }
 
      }
  }
  return;
}
  • #2
  • May 17, 2014 3:03am May 17, 2014 3:03am
  •  FerruFx
  • Joined May 2007 | Status: MT4/MT5 EAs/Indicators/Alerts coder | 6,542 Posts | Online Now
To fix the OrderSelect() warning, you must check if the function succeed.

Try this :

Inserted Code
if(!OrderSelect(i, SELECT_BY_POS)) {
  Print(__FUNCTION__,": failed to XXXXXXX ! Error code = ",GetLastError());
 }
 else {
  YOUR CODE HERE IF SUCCEED
 }
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • May 17, 2014 3:32am May 17, 2014 3:32am
FerruFX,

Thank you. I tried as you suggested. This is how I implemented it. Warnings disappeared and tests just the same as before. Based on this it should continue to function and trade normally as before here's the code with the section based on your suggestion.

Inserted Code
void CLOSETRADES()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
  if(!OrderSelect(i, SELECT_BY_POS)) {
  Print(__FUNCTION__,": failed to close trade as expected ! Error code = ",GetLastError());
 }
    bool result = false;
  {
    
if (OrderMagicNumber() == Magic1)
  {  
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );
  }
if (OrderMagicNumber() == Magic2)
  {
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );  
  }
      }
  }
  return;
}
  • #4
  • May 17, 2014 3:37am May 17, 2014 3:37am
Not sure why but substituting this worked just as well..

int result;

instead of

bool result = false;
  • #5
  • May 17, 2014 4:03am May 17, 2014 4:03am
  •  FerruFx
  • Joined May 2007 | Status: MT4/MT5 EAs/Indicators/Alerts coder | 6,542 Posts | Online Now
You forgot an "else" after the OrderSelect checking (like in my example). Your code continues its job even if the checking return false. That's not right.
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Last Post: May 17, 2014 5:13am May 17, 2014 5:13am
ok, this is what it looks like now...

it's testing the same as before, which is a good thing because now there is only one warning which is related to something else I'm working on...

thank you for your valuable input on this, you are the best

Inserted Code
void CLOSETRADES()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
  if(!OrderSelect(i, SELECT_BY_POS))
  {
  Print(__FUNCTION__,": failed to close trade as expected ! Error code = ",GetLastError());
  }
    
    else
    
    int result;
  {
    
if (OrderMagicNumber() == Magic1)
 
  {  
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
 
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );
  }
 
if (OrderMagicNumber() == Magic2)
 
  {
  if (OrderType() == OP_BUY && iOpen(NULL,1,0) > KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Bid, 50, Green );
 
  if (OrderType() == OP_SELL && iOpen(NULL,1,0) < KEYPRICE )
  result = OrderClose( OrderTicket(), OrderLots(), Ask, 50, Green );  
  }
 
      }
  }
  return;
}
0 traders viewing now