Need code to stop indicator deleting wrong signals | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Non-deleting Fractal to Fractal Trendlines mq4 3 replies

Deleting charts causes MT4 to hang..Vista 2 replies

Self deleting Indicators 1 reply

Buy Stop and Sell Stop orders with OCO and Trailing Stop 0 replies

Attachments: Need code to stop indicator deleting wrong signals
Exit Attachments

Need code to stop indicator deleting wrong signals

  • #1
  • First Post: Apr 10, 2014 7:02pm Apr 10, 2014 7:02pm
im running a test on a buy sell indicator that shows an arrow on the open of the current bar on whether to buy or sell. When the bar is closed, it does not matter if it was right or wrong, the arrow remains. but when i delete it off MT4 and reload it, the right bars stay on there and the wrong ones are deleted, which obviously makes backtesting pretty useless. However I would like to find out how accurate it REALLY is, so is there anything i can insert into the code to prevent it from deleting the wrong signals??
  • #2
  • Apr 10, 2014 8:02pm Apr 10, 2014 8:02pm
Probably, your indicator is calculating every tick. This means that conditions may be correct for a signal during the life of a particular candle, but by the time the candle closes, the conditions are no longer true. This means that a signal arrow can be painted while the candle is the current candle.
When you load the indicator on the chart, the only information it has for closed candles is the condition at the close, so arrows that were painted in real time will not be there if conditions were not true at the candle close.
You could code the indicator so that it only calculates on the candle close in real time, but that may not be what you want.
Please Do Not PM Me With Coding Enquiries
  • #3
  • Apr 10, 2014 10:21pm Apr 10, 2014 10:21pm
To be clear: thread title could also read "code to stop indicator from repainting" ?
I'm not trying to convince anyone. I'm not in the "convincing" business.
  • #4
  • Apr 11, 2014 1:50am Apr 11, 2014 1:50am
Quoting dekpips
im running a test on a buy sell indicator that shows an arrow on the open of the current bar on whether to buy or sell. When the bar is closed, it does not matter if it was right or wrong, the arrow remains. but when i delete it off MT4 and reload it, the right bars stay on there and the wrong ones are deleted, which obviously makes backtesting pretty useless. However I would like to find out how accurate it REALLY is, so is there anything i can insert into the code to prevent it from deleting the wrong signals??
you need to put the code here if you want to get any real help, otherwise it is all just speculation
  • #5
  • Apr 11, 2014 12:48pm Apr 11, 2014 12:48pm
Quoting MaxDoom
{quote} you need to put the code here if you want to get any real help, otherwise it is all just speculation
Here's the code mate. Its called pinbar but ignored that its just a template i used. It makes calculations on the last 10 bars, and compares them to the current bar. If on the bar close the conditions are met, it shows an arrow on the new candle. I can't seem to find any reason for it to repaint wrong signals, help me out if you can bud
Attached File(s)
File Type: mq4 PinBar.mq4   5 KB | 347 downloads
  • #6
  • Apr 11, 2014 1:09pm Apr 11, 2014 1:09pm
try Forex TSD if you have no luck on here
they can fix just about anything faster than you can say please stop this repainting
  • #7
  • Apr 11, 2014 2:07pm Apr 11, 2014 2:07pm
anyone??
  • #8
  • Apr 11, 2014 4:06pm Apr 11, 2014 4:06pm
someone pls help
  • #9
  • Apr 11, 2014 5:37pm Apr 11, 2014 5:37pm
Quoting dekpips
{quote} Here's the code mate. Its called pinbar but ignored that its just a template i used. It makes calculations on the last 10 bars, and compares them to the current bar. If on the bar close the conditions are met, it shows an arrow on the new candle. I can't seem to find any reason for it to repaint wrong signals, help me out if you can bud {file}
Change this line
Inserted Code
for(i = 0; i <= limit; i++) {
to
Inserted Code
for(i = limit; i >=0; i--) {
Please Do Not PM Me With Coding Enquiries
  • #10
  • Apr 11, 2014 7:17pm Apr 11, 2014 7:17pm
Quoting Gumrai
{quote} Change this line for(i = 0; i <= limit; i++) { to for(i = limit; i >=0; i--) {

thanks for the suggestion, but now all the arrows just disappear??
  • #11
  • Apr 11, 2014 7:40pm Apr 11, 2014 7:40pm
Quoting Gumrai
{quote} Change this line for(i = 0; i <= limit; i++) { to for(i = limit; i >=0; i--) {

apologies the arrows are there now. I however have another problem. while the indi is running it will not show ANY new arrows, just the old ones even if i leave it on the chart for hours. Then as soon as i delete the indi and reload it it shows all the arrows that would have come up during that period. can this be solveD? id be very grateful
  • #12
  • Last Post: Apr 11, 2014 9:10pm Apr 11, 2014 9:10pm
Difficult to say now that it is the weekend, so no ticks coming in.
I had another look at the code and you need to add a couple of lines after
limit=Bars-counted_bars;

Inserted Code
limit=Bars-counted_bars;
if(limit>Bars-12)
   limit=Bars-12;

This is to prevent the indi from trying to access bars that do not exist. Don't know that it will solve your problem though
Please Do Not PM Me With Coding Enquiries
0 traders viewing now