EA not managing trades | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA for managing multiple trades 0 replies

Managing multiple trades. 2 replies

New EA for managing trades and take profit 4 replies

Managing trades 2 replies

Managing Option Directional Trades 0 replies

EA not managing trades

  • #1
  • First Post: Mar 18, 2014 3:20am Mar 18, 2014 3:20am
I have coded a simple EA to manage my stoploss and takeprofit. I am a manual trader. I did this because it is a hassle for me to every time have to set the takeprofit and stoploss. I have attached my code. Thanks in advance.


Inserted Code
extern int StopLoss = 10;
extern int TakeProfit = 50;
double point;
 
int init()
{
if (Digits==2)point=0.01;
if (Digits==3)point=0.01;
if (Digits==4)point=0.0001;
if (Digits==5)point=0.0001;
 
return(0);
}
 
int deinit()
{
return(0);
}
 
int OrderCount(int type)
{
int buycnt,sellcnt;
for (int i=OrdersTotal()-1;i>=0;i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
{
if (OrderSymbol()==Symbol())
{
if (OrderType()==OP_BUY)buycnt=buycnt+1;
if (OrderType()==OP_SELL)sellcnt=sellcnt+1;
}
}
}
if (type==0)return(buycnt);
else if (type==1)return(sellcnt);
else if (type==3)return(buycnt+sellcnt);
else return(0);
}
 
//--------------------------------------------------------------------------------------------------------------------------
//--------------------------------------------------------------------------------------------------------------------------
void verifyStoploss()
{
double buystoploss, sellstoploss, buyTakeprofit, sellTakeprofit;
buystoploss=Bid-StopLoss*point;
buyTakeprofit=Ask+TakeProfit*point;
sellstoploss=Ask+StopLoss*point;
sellTakeprofit=Bid-TakeProfit*point;
if (OrderCount(0)>0 && (OrderStopLoss() < Point || OrderTakeProfit() < Point) ) //if they are not set
{
OrderModify(OrderTicket(), OrderOpenPrice(), buystoploss, buyTakeprofit, OrderExpiration(), CLR_NONE);
Sleep(3000);
}
 
if (OrderCount(1)>0 && (OrderStopLoss() < Point || OrderTakeProfit() < Point) )
{
OrderModify(OrderTicket(), OrderOpenPrice(), sellstoploss, sellTakeprofit, OrderExpiration(), CLR_NONE);
Sleep(3000);
}
}
 
int start()
{
verifyStoploss();
return(0);
}
  • #2
  • Mar 18, 2014 3:24am Mar 18, 2014 3:24am
You are calculating the TP/SL of existing trades with the Ask/Bid price which is wrong.

You should calculate the TP/SL with the OrderOpenPrice() instead.
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Mar 18, 2014 3:52am Mar 18, 2014 3:52am
Quoting FerruFx
You are calculating the TP/SL of existing trades with the Ask/Bid price which is wrong. You should calculate the TP/SL with the OrderOpenPrice() instead.
The reply was prompt and thank you very much.
  • #4
  • Mar 18, 2014 3:55am Mar 18, 2014 3:55am
Quoting superblack
{quote} The reply was prompt and thank you very much.
You're welcome.
MT4/MT5 EAs/Indicators/Alerts coder
  • #5
  • Mar 18, 2014 4:34am Mar 18, 2014 4:34am
Inserted Code
void verifyStoploss()
{
    double buystoploss, sellstoploss, buyTakeprofit, sellTakeprofit;
    
    if (OrderCount(0)>0 && (OrderStopLoss() < Point || OrderTakeProfit() < Point) ) //if they are not set
    {
        buystoploss    =OrderOpenPrice()-StopLoss*point;
        buyTakeprofit  =OrderOpenPrice()+TakeProfit*point;
        OrderModify(OrderTicket(), OrderOpenPrice(), buystoploss, buyTakeprofit, OrderExpiration(), CLR_NONE);
        Sleep(3000);
    }
    
    if (OrderCount(1)>0 && (OrderStopLoss() < Point || OrderTakeProfit() < Point) )
    {
        sellstoploss   =OrderOpenPrice()+StopLoss*point;
        sellTakeprofit =OrderOpenPrice()-TakeProfit*point;
        OrderModify(OrderTicket(), OrderOpenPrice(), sellstoploss, sellTakeprofit, OrderExpiration(), CLR_NONE);
        Sleep(3000);
    }
}

I am not an expert in MQL programming, please excuse me.
I tried the above code, however, the stoploss/takeprofit is still not set.
  • #6
  • Mar 18, 2014 4:43am Mar 18, 2014 4:43am
In the verifyStoploss() function you must select the opened orders in a loop.
MT4/MT5 EAs/Indicators/Alerts coder
  • #7
  • Edited 5:47am Mar 18, 2014 5:18am | Edited 5:47am
I suggest you to open your orders via a script (which you can assign a key) in general, where you can also set your sl, tp, automagically, instead of going the route you are going right now.
You can configure scripts ahead of start the same way as i.e. experts.

Sample script for OP_BUYLIMIT, build 600+:

Inserted Code
// script code
#property strict
#property script_show_inputs
input double PRICE = 0;
input double LOT = 0.01; // lot size
input double SL = 10; // stop loss pips
input double TP = 50; // take profit pips
input int MAGIC = 123; // magic number
void OnStart() {
    double f[] = {1,1,1,10,1,10}; // Point correction factor based on Digits
    double price = PRICE; // zero means price at current on script dropped
    RefreshRates();
    if(price == 0) price = Ask;
    int ticket = OrderSend(Symbol(), OP_BUYLIMIT, LOT, price, 0, 0, 0, NULL, MAGIC); // open order
    if(ticket != -1) OrderModify(ticket, price, price - f[Digits]*Point*SL, price + f[Digits]*Point*TP, 0); // set stop loss, take profit
}
Return To Disorder
  • #8
  • Last Post: Mar 18, 2014 10:23am Mar 18, 2014 10:23am
Thank you guys. I will look into both alternatives.
0 traders viewing now