HELP - this code is not refreshing itself

#property  indicator_separate_window
#property  indicator_buffers 3
#property  indicator_color1  Gold
#property  indicator_color2  DodgerBlue
#property  indicator_color3  Red
#property  indicator_width1 3
#property  indicator_width2 4
#property  indicator_width3 4
#property  indicator_level1 0
#property  indicator_levelstyle 0
#property  indicator_levelcolor Gold
#property  indicator_levelwidth 3
 
extern int period=2;
 
double         ExtBuffer0[];
double         ExtBuffer1[];
double         ExtBuffer2[];
 
int init()
  {
   SetIndexStyle(0,DRAW_LINE);
   SetIndexStyle(1,DRAW_HISTOGRAM);
   SetIndexStyle(2,DRAW_HISTOGRAM);
   IndicatorDigits(Digits+1);
   SetIndexBuffer(0,ExtBuffer0);
   SetIndexBuffer(1,ExtBuffer1);
   SetIndexBuffer(2,ExtBuffer2);
   IndicatorShortName("");
   SetIndexLabel(0,NULL);
   SetIndexLabel(1,NULL);
   SetIndexLabel(2,NULL);
   return(0);
  }
 
int start()
  {
   //int     period=10;
   int    limit;
   int    counted_bars=IndicatorCounted();
   double prev,current,old;
   double Value=0,Value1=0,Value2=0,Fish=0,Fish1=0,Fish2=0;
   double price;
   double MinL=0;
   double MaxH=0;  
  
   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;
 
   for(int i=0; i<limit; i++)
    {  MaxH = High[Highest(NULL,0,MODE_HIGH,period,i)];
       MinL = Low[Lowest(NULL,0,MODE_LOW,period,i)];
      price = (High[i]+Low[i])/2;
      Value = 0.33*2*((price-MinL)/(MaxH-MinL)-0.5) + 0.67*Value1;    
      Value=MathMin(MathMax(Value,-0.999),0.999);
      ExtBuffer0[i]=0.5*MathLog((1+Value)/(1-Value))+0.5*Fish1;
      Value1=Value;
      Fish1=ExtBuffer0[i];
      
    }
 
   bool up=true;
   for(i=limit-2; i>=0; i--)
     {
      current=ExtBuffer0[i];
      prev=ExtBuffer0[i+1];
          
      if (((current<0)&&(prev>0))||(current<0))   up= false;    
      if (((current>0)&&(prev<0))||(current>0))   up= true;
      
      if(!up)
        {
         ExtBuffer2[i]=current;
         ExtBuffer1[i]=0.0;
        }
        
       else
         {
          ExtBuffer1[i]=current;
          ExtBuffer2[i]=0.0;
         }
     }
   return(0);
  }

Quoting Karish

Disliked

Hi there!, so.., i have this code and its not refreshing itself.., when the chart is not refreshed by switching the Timeframe this code looks messed up.. i would be very glad if somebody could fix the refreshing issue on that, thanks for your help

Ignored

   bool up=true;
   for(i=limit-2; i>=0; i--)
     {
      current=ExtBuffer0[i];
      prev=ExtBuffer0[i+1];
          
      if (((current<0)&&(prev>0))||(current<0))   up= false;    
      if (((current>0)&&(prev<0))||(current>0))   up= true;
      
      if(!up)
        {
         ExtBuffer2[i]=current;
         ExtBuffer1[i]=0.0;
        }
        
       else
         {
          ExtBuffer1[i]=current;
          ExtBuffer2[i]=0.0;
         }
     }

Quoting Gumrai

Disliked

{quote} What is it with you and writing indis that use "future data? bool up=true; for(i=limit-2; i>=0; i--) { current=ExtBuffer0; prev=ExtBuffer0[i+1]; if (((current<0)&&(prev>0))||(current<0)) up= false; if (((current>0)&&(prev<0))||(current>0)) up= true; if(!up) { ExtBuffer2=current; ExtBuffer1=0.0; } else { ExtBuffer1=current; ExtBuffer2=0.0; } } When limit == 1, i will equal -1. You cannot access a buffer or any array by [-1], it does not exist. Adjust your code so that it does not look into...

Ignored

Quoting Karish

Disliked

{quote} thank you Gumrai, you always helping me out , would it be ok asking you to add alerts+arrows on cross when the price is crossing the 0.0 level please? thank you so much again.

Ignored