How to close trade in Metatrader after amount of time or bars | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Is there an EA to close trades after a certain amount of time? 27 replies

Default How to close trade in Metatrader after amount of time or amount of bars 5 replies

TP dollars amount and SL dollars amount columns (MT4) 0 replies

MT4 How to set TP to close a certain amount instead of entire amount? 3 replies

Amount of bars on chart? 5 replies

How to close trade in Metatrader after amount of time or bars

  • #1
  • First Post: Jul 26, 2009 7:35am Jul 26, 2009 7:35am
Does anyone know to code a exit after a certain amount of bars after opening a position...

For example, on a hourly chart, close the position after 4 hours or 4 bars have passed regardless of profit or loss...
  • #2
  • Jul 26, 2009 7:48am Jul 26, 2009 7:48am
You need to check the OrderOpenTime() function.

Inserted Code
Total = Orderstotal();

for (int i = 0; i < Total; i++)
   {
   OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
   if(OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol() && (OrderType() == OP_BUY || OrderType == OP_SELL))
        {
        Print("The trade was opened "+TimeCurrent() - OrderOpenTime()+" seconds ago.");
        }
   }
  • #3
  • Edited 2:36pm Jul 26, 2009 11:01am | Edited 2:36pm
Thanks Ronald.
  • #4
  • Sep 20, 2010 9:15am Sep 20, 2010 9:15am
Quoting Pipologist
close the position after 4 hours
"The position" <-- I ask you again: which position? Each position in the whole account?

Each Position:
(Run this as EA)
Inserted Code
int timediff = 4 * 3600; // 4 hours

int start(){
   int i;
   for (i=0; i<OrdersTotal(); i++){
      OrderSelect(SELECT_BY_POS, MODE_TRADES);
      if (TimeCurrent() - OrderOpenTime() > timediff){
         CloseTicket(OrderTicket());
      }
   }
}

int CloseTicket(int ticket){
   double price = 0;
   RefreshRates();
   OrderSelect(ticket, SELECT_BY_TICKET);
   if (OrderType() == OP_BUY){
      price = Bid;
   }
   if (OrderType() == OP_SELL){
      price = Ask;
   }
   if (price > 0){
      return(OrderClose(ticket, OrderLots(), price, 100, Yellow));
   }else{
      return(OrderDelete(ticket));
   }
}
Each Position in the same currency:
Inserted Code
int timediff = 4 * 3600; // 4 hours

int start(){
   int i;
   for (i=0; i<OrdersTotal(); i++){
      OrderSelect(SELECT_BY_POS, MODE_TRADES);
      if (OrderSymbol() == Symbol() && TimeCurrent() - OrderOpenTime() > timediff){
         CloseTicket(OrderTicket());
      }
   }
}
All the above code is untested. There might be typos and other errors, you have to test and debug it.
  • #5
  • Sep 20, 2010 2:54pm Sep 20, 2010 2:54pm
there are few errors when i compiled...please correct them...i don't know how to program...
  • #6
  • Sep 21, 2010 4:18am Sep 21, 2010 4:18am
Quoting superabdu
there are few errors when i compiled...please correct them...i don't know how to program...
I'm at a loss for words...
  • #7
  • Feb 20, 2012 10:06am Feb 20, 2012 10:06am
Could someone please help me with that code:

Inserted Code
extern bool    LimitDuration = true;
extern int    DurationTrade= 15;

(...)

Inserted Code
if (LimitDuration){
int maxDuration = DurationTrade * 60;
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if (
    OrderSelect(pos, SELECT_BY_POS)            // Only my orders w/
&&  OrderMagicNumber() == MagicNumber         // my magic number
&&  OrderSymbol()      == Symbol() ){               // and period and symbol
    int duration = TimeCurrent() - OrderOpenTime();
    if (duration >= maxDuration)
         OrderClose( OrderTicket(), OrderLots(), OrderClosePrice(),
                     Slippage*Point);
}

}

I want the Order to Close by MaxDuration only if the trade is loser. How can I set it?

Thank you and sorry my poor english.
  • #8
  • Feb 20, 2012 11:47am Feb 20, 2012 11:47am
I tried this (without success):

Inserted Code
if (LimitLength){
int maxDuration = LengthTrade * 60; // 60 minutes
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if (
    OrderSelect(pos, SELECT_BY_POS)            // Only my orders w/
&&  OrderMagicNumber() == MagicNumber         // my magic number
&&  OrderSymbol()      == Symbol()                // and period and symbol
&&  OrderType()        == OP_BUY 
//&&  Ask<=OrderOpenPrice
//&&  <=OrderOpenPrice
){
    int duration = TimeCurrent() - OrderOpenTime(); if (
        duration >= maxDuration)
        
        if (Bid<=High[1])//Is this ok? How put CurrentPrice here?
        OrderClose( OrderTicket(), OrderLots(), OrderClosePrice(),
                     Slippage*Point);
}
}
  • #9
  • Feb 20, 2012 2:08pm Feb 20, 2012 2:08pm
I guess it´s right:

Inserted Code
double OpenPrice=OrderOpenPrice();

//if (Bid<OpenPrice){
if (LimitLength==true)  {
int maxDuration = LengthTrade * 60; // 60 minutes
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if (
    OrderSelect(pos, SELECT_BY_POS)            // Only my orders w/
&&  OrderMagicNumber() == MagicNumber         // my magic number
&&  OrderSymbol()      == Symbol()                // and period and symbol
&&  OrderType()        == OP_BUY 

){
    int duration = TimeCurrent() - OrderOpenTime(); if (
        duration >= maxDuration) 
        if (Bid<OpenPrice)
        OrderClose( OrderTicket(), OrderLots(), OrderClosePrice(),Bid,
                     Slippage*Point);

}
}

It worked very well!
  • #10
  • Jan 3, 2014 5:14am Jan 3, 2014 5:14am
Can someone post this EA in .mq4 formation pls? Cant find it anywhere.
If someone is so kind as I cant programe a line of code...


So, EA must
1. look at all account open trades.
2. Close them promptly when position is opened for XX hours.

I appreciate.
  • #11
  • Jan 3, 2014 6:49am Jan 3, 2014 6:49am
look at this pls., maybe it is what you are looking for -> http://www.forexfactory.com/showthre...06#post7178806
PM me with coding requests and I'll probably put you on my ignore list
  • #12
  • Jan 3, 2014 6:55am Jan 3, 2014 6:55am
Quoting fxdaytrader_
look at this pls., maybe it is what you are looking for -> http://www.forexfactory.com/showthre...06#post7178806
seems I cant really search in FF

thank you, seems this is what Im looking for. Cheers
  • #13
  • Jan 29, 2014 8:00pm Jan 29, 2014 8:00pm
I'm looking for something like the original question posted:

Does anyone know to code a exit after a certain amount of bars after opening a position...
For example, on a hourly chart, close the position after 4 hours or 4 bars have passed regardless of profit or loss...

Time-based closes work fine until a weekend occurs, then the gap can throw off your trade (depending what you're looking for).

For example: I make an EA with a time-based close that automatically closes trades after three days. A trade executes on Friday at noon. The weekend passes, then the EA closes out the position on Monday at noon. On the chart, I'm missing two days worth of bars when a trade is held over a weekend.

On the other hand, if I make an EA with a bar-based close, it would automatically close out a trade after x amount of bars (regardless of weekend gaps). The length of bars would always be the same from open to close.

Just a different approach depending what you're looking for.
this is what i have so far:

Inserted Code
for(int pos = OrdersTotal()-1; pos >= 0 ; pos--) if ( 
    OrderSelect(pos, SELECT_BY_POS)            
&&  OrderSymbol()== "EURUSD"){               
    int CurrentBars = (I need help with this line to read how many bars have occurred since the trade opened)
    if (CurrentBars >= BarsAllowed) 
         OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), Slippage);


Any help would be much appreciated, and thanks.
Matt
  • #14
  • Edited 2:41pm Jan 30, 2014 2:25pm | Edited 2:41pm
Quoting megamixx
Any help would be much appreciated, and thanks. Matt
It ain't that hard:

1. when you open a trade, give a variable (barcount) the desired bar count; then put the time of current bar into another variable (time = Time[0])
2. on every tick check time snapshot against current bar's time, if it is less it means a new bar has started; if so, again take the Time[0], decrement barcount and, if barcount has become zero, your time is up, close the trade.

i.e. like so (pseudo code):

Inserted Code
#define BARCOUNT <your number>

when trade opened
    barcount = BARCOUNT
    time = Time[0]
    flag trade

// on every tick check:
if there is a trade
    if time < Time[0]
        time = Time[0]
        barcount--
        if barcount == 0
            close trade
            flag no trade


//
Return To Disorder
  • #15
  • Jan 30, 2014 4:16pm Jan 30, 2014 4:16pm
Thanks, Rockit, I'll try working this into my code
  • #16
  • Feb 11, 2014 11:29am Feb 11, 2014 11:29am
This is where I'm at (I'm a beginner at best) and so far unsuccessful.

extern int BARCOUNT = 72;
int barcount;

static datetime time;
if (time < Time[0])
time = Time[0];
barcount--;
if (barcount == 0)

Print("Bar count on the 'EURUSD' symbol with PERIOD_H1 is",iBars("EURUSD",PERIOD_H1));

OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), Slippage); //BarsAllowed
  • #17
  • Feb 11, 2014 1:04pm Feb 11, 2014 1:04pm
Quoting megamixx
This is where I'm at (I'm a beginner at best) and so far unsuccessful.
Can you give the full code you have?
When you post source code, enclose it in "[ code ]" and "[ /code ]" tags (without marks and gaps)..
Return To Disorder
  • #18
  • Feb 12, 2014 1:52pm Feb 12, 2014 1:52pm
Sure, thanks for looking at it. I'm getting order close errors 138 and 4051 since I inserted the barcount info. It's triggering very quick closes after the opens. I know I have incorrect code in regards to the new barcount info, but it works ok when removed.

Inserted Code
#define SIGNAL_NONE 0
#define SIGNAL_BUY   1
#define SIGNAL_SELL  2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

#property copyright "x"
#property link      "x"

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = False;
extern double Lots = 1.0;
extern int Slippage = 3;
extern int BARCOUNT = 240;

extern int MA1 = 50;
extern int MA2 = 200;

extern bool UseStopLoss = True;
extern int StopLoss = 1000;
extern bool UseTakeProfit = True;
extern int TakeProfit = 60;
extern bool UseTrailingStop = True;
extern int TrailingStop = 100;

int BarCount;
int barcount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init() {
   BarCount = Bars;

   if (EachTickMode) Current = 0; else Current = 1;

   return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit() {
   return(0);
}
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() {
   int Order = SIGNAL_NONE;
   int Total, Ticket;
   double StopLossLevel, TakeProfitLevel;



   if (EachTickMode && Bars != BarCount) TickCheck = False;
   Total = OrdersTotal();
   Order = SIGNAL_NONE;
   
   
   static datetime time;
if (time < Time[0])
        time = Time[0];
        barcount--;
        if (barcount == 0)
        
        Print("Bar count on the 'EURUSD' symbol with PERIOD_H1 is",iBars("EURUSD",PERIOD_H1));
        
         OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), Slippage);

   //+------------------------------------------------------------------+
   //| Variable Begin                                                   |
   //+------------------------------------------------------------------+


double Buy1_1 = iMA(NULL, 0, MA1, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Buy1_2 = iMA(NULL, 0, MA2, 0, MODE_SMA, PRICE_CLOSE, Current + 0);

double Sell1_1 = iMA(NULL, 0, MA1, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Sell1_2 = iMA(NULL, 0, MA2, 0, MODE_SMA, PRICE_CLOSE, Current + 0);



   
   //+------------------------------------------------------------------+
   //| Variable End                                                     |
   //+------------------------------------------------------------------+

   //Check position
   bool IsTrade = False;

   for (int i = 0; i < Total; i ++) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol()) {
         IsTrade = True;
         if(OrderType() == OP_BUY) {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Buy)                                           |
            //+------------------------------------------------------------------+

                     if (False) Order = SIGNAL_CLOSEBUY;


            //+------------------------------------------------------------------+
            //| Signal End(Exit Buy)                                             |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if(Bid - OrderOpenPrice() > Point * TrailingStop) {
                  if(OrderStopLoss() < Bid - Point * TrailingStop) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         } else {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Sell)                                          |
            //+------------------------------------------------------------------+

            

            //+------------------------------------------------------------------+
            //| Signal End(Exit Sell)                                            |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
                  if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         }
      }
   }

   //+------------------------------------------------------------------+
   //| Signal Begin(Entry)                                              |
   //+------------------------------------------------------------------+

   if (Buy1_1 > Buy1_2) Order = SIGNAL_BUY;

   if (Sell1_1 < Sell1_2) Order = SIGNAL_SELL;


   //+------------------------------------------------------------------+
   //| Signal End                                                       |
   //+------------------------------------------------------------------+

   //Buy
   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("BUY order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
            } else {
                Print("Error opening BUY order : ", GetLastError());
            }
         }
         barcount = BARCOUNT;
         time = Time[0];
         
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   //Sell
   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("SELL order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
            } else {
                Print("Error opening SELL order : ", GetLastError());
            }
         }
         barcount = BARCOUNT;
         time = Time[0];
         
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   if (!EachTickMode) BarCount = Bars;

   return(0);
}
//+---------------------------------------
  • #19
  • Edited 2:25pm Feb 12, 2014 2:06pm | Edited 2:25pm
Quoting megamixx
I'm getting order close errors 138 and 4051 since I inserted the barcount info. It's triggering very quick closes after the opens. I know I have incorrect code in regards to the new barcount info, but it works ok when removed.
Well, no surprise there, because you did not enclose the code (if-statement) in braces properly, so the code falls out of the context or scope that it should be in. It should read something like this (however, you first must select the order prior to access it; also, the check must not be performed if there has not a trade been made; when the order is made assign a flag that there is a order working, i.e. hastrade = true; )
Inserted Code
    if(hastrade)
    {
        if (time < Time[0])
        {
            time = Time[0];
            barcount--;
            if (barcount == 0)
            {            
                Print("Bar count on the 'EURUSD' symbol with PERIOD_H1 is",iBars("EURUSD",PERIOD_H1));
                
                 /* must select order first before attempt to close */ OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), Slippage);
                 hastrade = false;
             }
        }
    }
Return To Disorder
  • #20
  • Feb 12, 2014 6:02pm Feb 12, 2014 6:02pm
Is this better? Trades are still closing out within a bar and they're closing with the same 2 error types in the journal.

Inserted Code
static datetime time;
   int barcount;
   bool IsTrade = False;
   if (OrdersTotal() > 0)
    
  {
    IsTrade =true;
      {
        if (IsTrade==true && time < Time[0])
        {
            time = Time[0];
            barcount--;
            if (barcount == 0)
            {          
                Print("Bar count on the 'EURUSD' symbol with PERIOD_H1 is",iBars("EURUSD",PERIOD_H1));
              
                 //* must select order first before attempt to close
                 IsTrade = false;
             }
        }
    }
}
   for (int i =0; i < OrdersTotal(); i++) {
    if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) {
        OrderPrint();
    }
}
OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), Slippage);
1 trader viewing now