Modifying an EA - Adding SuperTrend indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to reference Custom Indicator (SuperTrend) 23 replies

Supertrend and MTF supertrend IDEA 11 replies

modifying supertrend 5 replies

Help with Supertrend Indicator error 2 replies

Modified Supertrend indicator 0 replies

Attachments: Modifying an EA - Adding SuperTrend indicator
Exit Attachments

Modifying an EA - Adding SuperTrend indicator

  • #1
  • First Post: Dec 17, 2013 5:00am Dec 17, 2013 5:00am
Hi All,

I'm new in coding and trying to modify an EA. Basically I'm trying to add SuperTrend indicator into an EA.

I've added the indicator like this

Inserted Code
//---- input parameters
extern bool      use_xsupertrend=true;
extern int       SuperTrend.Period=10;
extern int       SuperTrend.Multiplier=2.618;
extern int       xsupertrend_shift=0;



Inserted Code
double xsupertrend=iCustom(Symbol(),0,"xSuperTrend",SuperTrend.Period,SuperTrend.Multiplier,PRICE_CLOSE,xsupertrend_shift);

and created a condition like this

Inserted Code
  if(!use_bb && !use_xsupertrend)
  {
     if(High[bb_shift]>upBB && PRICE_CLOSE<xsupertrend) return(sell);
     if(Low[bb_shift]<loBB   && PRICE_CLOSE>xsupertrend)   return(buy);
  }

So i want it to sell if price closes below SuperTrend line.

Doesn't give any compiling errors but doesn't work properly either, any feedback would be highly appreciated.

cheers
mem
Attached File(s)
File Type: mq4 xSuperTrend.mq4   4 KB | 616 downloads
  • #2
  • Dec 17, 2013 5:07am Dec 17, 2013 5:07am
scheme: iCustom(Symbol(),TimeFrame,"NAME",parameter1,parameter2,...,BUFFER,Candleshift);

so you forgot to append ",buffer,0" (0:current candle,1:candle before, etc.)

you could try the following, scheme:
Inserted Code
int CandleShift=1;
double Up   = iCustom(NULL,0,"xSuperTrend","","",SuperTrendPeriod,SuperTrendMultiplier,2,CandleShift);
double Down = iCustom(NULL,0,"xSuperTrend","","",SuperTrendPeriod,SuperTrendMultiplier,1,CandleShift);
   
if (Up != 0.0 && Up != EMPTY_VALUE) LONGSIGNAL
if (Down != 0.0 && Down != EMPTY_VALUE) SHORTSIGNAL
PM me with coding requests and I'll probably put you on my ignore list
  • #3
  • Dec 17, 2013 5:53am Dec 17, 2013 5:53am
Many thanks Fxdaytrader!

not sure if I understood this bit;

Quote
",buffer,0" (0:current candle,1:candle before, etc.)

where exactly did you place it in the code?

regardless I've placed the code but left me with an unbalanced parentheses and 9 warnings of "Expression on global scope not allowed". Tried to fix it but no joy!

I've attached the EA after the modification, do you mind taking a quick look at it for me please?
Attached File(s)
File Type: mq4 swb grid supertrend.mq4   12 KB | 501 downloads
  • #4
  • Edited 7:24am Dec 17, 2013 6:59am | Edited 7:24am
Attached File(s)
File Type: mq4 xSuperTrend.mq4   4 KB | 732 downloads
edit: pls. download again, stupid bloop detected
implemented simple stats also (open orders, equity, etc.).

equity-graph looks quite impressive - but I wonder how long it takes to crash the account

edit2: Do not forget to have the xSuperTrend-Indicator in your mt4/experts/indicators/-folder ...
Attached File(s)
File Type: mq4 swb grid supertrend v1.1.mq4   16 KB | 1,056 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #5
  • Dec 17, 2013 7:09am Dec 17, 2013 7:09am
Thanks mate, highly appreciated!

just tested, it's running but Supertrend doesn't seem like functioning. Any idea where I might be going wrong?
  • #6
  • Dec 17, 2013 7:28am Dec 17, 2013 7:28am
fu**ing lack of concentration (that is if you want to finish something quick because you do not have much time).

pls. redownload again, I think everything is alright now.

I overlooked your condition-check, but should be fixed now. In short:
you have at least to choose use_bb=true or use_xsupertrend=true (one of the two is enough, if both are false the ea does not trade and gives a warning).

pls. try again ... at my backtests the ea is opening trades, etc.
PM me with coding requests and I'll probably put you on my ignore list
  • #7
  • Last Post: Dec 17, 2013 2:51pm Dec 17, 2013 2:51pm
Many thanks mate, works perfectly now!
0 traders viewing now