Unexpected splitting of trade volume

Quoting Gumrai

Disliked

U

Ignored

Quoting Gumrai

Disliked

I've been testing one of my EAs on an Ava MetaTrader demo account. The EA opens orders with 0.5 Lots as expected, but when it tries to close an order, often the trade is split up, so it will only close 0.22 or 0.28 Lots. The rest of the trade is left open and messes up the operation of the EA. As my EA only has 1 open order at any one time, I have got over this by closing the earliest order if there is more than 1 open order. So problem solved easily enough. I'm just wondering if this is unique to Ava MetaTrader as I haven't had this happen before....

Ignored

int STicket =0;
   int BTicket =0;
   for(int x=OrdersTotal()-1;x>=0;x--)
    {
     OrderSelect(x, SELECT_BY_POS, MODE_TRADES);
     if(OrderType()==OP_SELL && OrderMagicNumber()==MagicNumber)  STicket = OrderTicket() ;
     if(OrderType()==OP_BUY && OrderMagicNumber()==MagicNumber)   BTicket = OrderTicket() ;
     ObjectSetText("Message5","Buy Ticket= "+BTicket,8,"Arial",Colour);
     ObjectSetText("Message6","Sell Ticket= "+STicket,8,"Arial",Colour);
    }
   double ic1=iCustom(NULL,0,"PercentRange3",21,0,1);
   double ic2=iCustom(NULL,0,"PercentRange3",21,0,2);
   double ic3=iCustom(NULL,0,"PercentRange3",21,1,1);
   double ic4=iCustom(NULL,0,"PercentRange3",21,1,2);
 
   if( (ic1<ic3 && ic2>ic4) || (ic1>ic3 && ic2<ic4) )   
    {
    for(x=1;x<=10;x++)
       {
       if(CheckMinRangePips(x))
          {
          BuyEntry = RangeHigh+ ExceedBy*Pip+ spread*Pip;   // Buy entry level
          SellEntry =RangeLow - ExceedBy*Pip;               // Sell entry level
          ObjectSetText("Message3","BuyEntry="+BuyEntry,8,"Arial",Colour);
          ObjectSetText("Message4","SellEntry="+SellEntry,8,"Arial",Colour);
          break;
          }
       }
    }
    if(BTicket==0 && High[0]>= RangeHigh+ ExceedBy*Pip && CheckClosedTrades("BUY")==false
    && Ask<= BuyEntry + MaxGapPips*Pip)         //Check price is in allowable range
    {
    /*
    THIS IS THE ORIGINAL CODE
    if(STicket>0)
        {
        OrderClose(STicket,OrderLots(),Ask,MaxSlippage*Pip/Point,CLR_NONE);
        Print("Close Sell Order sent, ",OrderLots()," Lots, @,",Ask );
        }
   
    THIS IS THE CHANGED CODE
    */
    
    if(STicket>0)
        {
        OrderSelect(STicket,SELECT_BY_TICKET);
        bool OC =OrderClose(STicket,OrderLots(),Ask,MaxSlippage*Pip/Point,CLR_NONE);
        Print("Close Sell Order sent, ",OrderLots()," Lots, @,",Ask );
        if(OC== false)
          Print("Error closing Order  ",ErrorDescription(GetLastError() ) );
        }
    }
//----

Quoting FerruFx

Disliked

If you don't have any other OrderClose() function in the code, that makes absolutely no sense because you are using OrderLots() ... so the closure request is for the full opened lot size.

Ignored

Quoting Gumrai

Disliked

{quote} Glad that you find it wierd as well. Really had me puzzled.

Ignored

Quoting Gumrai

Disliked

Well, I feel a little bit silly. I had saved version 1 as version 2 and was modifying the code to find out what was happening, trouble is that I left version 1 on the chart. I just couldn't understand why my additional code wasn't working For the moment, I seem to have sorted the problem by reselecting the order. But I still don't understand why it was closing partial orders before

Ignored

Quoting RaptorUK

Disliked

{quote} I suspect you aren't selected Order correctly, I think you have the wrong Order sselected . . . before you close the Order Print() the ticket number by printing OrderTicket() this will tell you which Order you have selected . . . you also need to check return values and report errors and relevant variables. What are Function return values ? How do I use them ?

Ignored

Quoting RaptorUK

Disliked

I suspect you aren't selected Order correctly, I think you have the wrong Order sselected

Ignored

Quote

Disliked

All lot volumes are 0.5

Quoting FerruFx

Disliked

{quote} Yes it's a possibility but that would mean that there's another order with a 0.28 lot size ... Which seems to not be the case. {quote}

Ignored

Quoting Gumrai

Disliked

{quote} Yes there was and all my fault because my function checked order history and that's where the lot size came from. Another lesson learnt. Sorry to have wasted all of your time because of my inadequacy

Ignored

Quoting Gumrai

Disliked

{quote} Thankyou RaptorUK. you got it The CheckClosedTrades function that makes sure that there is only one trade in any direction on one bar was changing the OrderSelect. My bad coding to blame

Ignored

Quoting RaptorUK

Disliked

{quote} Live and learn eh just keep an open mind and you will keep finding the solutions to any problems you have

Ignored

Quoting FerruFx

Disliked

{quote} No wasted time. Don't worry. We all learn every day ... and FF is the right place for.

Ignored

Quoting Gumrai

Disliked

{quote} Thanks FerruFX, as per my above post, It really helps to have input from experienced programmers like you and RaptorUK

Ignored