Attachments: Symbol price indicator (Dashboard)

Symbol price indicator (Dashboard)

#21
Aug 12, 2013 7:12pm Aug 12, 2013 7:12pm

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

For UJ

Inserted Code

//----
int WhatCorner=0;
double pnt=0.01;
color FontColor;

for (int uji=1; uji<Bars-1; uji++)  {
    double UjClose = iClose("USDJPY",PERIOD_D1,uji);
    double UjOpen = iOpen("USDJPY",PERIOD_D1,uji);}
    
  UjClose = iClose("USDJPY",PERIOD_D1,0);
  UjOpen = iOpen("USDJPY",PERIOD_D1,0);
  
     if(MarketInfo("USDJPY", MODE_BID) > UjOpen)
   {
     FontColor = Lime;
   }
     if(MarketInfo("USDJPY", MODE_BID) < UjOpen)
   {
     FontColor = Red;
   }
   
  
  if (uji>0 && pnt>0)  {
    string UjObjChange = DoubleToStr((UjClose-UjOpen)/pnt,0);
    ObjectSet("UjChange",OBJPROP_CORNER,WhatCorner);
    ObjectSet("UjChange",OBJPROP_XDISTANCE,330);
    ObjectSet("UjChange",OBJPROP_YDISTANCE,100);
    ObjectSetText("UjChange",UjObjChange,20,"Arial Bold", FontColor);
  } 
//----

Please Do Not PM Me With Coding Enquiries

#22
Aug 13, 2013 12:05pm Aug 13, 2013 12:05pm

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Quoting Gumrai

Disliked

Again, I ask, what is the point of doing this? for (int eui=1; eui<Bars-1; eui++) { double EuClose = iClose("EURUSD",PERIOD_D1,eui); double EuOpen = iOpen("EURUSD",PERIOD_D1,eui); } UJ in next post

Ignored

I don't know (( I downloaded this indicator and use for my.
I'm beginer in this programming

Thank you for this code: double pnt=0.01;

Inserted Code

//----
int WhatCorner=0;
double pnt=0.01;
color FontColor;

for (int uji=1; uji<Bars-1; uji++) {
 double UjClose = iClose("USDJPY",PERIOD_D1,uji);
 double UjOpen = iOpen("USDJPY",PERIOD_D1,uji);}
 
 UjClose = iClose("USDJPY",PERIOD_D1,0);
 UjOpen = iOpen("USDJPY",PERIOD_D1,0);
 
 if(MarketInfo("USDJPY", MODE_BID) > UjOpen)
 {
 FontColor = Lime;
 }
 if(MarketInfo("USDJPY", MODE_BID) < UjOpen)
 {
 FontColor = Red;
 }
 
 
 if (uji>0 && pnt>0) {
 string UjObjChange = DoubleToStr((UjClose-UjOpen)/pnt,0);
 ObjectSet("UjChange",OBJPROP_CORNER,WhatCorner);
 ObjectSet("UjChange",OBJPROP_XDISTANCE,330);
 ObjectSet("UjChange",OBJPROP_YDISTANCE,100);
 ObjectSetText("UjChange",UjObjChange,20,"Arial Bold", FontColor);
 } 
//----

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#23
Aug 14, 2013 12:35pm Aug 14, 2013 12:35pm

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

What is it this error? " '0' - Internal stack overflow-simplify the program, please"

This is error line:

Inserted Code

ObjectCreate("Egrec04", OBJ_LABEL, 0, 0, 0);
   ObjectSetText("Egrec04", "a", 37, "PriceDashboardFont", DarkSlateBlue);
   ObjectSet("Egrec04", OBJPROP_CORNER,1);
   ObjectSet("Egrec04", OBJPROP_XDISTANCE, 5);
   ObjectSet("Egrec04", OBJPROP_YDISTANCE, 240);
   ObjectSet("Egrec04", OBJPROP_BACK, true);

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#24
Aug 14, 2013 7:26pm Aug 14, 2013 7:26pm

CodeMeister
Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts

Quoting mr-roma

Disliked

What is it this error? " '0' - Internal stack overflow-simplify the program, please" This is error line: ObjectCreate("Egrec04", OBJ_LABEL, 0, 0, 0); ObjectSetText("Egrec04", "a", 37, "PriceDashboardFont", DarkSlateBlue); ObjectSet("Egrec04", OBJPROP_CORNER,1); ObjectSet("Egrec04", OBJPROP_XDISTANCE, 5); ObjectSet("Egrec04", OBJPROP_YDISTANCE, 240); ObjectSet("Egrec04", OBJPROP_BACK, true);

Ignored

Several possibilities - memory leak or system resource limit.

What happens if you log off MT4 and log on again? If the problem disappears, its likely a MT4 memory leak.

What happens if you reduce the number of labels created by half? If the problem disappears, you have a system resource limitation. You have to restructure your code to use less.

#25
Aug 17, 2013 5:57am Aug 17, 2013 5:57am

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

How can I do 2 or more text label from one ObjectCreate codding, like this:

Inserted Code

#property indicator_chart_window
extern int    WhatCorner = 3;
double lastPrice = 0.0;
color  FontColor;
int dig;
double i;

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+

int init()
{ 
 if(Digits == 5)
 dig = 4;
 else if(Digits == 3)
 dig = 2;
 else
 dig = Digits;
 return(0);  
}

int deinit()
{
  
  
   for(i=1; i<=5; i++) {
   ObjectCreate("Symblo_Test",OBJ_LABEL,0,0,0);
   } 
   
  
  ObjectDelete("Symblo_Test");   
  return(0);
}       
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{          

   ObjectSetText("Symblo_Test", "Test Symbol n", 28, "Arial Bold", Green);
   ObjectSet("Symblo_Test", OBJPROP_CORNER, WhatCorner);
   ObjectSet("Symblo_Test", OBJPROP_XDISTANCE, 2);
   
   return(0);
}
//+------------------------------------------------------------------+

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#26
Aug 17, 2013 8:25am Aug 17, 2013 8:25am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

I don't understand why you are creating objects in deinit()

Is this really how you write code?

Inserted Code

int deinit()
{
 
 
 for(i=1; i<=5; i++) {
 ObjectCreate("Symblo_Test",OBJ_LABEL,0,0,0);
 } 
 
 
 ObjectDelete("Symblo_Test"); 
 return(0); 
}

if you don't have
{
}
lining up it makes the code very difficult to follow

Inserted Code

int deinit()
{
 
 
  for(i=1; i<=5; i++) 
    {
    ObjectCreate("Symblo_Test",OBJ_LABEL,0,0,0);
    } 
 
 
 ObjectDelete("Symblo_Test"); 
 return(0);  
}

is much better

Not a problem with this little bit of code, but when it gets more complicated, it will make it a lot more difficult to locate errors

Please Do Not PM Me With Coding Enquiries

#27
Sep 14, 2013 5:07am Sep 14, 2013 5:07am

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Hi, how can I do this simple indicator for 2 or more symbols with array? In one chart window

Inserted Code

#property indicator_chart_window
extern int    WhatCorner = 3;
double lastPrice = 0.0;
color  FontColor;
int dig;

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+

int init()
{ 
 if(Digits == 5)
 dig = 4;
 else if(Digits == 3)
 dig = 2;
 else
 dig = Digits;
 return(0);  
}

int deinit()
{
  ObjectDelete("Market_Price_Label");   
  return(0);
}       
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{       
      
   if(Close[0] > lastPrice)
   {
     FontColor = Lime;
   }
   if(Close[0] < lastPrice)
   {
     FontColor = OrangeRed;
   }
     
   lastPrice = Close[0];
   string Market_Price = DoubleToStr(Bid, dig);
 ObjectCreate("Market_Price_Label", OBJ_LABEL, 0, 0, 0);
   ObjectSetText("Market_Price_Label", Market_Price, 28, "Arial Bold", FontColor);
   ObjectSet("Market_Price_Label", OBJPROP_CORNER, WhatCorner);
   ObjectSet("Market_Price_Label", OBJPROP_XDISTANCE, 2);
   ObjectSet("Market_Price_Label", OBJPROP_YDISTANCE, 1);    
   return(0);
}
//+------------------------------------------------------------------+

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#28
Sep 17, 2013 12:50pm Sep 17, 2013 12:50pm

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Quoting mr-roma

Disliked

Hi, how can I do this simple indicator for 2 or more symbols with array? In one chart window #property indicator_chart_window extern int WhatCorner = 3; double lastPrice = 0.0; color FontColor; int dig; //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int init() { if(Digits == 5) dig = 4; else if(Digits == 3) dig = 2; else dig = Digits; return(0); } int deinit() { ObjectDelete("Market_Price_Label"); return(0);...

Ignored

I do this, but now I can't doing one simple code, example when price com down I wont that price BG color will Red, but when come up will Lime, can anyone help me? please

This is my code

Inserted Code

   string CuurPriceName;
   int    cpcol;  
   if(ExtLines<0)
     {
      for(cpcol=0; cpcol<15; cpcol++)
        {
         CuurPriceName="Current Price BG_"+cpcol;
         
            if(iClose(Symbols[cpcol], PERIOD_D1, 0) > lastPrice)
            {
             FontColor = Lime;
            }  
            if(iClose(Symbols[cpcol], PERIOD_D1, 0) < lastPrice)
            {
             FontColor = Red;
            }
         
            lastPrice = iClose(Symbols[cpcol], PERIOD_D1, 0);
            ObjectCreate(CuurPriceName,OBJ_LABEL,0,0,0);
            ObjectSetText(CuurPriceName,"a",37,"PriceDashboardFont",FontColor);
            ObjectSet(CuurPriceName,OBJPROP_XDISTANCE,CpbgShifts);
            ObjectSet(CuurPriceName,OBJPROP_YDISTANCE,CpbgVertShift[cpcol]);
            ObjectSet(CuurPriceName, OBJPROP_CORNER, 1);
           
        }
     }

But background's color does'nt change when price is changing

PS. Sorry for my bad english

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#29
Sep 17, 2013 3:24pm Sep 17, 2013 3:24pm

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quoting mr-roma

Disliked

{quote} I do this, but now I can't doing one simple code, example when price com down I wont that price BG color will Red, but when come up will Lime, can anyone help me? please This is my code string CuurPriceName; int cpcol; if(ExtLines<0) { for(cpcol=0; cpcol<15; cpcol++) { CuurPriceName="Current Price BG_"+cpcol; if(iClose(Symbols[cpcol], PERIOD_D1, 0) > lastPrice) { FontColor = Lime; } if(iClose(Symbols[cpcol], PERIOD_D1, 0) < lastPrice) { FontColor = Red; } lastPrice = iClose(Symbols[cpcol], PERIOD_D1, 0); ObjectCreate(CuurPriceName,OBJ_LABEL,0,0,0);...

Ignored

Shouldn't lastprice be an array?
Seems to me that you are comparing the iClose of a symbol with the iClose of the previous symbol in the loop.

Please Do Not PM Me With Coding Enquiries

#30
Sep 20, 2013 3:07am Sep 20, 2013 3:07am

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Quoting Gumrai

Disliked

Shouldn't lastprice be an array? Seems to me that you are comparing the iClose of a symbol with the iClose of the previous symbol in the loop.

Ignored

Hi Gumrai, thanks that helping me.
This is my 2 codes, but from here ~~first~~ doesn't work and second is working well, but second code is long than first. I want short code, because my indicator is big.

This is 2 simple code:

~~First~~

Inserted Code

#property indicator_chart_window
extern int    WhatCorner = 3;
double lastPrice = 0.0;
color  FontColor;
int dig;
int    ExtLines=-1;
string Symbols[2]={"EURUSD",
                   "USDJPY"};
int    CpbgShifts=2;
int    CpbgVertShift[2]={1, 35};

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+

int init()
{ 
 if(Digits == 5)
 dig = 4;
 else if(Digits == 3)
 dig = 2;
 else
 dig = Digits;
 return(0);  
}

int deinit()
{
  ObjectsDeleteAll(0); 
  return(0);
}       
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{       

   string CurrPriceName;
   int    col;  
   if(ExtLines<0)
     {
      for(col=0; col<2; col++)
        {
   if(MarketInfo(Symbols[col], MODE_BID) > lastPrice)
   {
     FontColor = Lime;
   }
   if(MarketInfo(Symbols[col], MODE_BID) < lastPrice)
   {
     FontColor = Red;
   }
         CurrPriceName="Current Price_"+col;
      
     
   lastPrice = MarketInfo(Symbols[col], MODE_BID);
   string Market_Price = DoubleToStr(MarketInfo(Symbols[col], MODE_BID),MarketInfo(Symbols[col], MODE_DIGITS));
 ObjectCreate(CurrPriceName, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(CurrPriceName, Market_Price, 28, "Arial Bold", FontColor);
   ObjectSet(CurrPriceName, OBJPROP_CORNER, WhatCorner);
   ObjectSet(CurrPriceName, OBJPROP_XDISTANCE, CpbgShifts);
   ObjectSet(CurrPriceName, OBJPROP_YDISTANCE, CpbgVertShift[col]);
     
   
        }
     }
   return(0);
}

Second

Inserted Code

#property indicator_chart_window
extern int    WhatCorner = 3;
double lastPrice = 0.0;
double lastPrice2 = 0.0;
color  FontColor;
int dig;

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+

int init()
{ 
 if(Digits == 5)
 dig = 4;
 else if(Digits == 3)
 dig = 2;
 else
 dig = Digits;
 return(0);  
}

int deinit()
{
  ObjectDelete("Market_Price_Label");   
  return(0);
}       
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{       
      
   if(MarketInfo("EURUSD", MODE_BID) > lastPrice)
   {
     FontColor = Lime;
   }
   if(MarketInfo("EURUSD", MODE_BID) < lastPrice)
   {
     FontColor = OrangeRed;
   }
     
   lastPrice = MarketInfo("EURUSD", MODE_BID);
   string Market_Price = DoubleToStr(MarketInfo("EURUSD", MODE_BID),MarketInfo("EURUSD", MODE_DIGITS));
 ObjectCreate("Market_Price_Label", OBJ_LABEL, 0, 0, 0);
   ObjectSetText("Market_Price_Label", Market_Price, 28, "Arial Bold", FontColor);
   ObjectSet("Market_Price_Label", OBJPROP_CORNER, WhatCorner);
   ObjectSet("Market_Price_Label", OBJPROP_XDISTANCE, 2);
   ObjectSet("Market_Price_Label", OBJPROP_YDISTANCE, 1);
   
   //+++++++++++++++++++++++++++++++++++++++++++++++++++++++//
   
   if(MarketInfo("USDJPY", MODE_BID) > lastPrice2)
   {
     FontColor = Lime;
   }
   if(MarketInfo("USDJPY", MODE_BID) < lastPrice2)
   {
     FontColor = OrangeRed;
   }
     
   lastPrice2 = MarketInfo("USDJPY", MODE_BID);
   string Market_Price2 = DoubleToStr(MarketInfo("USDJPY", MODE_BID),MarketInfo("USDJPY", MODE_DIGITS));
 ObjectCreate("Market_Price_Label2", OBJ_LABEL, 0, 0, 0);
   ObjectSetText("Market_Price_Label2", Market_Price2, 28, "Arial Bold", FontColor);
   ObjectSet("Market_Price_Label2", OBJPROP_CORNER, WhatCorner);
   ObjectSet("Market_Price_Label2", OBJPROP_XDISTANCE, 2);
   ObjectSet("Market_Price_Label2", OBJPROP_YDISTANCE, 35);    
   return(0);
}

Please help me if you can

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#31
Sep 20, 2013 5:46am Sep 20, 2013 5:46am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

This cuts the amount of code and makes it simple to add additional pairs.
I have added EURJPY as an example.

Inserted Code

#property indicator_chart_window
//--- input parameters
extern int    WhatCorner = 3;
color  FontColor;

string ArrSymbol[3] ; //change 3 to however many pairs you need to display
double LastPrice[3] ; //ditto

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- 

ArrSymbol[0]="EURUSDSB";
ArrSymbol[1]="USDJPYSB";
ArrSymbol[2]="EURJPYSB";
//ArrSymbol[3]=?
//ArrSymbol[4]=?
//ArrSymbol[5]=?

int  y=1;
for(int x=1;x<=ArraySize(ArrSymbol);x++)  //
{
ObjectCreate("Market_Price_Label_"+x, OBJ_LABEL, 0, 0, 0);// Creating obj.
   ObjectSet("Market_Price_Label_"+x, OBJPROP_CORNER, WhatCorner);   // Reference corner
   ObjectSet("Market_Price_Label_"+x, OBJPROP_XDISTANCE, 2);// X coordinate
   ObjectSet("Market_Price_Label_"+x, OBJPROP_YDISTANCE, y);// Y coordinate
   ObjectSetText("Market_Price_Label_"+x,".",8,"Arial",CLR_NONE);  // Empty Labels
   y=y+34;
 }

//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
for(int x=1;x<=ArraySize(ArrSymbol);x++)
{
ObjectDelete("Market_Price_Label_"+x) ;   
}
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
  //----
   
   for(int x=1;x<=ArraySize(ArrSymbol);x++)
      {
      if(MarketInfo(ArrSymbol[x-1], MODE_BID) > LastPrice[x-1])
         FontColor = Lime;
      if(MarketInfo(ArrSymbol[x-1], MODE_BID) < LastPrice[x-1])  
         FontColor = OrangeRed;
      LastPrice[x-1] = MarketInfo(ArrSymbol[x-1], MODE_BID);
      string Market_Price = DoubleToStr(LastPrice[x-1],MarketInfo(ArrSymbol[x-1], MODE_DIGITS));
      ObjectSetText("Market_Price_Label_"+x, Market_Price, 28, "Arial Bold", FontColor);
      }
   
   //+++++++++++++++++++++++++++++++++++++++++++++++++++++++//
   
   
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

Please Do Not PM Me With Coding Enquiries

#32
Sep 20, 2013 5:57am Sep 20, 2013 5:57am

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Thank you very much

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#33
Sep 20, 2013 7:58am Sep 20, 2013 7:58am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quoting mr-roma

Disliked

Thank you very much

Ignored

You're welcome

I'm not that confident with arrays yet, so working on your query helped me as well

Please Do Not PM Me With Coding Enquiries

#34
Sep 20, 2013 6:32pm Sep 20, 2013 6:32pm

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quoting Gumrai

Disliked

This cuts the amount of code and makes it simple to add additional pairs. I have added EURJPY as an example.

Ignored

I just realised that I compiled this code and tested on my broker that has "SB" suffix.

Inserted Code

ArrSymbol[0]="EURUSDSB";

etc will need to have the suffix removed

Inserted Code

ArrSymbol[0]="EURUSD";

or changed to whatever suffix your broker may use

Please Do Not PM Me With Coding Enquiries

#35
Oct 3, 2013 1:50am Oct 3, 2013 1:50am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Hey mr-roma,
you sent me a PM, but apparently your settings don't allow me to reply to you

firstly, I don't see the point of this in your code

Inserted Code

for (int chi=1; chi<Bars-1; chi++)  
    {
    double ChClose = iClose(Symbols[Chcol],PERIOD_D1,chi);
    double ChOpen = iOpen(Symbols[Chcol],PERIOD_D1,chi); 
    }

It just wastes the CPU and nothing is done with the values, especially as the variables are given new values almost immediately after the loop cycle finishes.

You should create your labels in init() and just alter the text as required. You will just keep creating new labels and overwriting the old ones.

In the following code, ObjChange is a string, so you cannot compare it to a number.

Inserted Code

if(ObjChange<0)

Please Do Not PM Me With Coding Enquiries

#36
Oct 3, 2013 3:00am Oct 3, 2013 3:00am

mr-roma
Joined Mar 2013 | Status: Think Different | 191 Posts | Online Now

Quoting Gumrai

Disliked

Hey mr-roma, you sent me a PM, but apparently your settings don't allow me to reply to you

Ignored

Oh thank you Gumrai and sorry for that, I change my PM settings ...

Quoting Gumrai

Disliked

firstly, I don't see the point of this in your code for (int chi=1; chi<Bars-1; chi++) { double ChClose = iClose(Symbols[Chcol],PERIOD_D1,chi); double ChOpen = iOpen(Symbols[Chcol],PERIOD_D1,chi); } It just wastes the CPU and nothing is done with the values, especially as the variables are given new values almost immediately after the loop cycle finishes. You should create your labels in init() and just alter the text as required. You will just keep creating new labels and overwriting the old ones. In the following code, ObjChange is a string, so...

Ignored

Ok, when I tried to codding this in init()

Inserted Code

pnt = MarketInfo(Symbols[Chcol],MODE_POINT);

Of course it getting error: Chcol variable not defined.
Can I codding in init() like that?

Inserted Code

for(int pch =0; pch < 15; pch++)
{
pnt = MarketInfo(Symbols[Chcol],MODE_POINT);
}

Can I us for() function in init()?

"Rule No.1: Never lose money. Rule No.2: Never forget rule No.1." — Warren

#37
Last Post: Oct 3, 2013 3:56am Oct 3, 2013 3:56am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quote

Disliked

Ok, when I tried to codding this in init()

No need to put that in init()

Quote

Disliked

Can I us for() function in init()?

Yes, no problem

Made a few adjustments that will not solve all your problems, but will create the labels in init() and delete them in deinit()
I have added comments in the code, they may not be easy to see at a glance

Inserted Code

int init()
  {
//----
   
   //Assuming that arrays Symbols[] and SaskVertShift[] are assigned their values in init() already
   
   string ChangePrice;
   int    Chcol; 
   
   for(Chcol=0; Chcol<15; Chcol++)
      {
      ChangePrice=Symbols[Chcol]+" Daily Pips Change";
      ObjectCreate(ChangePrice,OBJ_LABEL,0,0,0);
      ObjectSet(ChangePrice,OBJPROP_XDISTANCE,330);
      ObjectSet(ChangePrice,OBJPROP_YDISTANCE,SaskVertShift[Chcol]);
      ObjectSet(ChangePrice, OBJPROP_CORNER, 1);
      ObjectSetText(ChangePrice,".",17,"Arial Bold",Lime);
      } 
        

//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   string ChangePrice;
   int    Chcol; 
   
   for(Chcol=0; Chcol<15; Chcol++)
      {
      ChangePrice=Symbols[Chcol]+" Daily Pips Change";
      ObjectDelete(ChangePrice);
      } 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   string ChangePrice;
   int    Chcol;  
   if(ExtLines<0)     // No idea what this variable refers to
     {
      for(Chcol=0; Chcol<15; Chcol++)
        {
        
    pnt = MarketInfo(Symbols[Chcol],MODE_POINT);
    for (int chi=1; chi<Bars-1; chi++)  
   //chi will finish this loop with a value of Bars-1 
    {
    //This loop achieves nothing but put strain on the CPU every tick
    double ChClose = iClose(Symbols[Chcol],PERIOD_D1,chi);  
    double ChOpen = iOpen(Symbols[Chcol],PERIOD_D1,chi); 
    //Both these variables are assigned new values 2nd and 3rd line below 
   }
    
      ChangePrice=Symbols[Chcol]+" Daily Pips Change";
      
     ChClose = iClose(Symbols[Chcol],PERIOD_D1,0);
     ChOpen = iOpen(Symbols[Chcol],PERIOD_D1,0);
    
       if (chi>0 && pnt>0)  {        //chi is certainly>0 and so is pnt
       string ObjChange = DoubleToStr((ChClose-ChOpen)/pnt,0);
            ObjectSetText(ChangePrice,ObjChange,17,"Arial Bold",Lime);
            if(ObjChange<0) // Maybe you mean if( (ChClose-ChOpen)/pnt <0) ??
            ObjectSetText(ChangePrice,ObjChange,17,"Arial Bold",Red);
  } 
        }

//----
   return(0);
  }
//+------------------------------------------------------------------+

Please Do Not PM Me With Coding Enquiries

Platform Tech
/
Symbol price indicator (Dashboard)
Reply to Thread
- 1 Page 2
- 1 Page 2

0 traders viewing now

Options

Similar Threads

Symbol price indicator (Dashboard)