What's Wrong With This Code (Time calculation)? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Wrong Trade: Wrong Place / Wrong Time 16 replies

Time reference for Pivot calculation 1 reply

Help to code Piecewise Calculation 1 reply

What's wrong with this simple calculation code line? 6 replies

MT4 Stochastic wrong calculation? 3 replies

What's Wrong With This Code (Time calculation)?

  • #1
  • First Post: Edited 7:14am Sep 8, 2013 6:48am | Edited 7:14am
Comment(TimeToStr(Time[0],TIME_DATE)," ", TimeToStr(Time[0]+PERIOD_W1,TIME_DATE));

gives:

"2013.09.01 2013.09.01"

instead of

"2013.09.01 2013.09.08"

Sorry for bothering with trivial stuff, but I have lost already too much time with unsuccessfully calculating time stamps.
  • #2
  • Sep 8, 2013 7:20am Sep 8, 2013 7:20am
hey sven..... what is it actually you are trying to achieve.....h

//----

Inserted Code
 Comment(TimeCurrent());
 
 Comment(TimeToStr(Time[0],TIME_DATE|TIME_SECONDS));
 
  Comment(TimeToStr(iTime(Symbol(),0,0),TIME_DATE|TIME_SECONDS));
to trade and code, keep both simple... no call to impress....h
  • #3
  • Sep 8, 2013 7:23am Sep 8, 2013 7:23am
Quoting svengralla
Comment(TimeToStr(Time[0],TIME_DATE)," ", TimeToStr(Time[0]+PERIOD_W1,TIME_DATE)); gives: "2013.09.01 2013.09.01" instead of "2013.09.01 2013.09.08" Sorry for bothering with trivial stuff, but I have lost already too much time with unsuccessfully calculating time stamps.
Comment(TimeToStr(Time[0],TIME_DATE)," ", TimeToStr(Time[0]+PERIOD_W1*60,TIME_DATE));
MT4/MT5 EAs/Indicators/Alerts coder
  • #4
  • Sep 8, 2013 7:32am Sep 8, 2013 7:32am
Hi hayseed,

the problems is time arithmetics.
Adding e.g. PERIOD_W1 (or 10080) to Time[1] (weekly) does not give me the correct date (2013.09.08).
  • #5
  • Sep 8, 2013 7:33am Sep 8, 2013 7:33am
Quoting svengralla
Hi hayseed, the problems is time arithmetics. Adding e.g. PERIOD_W1 (or 10080) to Time[1] (weekly) does not give me the correct date (2013.09.08).
You have the answer in my post above ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Sep 8, 2013 7:50am Sep 8, 2013 7:50am
keep in mind your looking for time during non-market hours so time[0] is last known time.... h
//---

Inserted Code
TimeToStr(Time[0]+(PERIOD_D1*120),TIME_DATE)
to trade and code, keep both simple... no call to impress....h
  • #7
  • Sep 8, 2013 8:03am Sep 8, 2013 8:03am
Quoting svengralla
Hi hayseed, the problems is time arithmetics. Adding e.g. PERIOD_W1 (or 10080) to Time[1] (weekly) does not give me the correct date (2013.09.08).
Of course. Time is always in seconds. You are adding PERIOD_W1 (10080 minutes). But your formula takes PERIOD_W1 as seconds. You must multiply PERIOD_W1*60

My first post in this thread corrected your formula ... but it seems that you missed it ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #8
  • Sep 8, 2013 8:22am Sep 8, 2013 8:22am
Thanks FerruFx, hayseed,

PERIOD_W1 returns minutes, so we have to multiply with 60 for seconds.


Finally I figured out, there was another issue:

iTime with a negative shift will not give the correct date, but "1970.01.01"

Ok, the code is working now. Boy, this cost me several hours.



A good week to you and many pips
  • #9
  • Sep 8, 2013 8:31am Sep 8, 2013 8:31am
Quoting svengralla
there was another issue: iTime with a negative shift will not give the correct date, but "1970.01.01"
A negative shift will check a date in the furure where there's no candles, so it returns the default time value (1970.01.01). It's why you must add to the time the number of seconds needed to reach the point in future you want.
MT4/MT5 EAs/Indicators/Alerts coder
  • #10
  • Sep 8, 2013 8:58am Sep 8, 2013 8:58am
Guys, since we have just been talking:

I have a problem with quoting the character ''\".

No way in mt4 I can write a literal ''\" at the end of a string constant.

This doesnt work:


string path="mypath\\"
  • #11
  • Sep 8, 2013 9:17am Sep 8, 2013 9:17am
Quoting svengralla
PERIOD_W1 returns minutes, so we have to multiply with 60 for seconds.
//---

hey sven..... i might not be clear on what your after..... if your wanting to print, " 2013.09.08", adding w1 might give you next friday......

using TimeToStr(Time[0]+(PERIOD_D1*120),TIME_DATE) is the same thing as saying, last known day + 2 days..... which should be 9/8/2013 ....

PERIOD_D1*120 is the same thing as saying last known day + (2 "days" * 60)...... PERIOD_D1*2*60 ...... or PERIOD_D1*120 .......

and again, i might be completely off as to what your after......h

//----

Inserted Code
TimeToStr(Time[0]+(PERIOD_D1*120),TIME_DATE),"   same as   ",TimeToStr(Time[0],TIME_DATE)," ", TimeToStr(Time[0]+(PERIOD_D1*2*60)
to trade and code, keep both simple... no call to impress....h
  • #12
  • Sep 8, 2013 9:32am Sep 8, 2013 9:32am
hi hayseed,

thanks, the problem is already solved.
I missed the factor "60" for the seconds and had an issue with negative shift in using iTime.


But do you know how to quote for a literal "\" at the end of a string constant?
  • #13
  • Sep 8, 2013 6:31pm Sep 8, 2013 6:31pm
Quoting svengralla
hi hayseed, thanks, the problem is already solved. I missed the factor "60" for the seconds and had an issue with negative shift in using iTime. But do you know how to quote for a literal "\" at the end of a string constant?
You need double \\ in your string.

You can find the rules of the special caracters in the "Literal constants" of the MetaEditor help.
MT4/MT5 EAs/Indicators/Alerts coder
  • #14
  • Sep 8, 2013 10:47pm Sep 8, 2013 10:47pm
Quoting FerruFx
You need double in your string.
Double, triple, quadruple all didnt work out at the end of the string.

string path="mypath\";
string path="mypath\\";
string path="mypath\\\";
string path="mypath\\\\";
  • #15
  • Sep 8, 2013 10:59pm Sep 8, 2013 10:59pm
Quoting svengralla
{quote} Double, triple, quadruple all didnt work out at the end of the string. string path="mypath\"; string path="mypath\"; string path="mypath\"; string path="mypath\";
Just tested to be sure.

Comment("mypath\\");

The above return on the chart : mypath\
MT4/MT5 EAs/Indicators/Alerts coder
  • #16
  • Sep 9, 2013 2:09am Sep 9, 2013 2:09am
Just tested to be sure.

Comment( my path)

The above return on the chart: mypath
  • #17
  • Sep 9, 2013 2:46am Sep 9, 2013 2:46am
Quoting FerruFx
{quote} Just tested to be sure. Comment("mypath\\"); The above return on the chart : mypath
FerruFx:

Actually, I never tested the code but stopped because the syntax highlighting indicated its wrong.

Have you tried

Comment("mypath\\"); Comment("test");

?

Syntax Highlighting in Metaeditor is invalid, but it compiles.
I check the code later and let you know.
  • #18
  • Sep 9, 2013 2:53am Sep 9, 2013 2:53am
Quoting svengralla
{quote} FerruFx: Actually, I never tested the code but stopped because the syntax highlighting indicated its wrong. Have you tried Comment("mypath\"); Comment("test"); ? Syntax Highlighting in Metaeditor is invalid, but it compiles. I check the code later and let you know.
Anyway the way it should be wrote (according to the "Literal constants" of the MetaEditor help) works perfectly on my platform.
MT4/MT5 EAs/Indicators/Alerts coder
  • #19
  • Sep 9, 2013 3:20am Sep 9, 2013 3:20am
Ok. I'll check it out.
In case syntax highlighting has a bug, that should be fixed.
  • #20
  • Sep 9, 2013 10:37am Sep 9, 2013 10:37am
FerruFX:

It works as it should.
From the beginning I wrote the correct code, but didnt compile it, because syntax highlighting indicated it's wrong.
That's a bug in MetaEditor.

thanks, sven
0 traders viewing now