Attachments: Help about arrow name query

Help about arrow name query

#1
First Post: Sep 8, 2013 4:38am Sep 8, 2013 4:38am

james27
| Joined Jun 2013 | Status: Trader | 162 Posts

Hi,
i want to find Text value of arrow in my chart.
in this chart ,incoming many arrow and whenever i see new arrow in my chart i want to receive alert message
and i was modified some source .
one of problem is after every bar alert message popup.
how can i make alert message only one time ?
thanks in advance!

Inserted Code

#property indicator_chart_window



extern bool   alertsOn        = true;
extern bool   alertsOnCurrent = false;
extern bool   alertsMessage   = true;
extern bool   alertsSound     = false;
extern bool   alertsEmail     = false;

//bool Alerted = false;
extern bool   displayAlert = true;
static datetime lastAlertTime;

//
//------------------------------------------------------------------
datetime gOldTime=0;
bool NewBar()
{
     bool new = Time[0] != gOldTime;
     gOldTime = Time[0];
     return (new);
}

int init()   {

return(0);
}
int deinit() {

return(0); }


int start()
{
//static datetime Time0;
//if (Alerted) return(-1);

//int Sit;

int    counted_bars=IndicatorCounted();
int i,shift;
int limit;
if(counted_bars < 0)
return(-1);
if(counted_bars > 0)
counted_bars--;
limit = Bars - counted_bars;
for(i = shift ;i<=limit;i++){
 
 string name = ObjectName(i);
 if (StringFind(name, "Test") == 0)
 {
 DisplayAlert("Found!",Symbol());
      
 Print(Symbol());
 }

}

}




void DisplayAlert(string message, int shift)
{
if(shift <= 2 && Time[shift] != lastAlertTime)
  {
    lastAlertTime = Time[shift];
    Alert(message, Symbol(), " , ", Period(), " minutes chart");
  }
}


void doAlert(int forBar, string doWhat)
{
static string   previousAlert="nothing";
static datetime previousTime;
string message;

if (previousAlert != doWhat || previousTime != Time[forBar]) {
    previousAlert  = doWhat;
    previousTime   = Time[forBar];

    //
    //
    //
    //
    //

    message =  Symbol()+" at "+TimeToStr(TimeLocal(),TIME_SECONDS)+" "+doWhat;
    
       if (alertsMessage) Alert(message);
       if (alertsEmail)   SendMail(Symbol()+"alerts",message);
       if (alertsSound)   PlaySound("alert2.wav");
      
}

}

Attached Image

#2
Sep 8, 2013 4:55am Sep 8, 2013 4:55am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Why do you have so much of the code that is not accessed?

Inserted Code

#property indicator_chart_window
static datetime lastAlertTime;

//
//------------------------------------------------------------------

int init()   { 
   
return(0); 
}
int deinit() { 
 
return(0); }


int start()
{
  

   int    counted_bars=IndicatorCounted();
   int i,shift;
   int limit;
   if(counted_bars < 0)
   return(-1);
   if(counted_bars > 0)
   counted_bars--;
   limit = Bars - counted_bars;
   for(i = shift ;i<=limit;i++)
    {
    string name = ObjectName(i);
    if (StringFind(name, "Test") == 0) 
    {
    DisplayAlert("Found!",Symbol());
         
    Print(Symbol());
    }

}

}




void DisplayAlert(string message, int shift)
  {
   if(shift <= 2 && Time[shift] != lastAlertTime)
     {
       lastAlertTime = Time[shift];
       Alert(message, Symbol(), " , ", Period(), " minutes chart");
     } 
  }

Remove the stuff that does nothing and the code is much shorter
I don't know what happens when you send Symbol() to a function when it is expecting an integer. The more knowledgeable coders will be able to say whether this is a problem or not

Please Do Not PM Me With Coding Enquiries

#3
Sep 8, 2013 5:14am Sep 8, 2013 5:14am

james27
| Joined Jun 2013 | Status: Trader | 162 Posts

sorry i upload source again..
it more clean but problem is only one time alerted..and not alert when new arrow incoming..
thanks for your help!

Inserted Code

#property indicator_chart_window


extern bool   alertsOn        = true;
extern bool   alertsOnCurrent = false;
extern bool   alertsMessage   = true;
extern bool   alertsSound     = false;
extern bool   alertsEmail     = false;

bool Alerted = false;

//
//------------------------------------------------------------------
datetime gOldTime=0;
bool NewBar()
{
    bool new = Time[0] != gOldTime;
    gOldTime = Time[0];
    return (new);
}

int init()   { 
   
return(0); 
}
int deinit() { 
  
return(0); }


int start()
{
   //static datetime Time0;
   if (Alerted) return(-1);
   
   int Sit;

       int    counted_bars=IndicatorCounted();
   int i;
   int limit;
   if(counted_bars < 0)
   return(-1);
   if(counted_bars > 0)
   counted_bars--;
   limit = Bars - counted_bars;
   for(i=0;i<=limit;i++){
    
    string name = ObjectName(i);
    if (StringFind(name, "Test") == 0) 
         
    Print("found");

}
    if(NewBar()) {
   
      doAlert(0," found 2");
      Sit= 1;
 
      Alerted = true; // no more alert 
  
   
      }
}

//------------------------------------------------------------------
//
//------------------------------------------------------------------


void doAlert(int forBar, string doWhat)
{
   static string   previousAlert="nothing";
   static datetime previousTime;
   string message;
   
   if (previousAlert != doWhat || previousTime != Time[forBar]) {
       previousAlert  = doWhat;
       previousTime   = Time[forBar];

       //


       message =  Symbol()+" at "+TimeToStr(TimeLocal(),TIME_SECONDS)+" "+doWhat;
       
          if (alertsMessage) Alert(message);
          if (alertsEmail)   SendMail(Symbol()+"alerts",message);
          if (alertsSound)   PlaySound("alert2.wav");
         
   }
   
}

#4
Sep 8, 2013 6:26am Sep 8, 2013 6:26am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Make up your mind what code you want to post and then somebody may be able to help you.
Your first post had NewBar() function that was not accessed, in your 2nd post it is. Same goes for doAlert().
Your first post's code accessed a DisplayAlert() function that has now disappeared.
If you are going to make changes, then please highlight those changes.

Please Do Not PM Me With Coding Enquiries

#5
Sep 8, 2013 7:30am Sep 8, 2013 7:30am

james27
| Joined Jun 2013 | Status: Trader | 162 Posts

yes..so only this source code what i want to modify. and first posted source and this source is different.
i was try to edit first post's source but couldn't edit so i was post again in here. sorry again give to confuse.
so first source can ignore totally.
i was modified unnessary parts.

Inserted Code

#property indicator_chart_window


extern bool   alertsOn        = true;
extern bool   alertsOnCurrent = false;
extern bool   alertsMessage   = true;
extern bool   alertsSound     = false;
extern bool   alertsEmail     = false;

bool Alerted = false;
datetime gOldTime=0;
bool NewBar()
{
bool new = Time[0] != gOldTime;
gOldTime = Time[0];
return (new);
}

int init()   {

return(0);
}
int deinit() {

return(0); }


int start()
{
//static datetime Time0;
if (Alerted) return(-1);

int Sit;

int    counted_bars=IndicatorCounted();
int i;
int limit;
if(counted_bars < 0)
return(-1);
if(counted_bars > 0)
counted_bars--;
limit = Bars - counted_bars;
for(i=0;i<=limit;i++){

string name = ObjectName(i);
if (StringFind(name, "Test") == 0)
    
Print("found");

}
if(NewBar()) {

  doAlert(0," here text goes to doWhat");
  Sit= 1;

  Alerted = true; // no more alert


  }
}

//------------------------------------------------------------------
//
//------------------------------------------------------------------


void doAlert(int forBar, string doWhat)
{
static string   previousAlert="nothing";
static datetime previousTime;
string message;

if (previousAlert != doWhat || previousTime != Time[forBar]) {
   previousAlert  = doWhat;
   previousTime   = Time[forBar];

   //


   message =  Symbol()+" at "+TimeToStr(TimeLocal(),TIME_SECONDS)+" "+doWhat;
  
      if (alertsMessage) Alert(message);
      if (alertsSound)   PlaySound("alert2.wav");
    
}

}

#6
Last Post: Sep 8, 2013 5:23pm Sep 8, 2013 5:23pm

RaptorUK
Joined Jan 2008 | Status: Trader | 870 Posts

Quoting james27

Disliked

yes..so only this source code what i want to modify.

Ignored

Try this . . . http://forum.mql4.com/57713

20 pips a day isn't too much to ask . . .

Platform Tech
/
Help about arrow name query
Reply to Thread

0 traders viewing now

Options

Similar Threads

Help about arrow name query