Counting how many open trades there are...? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How many strategies are u using and how many pairs do u trade? 0 replies

How many parameters are too many? 0 replies

Number of trades before counting consistency 9 replies

Is there any website show the elliott counting? 8 replies

How many pairs is considered too many? 8 replies

Attachments: Counting how many open trades there are...?
Exit Attachments

Counting how many open trades there are...?

  • #1
  • First Post: May 26, 2010 8:40am May 26, 2010 8:40am
Hi there I would Like to know how can I write some code to count how many orders are currently open on the account ... like If I currently have 5 open orders I would like it to return me a value of 5 ....



thanks alot !!
  • #2
  • May 26, 2010 8:54am May 26, 2010 8:54am
int Count = 0;
for(int i=OrdersTotal()-1; i>=0; i--)
{
OrderSelect(i,SELECT_BY_POS);
if(OrderType()<=OP_SELL) Cnt++;
}
//now Count variable contains the number of open orders, excluding pending orders
  • #3
  • Edited Sep 3, 2013 5:25am Sep 2, 2013 10:25pm | Edited Sep 3, 2013 5:25am
I wonder if anyone can help me. I have this code that counts the number of open BUY or SELL orders. But once these trades closed the count displayed 0. What I want is to modify or add to this code the feature to tally the total trades taken today, because I want to control my over-trading bad habits. How to make the code display the total count (not reset to 0) when all trades are closed? I'm a daytrader so I make sure I have no open trades overnight.

ObjectSetText ( "fpm_short",DoubleToStr ( countOrders ( OP_SELL,allSymbols ),0 ) );
ObjectSetText ( "fpm_long",DoubleToStr ( countOrders ( OP_BUY,allSymbols ),0 ) );


int countOrders ( int oType,bool allSymbols=false )
{
int count=0;

for ( int i=0; i<OrdersTotal(); i++ )
if ( OrderSelect ( i,SELECT_BY_POS ) )
if ( allSymbols || OrderSymbol() ==Symbol() )
if ( OrderType() ==oType || oType<0 )
count++;

return ( count );
}
No longer trading forex. Looking for full time job.
  • #4
  • Sep 2, 2013 11:43pm Sep 2, 2013 11:43pm
This should give you the total of all trades closed today.
You would have to add extra code if you wanted to filter symbol or types of trade

Inserted Code
datetime daystart = TimeCurrent() - (TimeCurrent()%(PERIOD_D1 * 60));
datetime dayend = daystart + (PERIOD_D1 * 60);

int count=0;
for(int i=OrdersHistoryTotal()-1;i>=0;i--)
   {
   OrderSelect(i,SELECT_BY_POS,MODE_HISTORY);
   if(OrderCloseTime() >= daystart && OrderCloseTime() <dayend)
    count++;
   }
 // count is the number of trades closed today
Please Do Not PM Me With Coding Enquiries
  • #5
  • Sep 2, 2013 11:49pm Sep 2, 2013 11:49pm
Possibbly, this may work with your existing code, but not sure
Inserted Code
ObjectSetText ( "fpm_short",DoubleToStr ( countOrders ( OP_SELL,allSymbols ),0 ) );
ObjectSetText ( "fpm_long",DoubleToStr ( countOrders ( OP_BUY,allSymbols ),0 ) );

int countOrders ( int oType,bool allSymbols=false )
{
int count=0;

for ( int i=0; i<OrdersTotal(); i++ )
if ( OrderSelect ( i,SELECT_BY_POS ) )
if ( allSymbols || OrderSymbol() ==Symbol() )
if ( OrderType() ==oType || oType<0 )
count++;

datetime daystart = TimeCurrent() - (TimeCurrent()%(PERIOD_D1 * 60));
datetime dayend = daystart + (PERIOD_D1 * 60);

for(int i=OrdersHistoryTotal()-1;i>=0;i--)
   {
   if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY) );
   if(OrderCloseTime() >= daystart && OrderCloseTime() <dayend)
   if ( allSymbols || OrderSymbol() ==Symbol() )
   if ( OrderType() ==oType || oType<0 )
    count++;
   }

return ( count );
}
Please Do Not PM Me With Coding Enquiries
  • #6
  • Edited 5:28am Sep 3, 2013 12:15am | Edited 5:28am
Here's the indicator I modified from. I'm not a trained programmer so my modifications are not clean but ..... as long as it works. I added your code at YDISTANCE=139 (see pink arrow) so that I can test out live today. The existing script showed the number of open BUY and number of open SELL orders, but quickly reset to 0 when trades are closed. No trades so far so everything is 0 except for account starting balance. At the end of the day if I took 17 trades, I want to see that number stay at "17".

Quoting mmaker
1. Stop Loss in pips.
2. Stop Loss in dollars.
3. Realized gain in pips.
4. Realized gain in dollars.
5. Number of Long or Short positions.
6. Overall risk in dollars of all open positions (on all symbols). This will be the scary number to you if you open multiple positions on multiple pairs at max leverage.
7. Yesterday's account balance, percentage gain for today, dollar gain for today.
Attached Image (click to enlarge)
Click to Enlarge Name: 01.png Size: 21 KB
Attached File(s)
File Type: mq4 Pipsometer_Mod4.mq4   12 KB | 671 downloads
No longer trading forex. Looking for full time job.
  • #7
  • Sep 3, 2013 3:20am Sep 3, 2013 3:20am
Quoting mmaker
Here's the indicator I modified from. I'm not a trained programmer so my additions are not clean but ..... as long as it works. I added your code at YDISTANCE=139 (see pink arrow) so that I can test out live today. The existing script showed the number of open BUY and number of open SELL, but quickly reset to 0 when trades are closed. No trades so far so everything is 0 except for account starting balance. At the end of the day if I took 17 trades, I want to see that number stay "17".
Do you want the total opened today ? or the total opened today that have been closed ? if you want the former you also have to count the currently open trades . . .

You added the code inside an if() condition, if showOverallPnL = false the count will not be updated.
20 pips a day isn't too much to ask . . .
  • #8
  • Sep 3, 2013 3:58am Sep 3, 2013 3:58am
This bit of code should only count closed market orders, so ignore pending orders that didn't trigger
Inserted Code
datetime daystart = TimeCurrent() - (TimeCurrent()%(PERIOD_D1 * 60));
datetime dayend = daystart + (PERIOD_D1 * 60);

int count=0;
for(int i=OrdersHistoryTotal()-1;i>=0;i--)
   {
   OrderSelect(i,SELECT_BY_POS,MODE_HISTORY);
   if(OrderCloseTime() >= daystart && OrderCloseTime() <dayend && (OrderType()== OP_BUY || OrderType()== OP_SELL) )
    count++;
   }
 // count is the number of trades closed today
Please Do Not PM Me With Coding Enquiries
  • #9
  • Sep 3, 2013 4:21am Sep 3, 2013 4:21am
Quoting mmaker
{quote} Many thanks Gumrai and RaptorUK, I've tested and it works! Sorry to take up your time, I'm solved now.
No worries Mmaker, only took 5 minutes.
BTW, I should mention that the timing is your broker's time, so if your day's trading session crosses your broker's midnight, it will only count the trades after midnight. It would need modifying if you want it to work on your local time.
Please Do Not PM Me With Coding Enquiries
  • #10
  • Last Post: Aug 17, 2024 12:04am Aug 17, 2024 12:04am
Quoting Gumrai
Possibbly, this may work with your existing code, but not sure ObjectSetText ( "fpm_short",DoubleToStr ( countOrders ( OP_SELL,allSymbols ),0 ) ); ObjectSetText ( "fpm_long",DoubleToStr ( countOrders ( OP_BUY,allSymbols ),0 ) ); int countOrders ( int oType,bool allSymbols=false ) { int count=0; for ( int i=0; i<OrdersTotal(); i++ ) if ( OrderSelect ( i,SELECT_BY_POS ) ) if ( allSymbols || OrderSymbol() ==Symbol() ) if ( OrderType() ==oType || oType<0 ) count++; datetime daystart = TimeCurrent() - (TimeCurrent()%(PERIOD_D1 * 60)); datetime dayend...
this code is working for closed orders and current order, pending not included.
but its working counting the closed and current one.
thank you for sharing. pip pips more...
0 traders viewing now