Bug in Indi? Please help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Please help to make this indi into a Multiple Time Frame (MTF) indi 3 replies

Coder needed for small fee- fixing every Indi/Idea for Indi 2 replies

Repainting indi into Non-Repainting Indi - Help 2 replies

Consecutive candles indi combined with volume & spread indi 13 replies

Need help to convert this indi into MTF indi 3 replies

Attachments: Bug in Indi? Please help
Exit Attachments

Bug in Indi? Please help

  • #1
  • First Post: Aug 16, 2013 6:47am Aug 16, 2013 6:47am
Hi guys

I am getting each candle alert!!! Which is strange because conditions are not there!!
Please can anybody help? Maybe I have wrong {}. But I have check it several times and can;t find problem
Overall logic of this indi is...
After first set of condition save time.
Next add to this time 120sec and after that check for Highest volume....

thx for help guys!!!
Attached File(s)
File Type: mq4 nTimeSection testing code.mq4   5 KB | 149 downloads
  • #2
  • Aug 16, 2013 7:50am Aug 16, 2013 7:50am
Not totally sure when reading other people's code, but I think that this may be something wrong.


Inserted Code
 if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2)) 
    && (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2)))
         mStoredTime = Time[0];
         Comment(mStoredTime);

Your conditions assign the current bars open time to mStoredTime


Inserted Code
if((Time[0] >= (mStoredTime + 120)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 5, 1)))))
             Comment("12354321");

Will the volume of bar shift 1 ever be higher than the highest of bar shift 1 through 5?


Inserted Code
   if(Time[0] > mAlertTime)
          {
            Alert(Symbol() + " Buy NSND Loop !! ");
            PlaySound("Alert.wav");
            mAlertTime = Time[0];
            string mStr = Symbol()  + " " + Period() + "m  " + TimeHour(Time[0]) + ":" + TimeMinute(Time[0]);
            string mMessStr = Symbol() + " " + Period() + " TimeSection  " ;
            SendMail(mMessStr, mStr);

          }

This appears to be independant and not conditional, apart from the time.
So you will get the alert at the start of every new candle in higher than 1 minute time-frame
Please Do Not PM Me With Coding Enquiries
  • #3
  • Aug 16, 2013 8:40am Aug 16, 2013 8:40am
Quoting Gumrai
Not totally sure when reading other people's code, but I think that this may be something wrong. if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2)) && (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2))) mStoredTime = Time[0]; Comment(mStoredTime); Your conditions assign the current bars open time to mStoredTime if((Time[0] >= (mStoredTime + 120)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 5, 1))))) Comment("12354321"); Will the volume of bar...
Thanks Gumrai for your points!!
Will change it and let you know.
Again many thanks
  • #4
  • Aug 16, 2013 8:54am Aug 16, 2013 8:54am
Quoting crusader1
{quote} Thanks Gumrai for your points!! Will change it and let you know. Again many thanks

You have to think what do these do?
{
}


Inserted Code
if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2)) 
    && (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2)))
         mStoredTime = Time[0];
         Comment(mStoredTime);
        {   //HERE
        
             if((Time[0] >= (mStoredTime + 120)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 5, 1)))))
             Comment("12354321");
            
            if(Time[0] > mAlertTime)
          {
            Alert(Symbol() + " Buy NSND Loop !! ");
            PlaySound("Alert.wav");
            mAlertTime = Time[0];
            string mStr = Symbol()  + " " + Period() + "m  " + TimeHour(Time[0]) + ":" + TimeMinute(Time[0]);
            string mMessStr = Symbol() + " " + Period() + " TimeSection  " ;
            SendMail(mMessStr, mStr);

          }
                
       }  AND HERE?
Please Do Not PM Me With Coding Enquiries
  • #5
  • Aug 16, 2013 9:09am Aug 16, 2013 9:09am
Quoting Gumrai
{quote} You have to think what do these do? { } if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2)) && (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2))) mStoredTime = Time[0]; Comment(mStoredTime); { //HERE if((Time[0] >= (mStoredTime + 120)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 5, 1))))) Comment("12354321"); if(Time[0] > mAlertTime) { Alert(Symbol() + " Buy NSND Loop !! "); PlaySound("Alert.wav"); mAlertTime = Time[0]; string mStr...
that is end of the code....
What I need there? I don't understand
  • #6
  • Aug 16, 2013 9:16am Aug 16, 2013 9:16am
here is what I have change...
I am storing now not Time[0] but Time[1] after that first conds...
Then I add to this stored time next 300sec which is on 1M 5 more candles
and then I am waiting if current Time will be bigger than that and next indi must check if candle after this time pause will have iHighest from previous 15 candles.
I put there also after each step also drawline
And result....
I get on each candle gold Vline

------------------------------------------------------------
------------------------------------------------------------


if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2))
&& (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2)))
mStoredTime = Time[1];
ObjectCreate("mDivLine"+Time[1], OBJ_VLINE, 0, 0, 0, 0, 0);
ObjectSet("mDivLine"+Time[1], OBJPROP_COLOR, Green);
ObjectSet("mDivLine"+Time[1], OBJPROP_STYLE, STYLE_SOLID);
ObjectSet("mDivLine"+Time[1], OBJPROP_WIDTH, 2);
ObjectSet("mDivLine"+Time[1], OBJPROP_TIME1, Time[1]);
ObjectSet("mDivLine"+Time[1], OBJPROP_BACK, true);
Comment(mStoredTime);
{

if((Time[1] > (mStoredTime + 300)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 15, 2)))))
ObjectCreate("mDivLine"+Time[1], OBJ_VLINE, 0, 0, 0, 0, 0);
ObjectSet("mDivLine"+Time[1], OBJPROP_COLOR, Gold);
ObjectSet("mDivLine"+Time[1], OBJPROP_STYLE, STYLE_SOLID);
ObjectSet("mDivLine"+Time[1], OBJPROP_WIDTH, 2);
ObjectSet("mDivLine"+Time[1], OBJPROP_TIME1, Time[0]);
ObjectSet("mDivLine"+Time[1], OBJPROP_BACK, true);
Comment("12354321");
{
if(Time[0] > mAlertTime)
{
Alert(Symbol() + " Buy NSND Loop !! ");
PlaySound("Alert.wav");
mAlertTime = Time[0];
string mStr = Symbol() + " " + Period() + "m " + TimeHour(Time[0]) + ":" + TimeMinute(Time[0]);
string mMessStr = Symbol() + " " + Period() + " TimeSection " ;
SendMail(mMessStr, mStr);

}
}
Attached File(s)
File Type: mq4 nTimeSection testing code.mq4   6 KB | 131 downloads
  • #7
  • Aug 16, 2013 9:57am Aug 16, 2013 9:57am
Quoting crusader1
here is what I have change... I am storing now not Time[0] but Time[1] after that first conds... Then I add to this stored time next 300sec which is on 1M 5 more candles and then I am waiting if current Time will be bigger than that and next indi must check if candle after this time pause will have iHighest from previous 15 candles. I put there also after each step also drawline And result.... I get on each candle gold Vline ------------------------------------------------------------ ------------------------------------------------------------...
hi crusader

once again you have some odd code stuff going on....

I think you are trying to nest the IF statements but not doing it correctly
Attached Image (click to enlarge)
Click to Enlarge Name: Capture.PNG Size: 72 KB
  • #8
  • Aug 16, 2013 10:09am Aug 16, 2013 10:09am
Quoting MaxDoom
{quote} hi crusader once again you have some odd code stuff going on.... I think you are trying to nest the IF statements but not doing it correctly {image}
Sorry Max I am learning mq4 and looks that it is really bad one

first arrow
You mean that mStoredTime=Time[1]; is only code that is activated from that first if statement? all code below that (code for drawing line) is not taken?

second arrow
I was thinking that it is starting next step what must be done after first if statement with mStoredTime and drawing Green Line. after first if it will save time and draw green line and then move to that next if which start {

third arrow
Looks that it is same problem like in first if statement.... I must add some {}???

last arrow
After all ifs statement after that { it will do the alert section

But what you have signed (noted) on that code looks to me that I really can't use {} correctly

My Q is
How I know when which if statement will do everything below it?

thx for helping me again
  • #9
  • Aug 16, 2013 10:13am Aug 16, 2013 10:13am
Quoting crusader1
{quote} Sorry Max I am learning mq4 and looks that it is really bad one first arrow You mean that mStoredTime=Time[1]; is only code that is activated from that first if statement? all code below that (code for drawing line) is not taken? second arrow I was thinking that it is starting next step what must be done after first if statement with mStoredTime and drawing Green Line. after first if it will save time and draw green line and then move to that next if which start { third arrow Looks that it is same problem like in first if statement.......

no worries.

you use { } to block code together in certain situations.

an IF statement will process the next command IF conditions are true ie:

IF (dValue == 1)
Comment("HELLO dValue =1");

it will not process any more commands than the Comment command, but you can use { } to extend the command list like this:

IF (dValue == 1)
{
Comment("HELLO dValue =1");
next command
next command
etc.
}

now all those commands are done only if the IF is true.

there is no point just putting { } randomly in your code it will not do anything, it has to be to block code together is certain circumstances.
  • #10
  • Aug 16, 2013 10:20am Aug 16, 2013 10:20am
Quoting MaxDoom
{quote} no worries. you use { } to block code together is certain situations. an IF statement will process the next command IF conditions are true ie: IF (dValue == 1) ; so if you want it to process 5 commands say only IF tru then you can use:
ok then correct code will be like this?
I have select with {} each code after if statement. Then if first IF is true it will do what is in {} and go to second etc....
Am I correct or I am again wrong ?

if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2))
&& (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2)))
{
mStoredTime = Time[1];
ObjectCreate("mDivLine"+Time[1], OBJ_VLINE, 0, 0, 0, 0, 0);
ObjectSet("mDivLine"+Time[1], OBJPROP_COLOR, Green);
ObjectSet("mDivLine"+Time[1], OBJPROP_STYLE, STYLE_SOLID);
ObjectSet("mDivLine"+Time[1], OBJPROP_WIDTH, 2);
ObjectSet("mDivLine"+Time[1], OBJPROP_TIME1, Time[1]);
ObjectSet("mDivLine"+Time[1], OBJPROP_BACK, true);
Comment(mStoredTime);
}

if((Time[1] > (mStoredTime + 300)) && (iVolume(NULL, 0, 1) > (iVolume(NULL, 0, iHighest(NULL, 0, MODE_VOLUME, 15, 2)))))
{
ObjectCreate("mDivLine"+Time[1], OBJ_VLINE, 0, 0, 0, 0, 0);
ObjectSet("mDivLine"+Time[1], OBJPROP_COLOR, Gold);
ObjectSet("mDivLine"+Time[1], OBJPROP_STYLE, STYLE_SOLID);
ObjectSet("mDivLine"+Time[1], OBJPROP_WIDTH, 2);
ObjectSet("mDivLine"+Time[1], OBJPROP_TIME1, Time[0]);
ObjectSet("mDivLine"+Time[1], OBJPROP_BACK, true);
Comment("12354321");
}

if(Time[0] > mAlertTime)
{
Alert(Symbol() + " Buy NSND Loop !! ");
PlaySound("Alert.wav");
mAlertTime = Time[0];
string mStr = Symbol() + " " + Period() + "m " + TimeHour(Time[0]) + ":" + TimeMinute(Time[0]);
string mMessStr = Symbol() + " " + Period() + " TimeSection " ;
SendMail(mMessStr, mStr);

}
Attached File(s)
File Type: mq4 nTimeSection testing code.mq4   6 KB | 119 downloads
  • #11
  • Aug 16, 2013 10:39am Aug 16, 2013 10:39am
Quoting crusader1
{quote} ok then correct code will be like this? I have select with {} each code after if statement. Then if first IF is true it will do what is in {} and go to second etc.... Am I correct or I am again wrong ? if((iVolume(NULL, 0, 2) < (iVolume(NULL, 0, iLowest(NULL, 0, MODE_VOLUME, mNoBars, 3)))) && (iClose(NULL, 0, 2) < iOpen(NULL, 0, 2)) && (iClose(NULL, 0, 1) > iHigh(NULL, 0, 2))) { mStoredTime = Time[1]; ObjectCreate("mDivLine"+Time[1], OBJ_VLINE, 0, 0, 0, 0, 0); ObjectSet("mDivLine"+Time[1], OBJPROP_COLOR, Green); ObjectSet("mDivLine"+Time[1],...

yes that is three separate IF statements each with a block of code that will get executed only IF the conditions are true. the IFs are not nested.
  • #12
  • Aug 16, 2013 10:48am Aug 16, 2013 10:48am
Quoting MaxDoom
{quote} yes that is three separate IF statements each with a block of code that will get executed only IF the conditions are true. the IFs are not nested.

Ok.

Tested this code but I am again getting on each 1M candle alert.... and also that Gold Vline
Whyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy :'(
If I understand it correctly what you are saying me then if first IF is not true.... then there can't be any alert...
Because now it looks to me that code is jumping to the second IF without checking first one.....
  • #13
  • Aug 16, 2013 11:06am Aug 16, 2013 11:06am
Quoting crusader1
{quote} Ok. Tested this code but I am again getting on each 1M candle alert.... and also that Gold Vline Whyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy :'( If I understand it correctly what you are saying me then if first IF is not true.... then there can't be any alert... Because now it looks to me that code is jumping to the second IF without checking first one.....
the way you have the IFs they are three separate ones, each will get executed and if true each block of code will get executed.

If you want to nest them.....

IF ( condition1 == true)
{
do if condition 1 is true
}
else
{
do if condition 1 is false
}


or

IF ( condition1 == true)
{
do if condition 1 is true
}
else if (condition 2 == true)
{
do if condition 1 is false AND condition 2 is true
}
else
{
do if condition 1 & 2 are false
}

you can get the picture from here yes?
  • #14
  • Aug 16, 2013 11:20am Aug 16, 2013 11:20am
Quoting MaxDoom
{quote} the way you have the IFs they are three separate ones, each will get executed and if true each block of code will get executed. If you want to nest them..... IF ( condition1 == true) { do if condition 1 is true } else { do if condition 1 is false } or IF ( condition1 == true) { do if condition 1 is true } else if (condition 2 == true) { do if condition 1 is false AND condition 2 is true } else { do if condition 1 & 2 are false } you can get the picture from here yes?

Max
What I want is that IF first is TRUE do cond1 then move to second IF and if it is TRUE do cond2 and move to last IF and if also this is TRUE then to the last cond......

What you have write me and what I have changed on last code is what I don;t want.. I can see that I really don't understand how IF and {} works....

How You will put together these three IFs and three conds that will work like I have described ...

thx
  • #15
  • Last Post: Aug 16, 2013 11:25am Aug 16, 2013 11:25am
Quoting crusader1
{quote} Max What I want is that IF first is TRUE do cond1 then move to second IF and if it is TRUE do cond2 and move to last IF and if also this is TRUE then to the last cond...... What you have write me and what I have changed on last code is what I don;t want.. I can see that I really don't understand how IF and {} works.... How You will put together these three IFs and three conds that will work like I have described ... thx

IF ( condition 1 == true)
{
. do 1 commands

. IF ( condition 2 == true)
. {
. do 2 commands

. IF(condition 3 == true)
. {
. do 3 commands
. }
. }
}


ignore the dots just there to format on FF

this will test condition 1 and:

if false do nothing else

if true do condition1 commands then test condition 2

if 2 is true will do condition2 commands then test condition 3.

I suggest you look at some of the articles at www.mql4.com on how to program with it.
0 traders viewing now