Wrong "else" statement? Please help!

if(mPriceRange != mPriceDistance) // only if mPriceDistance is not same then cont

Quoting crusader1

Disliked

Hi guys. I am trying to code indicator that will alert me only in Fib area. But I am getting only alert from first part before "else" I am not receiveing any email if price break above 62%. Please can anyone tell m e what I do wrong? Many thx for help if(mPriceDistance > mGap*pips) // check if range is bigger than some amount of pips because we are looking only for big Fibs if(mPriceRange != mPriceDistance) // only if mPriceDistance is not same then cont { if((Open[0] < (Low[LowCandle] + mPriceDistance*0.5)) && (Open[0] > (Low[LowCandle] + mPriceDistance*0.62)))...

Ignored

Quoting Gumrai

Disliked

Not knowing the calculations, but it is possibly highly unlikely that if(mPriceRange != mPriceDistance) // only if mPriceDistance is not same then cont will ever be false.

Ignored

Quoting MaxDoom

Disliked

{quote} You could try checking the values by adding some Print statements before the IF in the else code, to show the values of what you are testing

Ignored

Quoting crusader1

Disliked

{quote} Hi it is only HIgh and low swing price from previous X-candles... nothing else. For example I want only Fibs that are bigger than 30 pips moves... Then I set mPriceDistance to 30 pips.. and what I was looking for is that if Price will break 62% of Fib then that PriceDistance (Fib) is not valid anymore for me and indi must find new fresh Fib with new PriceDistance.... and because mPriceDistance is something like this: double mPriceDistance = High[HighCandle] - Low[LowCandle]; There will be always new PriceDistance when chart will plot new...

Ignored

Quoting Gumrai

Disliked

{quote} Yes, but what is mPriceRange and how likely is it that this will be exactly equal to mPriceDistance

Ignored

Quoting crusader1

Disliked

{quote} But you previously wrote something like this no?? else (Open[0] < (Low[LowCandle] + mPriceDistance*0.62)) why you have removed it? It will not be valid?

Ignored

Quoting MaxDoom

Disliked

{quote} I removed it because although correct and the tidy way to write the code, how he had written it would also work. IE: if (condtion) { do... } else (optional condition) { do....} is the same as if (condtion) { do... } else { if (condition) {do.... }} HOWEVER, I notice that even his way of writing it he is missing some brackets { if(Open[0] < (Low[LowCandle] + mPriceDistance*0.62)) // if price is above save that mPriceDistance to mPriceRange and wait for fresh new mPriceDistance mPriceRange = mPriceDistance; mStr = Symbol() + " " + Period()...

Ignored

Quoting crusader1

Disliked

{quote} ok Thx Will rewrite it and test it with your changes. But I have one Q. Why you have aff before mPriceRange = mPriceDistance; that mPriceDistance again? and without any ";"

Ignored

Quoting MaxDoom

Disliked

ALSO... life becomes a lot easy with debugging if you indent you command groups so that you can easily see what the if and else relate to.. like this {image}

Ignored

Quoting crusader1

Disliked

{quote} How did you do this? With Snipping tool? thx

Ignored

Quoting MaxDoom

Disliked

{quote} yes, dropped your code into the editor with cut & paste, formated it, then used the snipper

Ignored

if(mPriceDistance > mGap*pips) // check if range is bigger than some amount of pips because we are looking only for big Fibs
if(mPriceRange != mPriceDistance) // only if mPriceDistance is not same then cont
{
//code code
//etc etc
}

else

{
//more code
}

Quoting crusader1

Disliked

{quote} Then you think that overall Logic can work but only there was bad writing in that else section?

Ignored

Quoting Gumrai

Disliked

It's much easier to read if you use the insert code box guys. So if the first line is true but the 2nd line is false the, else code will be actioned If the first line is true and the 2nd line true, the else code will not be actioned If the first line is false, the else code will not be actioned The only time that the else code will be actioned is when mPriceRange == mPriceDistance if(mPriceDistance > mGap*pips) // check if range is bigger than some amount of pips because we are looking only for big Fibs if(mPriceRange != mPriceDistance) // only...

Ignored

Quoting MaxDoom

Disliked

{quote} the logic will work as I posted it in the hierarchy as indented, will it give you the results you want? I do not know. If you are not getting any alerts then you should put some debugging statements in like the Print and put info into the journal that you can check to see if it as you expect it to be.

Ignored

Quoting crusader1

Disliked

{quote} Hmmmmmmm. Ok now I see.... Then "esle" statement will never be actioned because if(mPriceRange != mPriceDistance) // only if mPriceDistance is not same then cont will be always true Ok.How then I will write these ifs and else statements that it will also work with else statement?

Ignored

Quoting Gumrai

Disliked

{quote} Now you understand what I have been saying, you will get there

Ignored