Counting Multiple Orders With Multiple Magic Numbers in one EA

OK, so I've been able to create an EA that can handle simultaneous modules with different trading parameters that can be run at the same time or toggled on and off. Although I'm running into a wall with a order count handling.

I want to have the EA count MaxTotalPositions against Total Positions for ModuleA and Total Positions for ModuleB. The EA must not exceed Max Total (A=B), but it also must not exceed TotalforModuleA and B respectively. For example, if the MaxTotal is 2, and the ModuleA and B total is one each, then it can't exceed 2. This part is easy. However, if the Max is 2, and the ModuleA is 1, it is still trading up to 2. I've tried calling the orders by magic to make it easier to count but somewhere it's overcounting the MaxPerModule. Does anyone have any idea how to approach this? The code is compiling properly so there's no syntax errors. Here's the portion of the code:

/////////////////////////////////////////////////////////////////////////////

TotalMaxPositions is declared globally at the top of the EA as an "extern" variable

extern double TotalMaxPositions = 2;

//////////////////////////////////////////////////////////////////////////////

//--------------------------------------------------
// MAX POSITIONS ORDER COUNT
//--------------------------------------------------

int TotalCurrentOrders;
int countA=0; int countB=0; int totalA; int totalB;

TotalCurrentOrders = OrdersTotal();
if (TotalCurrentOrders >= TotalMaxPositions) return(0);

else

if (TotalCurrentOrders < TotalMaxPositions)

{

if (countA >= MaxPositionsA) return(0);
if (countA < MaxPositionsA)
for (int posA = 0; posA < totalA; posA++)
{
if (OrderSelect(posA, SELECT_BY_POS) == false) continue;
if (OrderMagicNumber() == MagicA) countA++;
}

if (countB >= MaxPositionsB) return(0);
if (countB < MaxPositionsB)
for (int posB = 0; posB < totalB; posB++)
{
if (OrderSelect(posB, SELECT_BY_POS) == false) continue;
if (OrderMagicNumber() == MagicB) countB++;
}

if (TotalCurrentOrders >= TotalMaxPositions) return(0);

}

Why is this a double ?


if you try to compare an int with a double you may find it is never equal even if it is . . .

Then


Then you have some code that does some counting but doesn't appear to do anything with the result
followed by


which you have already tested (first quote) and know to be false otherwise the ELSE would not have been carried out. There is nothing in the code to change the values of TotalCurrentOrders or TotalMaxPositions.

It's a double because I was too lazy to change it. By default all my externs are doubles and then I change them if they don't compile. I just finished that multiple EAs within a EA concept EA and I've left room for over 10 variables plus SL TP and an off and off toggle. Now I go wild with my strategies within one EA. It's easier for me to test ideas that way.

Thanks for your input on the last EA thread, with your reply, "you can pretty have an EA do anything" I took your word for it and went for it.

I'll keep in mind your comment on the double vs. int and even test it, but I think Gumrai's reply on not adding to or subtracting the TotalOrders on each Module might be what I need to look at.

Thanks makes complete sense. I'll take a look at that. I'm assuming I do it the same way as

for (int posB = 0; posB < totalB; posB++)
{
if (OrderSelect(posB, SELECT_BY_POS) == false) continue;
if (OrderMagicNumber() == MagicB) countB++;
}

But by modifying the values of what I need to accomdate for as well.

The code is trickier than I thought but it *should* be able to run with the change in logic (at least that's what I hope).

Thanks for the suggestion, I'll try experimenting with it.

Did you ever get a result on this?

Im doing something really similar I have 4 BuyStop/SellStop orders that activate based on certain perameters and I have individual order modifiers for each order that i cant seem to get them to modify them by ticket number (issue with using this is that everytime you modifiy the order it changes the ticket-id which in turn kills the modify order on the second time around it trys to change it so have to use magic numbers.

Have that part of the EA working fine but I cant seem to limit the amount of orders by Magic Number on their own. I was using Iexpertadvisor VTS builder as its really easy to visualise what your doing and it has its own system to limit orders but you cant add multiple magic numbers to it.

Not sure where to go with it from here really..........

Also creating it and trying to make it useable within Iexpertadvisor VTS is even harder.

Dear!

Could you please tell me how to write an EA with the following features?

1. If we open a trade, it will automatically open multiple trades as we wish (so-called N positions).

2. Regarding the first trade, we can set up by hand or by EA as an option along with setting up stop loss (so-called S_1) and take profit (so-called T_1) as schedule.

3. After the first trade, it will automatically open multiple position at the same price and stop loss based on the first trade (spread is accepted). which means P=P_1~=P_2~=P_3~=...~=P_N and S=S_1=S_2=S_3=...=S_N.

4. The Nth trade's take profit will be P pips more than that of (N-1)th trade, which means T_N=T_(N-1) +P (e.g. T_2=T_1+P).

5. If we monitor that the market movement is not as our expectation, we can close all trades simultaneously prior to hitting stop losses or take profit.

Please this is the best strategy to hedge a trade that you have ever heard. Imagine if N = 1000 trades, P = 1 point, S=T_1 or S=T_1/2 is fixed. According to the law of large number, we are reaching our expectation. I reckon that you won't waste your time compared with entering only one trade at once time.

This is the first step in my strategy, if you can do that we can build a system together. My email is { email address deleted by staff }