Why won't this work? Please Help! (Color Changing TMA Slope) | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading DAX with TMA Slope 217 replies

RSI Color - Changing color when above/below 50 18 replies

Renko + TMA slope + MACD Colored 124 replies

please help adding changing color to this alert 1 reply

EA based on 10.2 TMA Slope indicator? 0 replies

Attachments: Why won't this work? Please Help! (Color Changing TMA Slope)
Exit Attachments

Why won't this work? Please Help! (Color Changing TMA Slope)

  • #21
  • Jul 13, 2013 1:04pm Jul 13, 2013 1:04pm
Quoting Kilian19
{quote} Sorry I think I expressed myself not clearly enough. I am not trying to program using Ninjascript I just want to learn how the platform works. I use the marketreplayconnection to trade on weekends and opened a market buy position on EURUSD. After I opened the position how do I add a stoploss and take profit by hand ? Thats like one of the most basic tasks but I can't seem to find the option. I don't want to use the DOM or charttrader isn't there a window where I can just set my stop loss and take profit?
Oh, ha! Completely misunderstood the question. Ninja is a bit finicky on OTO orders. If I ever used them, they would go in when I placed the order. I'm not sure there is a way to "protect" an already placed order to be honest, at least from what I recall. I only traded from the DOM though so I could be wrong. Also, OCO orders in Ninja are kept on the platform, not at the broker. So if the platform is off, the OCO doesn't exist.
Small disciplines repeated with consistency lead to great achievements.
  • #22
  • Jul 13, 2013 3:45pm Jul 13, 2013 3:45pm
Quoting Kilian19
{quote} There used to be a mt4 tick simulator somewhere on the internet. It's a really neat and little program when you want to test your code during the time markets are closed. The simulator sends a fake tick every few ms
Look here for that script file.

http://www.forexfactory.com/showthre...68#post4049368
  • #23
  • Jul 13, 2013 4:03pm Jul 13, 2013 4:03pm
Quoting BlackStack
{quote} Look here for that script file. http://www.forexfactory.com/showthre...68#post4049368
I was talking about this little tool which works great. I haven't looked at the script but if it works it's nice as well

https://www.fx1.net/wiki/pmwiki.php/MT4Ticker/MT4Ticker
  • #24
  • Jul 14, 2013 2:38pm Jul 14, 2013 2:38pm
Quoting Kilian19
{quote} I was talking about this little tool which works great. I haven't looked at the script but if it works it's nice as well https://www.fx1.net/wiki/pmwiki.php/MT4Ticker/MT4Ticker
Kilian I have one more issue that I'm hoping you could give me a hint or two about. I am practicing by making a Matrix for my 1M scalping charts (some of the parts). I am having a real issue though when it comes to the MTF matrix line - the slope of the TMA M5 (this indicator would be for a 1M chart). I am trying to review Xaphod's MTF stoch and arrow tape indicators, but am having trouble deciphering what it is that I need to use.

Again, I wouldn't expect you to fix my indi, but some advice for the right direction would be much appreciated.
Attached File(s)
File Type: mq4 Scalper's Matrix.mq4   10 KB | 347 downloads
Small disciplines repeated with consistency lead to great achievements.
  • #25
  • Edited 5:10pm Jul 14, 2013 4:56pm | Edited 5:10pm
I gladly help you with whatever question you got, but this time I don't understand what your problem is. Please elaborate it a little more closely.

Even though I don't know whats wrong there are 3 things that bother me:

1:
At least from my point of view this line of code is really bad habit if you are playing around with indicators

SetIndexLabel(i,NULL); delete it and give each IndexLabel a correct name.
e.g.
Inserted Code
//---- buffers
  IndicatorBuffers(8);
  SetIndexStyle(0,DRAW_ARROW);
  SetIndexBuffer(0,m5TMAUp);
  SetIndexLabel(0,"m5TMAUp");
  SetIndexStyle(1,DRAW_ARROW);
  SetIndexBuffer(1,m5TMADn);
  SetIndexLabel(1,"m5TMADn");
  SetIndexStyle(2,DRAW_ARROW);
  SetIndexBuffer(2,m1TMAUp);
  SetIndexLabel(2,"m1TMAUp");
  SetIndexStyle(3,DRAW_ARROW);
  SetIndexBuffer(3,m1TMADn);  
  SetIndexLabel(3,"m1TMADn");
  SetIndexStyle(4,DRAW_ARROW);
  SetIndexBuffer(4,kijunUp);
  SetIndexLabel(4,"kijunUp");
  SetIndexStyle(5,DRAW_ARROW);
  SetIndexBuffer(5,kijunDn);
  SetIndexLabel(5,"kijunDn");
  SetIndexStyle(6,DRAW_ARROW);
  SetIndexBuffer(6,babonUp);
  SetIndexLabel(6,"babonUp");
  SetIndexStyle(7,DRAW_ARROW);
  SetIndexBuffer(7,babonDn);
  SetIndexLabel(7,"babonDn");
Through that the indicator values will show up in the data box and debuging will be much easier.

2: Create Text Objects to make the indi more userfriendly.

3: The error say "Invalid Double Parameter for DoubleToStr method. So where did you use that method?

"string jj=DoubleToStr(hh,2);" Well first of all you don't use the variable jj anywere and if you are planing on using it be aware that you declared it inside the loop and that it can just be used there. Next step. hh is an array. You can't call the value like that it has to be hh[x] with an index. I am surprised why the compiler compiled the code ... Usually it's supposed to throw an error.
Attached Image (click to enlarge)
Click to Enlarge Name: Indi.jpg Size: 379 KB
  • #26
  • Jul 14, 2013 5:37pm Jul 14, 2013 5:37pm
The problem is that the top row, the TMA m5 slope changes all colors from the past to match the current slope. That is why it is all blue in the picture you posted. I want it to show what the slope was in the past as well as now.

1) I copied that from Xaphod's Genesis Matrix indicator. I will update it to reflect what each represents.

2) I don't know how to add labels yet, so I've got to figure that, but wanted to make sure I could even make the indicator work in the first place.

3) This was a line used for debugging to make sure that the TMA M5 value was calculating correctly, and it was. The problem is that it just changes the entire histogram color for that row to the current slope color, as mentioned above. I forgot to remove it once I went back to turning HH into an array. Previously, it was just a double, hence the double to string line. It just printed the vlaue on the right side of the indicator window.

Thank you for the advice, and hopefully the problem I am having is more clear. I want the top row, the TMA M5 slope, to reflect what the slope was at that point in time. As you see yours is all blue in that picture. It should not be as that chart appears to have been in a serious downtrend on the left side of your chart. It should print red over there.

The arrows you added next to the labels is awesome. That's what I wanted to do all along, but am not sure how. Again, once I get that top line working the way it should, then I will hopefully try to teach myself the extras. Thanks again -
Small disciplines repeated with consistency lead to great achievements.
  • #27
  • Jul 14, 2013 10:35pm Jul 14, 2013 10:35pm
Quoting jmflukeiii
1) I copied that from Xaphod's Genesis Matrix indicator. I will update it to reflect what each represents.
Quoting Kilian19
At least from my point of view this line of code is really bad habit if you are playing around with indicators SetIndexLabel(i,NULL);
Yes, I will take full responsibility for that. What is the point of displaying color coded binary data in 4 different places on your screen to 4 decimal places. The whole point of the matrix is to condense the data so it can be read at a glance, give a broad overview and reduce the clutter on the screen.

  1. The data is displayed in the matrix. Color and position coded binary data.
  2. The arrows added to the right are simply the last/current line of the matrix, sitting right next to very values the depict. The only difference is the graphical depiction. Redundant.
  3. Top-left beside the name of the indicator are the current values in four decimal places. They however do not show which variables are being depicted. Useless, confusing and redundant.
  4. Data window. What is easier to understand and to take in:
    Four vertical listed color coded squares: blue, red, red, red
    or
    A list of 8 variable names with fixed values to 4 decimal places taking up a non-trivial chunk of your screen real estate.

Points 2, 3 and 4 do not add any information not already displayed in point 1.
Setting the indexlabel values to NULL gets rid of point 3.
It was done on purpose and not as a result of a really bad habit.
The data displayed in point 4 is of no use for this type of indicator in production.

  • #28
  • Jul 14, 2013 11:15pm Jul 14, 2013 11:15pm
Thanks for the response X. Do you have any words of wisdom concerning my question - the top row, which represents a MTF TMA, is printing the color of the current bar throughout the entire history... For example, in that pic, it is blue because the TMA mtf is currently up, but it has set all bars throughout the history as blue.

thanks for any direction you might be able to provide
Small disciplines repeated with consistency lead to great achievements.
  • #29
  • Jul 14, 2013 11:47pm Jul 14, 2013 11:47pm
Quoting jmflukeiii
Thanks for the response X. Do you have any words of wisdom concerning my question - the top row, which represents a MTF TMA, is printing the color of the current bar throughout the entire history... For example, in that pic, it is blue because the TMA mtf is currently up, but it has set all bars throughout the history as blue. thanks for any direction you might be able to provide
First off, if you format your code properly, it will make it easier read and more likely others may try to help:
http://en.wikipedia.org/wiki/Indent_style
http://universalindent.sourceforge.net/

A single color across a full row usually means it is not getting any data. Print out the last 20 or so data values from the hh[] array to verify that they are correct. If they are not correct follow the calculations for hh[] with debug printing until you find the problem.
http://www.forexfactory.com/showthre...72#post5453772

Using iCustom to get data for higher a timeframe indicator is much easier that managing your own series arrays and calculations locally. It is probably also faster as managing series arrays locally is slower that mql4s internal management.

So I would suggest getting the MTF TMA data via iCustom to start off. When you get that working you can then move the MTF functionality into the indicator and eliminate iCustom.
  • #30
  • Jul 15, 2013 12:11am Jul 15, 2013 12:11am
Thank you
Small disciplines repeated with consistency lead to great achievements.
  • #31
  • Jul 15, 2013 12:35am Jul 15, 2013 12:35am
A few more tips.

If you are managing your own array series, you should read this thread:
http://www.forexfactory.com/showthread.php?t=165411

Kijun Calculations
Why not use the built in Ichimoku function to calculate the Kijun data. It is significantly faster than re-sizing arrays and recalculating all bars on every tick:
http://docs.mql4.com/indicators/iIchimoku

It may be more efficient to resize the arrays only when new bars are added.
  • #32
  • Edited 4:47am Jul 15, 2013 12:53am | Edited 4:47am
Quoting Xaphod
Yes, I will take full responsibility for that. What is the point of displaying color coded binary data in 4 different places on your screen to 4 decimal places.
It was done on purpose and not as a result of a really bad habit.
Hiding the values after you are done with the indicator is perfectly reasonable it even makes the terminal cleaner but for me it makes coding easier since the data box is an easy place to look at . You can start debugging right away without adding much code. I didn't want to attack you in any ways I just believe that at this stage he should change it back . Once he is done with everything of course it is better to set those lables to null.
I didn't want to say that the way you did it above was wrong it probably is even better for the final result. Maybe I didn't express myself clearly enough ( habit was probably the wrong word there )

Once something doesn't work the way it is intended to work I usually compare what the variables should be and what they currently are!

Quote
Using iCustom to get data for higher a timeframe indicator is much easier that managing your own series arrays and calculations locally. It is probably also faster as managing series arrays locally is slower that mql4s internal management.

Well said. When I write a matrix I usually separate the logic of the indicator and the matrix completely. It makes changes simpler and if you need more than 8 buffers you can simply copy and paste much of the code needed from the matrix code and create a second indicator.

I was using iCustom throughout the time but I thought that this wasn't the way you are supposed to do it ...... I personally don't bother if I have 1 or two indicator files sitting in my folder. You learn something new every day

Yes the arrows don't offer any additional information but I like the way they look ....


And important:
#1 Remember this code we added earlier? It was only to fill the gaps of the slope and had a visual purpose only. If you perform any calculation on this data series you will get wrong results since there are values stored where following the logic of the calculations shouldn't be anything.

It was necessary to connect the slope of the indicator but now your indicator will draw both, the up and the down block. One will be painted in front of the other so you either have too many red or too many blue squares

Inserted Code
   if ( slopeAverage[inx] > slopeAverage[inx+1] ) 
            { m1TMAUp[inx] = gadGap[IDX_TMAm1];
             //if(m1TMAUp[inx+1] == EMPTY_VALUE)
                  // m1TMAUp[inx+1] = m1TMADn[inx+1];
             }
         else 
            { m1TMADn[inx] = gadGap[IDX_TMAm1]; 
              //if(m1TMADn[inx+1] == EMPTY_VALUE)
                   //m1TMADn[inx+1] = m1TMAUp[inx+1];
             }


#2

Inserted Code
   
for ( inx = intLimit; inx >=0; inx--)
   {
      double atrMTF = iATR(NULL,select_other_tf_to_show,atrPeriod,10)*0.1;
      if (atrMTF == 0) return( 0 );

If you are using functions (which would be a good thing to do btw ) this code would do what you except it to do but you are stooping the whole start function once the ATR is zero meaning Kijun and babon will not be calculated. You should take a look at the break or continue! statement.
It doesn't matter what you return in this case but by convention return ( 0 ) means everything worked fine and return( -1 ) indicates that there was an error somewhere.


#3
One common error happening with MTF indicators is that some of the required data history is missing and mt4 doesn't tell you about it. Make sure to open the charts of every tf at least once and scroll to the beginning.


#4
Inserted Code
   hh[inx] = ( dblTmaMTF - dblPrevMTF ) / atrMTF;
    
         if(hh[inx]<0) { m5TMADn[inx] = gadGap[IDX_TMAm5]; }
         else          { m5TMAUp[inx] = gadGap[IDX_TMAm5]; }

That is the only time you are using hh[inx] and the only operation you do is to compare if it is bigger or smaller than 0. If you divide a positive number by something positive the outcome is always going to be a positive number. If you divide a negative number by something positive the value will always be negative so you can delete all the ATR stuff.

#5

Inserted Code
      double dblTmaMTF = calcTmaMTF( inx , select_other_tf_to_show );
      double dblPrevMTF = calcTmaMTF( inx , select_other_tf_to_show);
      
      hh[inx] = ( dblTmaMTF - dblPrevMTF );
What are you doing here? You take 2 variables perform the same calculations on it and afterwards you check if they are any different? Just because you name the variable prev it doesn't calculate the previous value. Look at the inx value. Shouldn't they point at different bars?

#6
Once you have that fixed the historic bars should be correct. But think about what happens when the current bar is close to the threshold and will be above and below 0 during the same bar? What values will be stored in your buffers? What could cause a problem?
Attached Image (click to enlarge)
Click to Enlarge Name: Unbenannt.png Size: 31 KB
  • #33
  • Edited 9:38am Jul 15, 2013 7:56am | Edited 9:38am
Kilian - thank you very much for your extended, detailed response. I very much appreciate it -

I addressed issue number 5, and now the top row does change colors, but the colors aren't right. So I will have to try something else there I guess.
Small disciplines repeated with consistency lead to great achievements.
  • #34
  • Jul 15, 2013 10:04am Jul 15, 2013 10:04am
Quoting jmflukeiii
Kilian - thank you very much for your extended, detailed response. I very much appreciate it - I addressed issue number 5, and now the top row does change colors, but the colors aren't right. So I will have to try something else there I guess.
Just keep us updated.

First thing you need to check is if dblTmaMTF and dblTmaMTF contain the right values. For that purpose just comment out 2 other buffers and use those to display the value
  • #35
  • Jul 15, 2013 10:32am Jul 15, 2013 10:32am
Quoting Xaphod
A few more tips. If you are managing your own array series, you should read this thread: http://www.forexfactory.com/showthread.php?t=165411 Kijun Calculations Why not use the built in Ichimoku function to calculate the Kijun data. It is significantly faster than re-sizing arrays and recalculating all bars on every tick: http://docs.mql4.com/indicators/iIchimoku It may be more efficient to resize the arrays only when new bars are added.
X I missed your comment, thank you for the response as well. I didn't think to just use ichimoku - I will try to make that work. Thanks again
Small disciplines repeated with consistency lead to great achievements.
  • #36
  • Edited 2:49pm Jul 15, 2013 2:25pm | Edited 2:49pm
Quoting Kilian19
{quote} Just keep us updated. First thing you need to check is if dblTmaMTF and dblTmaMTF contain the right values. For that purpose just comment out 2 other buffers and use those to display the value
To draw the arrows you did in the right margin, did you use ObjectCreate? If so, it is my understanding, not that I have much , that ObjectCreate must use price and time coordinates for all but Draw Label/Text. Could you explain a little about how you do that?

I have set the Time parameter similar to what Xaphod did - just set it for a future date. However, if I wanted to say draw an arrow in the main window, how would I specificy a price if I always wanted it to be in the lower right of the chart (because obviously the chart range will change depending on the market)?
Small disciplines repeated with consistency lead to great achievements.
  • #37
  • Jul 15, 2013 3:13pm Jul 15, 2013 3:13pm
Quoting jmflukeiii
I specificy a price if I always wanted it to be in the lower right of the chart (because obviously the chart range will change depending on the market)?
Objects are set to a specific time and price, Labels behave differently.
Labels stay at a fixed position (x pixels, y pixels ) at the screen. The trick is to create a Label and convert it into an arrow using webdings.
  • #38
  • Jul 15, 2013 3:38pm Jul 15, 2013 3:38pm
Quoting Kilian19
{quote} Objects are set to a specific time and price, Labels behave differently. Labels stay at a fixed position (x pixels, y pixels ) at the screen. The trick is to create a Label and convert it into an arrow using webdings.
That realization had just come to me and I was coming here to update my statement! Thank you for helping with my elementary questions -
Small disciplines repeated with consistency lead to great achievements.
  • #39
  • Jul 15, 2013 3:40pm Jul 15, 2013 3:40pm
Quoting jmflukeiii
{quote} That realization had just come to me and I was coming here to update my statement! Thank you for helping with my elementary questions -
Well if you figure it out on your own it will stick in your mind faster
  • #40
  • Jul 15, 2013 3:55pm Jul 15, 2013 3:55pm
Quoting jmflukeiii
{quote} That realization had just come to me and I was coming here to update my statement! Thank you for helping with my elementary questions -
I don't have that arrow that you used in my fonts. I have Webdings, Wingdings, Wingdings 2, Wingdings 3. Which did yours come from?
Small disciplines repeated with consistency lead to great achievements.
0 traders viewing now