Why won't this work? Please Help! (Color Changing TMA Slope) | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading DAX with TMA Slope 217 replies

RSI Color - Changing color when above/below 50 18 replies

Renko + TMA slope + MACD Colored 124 replies

please help adding changing color to this alert 1 reply

EA based on 10.2 TMA Slope indicator? 0 replies

Attachments: Why won't this work? Please Help! (Color Changing TMA Slope)
Exit Attachments

Why won't this work? Please Help! (Color Changing TMA Slope)

  • #1
  • First Post: Jul 13, 2013 2:58am Jul 13, 2013 2:58am
Hi - I have been working on this for hours and hours, and I'm sure its something simple that I am overlooking. The attached code is supposed to be a slope of a TMA slope. When I first attach it to a chart it shows up as blank. Then if I compile the code and look at the chart again, it is doing what it is supposed to do. Then if I edit the properties in MT4, it goes blank again! Then if I click compile in the editor, it comes back.... etc. What have I over looked here???

Thank you in advance for any help you could provide -
Attached File(s)
File Type: mq4 TMA Slope True .mq4   4 KB | 574 downloads
Small disciplines repeated with consistency lead to great achievements.
  • #2
  • Jul 13, 2013 4:43am Jul 13, 2013 4:43am
In my opinion mql4 is a poorly written language. Anyways that is a bug that happens but is not that crucial since you won't be changing the code all the time .
One thing you might want to try is adding the color property for the Buffers in the SetIndexStyle call.
  • #3
  • Jul 13, 2013 4:50am Jul 13, 2013 4:50am
I don't know for sure, but have you had this problem only when the market is closed for the weekend?
I've had problems with my codes working fine as long as there are incoming ticks. but not at weekends
Right click on your chart and refresh and see if this does the trick.
Can't offer any solutions though as I am not good enough to follow your code yet.
Please Do Not PM Me With Coding Enquiries
  • #4
  • Jul 13, 2013 4:52am Jul 13, 2013 4:52am
Quoting Gumrai
I don't know for sure, but have you had this problem only when the market is closed for the weekend? I've had problems with my codes working fine as long as there are incoming ticks. but not at weekends Right click on your chart and refresh and see if this does the trick. Can't offer any solutions though as I am not good enough to follow your code yet.

There used to be a mt4 tick simulator somewhere on the internet. It's a really neat and little program when you want to test your code during the time markets are closed. The simulator sends a fake tick every few ms
  • #5
  • Edited 5:43am Jul 13, 2013 5:09am | Edited 5:43am
Quoting jmflukeiii
Hi - I have been working on this for hours and hours, and I'm sure its something simple that I am overlooking. The attached code is supposed to be a slope of a TMA slope. When I first attach it to a chart it shows up as blank. Then if I compile the code and look at the chart again, it is doing what it is supposed to do. Then if I edit the properties in MT4, it goes blank again! Then if I click compile in the editor, it comes back.... etc. What have I over looked here??? Thank you in advance for any help you could provide - {file}
Put the iMAOnArray calculation in its own loop after the tma loop. Ie, first you calculate the tma slope for all data points in the series and then you calculate the averages for the tma slope data.
  • #6
  • Jul 13, 2013 5:36am Jul 13, 2013 5:36am
Xaphod good point. I didn't see him using an average function in his code and I thought the only problem was that the lines had a wrong color.

I had my trouble with average calculation as well the first time I used it. You need 2 for loops. During the first you fill the base array with data and after that you need a second loop to execute the operations.
  • #7
  • Jul 13, 2013 11:10am Jul 13, 2013 11:10am
Wow - thank you both for your help, I really appreciate it. I have become fairly proficient at programming for Ninjatrader, but its amazing how different mql4 is. Practice I guess. Again, thank you very much
Small disciplines repeated with consistency lead to great achievements.
  • #8
  • Jul 13, 2013 11:41am Jul 13, 2013 11:41am
Again, thank you both. I got it working other than the holes in the line when the slope goes from rising to falling. A hint would be appreciated concerning that also.

And if someone had the time, could you please explain what the following code is for (I took it from the original file I modified into this one that I made):

int intLimit = MathMin( Bars - 1, Bars - counted_bars + eintPeriod );

Thanks again -
Small disciplines repeated with consistency lead to great achievements.
  • #9
  • Jul 13, 2013 11:43am Jul 13, 2013 11:43am
would you be so kind and upload your current version ?
  • #10
  • Jul 13, 2013 12:14pm Jul 13, 2013 12:14pm
Quoting Kilian19
would you be so kind and upload your current version ?
Certainly! Wouldn't be working without you guys anyway
Attached File(s)
File Type: mq4 TMA Slope True .mq4   5 KB | 564 downloads
Small disciplines repeated with consistency lead to great achievements.
  • #11
  • Jul 13, 2013 12:19pm Jul 13, 2013 12:19pm
Quoting Kilian19
would you be so kind and upload your current version ?
Killian, or Xaphod, perhaps you could help me with another project - I want to set the background color of a lower panel indicator based on a set of conditions. a) is this possible, and b) what methods should I read about to do so. The conditions are going to be the slope of the M5 TMA, but this will be on a M1 chart.

I have plenty of MTF TMA code to work from, but not sure if modifying background color is possible in just one indicator panel. If not, perhaps I could draw a rectangle, or actually even better, draw a big big red or green arrow in the right margin depending on the M5 TMA slope.
Small disciplines repeated with consistency lead to great achievements.
  • #12
  • Edited 12:39pm Jul 13, 2013 12:29pm | Edited 12:39pm
Quoting jmflukeiii
{quote} Certainly! Wouldn't be working without you guys anyway {file}
try it that way.

it is working for me

Inserted Code
if ( slopeAverage[inx] > slopeAverage[inx+1] )
       {
           gadblUp1[inx] = slopeAverage[inx];
           if(gadblUp1[inx+1] == EMPTY_VALUE)
              gadblUp1[inx+1] = gadblDn1[inx+1];
       }
       else 
       {
           gadblDn1[inx] = slopeAverage[inx];
           if(gadblDn1[inx+1] == EMPTY_VALUE)
              gadblDn1[inx+1] = gadblUp1[inx+1];
       }

Quote
Killian, or Xaphod, perhaps you could help me with another project - I want to set the background color of a lower panel indicator based on a set of conditions. a) is this possible, and b) what methods should I read about to do so. The conditions are going to be the slope of the M5 TMA, but this will be on a M1 chart.


Well it's possible with a workaround


ObjectCreate(); OBJ_RECTANGLE
ObjectSet , OBJPROP_COLOR
Obj has to be set to background = true

Quote
I have plenty of MTF TMA code to work from, but not sure if modifying background color is possible in just one indicator panel. If not, perhaps I could draw a rectangle, or actually even better, draw a big big red or green arrow in the right margin depending on the M5 TMA slope.

Changing the background color is only possible via objects. If for some reason you want to cover up some parts of the chart you have to create objects (squares) using winding or webdings. Arrows are created the same way.


Quote
int intLimit = MathMin( Bars - 1, Bars - counted_bars + eintPeriod );
That my dear friend you can figure our on your own. Where is this variable used? Just at the for loop. So it somehow has to do over which bars the calculations take place. Why does it look so weird? Usually this for loop is constructed without the min function and I am not sure if it really is necesary it might be important for what ever reason. But just look at what those things do and you will figure it out. It's not that hard.
  • #13
  • Jul 13, 2013 12:34pm Jul 13, 2013 12:34pm
Quoting Kilian19
{quote} try it that way. it is working for me if ( slopeAverage[inx] > slopeAverage[inx+1] ) { gadblUp1[inx] = slopeAverage[inx]; if(gadblUp1[inx+1] == EMPTY_VALUE) gadblUp1[inx+1] = gadblDn1[inx+1]; } else { gadblDn1[inx] = slopeAverage[inx]; if(gadblDn1[inx+1] == EMPTY_VALUE) gadblDn1[inx+1] = gadblUp1[inx+1]; } {quote} Well it's possible with a workaround ObjectCreate(); OBJ_RECTANGLE ObjectSet , OBJPROP_COLOR
Excellent - thank you. I was just looking at another piece of code and working on that solution.

I'll check out the workaround. Ninja I have to say is far far more user friendly to program in. But I bet for someone that really knows what they are doing, both are equally as powerful.
Small disciplines repeated with consistency lead to great achievements.
  • #14
  • Jul 13, 2013 12:44pm Jul 13, 2013 12:44pm
Quoting jmflukeiii
{quote} Excellent - thank you. I was just looking at another piece of code and working on that solution. I'll check out the workaround. Ninja I have to say is far far more user friendly to program in. But I bet for someone that really knows what they are doing, both are equally as powerful.
No thats not true. Mql4 is really limited but it is enough for the average persons use. Once you want to do complex stuff you need to export the data and use external programms and programming languages.
Mql4 gets much stronger once you learn how to import the windows api. Dll calls make mql4 at least workable with.

Mql5 on the other hand is object oriented which makes it much much better. Right now I work with Ninjatrader as well and I prefer it over Metatrader but I am still struggling with some basic tasks like adding a stop loss to an already open position (manually not with code ). Would you mind helping me out there? I will send you a message later.
  • #15
  • Jul 13, 2013 12:46pm Jul 13, 2013 12:46pm
Quoting Kilian19
{quote} It's not that hard.
In ninja, the code is much simpler, and I wasn't accustomed to seeing the Min( function, so I was curious as to why that was used.
Small disciplines repeated with consistency lead to great achievements.
  • #16
  • Jul 13, 2013 12:50pm Jul 13, 2013 12:50pm
Quoting Kilian19
{quote} No thats not true. Mql4 is really limited but it is enough for the average persons use. Once you want to do complex stuff you need to export the data and use external programms and programming languages. Mql4 gets much stronger once you learn how to import the windows api. Dll calls make mql4 at least workable with. Mql5 on the other hand is object oriented which makes it much much better. Right now I work with Ninjatrader as well and I prefer it over Metatrader but I am still struggling with some basic tasks like adding a stop loss to an...
I assume you want to add a stop loss given a certain set of conditions occurs? Do you place a stop initially with the position?
As for Ninja, Koganam at the Ninja forums is an excellent resource and will usually respond to any question you may have, but I can certainly try to help.

As for my previous question, I guess I was trying to compare what parts of the mql4 code serve the same funtion as the Ninja code I'm accustomed to.

For example, to ensure that their are enough bars from which to calculate data in Ninja, you would use something along the lines of:

If (CurrentBar<maPeriod) return;

The code I asked about in mql4 indi I'm working on... I assume that serves the same function?
Small disciplines repeated with consistency lead to great achievements.
  • #17
  • Jul 13, 2013 12:51pm Jul 13, 2013 12:51pm
Quoting jmflukeiii
{quote} In ninja, the code is much simpler, and I wasn't accustomed to seeing the Min( function, so I was curious as to why that was used.
Do you know how we used to solve those questions? Take a pen and paper write down all the important variables and simulate 2 loops. Then pick the scenario when something interesting parts like when the Min function chooses the other value. It really helps you to get into the code

If you got any other questions feel free to ask.

I got no idea why they chose this way but I wouldn't bother too much about it. It usually is written in a way simpler and more logical way.
  • #18
  • Jul 13, 2013 12:56pm Jul 13, 2013 12:56pm
Quoting Kilian19
{quote} No thats not true. Mql4 is really limited but it is enough for the average persons use. Once you want to do complex stuff you need to export the data and use external programms and programming languages. Mql4 gets much stronger once you learn how to import the windows api. Dll calls make mql4 at least workable with. Mql5 on the other hand is object oriented which makes it much much better. Right now I work with Ninjatrader as well and I prefer it over Metatrader but I am still struggling with some basic tasks like adding a stop loss to an...
I have attached one of my largest strategies I wrote, uses SuperTrend and some other filters to trade on a Range Bar chart. In the one file, ATRTradeNQ, there are some examples of trailing stops. In the other one, ScarletWillow, this is my live trading version with toolbar buttons as well to make changes on the fly.
Attached File(s)
File Type: zip ScarletWillowLiveTrader.zip   44 KB | 600 downloads
File Type: zip ATRTradeNQ.zip   42 KB | 563 downloads
Small disciplines repeated with consistency lead to great achievements.
  • #19
  • Jul 13, 2013 1:00pm Jul 13, 2013 1:00pm
Quoting Kilian19
{quote} Do you know how we used to solve those questions? Take a pen and paper write down all the important variables and simulate 2 loops. Then pick the scenario when something interesting parts like when the Min function chooses the other value. It really helps you to get into the code If you got any other questions feel free to ask. I got no idea why they chose this way but I wouldn't bother too much about it. It usually is written in a way simpler and more logical way.
Good idea - thanks again for the help.
Small disciplines repeated with consistency lead to great achievements.
  • #20
  • Jul 13, 2013 1:00pm Jul 13, 2013 1:00pm
Quoting jmflukeiii
{quote} I have attached one of my largest strategies I wrote, uses SuperTrend and some other filters to trade on a Range Bar chart. In the one file, ATRTradeNQ, there are some examples of trailing stops. In the other one, ScarletWillow, this is my live trading version with toolbar buttons as well to make changes on the fly. {file} {file}

Sorry I think I expressed myself not clearly enough. I am not trying to program using Ninjascript I just want to learn how the platform works. I use the marketreplayconnection to trade on weekends and opened a market buy position on EURUSD. After I opened the position how do I add a stoploss and take profit by hand ? Thats like one of the most basic tasks but I can't seem to find the option. I don't want to use the DOM or charttrader isn't there a window where I can just set my stop loss and take profit?
0 traders viewing now