Encoded MagicNumber | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to give a manually entered trade the same MagicNumber as EA 19 replies

MagicNumber Profit tracker? 0 replies

Check magicnumber of open position 4 replies

Why is there NOT a Multi-MagicNumber Manager EA? 6 replies

Search: Buy/Sell Skript with TP/SL and MagicNumber ? 3 replies

Encoded MagicNumber

  • #1
  • First Post: Jun 26, 2013 11:49am Jun 26, 2013 11:49am
hi,

Maybe someone has done this befor so I ask.

I would like to send some encoded string as MagicNumber
e.g. the Chart an EA was executed on: Symbol, Period and some additional info

when selecting an Order: OrderMagicNumber I want to be able to decode this again.

1.
e.g. string to send as MagicNum: "Chart:EURUSD,M1 System:MyLongHopefullyWinningNeverLoosingSystemName"

result should be a valid MagicNum: integer e.g. 847483647

2.
afterwards I need to decode it back to the initial string


I know there is the CommentField but I would prefer to have it encoded in the MagicNum
Metatrade4 Docu: comment: Order comment text. Last part of the comment may be changed by server. (which does not say too much does it)


Any ideas ??

thanks
Money is important, Love is essential.
  • #2
  • Jun 26, 2013 12:29pm Jun 26, 2013 12:29pm
Hello Ati Baia!

Well, it may be somewhat difficult to do because the Magic Number is expecting an integer. It’s probably better to use the Comment because it’s a string. Using OrderSend() and then OrderComment() in combination with OrderSelect() would allow you to do what you are seeking.

Is there a specific reason you want to avoid using the comment field?

Brad
  • #3
  • Jun 26, 2013 12:31pm Jun 26, 2013 12:31pm
Thanks Brad Bonds,

I'm unsure about the comment field and how different broker handle it.

Metatrade4 Docu: comment: Order comment text. Last part of the comment may be changed by server. (which does not say too much does it)

Do you know how long: many chars the string can be: how much the broker can change ect. ect


Thanks
Money is important, Love is essential.
  • #4
  • Jun 26, 2013 12:49pm Jun 26, 2013 12:49pm
You’re welcome!

I’m not sure what the maximum length of characters is in the comment field, but I’d venture a guess that it’s the same maximum as any string, so 255 characters. I’ve talked to some of our developers, and they’ve built EA’s with up to 50 character comments and had no issues.

Regarding the comment change, MT4 itself may change the comment on a particular ticket. One example is a margin called ticket; the last characters may be modified to say “SO” or something similar. In this case you’d want to build your logic to search the comment and see if it contains the string, not if it equals that string. This should work around any server-change issues.

With that, I can’t see a reason that a broker would actively change the comment field, but I suppose it’s possible. But since the comment field is probably used by a number of EA’s for tracking purposes, it doesn’t seem likely that a broker would do so.

Hope this helps as well! Thanks again for your time and best of luck coding!

Brad
  • #5
  • Jun 26, 2013 12:56pm Jun 26, 2013 12:56pm
thanks Brad.

I might give it a try: maybe someone ese still comes up with some nice ideas to encode it to the MacigNum.

Cheers

Ati
Money is important, Love is essential.
  • #6
  • Jun 26, 2013 1:06pm Jun 26, 2013 1:06pm
Quoting Brad Bonds
You’re welcome! I’m not sure what the maximum length of characters is in the comment field, but I’d venture a guess that it’s the same maximum as any string, so 255 character. With that, I can’t see a reason that a broker would actively change the comment field, but I suppose it’s possible. But since the comment field is probably used by a number of EA’s for tracking purposes, it doesn’t seem likely that a broker would do so. Hope this helps as well! Thanks again for your time and best of luck coding! Brad

Some (most?) brokers will change the comments field when an order is partially closed. A new order is created and the comment field contains the original ticket number appended to the comments.
  • #7
  • Jun 26, 2013 1:19pm Jun 26, 2013 1:19pm
There was a lengthy discussion about creating unique and meaningful Magic Numbers several years ago and someone came up with a clever (to me) hashing algorithm to implement it. Not sure if it suits your needs, but it may give you some ideas.

http://www.forexfactory.com/showthread.php?p=3729335
  • #8
  • Jun 26, 2013 1:24pm Jun 26, 2013 1:24pm
Thanks CodeMeister,

I know 7bits MagicNumber Hash code.

To generate the Integer is not a real problem but to get an encoding which allows for later decoding and is small enough to fit an integer.

I did not give it much thought until now - just asked in case someone did such before me.
Money is important, Love is essential.
  • #9
  • Jun 26, 2013 1:34pm Jun 26, 2013 1:34pm
Quoting CodeMeister
{quote} Some (most?) brokers will change the comments field when an order is partially closed. A new order is created and the comment field contains the original ticket number appended to the comments.


Thanks for the replies! And great point CodeMeister! I didn’t even think of that. The ticket number changes because… it has to. In the case of a partial close, there’s no way to keep the same ticket number from a coding perspective, a new ticket number (with the same opening trade details) must be created, which will change the comments. But, if Ati Baia’s EA doesn’t partially close trades, I don’t think there’ll be an issue.

Thanks for the link too! Much appreciated.

Brad
  • #10
  • Jun 26, 2013 1:40pm Jun 26, 2013 1:40pm
Quoting Brad Bonds
But, if Ati Baia’s EA doesn’t partially close trades, I don’t think there’ll be an issue. Thanks for the link too! Much appreciated. Brad
would not be a problem in my case.
anyway here is a link to 7bits webpage (contains his makeMagicNumber function): https://sites.google.com/site/prof7bit/common_functions
Money is important, Love is essential.
  • #11
  • Jun 26, 2013 4:55pm Jun 26, 2013 4:55pm
Quoting Ati Baia
hi, Maybe someone has done this befor so I ask. I would like to send some encoded string as MagicNumber e.g. the Chart an EA was executed on: Symbol, Period and some additional info when selecting an Order: OrderMagicNumber
You don't need to encode the Symbol in the Magic Number, just use OrderSymbol() . . . I have a unique Magic umber for each of my EAs and then I add on an integer to represent the period.
20 pips a day isn't too much to ask . . .
  • #12
  • Jun 26, 2013 5:20pm Jun 26, 2013 5:20pm
Quoting Ati Baia
I would like to send some encoded string as MagicNumber e.g. the Chart an EA was executed on: Symbol, Period and some additional info when selecting an Order: OrderMagicNumber I want to be able to decode this again. 1. e.g. string to send as MagicNum: "Chart:EURUSD,M1 System:MyLongHopefullyWinningNeverLoosingSystemName" result should be a valid MagicNum: integer e.g. 847483647 2. afterwards I need to decode it back to the initial string
Any ideas ?? thanks
Just an idea how to accomplish it :

Define integers for each Symbol() .
Example: EURUSD = 11
GBPUSD = 22
USDJPY = 33

Define integers for each timeframe .
M1 = 1
M5 = 5
M15 = 15

Define integers for each strategy.
MA-cross with RSI = 1
MACD 4 hour strategy = 2
Sam Seiden style = 3

With such predefined arrays you can create a MagicNumber which is a valid integer like
MagicNumber = 11254879
Since you defined each substring in a function,
you can decode the whole thing easily in a function.
  • #13
  • Jun 26, 2013 6:33pm Jun 26, 2013 6:33pm
Quoting RaptorUK
{quote} You don't need to encode the Symbol in the Magic Number, just use OrderSymbol() . . . I have a unique Magic umber for each of my EAs and then I add on an integer to represent the period.
In my case this does not work: because I execute multiple Symbols/TFI from one EA: So the Order symbol will not show me where the original EA was running on.
Money is important, Love is essential.
  • #14
  • Last Post: Edited 9:00pm Jun 26, 2013 6:41pm | Edited 9:00pm
Thanks for all the input: I just came back and wanted to post what I decided to do which is basically what you guys suggested.

1. Index all Symbols: I decided to index them in 100 steps
e.g.
AUDCAD 100
AUDCHF 200
AUDHKD 300
AUDJPY 400
AUDNZD 500

2. the last 2 digits I use twice for the 9 official MT4 TimeFrames
- 10-90 for the Chart TF the EA is attached to (ExecutionTFI)
- 1-9 the Order Symbol: virtual Base TF (like if the EA would run on this Chart with such Period)

ExecutionTFI
M1 = 10
M5 = 20
M15 = 30
M30 = 40
H1 = 50

VirtualBaseTFI
M1 = 1
M5 = 2
M15 = 3
M30 = 4
H1 = 5

So if an EA is attached to AUDJPY and Period M15 and simulates a execution of: EURUSD Period H1 the MagicNum would be:
AUDJPY = 400
Period M15 (ExecutionTFI) = 30

Period H1 (VirtualBaseTFI) = 5
MagicNum = 435

The Order Symbol I can get always with OrderSymbol()

Anyway Thanks a lot

ATI
Money is important, Love is essential.
0 traders viewing now