TCO Trader EA | Page 18 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Are you a trend trader or a counter-trend trader? 29 replies

A beginner trader vs pro trader 15 replies

from retail trader to full-time trader 17 replies

Discipline Trader and Voice Trader EA/IND 16 replies

IkonFX Viking Trader or Pfgbest Viking Trader? 2 replies

Attachments: TCO Trader EA
Exit Attachments

TCO Trader EA

  • #341
  • Jun 16, 2013 11:12am Jun 16, 2013 11:12am
BetterLife, I appreciate your looking at the code and looking for issues and bugs. I don't appreciate you posting another EA version. My new update will be handling the ATR multiplier as defined as double and not int. This will be released with the next EA update along with other fixes and improvements. Please remove your EA so that we don't get a bunch of versions of different EAs. Then we have to start answering support questions about this EA or that EA. This thread is dedicated to the EA I created. Please list and issues or bugs and possible code improvements or strategy improvements in the thread or by PMing me.

Thanks!
  • #342
  • Jun 16, 2013 11:20am Jun 16, 2013 11:20am
I am very sorry for this misunderstanding.
I remove immediately the EA.
If you didn't manage to download it and you want to have a look, let me know how I can send it to you.

I just wanted to be useful, no other intention.

Bye

BL
πάντα δοκιμάζετε τὸ καλὸν κατέχετε
  • #343
  • Jun 16, 2013 11:33am Jun 16, 2013 11:33am
Quoting betterlife
I am very sorry for this misunderstanding. I remove immediately the EA. If you didn't manage to download it and you want to have a look, let me know how I can send it to you. I just wanted to be useful, no other intention. Bye BL

Thanks BetterLife, I appreciate your cooperation and understanding in keeping an organized thread.

As far as the issues that you brought up, must of them are just cut and paste things from previous EAs or other code. So they are not an issue and don't pose an issue with how the EA actually trades.

The Code here
if(CheckOncePerBar == true)
{
Check_New_Bar();
shift = 1;
double BidPrice = iClose(Symbol(), Lower_TF, shift);
double AskPrice = iClose(Symbol(), Lower_TF, shift); //why the hell? BL
}
Was done so we could use the same variables for either Bar Mode or Tick Mode.

If we are using bar mode, we really only car of the last bar's close was above/below the EMAs or above/below the Kijun and Tenkan Sens, for tick mode we are checking if bid or ask are above or below. That was my way of making the coding in the main trade logic section easier to handle.
  • #344
  • Jun 16, 2013 1:22pm Jun 16, 2013 1:22pm
Hi All
Could some answer the following related to the EA see below setting explanation from the txt document explaining the EA;

CloseAfterPctProfit=true; - If set to true, EA will close all orders after certain profit percentage reached
ProfitPct =3.0; - Percentage profit to reach before closing all orders

  1. Does the above mean that the EA will close all open orders on the MT4 paltform regardless of open orders that have not been opened by the EA?
  2. Or will it close orders pair specific e.g. the pair that the EA is loaded to, if loaded to eurusd the EA will close if profit is 3% on the eurusd pair?
  3. What is the 3% based on equity or balance?

Thanks

  • #345
  • Jun 16, 2013 2:00pm Jun 16, 2013 2:00pm
Quoting moneyrunner
Hi All Could some answer the following related to the EA see below setting explanation from the txt document explaining the EA; CloseAfterPctProfit=true; - If set to true, EA will close all orders after certain profit percentage reached ProfitPct =3.0; - Percentage profit to reach before closing all orders Does the above mean that the EA will close all open orders on the MT4 paltform regardless of open orders that have not been opened by the EA? Or will it close orders pair specific e.g. the pair that the EA is loaded to, if loaded to eurusd the...
1) It does not close pending orders, just actual executed orders.
2) It closes orders from ALL pairs, not just the pair on which you have the settings attached.
3) The percentage is based on balance, not equity.

TurtleFan
Prices are never too high to begin buying or too low to begin selling.
  • #346
  • Jun 16, 2013 2:13pm Jun 16, 2013 2:13pm
Turtlefan
Thanks for the reply, this will help
  • #347
  • Jun 16, 2013 4:33pm Jun 16, 2013 4:33pm
In the settings display located top left, even though I have TP and SL set to true using ATR levels, it still shows default hard 250 SL and 350 TP. Is this normal?

Would also just like to reiterate my request for an arrow showing us the higher TF trend on the top right corner of the screen under the smiley face, so we don't have to flip chart to remember the main trend direction. Something similar to Khaled's EA. Not necessary to have both the higher and lower TF arrows like he has. Just need the higher TF arrow only.

Thank you once again to TCO. I'm running the EA this week.

GL this week, and happy trading everyone.

Cheers
  • #348
  • Jun 16, 2013 4:34pm Jun 16, 2013 4:34pm
Quoting turtlefan
{quote} 1) It does not close pending orders, just actual executed orders. 2) It closes orders from ALL pairs, not just the pair on which you have the settings attached. 3) The percentage is based on balance, not equity. TurtleFan
And it close all orders regardless magic numbers. It is for all open orders not only for open order by this EA.

with regards,

Maudur
Enter Signature
  • #349
  • Jun 16, 2013 8:15pm Jun 16, 2013 8:15pm
Quoting maudur
{quote} And it close all orders regardless magic numbers. It is for all open orders not only for open order by this EA. with regards, Maudur
Exactly. The code would need to be amended to have it only close out orders for this EA.

TurtleFan
Prices are never too high to begin buying or too low to begin selling.
  • #350
  • Jun 16, 2013 8:24pm Jun 16, 2013 8:24pm
Quoting turtlefan
{quote} Exactly. The code would need to be amended to have it only close out orders for this EA. TurtleFan
If it does, can it have the option to close by magic number or close all, I actually like the basket strategy.
  • #351
  • Jun 17, 2013 3:08am Jun 17, 2013 3:08am
Quoting MKFXTrader
In the settings display located top left, even though I have TP and SL set to true using ATR levels, it still shows default hard 250 SL and 350 TP. Is this normal? Would also just like to reiterate my request for an arrow showing us the higher TF trend on the top right corner of the screen under the smiley face, so we don't have to flip chart to remember the main trend direction. Something similar to Khaled's EA. Not necessary to have both the higher and lower TF arrows like he has. Just need the higher TF arrow only. Thank you once again to TCO....
In the meantime you can use a MTF Macd Indi on H1 Chart.
- Green or Red - Lines below the blue line is Trend Short,
- Green or Red - Lines above the blue line is Trend Long
Cheers
Tebis
Attached Image (click to enlarge)
Click to Enlarge Name: MTF_MACD1.png Size: 8 KB
Attached File(s)
File Type: ex4 MACD nrp mtf.ex4   9 KB | 321 downloads
File Type: mq4 MACD nrp mtf.mq4   7 KB | 336 downloads
  • #352
  • Jun 17, 2013 5:30am Jun 17, 2013 5:30am
Quoting turtlefan
{quote} Exactly. The code would need to be amended to have it only close out orders for this EA. TurtleFan

I have made a change in the coming updated EA that will close all orders using magic number. Thanks!
  • #353
  • Jun 17, 2013 5:42am Jun 17, 2013 5:42am
Quoting TallCoolOne
{quote} I have made a change in the coming updated EA that will close all orders using magic number. Thanks!
I've only been exposed to EA's last few weeks as I've been a manual trader throughout my trading experience, so can someone tell me what magic number means? What is it's purpose? I like things the way they are now except for what I have requested with the next update.

Thank you.
  • #354
  • Jun 17, 2013 6:50am Jun 17, 2013 6:50am
Quoting MKFXTrader
{quote} I've only been exposed to EA's last few weeks as I've been a manual trader throughout my trading experience, so can someone tell me what magic number means? What is it's purpose? I like things the way they are now except for what I have requested with the next update. Thank you.

Hi MKFX, a magic number is just another identifier for a trade. Usually the EA will confirm the pair (symbol) and the magic number to make sure it is opening and managing the correct trades for that EA. If you have another EA operating on your account, you want to set the magic number differently for that EA, so that both EAs would be able manage their own trades for each symbol.

So if I wanted to use 2 EAs on an account and I open a EURUSD chart for EA1, I might make the magic number 00001 and then if I opened another EURUSD chart for EA2, I would make that magic number maybe 00002. So EA1 will manage all EURUSD trades with a magic number of 00001 and EA2 will manage all EURUSD trades with a magic number of 00002.

I usually don't operate more than 1 EA on one account, so I just sent my magic number to 00000 for each account.

I hope that helps.
  • #355
  • Jun 17, 2013 7:45am Jun 17, 2013 7:45am
Hi TCO,

I'm very happy with your EA and I explicitly appreciate your efforts for making it still better....!

I have a suggestion on the CloseTradesOnOppositeSignal option. If set to true it should require two consecutive closes above/below trend indicator in order to take actions. But I dont know whether this is difficult to code therefore forgive me if it does too much work for you.

The reason for that request was a loss of several hundred pips on JPY crosses on June10th as market just looks for one day above EMAtrend and then reverses again the next day below trend.

Many thanks and stay tuned...

Happy trading, jdva
I never lose - either I win or I learn...
  • #356
  • Jun 17, 2013 8:14am Jun 17, 2013 8:14am
Quoting TallCoolOne
{quote} I have made a change in the coming updated EA that will close all orders using magic number. Thanks!
Thank YOU for your continued work, TCO. Much appreciated.

TurtleFan
Prices are never too high to begin buying or too low to begin selling.
  • #357
  • Jun 17, 2013 9:11am Jun 17, 2013 9:11am
Quoting jdva
Hi TCO, I'm very happy with your EA and I explicitly appreciate your efforts for making it still better....! I have a suggestion on the CloseTradesOnOppositeSignal option. If set to true it should require two consecutive closes above/below trend indicator in order to take actions. But I dont know whether this is difficult to code therefore forgive me if it does too much work for you. The reason for that request was a loss of several hundred pips on JPY crosses on June10th as market just looks for one day above EMAtrend and then reverses again...
Hi jdva, thanks for the suggestion. One thing to remember when you add more complexity to the EA trying to avoid losses - a lot of times you miss out on trade opportunities that may have been more profitable. if we wait and require two consecutive closes above/below trend indicator in order to CloseTradesOnOppositeSignals we may never get the second signal and we may miss out on the huge trend move going the other way. With trading we are going to have losses. We just need to make sure our profit runs are greater than our loss runs. It is the nature of the beast. We will have drawdown, we will have some whipsaws. We need to take a look at the big picture. Are we just having a brief run of whipsaws before another big move. Or does the pair whipsaw all the time. Do we want to add complexity to the EA where the juice may not even be worth the squeeze. Do you see what I'm saying?
  • #358
  • Jun 17, 2013 9:25am Jun 17, 2013 9:25am
Quoting TallCoolOne
{quote} Hi jdva, thanks for the suggestion. One thing to remember when you add more complexity to the EA trying to avoid losses - a lot of times you miss out on trade opportunities that may have been more profitable. if we wait and require two consecutive closes above/below trend indicator in order to CloseTradesOnOppositeSignals we may never get the second signal and we may miss out on the huge trend move going the other way. With trading we are going to have losses. We just need to make sure our profit runs are greater than our loss runs. It is...
Yes, TCO, I do understand you and of course you should be right.....and make the EA managing trades on K.I.S.S.!
I never lose - either I win or I learn...
  • #359
  • Edited 10:54am Jun 17, 2013 10:38am | Edited 10:54am
I'm wondering why on one of my platform, the settings that is displayed on the top left of charts has TP/SL set at a fixed number when I have ATR turned on both. The open position reflect the ATR SL/TP parameters but the setting displayed is all the same 250 SL/350 TP. Doesn't do that on my other broker. Must it be the broker feed?

ADD: My other broker displays GBP/USD TP/SL not according to ATR settings. It's also fixed at 250/350. All the other pairs are ok with this broker except G/U. Strange. Any idea?

ADD: Just did a test on the broker that had only one pair(G/U) displayed wrong by restarting MT4, now all pairs show 250SL and 350TP within the display settings top left of chart. Open positions are fine and has SL/TP based on ATR settings.
  • #360
  • Edited 12:27pm Jun 17, 2013 11:25am | Edited 12:27pm
TCO,
Receiving Error 4109- Open sell order. Error 4109: trade is not allowed in the expert properties. Going off like a pinball machine.

Charts set up on tick mode with WPR confirm set to true.

Edit: Pinball alert sound went away when I changed tick mode to "candle close mode". Left WPR confirm set to true.

Sorry for all the questions but I want to try and eliminate any potential errors.
2 traders viewing now