Equity Sentry mod request | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Indicator (HP, Cycle) mod request 9 replies

Another Renko mod request 4 replies

Sentry EA required 0 replies

Pivot point mod request (Sunday Bars) 0 replies

Script mod request 0 replies

Attachments: Equity Sentry mod request
Exit Attachments

Equity Sentry mod request

  • #1
  • First Post: Edited Apr 24, 2013 10:42am Apr 23, 2013 9:16am | Edited Apr 24, 2013 10:42am
I have been testing with Equitry Sentry, but found a flaw\bug. I'm trying to use the equityprofitmoney to close a basket of trades at a net profit, but instead of the EA looking at the increase in equity from the last time it closed trades, it seems to just be looking at the unrealized profit\loss, which is always negative, despite my equity rising. Can someone look at the coding on this? The cumulative profit function doesn't apply to my strat because it only looks at closed positions. Or does somebody have a trade management EA that will close all trades when equity has increased the desired amount from the last time all the trades were closed by it, and then start over?

I AM NOT ASKING FOR YOU TO EDIT OR MODIFY THE ATTACHED EA...ONLY FOR IDEAS, OR OTHER EA's

thanks!

Attached File(s)
File Type: zip equity-sentry.zip   202 KB | 2,636 downloads


EDIT: I think my request is best described in this thread: http://www.forexfactory.com/showthread.php?t=197350
again, the equity sentry ea doesn't need mod, it's copyrighted...please, just for someone to tell me which EA in this other thread works best, I am not having any luck with the trendcatcher version, it still lets the equity just go on and on, without closing the trades.
Too close for pips, switching to points.
  • #2
  • Apr 23, 2013 12:11pm Apr 23, 2013 12:11pm
...more detail on what's happening...

the EA claims the equityprofitmoney function will close all trades when the equity level has increased by the entered amount. Instead it's closing when the unrealized difference between equity and balance level reaches the set amount. This doesn't help me, because I'm having trades hitting TP, increasing my balance, but other trades going negative, keeping the unrealized part negative, even though the equity, or net account balance should all trades be closed is well over my desired limit to close all trades.
Too close for pips, switching to points.
  • #3
  • Apr 23, 2013 3:29pm Apr 23, 2013 3:29pm
this thread deals with exactly what I'm looking for...I'll try the mods attached on it.

http://www.forexfactory.com/showthread.php?t=197350
Too close for pips, switching to points.
  • #4
  • Apr 24, 2013 8:08am Apr 24, 2013 8:08am
I tried the EA mod in the afore mentioned thread by trendcatcher, but it still doesn't do what I want, I'll try hayseed's, but I don't know what backtesting code he is referencing that I would have to remove...???
Too close for pips, switching to points.
  • #5
  • Apr 24, 2013 9:53am Apr 24, 2013 9:53am
Quoting Thepipster
I have been testing with Equitry Sentry, but found a flawbug. I'm trying to use the equityprofitmoney to close a basket of trades at a net profit, but instead of the EA looking at the increase in equity from the last time it closed trades, it seems to just be looking at the unrealized profitloss, which is always negative, despite my equity rising. Can someone look at the coding on this?
What you have attached in the zip file is the compiled code, if you wanted someone to modify it they would need the source code, the .mq4 file, do you have it ?
20 pips a day isn't too much to ask . . .
  • #6
  • Apr 24, 2013 10:12am Apr 24, 2013 10:12am
Quoting RaptorUK
{quote} What you have attached in the zip file is the compiled code, if you wanted someone to modify it they would need the source code, the .mq4 file, do you have it ?
I'm sorry, I don't.
It isn't what I need exactly, anyways. I need to be able to close all trades when the equity has increased by the desired amount, despite the fact that the unrealized profit will always show as negative.
Too close for pips, switching to points.
  • #7
  • Apr 24, 2013 10:30am Apr 24, 2013 10:30am
Equity Sentry is copyright protected, so its not possible to change it legally. They offer a modification service for a fee, and probably will fix as well. Posting on this forum is futile.
  • #8
  • Apr 24, 2013 10:40am Apr 24, 2013 10:40am
Quoting CodeMeister
Equity Sentry is copyright protected, so its not possible to change it legally. They offer a modification service for a fee, and probably will fix as well. Posting on this forum is futile.
THANKS for your incredible contribution...I will edit my request so as not to infringe on copyright....still looking for help though.
Too close for pips, switching to points.
  • #9
  • Apr 24, 2013 1:00pm Apr 24, 2013 1:00pm
Quoting Thepipster
{quote} I'm sorry, I don't. It isn't what I need exactly, anyways. I need to be able to close all trades when the equity has increased by the desired amount, despite the fact that the unrealized profit will always show as negative.
Perhaps I am misunderstanding what you need/want . . . but where will "the unrealized profit will always show as negative." ?
20 pips a day isn't too much to ask . . .
  • #10
  • Edited 2:25pm Apr 24, 2013 1:30pm | Edited 2:25pm
Quoting RaptorUK
{quote} Perhaps I am misunderstanding what you need/want . . . but where will "the unrealized profit will always show as negative." ?
the long answer is in this thread: http://www.forexfactory.com/showthread.php?t=197350

basically, I'm using a hedging strat, so as I cash in profits, I am also opening new trades which causes the unrealized profit to always be negative. so, for example, here's what i want:

Let's say I have $1000 in the account, and I have my EA opening all the trades, and I want the management EA to close all trades when my account equity is $5 more, so account equity would be $1005, which is what account balance would be when all trades are closed at that moment. But, the way my EA works is in an hour it will look like this: $1085 account balance, -$80 unrealized profitloss, $1005 account equity. Every equity EA I have used won't close the trades, because the floating profitloss is how they calculate this, not what the account balance was to start with. The thread attached seems to find the answer, but none of the posted EAs work correctly. I need all orders, both pending and opened to be closed, and the EA to then allow my other grid ea to start trading again, keeping track that the account balance will need another $5 of added equity in it to close all trades...make sense? The attached thread has a better explanation.


Another way of saying this is all the equity manager EAs look only at open trades. I need one that looks at both closed trades during the period since last closealltrades, as well as open trades and watches for net increase in equity account balance.
Too close for pips, switching to points.
  • #11
  • Apr 24, 2013 4:05pm Apr 24, 2013 4:05pm
Quoting Thepipster
{quote} the long answer is in this thread: http://www.forexfactory.com/showthread.php?t=197350 basically, I'm using a hedging strat, so as I cash in profits, I am also opening new trades which causes the unrealized profit to always be negative. so, for example, here's what i want: Let's say I have $1000 in the account, and I have my EA opening all the trades, and I want the management EA to close all trades when my account equity is $5 more, so account equity would be $1005, which is what account balance would be when all trades are closed...
I am a little confused, account equity takes into account open trades, you say that you want to "close all trades when my account equity is $5 more" but you seem to be suggesting you don't want to take into account the unrealised profits/losses. That is a contradiction . . . if you just want to work with Account Balance then that is simple to do . . .
20 pips a day isn't too much to ask . . .
  • #12
  • Edited 6:03am Apr 25, 2013 5:10am | Edited 6:03am
Quoting RaptorUK
{quote} I am a little confused, account equity takes into account open trades, you say that you want to "close all trades when my account equity is $5 more" but you seem to be suggesting you don't want to take into account the unrealised profits/losses. That is a contradiction . . . if you just want to work with Account Balance then that is simple to do . . .
It's because most equity EA's only look at open positions only, not taking into account positions closed during the time span between close all trades. It needs to look at starting account balance, let's say $1000 for example. Then it needs to keep track of all open positions, which is unrealized pl, AND all postions closed due to hitting TP. <- It's this last part that they all skip. So it has to record that "starting balance", then know when the account equity is $5 more than it was when it started, in other words $1005. Then when it closes all trades, it must start from the new account balance of $1005 keeping track again until the account equity is $1010. Over and over again. Does it make sense, now? It's about looking at both unrealized AND realized (cashed in) profit.
Too close for pips, switching to points.
  • #13
  • Apr 25, 2013 7:19am Apr 25, 2013 7:19am
Currently, the posted EA will either look at unrealized profitloss with equity part, or only realized profitloss with cumulative part, but not both, which is what I need.
Too close for pips, switching to points.
  • #14
  • Apr 25, 2013 9:22am Apr 25, 2013 9:22am
I have attached a trade explorer to illustrate why I need an EA to work the way I have described. If you click on the equitybalance trade graph, in the lower right corner, and then on the next page select the time axis to per trade, you'll see at the far right that the account equity has increased, even though there is a negative floating PL.
Too close for pips, switching to points.
  • #15
  • Apr 25, 2013 1:44pm Apr 25, 2013 1:44pm
Quoting Thepipster
{quote} It's because most equity EA's only look at open positions only, not taking into account positions closed during the time span between close all trades. It needs to look at starting account balance, let's say $1000 for example. Then it needs to keep track of all open positions, which is unrealized pl, AND all postions closed due to hitting TP. <- It's this last part that they all skip. So it has to record that "starting balance", then know when the account equity is $5 more than it was when it started, in other words $1005. Then when it...
I'm happy to try and help, I can code an EA up pretty quickly, but I am not going to do 2 things . . . I'm not going to spend 2 days trying to figure out what it is you want and I'm not going to code something that isn't what you want because I don't understand what you want or because you don't understand what you want.

So if we can both understand what you want I'm happy to code something for you, OK ? I know you haven't asked me to code anything for you, but, as I said, I'm happy to help if I can.

So let me explain how I understand things work;

with no open trades our account balance is equal to our account equity, lets call this our starting balance
when we open a trade our balance is still the same as our starting balance but our equity falls, the equity reflects the floating loss due to the spread
as time passes if our trade is profitable the equity becomes greater than the balance but the balance is still the same as the starting balance
if this trade is closed in profit the balance will now be larger than the starting balance and the equity will again be equal to the account balance

So it seems to me that what you want is this;

 

  1. at the start of this process the EA has to look at the account balance, while there are no open trades, and use this as it's starting point
  2. trades get placed and the EA will monitor the difference between the starting balance and the current equity, if this difference excceeds a pre-set threshold all trades, both pending and open trades, will be deleted/closed
  3. the new balance is noted and the process repeats.


is this a correct description of what you want ?

20 pips a day isn't too much to ask . . .
  • #16
  • Edited 3:23pm Apr 25, 2013 3:11pm | Edited 3:23pm
Quoting RaptorUK
{quote} I'm happy to try and help, I can code an EA up pretty quickly, but I am not going to do 2 things . . . I'm not going to spend 2 days trying to figure out what it is you want and I'm not going to code something that isn't what you want because I don't understand what you want or because you don't understand what you want. So if we can both understand what you want I'm happy to code something for you, OK ? I know you haven't asked me to code anything for you, but, as I said, I'm happy to help if I can. So let me explain how I understand things...
That is pretty close. Since I have not only multiple trades open, but new trades opening, and trades closing due to hitting their own TP, I need something more unique than just close when equity positive $X.

Here's what I want (at risk of telling everybody my strat):

I want to run my hedging grid EA. I want a trade managing EA to know I am starting an account balance of $1000. As trades accumulate, close at TP, and open new trades as price runs around, I want it to close all open AND pending orders when the balance of the account would show when all trades are closed as $1005. A $5 net profit. And then after checking to make sure all trades are closed, note the new balance of $1005 and the profit target of another $5, so when all trades are closed the account balance is $1010. And so on... To copy saint's reasoning, act on relative profit calculated from Initial equity and present equity. Say when it is dropped onto charts, it records the balance/equity...as soon as Set Amountprofit target is realised , it closes all trades and resets itself again to new account balance for next cycle.

Basically, $1000 noted, $1005 target, start my other grid EA (i am only asking for the trade manager, not a grid ea-got that already!), trade, trade, trade, close all when bottom line, or account equity is $1005. Start over with $1010 target...etc.

If you see the attached trade explorer, you can see that the last few trades show the account balance at $327, the unrealized or floating pl is -$113, and the equity is $214. Now, yesterday when I closed all trades, and started everything over manually, the account balance and equity started out at $155, at the bottom of the last climb on the graph. The EA needs to see that the equity has gone from $155 to $214. The only reason the equity has increased is a ton of trades that hit TP. The other trades are danglers in the negative. Hayseed in the saint thread i posted got the idea exactly, but he didn't post a working EA.

I would very greatfully appreciate you coding something up.
Too close for pips, switching to points.
  • #17
  • Apr 25, 2013 3:33pm Apr 25, 2013 3:33pm
Quoting Thepipster
I would very greatfully appreciate you coding something up.
OK, I'll have a play in the Morning, it's almost bed time for me now, one question before I go . . . your Hedging EA that places the trades, does it use a Magic Number ? does it use several Magic Numbers ? I need to know how many unique Magic Numbers it uses.
20 pips a day isn't too much to ask . . .
  • #18
  • Edited 7:02am Apr 26, 2013 5:19am | Edited 7:02am
Quoting RaptorUK
{quote} OK, I'll have a play in the Morning, it's almost bed time for me now, one question before I go . . . your Hedging EA that places the trades, does it use a Magic Number ? does it use several Magic Numbers ? I need to know how many unique Magic Numbers it uses.
It uses one 4 digit magic number. I don't care if you have the EA trade with only one magic number or all trades regardless of magic number, I'm only going to use the grid EA, and this trade management EA.

Thanks again for your help!

quick note: remember the balance on the trade explorer at the last time all trades were closed was $155. The equity is now $234, so while the unrealized\floating P\L shows -$102, it's really +$79 that we've gained. The $79 is what we want to track.
Too close for pips, switching to points.
  • #19
  • Apr 26, 2013 9:07am Apr 26, 2013 9:07am
Quoting Thepipster
quick note: remember the balance on the trade explorer at the last time all trades were closed was $155. The equity is now $234, so while the unrealizedfloating PL shows -$102, it's really +$79 that we've gained. The $79 is what we want to track.
OK, I've code th EA to use one Magic Number . . . or if you leave it set to 0 it will close all trades regardless of Magic Number.

I think I have coded what you have described . . .
20 pips a day isn't too much to ask . . .
  • #20
  • Apr 26, 2013 9:19am Apr 26, 2013 9:19am
Quoting RaptorUK
{quote} OK, I've code th EA to use one Magic Number . . . or if you leave it set to 0 it will close all trades regardless of Magic Number. I think I have coded what you have described . . .
Ok, great! Thanks so much for your help, I'll put it to the test starting next week.
Too close for pips, switching to points.
0 traders viewing now