Partial OrderClose() | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Partial close StopLoss (Neither trailing nor partial TP) 9 replies

OrderClose Error 145 during strategy tester 8 replies

OrderClose() issue on EA 4 replies

OrderClose wont work 2 replies

OrderClose error 4107 1 reply

Partial OrderClose()

  • #1
  • First Post: Apr 21, 2013 3:11pm Apr 21, 2013 3:11pm
Hi All,

In MQL4 language, if we use OrderClose() function to close just a part of the lots of the entire position, the EA will close the actual position ticket(number), and create another position ticket(number) with the remaining lots.

Inserted Code
OrderClose(OrderTicket(),(OrderLots()/2),Bid,3,Pink);
I need to catch the new ticket number that is generated!

If there aren't any other positions created, between the creation of the order and the partial close, I can use
Inserted Code
OrderTicket()+1
to catch the following position ticket number.

But in case, there are an aleatory number of open positions / partial closes, between the creation of a position and the partial close, I cannot catch the ticket number.

Does anyone has ever come across this situation?

Can someone help me?

Thanks in advance.
  • #2
  • Apr 21, 2013 3:37pm Apr 21, 2013 3:37pm
You cannot use OrderTicket()+1. Don't waste any more time trying.

It is difficult to explain an absolutely fail safe method guaranteed to work. So I will give you a simpler method that might work for your needs. Use OrderSelect() to retrieve all active orders. Then look for an order for the currency pair you are trading. That should be the partial order. Of course if you have multiple orders for a currency pair that won't work.
  • #3
  • Apr 21, 2013 4:25pm Apr 21, 2013 4:25pm
CodeMeister, thank you for trying to help.

I found a solution.

I use a Global variable, that will count every time an order is created and every time a order is partial closed! In that way, after an order is partial closed I can access to the global variable and get the ticket number.

It's working
  • #4
  • Apr 21, 2013 4:40pm Apr 21, 2013 4:40pm
Look in the Comments field of the closed piece. I'm not sure if this is true on all brokers, check it out, but some put the "to" split orderid in the comments, and the "from" orderid in the new tickets comment.
  • #5
  • Apr 21, 2013 4:52pm Apr 21, 2013 4:52pm
Quoting nunonuk
CodeMeister, thank you for trying to help. I found a solution. I use a Global variable, that will count every time an order is created and every time a order is partial closed! In that way, after an order is partial closed I can access to the global variable and get the ticket number. It's working
It seems that my solution only works in Strategy_Tester only!

Next solution I'll implement, suggested by another fellow from another forum is to insert all ticket in an array before the partial closing and then find the new ticket comparing to the array created!
  • #6
  • Apr 21, 2013 8:11pm Apr 21, 2013 8:11pm
I am going to share the function I have developed for this purpose!


First I thought about finding the ticket number from the "OrderOpenTime()", when I realized that when "OrderClose()" is executed, a new ticket number is assigned, but the "OrderOpenTime()" is equal to the first order before the partial close!


Then I thought about the "OrderOpenPrice()", this one alone, would work, but who knows..., so combining ""OrderOpenTime()" and "OrderOpenPrice()" gives me for sure the ticket I am looking for.


Here is the function:
Inserted Code
int getLastTicketNumber(double openPrice)
{
   datetime temp = 0;
   int lastTicketNumber;
   
   for(i=1; i<=OrdersTotal(); i++)
      {
         if ( OrderSelect(i-1,SELECT_BY_POS,MODE_TRADES) == true )
         {
            if ( OrderOpenTime() > temp && openPrice == OrderOpenPrice() ) 
            {
               temp = OrderOpenTime();
               lastTicketNumber = OrderTicket();
            }
         }
      }
   return(lastTicketNumber);
}
  • #7
  • Apr 22, 2013 2:36am Apr 22, 2013 2:36am
Quoting nunonuk
I am going to share the function I have developed for this purpose! First I thought about finding the ticket number from the "OrderOpenTime()", when I realized that when "OrderClose()" is executed, a new ticket number is assigned, but the "OrderOpenTime()" is equal to the first order before the partial close! Then I thought about the "OrderOpenPrice()", this one alone, would work, but who knows..., so combining ""OrderOpenTime()" and "OrderOpenPrice()" gives me for sure the ticket I am looking for. Here is the function: int getLastTicketNumber(double...
In your code, you donīt check the OrderOpenTime(), you only check the OrderOpenPrice().

And you are not searching for the "last ticket number" but the new ticketnumber.

The code for finding the new ticketnumber by checking OrderOpenPrice and OrderOpenTime is this:
Inserted Code
int getNewTicketNumber(double openPrice, datetime openTime) 
{    
    for(i=1; i<=OrdersTotal(); i++)       
    {          
        if ( OrderSelect(i-1,SELECT_BY_POS,MODE_TRADES) == true )          
        {             
           if ( OrderOpenTime() == openTime && OrderOpenPrice()== openPrice )              
                return(OrderTicket());                                       
        }       
     }    
      return(-1);  // if no ticket has been found 
}
But what if for some reason there are 2 or more orders which have been opened at same time and
same price ?
In that case your code would fail.

Since Mt4 automatically inserts a comment for a partially closed order, a safe function would be this one:
Inserted Code
int searchNewTicket(int oldTicket)
{
   for(int i=OrdersTotal()-1; i>=0; i--)
      if(OrderSelect(i,SELECT_BY_POS) && 

         StrToInteger(StringSubstr(OrderComment(),StringFind(OrderComment(),"#")+1)) == oldTicket )
         return (OrderTicket());
   return (-1);
}
  • #8
  • Apr 22, 2013 3:49am Apr 22, 2013 3:49am
Quoting fxtr51
{quote} In your code, you donīt check the OrderOpenTime(), you only check the OrderOpenPrice(). And you are not searching for the "last ticket number" but the new ticketnumber. The code for finding the new ticketnumber by checking OrderOpenPrice and OrderOpenTime is this: int getNewTicketNumber(double openPrice, datetime openTime) { for(i=1; i<=OrdersTotal(); i++) { if ( OrderSelect(i-1,SELECT_BY_POS,MODE_TRADES) == true ) { if ( OrderOpenTime() == openTime && OrderOpenPrice()== openPrice ) return(OrderTicket()); } } return(-1); // if no...
Maybe I didn't explain well what i pretend with my function, I am finding most recent order "OrderOpenTime()" with the specific price "OrderOpenPrice()"!
And it works very good in my code.

Anyway, I find your solution better, less resources consuming and more reliable.

I don't think that the one to check the comment is really needed because, I am 100% sure that in my code, there will never be two positions at the same time, with the same price

Anyway I'll keep it in my library, just in case some of this days I need it!

Thanks for helping fxtr51.
  • #9
  • Apr 22, 2013 4:29am Apr 22, 2013 4:29am
Quoting nunonuk
{quote} I don't think that the one to check the comment is really needed because, I am 100% sure that in my code, there will never be two positions at the same time, with the same price
Yes, the one which searches for the "#" in the comment is the universal solution.

Yours works for you because you donīt have 2 or more orders opened at same price and time on your platform.

Anyways, we can say that Mt4 handles partial closure with 4 characteristics:

1. Full order is closed and new order is opened with remaining volume (lotsize).
2. New order shows same OrderOpenPrice() as closed order, although the real open price is different in most
cases.
3. New order shows same OrderOpenTime() as closed order, although the real open time is different.
4. New order has comment as "from #oldTicketnumber"

Knowing this, we can find the new ticketnumber.
  • #10
  • Apr 24, 2013 7:06am Apr 24, 2013 7:06am
Why not use the magic number?

This has been used extensively by EAs to enable them to manage trades made by that EA.

However the magic number can be assigned at initial trade open and will not change -even though the ticket number does - throughout the entire life of the trade.

Its easy then to manage a the list of your magic numbers (in an array) and use Orderselect specifying the magic number.

If your running multiple EAs then use assign a range of numbers to each EA
E.G.

EA1 = magic numbers 1 to 2999
EA2 = magic numbers 3000 to 5999

etc.

If this wont work well then you can always iterrate all the open trades ... compile a list of active magic numbers and then add 1 to the highest value.

Since you're EA(s) are managing a list of the magic numbers that they have opened then it will be easy to ensure it doesnt interfere with any other EA.
  • #11
  • Apr 24, 2013 11:35am Apr 24, 2013 11:35am
Are you sure that the Magic Number is copied to the new order? I seem to recall that it isn't. Besides, manual orders don't have Msgic Numbers, so that your approach has limitations.
  • #12
  • Last Post: Apr 24, 2013 2:14pm Apr 24, 2013 2:14pm
Quoting CodeMeister
Are you sure that the Magic Number is copied to the new order? I seem to recall that it isn't. Besides, manual orders don't have Msgic Numbers, so that your approach has limitations.
Yes Magic numbers remain with the trade throughout its whole life. Even where those orders started life as a stop or limit.

If an order doesnt have a magic then it wont matter. The EA should only be manging the trades that have magic numbers that match the list held by the EA. (I.E. those numbers the EA provided when it opened its orders).

The only issues are :

1) If the EA is closed and reopened (or computer reboot). This can be taken care of by writing the EAs magic numbers list to a disk file after each trade.


2) (IF using this strategy with multiple EAs on same account) : "you can always iterrate all the open trades ... compile a list of active magic numbers and then add 1 to the highest value."

In this case there is a very slim possibilty that 2 EAs trying to open orders at the same time will calculate the same next available magic. In this case code can be added immediately after succesfull opening of an order to check if this has occurred and remedy the situation (change the magic number) whilst the ticket number is still unaltered. Or you could simply use a global var (used by all EAs) to store the next magic value that should be used.
0 traders viewing now