Drawing an indicator line, fixed length and not growing further | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

indicator that shows length of the previous candle's body 35 replies

Multiple horizontal line drawing indicator 3 replies

Prorealtime: drawing a line from indicator 0 replies

Drawing Objects vs Drawing lines 1 reply

Draw a certain-length line 3 replies

Drawing an indicator line, fixed length and not growing further

  • #1
  • First Post: Mar 24, 2013 6:06pm Mar 24, 2013 6:06pm
Hi, I have difficulties with coding a fixed length indicator line.
After initialization it is, as expected, exactly 25 bars long.
However, with every new bar it grows further to the left side.
I don't want that, but a line that updates and still stays all the time exactly 25 bars long.
What am i missing?

Regards, Sven
  • #2
  • Mar 24, 2013 6:51pm Mar 24, 2013 6:51pm
Quoting svengralla
Hi, I have difficulties with coding
hey sven..... kinda need to see the code...... without seeing it, we would just be shooting in the dark..... below is a quick example of a horizontal line.....h

//----


Inserted Code
 
extern double   price      =  0;
extern int      length     = 24;
       int      bars;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- 
   if(price == 0.0) price = Bid;
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
//----
 
if(bars != Bars)
  {
  ObjectDelete("line");
  bars = Bars;
  }
 
ObjectCreate("line",OBJ_TREND, 0, Time[length],price,Time[0],price);
ObjectSet("line",OBJPROP_COLOR,Blue);
ObjectSet("line",OBJPROP_RAY, false);
ObjectSet("line",OBJPROP_WIDTH,2);      
 
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
to trade and code, keep both simple... no call to impress....h
  • #3
  • Edited 2:14am Mar 25, 2013 2:02am | Edited 2:14am
Hi hayseed, thanks a lot for your answer.
Below is valid example code, illustrating the problem. As you will see, the RSI line initializes 25 bars long but then grows further with every new bar on the chart. I want it to update and stay exactly 25 bars long (dump the oldest data). Is there a straightforward solution to this, besides object creation/deletion?

Inserted Code
//---------------------------------------------------------------
#property indicator_separate_window 
#property indicator_buffers 1       
#property indicator_color1 White     

double Line_0[];
int History=25;                     

//---------------------------------------------------------------
int init() {                              
//---------------------------------------------------------------
  SetIndexBuffer(0,Line_0);              
  SetIndexStyle(0, DRAW_LINE, EMPTY, 1); 

  }

//--------------------------------------------------------------- 
int start() {                        
//---------------------------------------------------------------                              
  int i, Counted_bars;
//--------------------------------------------------------------- 
  Counted_bars=IndicatorCounted(); 
  i=Bars-Counted_bars-1;           
  
  if (i>History-1)                 
      i=History-1;                  

   while(i>=0)                      
     {
    
      Line_0[i]= iRSI(NULL,0,14,PRICE_CLOSE,i);
      
      i--;                          
     }

  return;                          

  }
  • #4
  • Mar 25, 2013 3:35am Mar 25, 2013 3:35am
i need a indicator.

so show on chart

1.6000,1.6010,1.6020,1.6030,1.6040.......

who can help me?

thanks
  • #5
  • Last Post: Mar 25, 2013 6:59am Mar 25, 2013 6:59am
Quoting hayseed
hey sven.....
Solved it by myself by modification of the drawing routine.
Thank you, heyseed.

Inserted Code
int start() {                        
//---------------------------------------------------------------                              
  int i;
//---------------------------------------------------------------          
    Line_0[History]=EMPTY_VALUE;

    i=History-1;                  
 
    while(i>=0)                      
     {
    
      Line_0[i]= iRSI(NULL,0,14,PRICE_CLOSE,i);
      
      i--;                          
     }

  return;                          

  }
0 traders viewing now