AccountProfit() Issues | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Question about AccountProfit() 2 replies

MT4 - Build 198 connection issues??? 8 replies

MT4 email issues 4 replies

Oanda issues... again 12 replies

Structural Issues? 12 replies

AccountProfit() Issues

  • #1
  • First Post: Feb 23, 2013 9:12pm Feb 23, 2013 9:12pm
I have been attempting to write an easy function that closes a basket of trades at a variable percentage of gain of the overall account balance.

My "CloseAll()" function works perfectly, but integrating it with the criteria that triggers that function is where my problem lies.

Here's what I have:

//--------------------------
extern double BalanceMultiple = 0.02;
//--------------------------
void StopPercent()
{
if (AccountProfit() >= (AccountBalance()*BalanceMultiple))
{
CloseAll();
}
Comment("Balance: ",AccountBalance(),", Account Equity: ",AccountEquity(),", Account Profit: ",AccountProfit());
return (0);
}
//-------------------------

The close all, and comments work perfectly. But I notice the "AccountProfit" number never changes in the comment section when running the tester.
Since that never changes once it shows the negative from the spread, I'm assuming that the same is happening with the use if AccountProfit in my if statement, so no value will ever be compared top the account balance.

I am obviously missing something simple here, but I've searched endlessly for examples, and have no clue why it's not working as I wrote it.

Any ideas from the smart guys? 'cuz I apparently be a dummy
No way I'll wreck this... It's a beer truck!
  • #2
  • Feb 23, 2013 9:26pm Feb 23, 2013 9:26pm
hey bruce..... all the smart guys are busy countin their accountprofit()s....

is there a reason you have the comment line inside the function...... usually comments are placed the start section itself..... doing so will alleviate most problems that might come up by calling the StopPercent() function.....h
to trade and code, keep both simple... no call to impress....h
  • #3
  • Feb 23, 2013 9:36pm Feb 23, 2013 9:36pm
Congrats to the smart guys for counting profits I just look at my ever growing balance, and let it count for me

I didn't have them at all when I originally wrote the function up, but added them when the function didn't work properly to trouble shoot a bit. That's when I noticed the value of AccountProfit not changing on the tester.

It didn't work without the comments there either, so I left them.

And much thanks for taking a look at this. It's deeply appreciated.
No way I'll wreck this... It's a beer truck!
  • #4
  • Feb 23, 2013 9:47pm Feb 23, 2013 9:47pm
Quoting Bruce Flea
Congrats to the smart guys for counting profits I just look at my ever growing balance, and let it count for me

I didn't have them at all when I originally wrote the function up, but added them when the function didn't work properly to trouble shoot a bit. That's when I noticed the value of AccountProfit not changing on the tester.

It didn't work without the comments there either, so I left them.

And much thanks for taking a look at this. It's deeply appreciated.
strategy tester does not change your account details.
Congratulations ScalaFX for coming out of the closet!
  • #5
  • Feb 23, 2013 9:54pm Feb 23, 2013 9:54pm
Now THAT is a helpful revelation... LOL

Thanks a ton!

Much appreciated.
No way I'll wreck this... It's a beer truck!
  • #6
  • Feb 23, 2013 9:58pm Feb 23, 2013 9:58pm
Quoting nubcake
strategy tester does not change your account details.
in the fictional world of the strategy tester, some account details will subject change...... accountprofit() is one.....h

//----

well, let me edit this to say obviously i'm missing the question.....

But I notice the "AccountProfit" number never changes in the comment section when running the tester.

when running a ea in the strategy tester the accountprofit() clearly is subject to change.... if a ea is being tested , as trades open and close the accountprofit() value should change to refect.....
to trade and code, keep both simple... no call to impress....h
  • #7
  • Feb 23, 2013 10:16pm Feb 23, 2013 10:16pm
Quoting hayseed
in the fictional world of the strategy tester, some account details will subject change...... accountprofit() is one.....h

//----

well, let me edit this to say obviously i'm missing the question.....

But I notice the "AccountProfit" number never changes in the comment section when running the tester.

when running a ea in the strategy tester the accountprofit() clearly is subject to change.... if a ea is being tested , as trades open and close the accountprofit() value should change to refect.....
the tester is a whore, but you are probably right. i'm terribly sleep deprived right now, so grain of salt. i cbf testing anything so i'm going to take a guess that maybe profit isn't updated, but things like balance and equity are. really, it's just a case of printing them all out and seeing what does and does not change. and if none of them change the code is what is busted. but i wouldn't put it past mt4 to not emulate accountprofit in backtests.
Congratulations ScalaFX for coming out of the closet!
  • #8
  • Feb 23, 2013 10:18pm Feb 23, 2013 10:18pm
Quoting hayseed
when running a ea in the strategy tester the accountprofit() clearly is subject to change.... if a ea is being tested , as trades open and close the accountprofit() value should change to refect.....

That's what one would think.

And was the reason for putting the comments in. When I didn't see a tick by tick reflection of profit fluctuating, I figured something was wrong with either my code, or that possibly account information isn't subjected to the tester. But it DOES show current info. At least when the EA initially opens the trade. It reflects the loss of spread in the AccountProfit() comment. But then it never moves from that point, nor does it close trades based on the 2% balance increase I am asking it to close at.

And I purposely found a date that most definitely grows by 2%.

So, I guess I'll wait until tomorrow night, and see what happens on a demo when the market is open.

Thanks again!
No way I'll wreck this... It's a beer truck!
  • #9
  • Feb 23, 2013 10:26pm Feb 23, 2013 10:26pm
Quoting Bruce Flea
That's what one would think.

And was the reason for putting the comments in. When I didn't see a tick by tick reflection of profit fluctuating, I figured something was wrong with either my code, or that possibly account information isn't subjected to the tester. But it DOES show current info. At least when the EA initially opens the trade. It reflects the loss of spread in the AccountProfit() comment. But then it never moves from that point, nor does it close trades based on the 2% balance increase I am asking it to close at.

And I purposely found...
you aren't doing something stupid like running this in an infinite loop and not refreshing the rates, are you?
Congratulations ScalaFX for coming out of the closet!
  • #10
  • Feb 23, 2013 10:31pm Feb 23, 2013 10:31pm
Quoting nubcake
you aren't doing something stupid like running this in an infinite loop and not refreshing the rates, are you?
Nossir.

But that was something that crossed my mind early on. It isn't the case though.

Thanks!
No way I'll wreck this... It's a beer truck!
  • #11
  • Feb 23, 2013 10:33pm Feb 23, 2013 10:33pm
Quoting nubcake
but you are probably right. i'm terribly sleep deprived right now,
...... after reading your post kinda thought you might be, but figured possibly i did not understand the question.....

there is no doubt in my mind, accountprofit(), accountbalance(), accountequity() and such should reflect changing values in the tester and Comments()......

if the Comments() are not updating then their in the wrong place or something is blocking them.... with so little code to go on, it's hard to say for sure......h

//----

Inserted Code
 
 
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
Comment("Balance: ",AccountBalance(),", Account Equity: ",AccountEquity(),", Account Profit: ",AccountProfit());  /// here
to trade and code, keep both simple... no call to impress....h
  • #12
  • Feb 23, 2013 10:45pm Feb 23, 2013 10:45pm
They update there.

Hmmmmm....

Now, to find why it's not closing trades based on the same info.
No way I'll wreck this... It's a beer truck!
  • #13
  • Feb 23, 2013 10:55pm Feb 23, 2013 10:55pm
how are you calling the StopPercent() function....h

//---
//---

Inserted Code
 
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   Comment("Balance: ",AccountBalance(),", Account Equity: ",AccountEquity(),", Account Profit: ",AccountProfit(), "  Target:  ",DoubleToStr((AccountBalance()*0.02),2) );
 
 
   StopPercent();
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//---
//---
void StopPercent()
{
if (AccountProfit() >= (AccountBalance()*0.02))
{
CloseAll(); 
}
return (0);
}
//---
//---
 
  void CloseAll() 
   {
  int Orders = OrdersTotal();
  for(int i=Orders-1 ; i>=0 ; i--)
    {
      OrderSelect(i, SELECT_BY_POS);
      if (OrderSymbol() == Symbol())
        {
          if (OrderType() == OP_BUY)
            {
              OrderClose(OrderTicket(),OrderLots(),Bid, 3, CLR_NONE);
            }
          if (OrderType() == OP_SELL)
            {
              OrderClose(OrderTicket(),OrderLots(),Ask, 3, CLR_NONE);
            }
 
        }
    }
   }
 
 
//---
to trade and code, keep both simple... no call to impress....h
  • #14
  • Feb 23, 2013 11:01pm Feb 23, 2013 11:01pm
Quoting Bruce Flea
They update there.

Hmmmmm....

Now, to find why it's not closing trades based on the same info.
stop being a bitch and just pony-up the code already... i promise i'll only on-sell it for a small fee.
Congratulations ScalaFX for coming out of the closet!
  • #15
  • Feb 23, 2013 11:01pm Feb 23, 2013 11:01pm
Much like your first example.

And my CloseAll() is almost verbatim your code




Inserted Code
//+------------------------------------------------------------------+  
//| expert start function                                            | 
//+------------------------------------------------------------------+  
int start()   
{
 //----   
 Comment("Balance: ",AccountBalance(),",  Account Equity: ",AccountEquity(),", Account Profit: ",AccountProfit(), "   Target:  ",DoubleToStr((AccountBalance()*0.02),2) ); 
     {
      All My Trade code here
     }

 StopPercent();  

 //----   

 return(0);   
}
No way I'll wreck this... It's a beer truck!
  • #16
  • Feb 23, 2013 11:18pm Feb 23, 2013 11:18pm
put the StopPercent() function first..... before the trade send code..... see if it closes 1 and only 1 set of orders......

you do realize, your makin us walk up Pikes Peak on a rainy night with our eyes closed and our hands and feet tied while we're sleep deprived....h
to trade and code, keep both simple... no call to impress....h
  • #17
  • Feb 23, 2013 11:33pm Feb 23, 2013 11:33pm
I hereby nominate you for Sainthood.

Works like a charm.

Wasn't my code, it was my misunderstanding of placement of such.

Much obliged sir! Here's some cyberbeer!

I spared NO expense

http://chewthedirt.com/wp-content/up...970c-800wi.jpg
No way I'll wreck this... It's a beer truck!
  • #18
  • Last Post: Feb 24, 2013 11:32am Feb 24, 2013 11:32am
even after 12hrs sleep i still don't get it... maybe i need another 12.
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now