Break even indicator for multiple positions | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Break Even Line for Multiple Order (Indicator) 37 replies

EA "Close all positions at profit target" closed all positions at loss ? 9 replies

Open multiple positions at once script.. 0 replies

Looking for ea to open multiple positions 0 replies

Closing multiple positions at the same time 5 replies

Attachments: Break even indicator for multiple positions
Exit Attachments

Break even indicator for multiple positions

  • #1
  • First Post: Edited 11:42pm Jan 30, 2013 9:35pm | Edited 11:42pm
Dear Member of FF. I just want to ask is there any indicator that show breakeven price for multiple position and multiple lot?
For example :
- Buy eurusd 2 lot at 1.3300 , buy eurusd 3.5 lot at 1.3350, buy eurusd 2.2 lot at 1.3344. I just want to know what is the price of breakeven point from those position. thanks for your kind reply.
  • #2
  • Jan 30, 2013 11:10pm Jan 30, 2013 11:10pm
Good morning,
Can any one assist me with this indicator #4x 2010 ABHA
  • #3
  • Jan 31, 2013 6:46am Jan 31, 2013 6:46am
Maybe this is what your looking for
Attached File(s)
File Type: mq4 NB i-Breakeven.mq4   6 KB | 6,149 downloads
You see, but you do not observe. The distinction is clear
  • #4
  • Jan 31, 2013 7:51pm Jan 31, 2013 7:51pm
Ronald,

have a look at attached - just something I extracted from somebody's EA a while ago - it shows the combined PL of all open positions plus the average entry price, which is more or less equal to your BE price (it does not take into account spread and/or swap)

Depending on your chart layout, you may have to play with the colours to suit your taste

Cheers Mop
Attached File(s)
File Type: mq4 AverageOrder.mq4   8 KB | 4,768 downloads
  • #5
  • Jan 31, 2013 8:19pm Jan 31, 2013 8:19pm
Quoting mobthehop
Ronald,

have a look at attached - just something I extracted from somebody's EA a while ago - it shows the combined PL of all open positions plus the average entry price, which is more or less equal to your BE price (it does not take into account spread and/or swap)

Depending on your chart layout, you may have to play with the colours to suit your taste

Cheers Mop
Thanks for your reply. I will try it. thanks very much
  • #6
  • Feb 1, 2013 2:27am Feb 1, 2013 2:27am
Quoting budii
Maybe this is what your looking for
Thanks for sharing
  • #7
  • Feb 4, 2013 12:15pm Feb 4, 2013 12:15pm
Quoting budii
Maybe this is what your looking for
Thank you. It is really helpful. Am grateful
  • #8
  • Feb 15, 2013 10:15am Feb 15, 2013 10:15am
Quoting budii
Maybe this is what your looking for
May I you question :
1. Is this indicator could be use on every pair, how about using it in commodity chart and stock index ?
2. Is that possible to change the font size ?

Thanks for your very kindly reply.
  • #9
  • Feb 19, 2013 9:28am Feb 19, 2013 9:28am
Anyone could help me to modify this indi?
  • #10
  • Edited 10:39pm Feb 19, 2013 1:17pm | Edited 10:39pm
Quoting ronald_fsm
Anyone could help me to modify this indi?
I tried to make the horizontal and vertical positioning at least a little bit dynamic for given values of FontSize and dy.

The input named "dy" was a little ambiguous to me when I first downloaded the indicator. No matter what its setting, the top label line wouldn't move, and as the value was increased, the symbol lines and the total lines stretched farther and farther apart. I changed to functionality of "dy" to actually mean "Y-Offset", but it still has the same name in the inputs box.

I was able to remove quite a bit of code without losing any functionality by replacing all the redundant object creation routines with a simple one-liner.

And lastly, it no longer clears the comment on the chart. I'm not sure why it was doing this to begin with; maybe the original programmer was using it for debug?

Edit: Also changed the +/- symbol to be on the outside of the dollar sign. It just makes more sense to me this way.

Edit2: Updated the indicator to automatically draw the Breakeven line on the chart. It wiggles around according to number of trades open, spread, swap, etc. You can turn it off by setting DrawBreakeven to false. You can also turn the chart on or off by modifying DrawSymbolChart.

Edit3: So... Turns out I was checking the wrong value for total equity. Small bug squashed now. The attached MQL is updated.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: nb-i-breakeven-mod.JPG Size: 94 KB
Click to Enlarge Name: nb-i-breakeven-mod2.JPG Size: 116 KB
Attached File(s)
File Type: mq4 NB i-Breakeven.mq4   4 KB | 3,692 downloads
  • #11
  • Feb 19, 2013 10:24pm Feb 19, 2013 10:24pm
Quoting tener
I tried to make the horizontal and vertical positioning at least a little bit dynamic for given values of FontSize and dy.

The input named "dy" was a little ambiguous to me when I first downloaded the indicator. No matter what its setting, the top label line wouldn't move, and as the value was increased, the symbol lines and the total lines stretched farther and farther apart. I changed to functionality of "dy" to actually mean "Y-Offset", but it still has the same name in the inputs box.

I was able to remove quite a bit of code without...
Thank you very much for your help modify this. One more question , is this indicator can be use for trading commodity, index,etc ? thanks alot. Hope have a great trading.
  • #12
  • Feb 19, 2013 10:31pm Feb 19, 2013 10:31pm
Quoting ronald_fsm
Thank you very much for your help modify this. One more question , is this indicator can be use for trading commodity, index,etc ? thanks alot. Hope have a great trading.
If you can open those charts in MT4, I don't see why the indicator wouldn't work. But I can't know for sure as my broker doesn't offer anything except currency pairs.
  • #13
  • Feb 20, 2013 9:24pm Feb 20, 2013 9:24pm
Quoting tener
If you can open those charts in MT4, I don't see why the indicator wouldn't work. But I can't know for sure as my broker doesn't offer anything except currency pairs.
I already tried for trading gold and silver, but the breakeven indicator show wrong calculation about break even price. could you please tell me why this happen? thanks for your assistance
  • #14
  • Feb 21, 2013 2:00am Feb 21, 2013 2:00am
i just had a look at the code... it's a bit strange because i use the nb prefix on names etc, but this surel isn't my code... anyways.

i just woke-up so keep this in mind :

1. from what i can see there is redundant code at the start where you loop through the Sym array. why do that? you had just resized all arrays to zero, so this loop and code never executes.

2. the way this calculates things is just wrong. you can't use the order profit values and mode_tickvalue to find a distance you need to step up or down a chart from the current bid. the problem ronald is most-likely having is that his tickvalue is getting all messed-up due to his account currency NOT being whatever the quote currency of the symbol is, so his tickvalue is being converted twice and coming to a different amount each time the price moves up or down, and this will skew the whole calculation to a wrong value.

3. you also shouldn't be using the bid value anyway when it's a sell order, but there is no distinction between the order types.

this indicator tries to be clever and list-off for all open orders (this chart or not) and then also mark visually them if the values are for this chart, but also include swap etc. it's too clever for it's own good. it needs to be re-done completely. orderprofit etc is the wrong way to go about this. it needs to be calculated correctly, and that means using lot sizes and open prices to calculate a true buy average price or sell average price.

that's my take on it at least.
Congratulations ScalaFX for coming out of the closet!
  • #15
  • Feb 21, 2013 2:36am Feb 21, 2013 2:36am
Quoting nubcake
i just had a look at the code... it's a bit strange because i use the nb prefix on names etc, but this surel isn't my code... anyways.

i just woke-up so keep this in mind :

1. from what i can see there is redundant code at the start where you loop through the Sym array. why do that? you had just resized all arrays to zero, so this loop and code never executes.

2. the way this calculates things is just wrong. you can't use the order profit values and mode_tickvalue to find a distance you need to step up or down a chart from the current bid....
Thanks for your explanation. I don't really understand about coding. . It is ok when use in forex pairs but it don't work when using this indi on commodity chart. Do you use indicator like this? thanks for sharing .
  • #16
  • Feb 21, 2013 3:05am Feb 21, 2013 3:05am
Quoting ronald_fsm
Thanks for your explanation. I don't really understand about coding. . It is ok when use in forex pairs but it don't work when using this indi on commodity chart. Do you use indicator like this? thanks for sharing .
in that case i'm guessing you have a usd account and are trading xxxUSD pairs. i believe it will break on you if you trade some pair that isn't ending in whatever your account currency is based in. hey, maybe i'm totally wrong.

but, a quick google of "gold mode_tickvalue" returns this http://forum.mql4.com/43736 which suggests that marketinfo on gold and silver is all kinds of broken.

my previous post still stands. the indi is just not done properly afaic. i'm not about to do it for you, but someone else can re-do it if they agree with my suspicions.
Congratulations ScalaFX for coming out of the closet!
  • #17
  • Feb 21, 2013 2:03pm Feb 21, 2013 2:03pm
Quoting nubcake
i just had a look at the code... it's a bit strange because i use the nb prefix on names etc, but this surel isn't my code... anyways.
For each instance you see nb_drawLabel() in the start() routine, imagine someone had copied and pasted the contents of nb_drawLabel() to that line. That's basically what it looks like in post #3. Using the first couple letters or an abbreviation of the file is part of the naming convention I prefer.

Quoting nubcake
i just woke-up so keep this in mind :
I went to find you a picture of a glorious cup of a coffee and got completely distracted.
http://wiihd.wdfiles.com/local--file...ve/megaman.gif

Quoting nubcake
1. from what i can see there is redundant code ...

2. the way this calculates things is just wrong. ...

3. ... there is no distinction between the order types.
1. Agreed.
2. It can be done differently.
3. Lines 96 and 97 are pretty much the only ones that differentiate between OP_BUY and OP_SELL.

Quoting nubcake
this indicator tries to be clever and list-off for all open orders (this chart or not) and then also mark visually them if the values are for this chart, but also include swap etc. it's too clever for it's own good. it needs to be re-done completely. orderprofit etc is the wrong way to go about this. it needs to be calculated correctly, and that means using lot sizes and open prices to calculate a true buy average price or sell average price.
The whole mark-visually-on-the-chart thing was an afterthought I had; something I thought would make this a bit more useful. To draw the line, the indicator actually takes the string from the label, calls StrToDouble() and throws it on the chart. I didn't modify any of the math in the code that has to do with calculating any of the values displayed to the user, because, well, it hurts my eyes.

I agree with you that all the math should be redone. However, for the currency pairs that I can attach it to, it gives accurate information. And really I just wanted to change the font size.
  • #18
  • Feb 21, 2013 3:17pm Feb 21, 2013 3:17pm
Quoting tener
For each instance you see nb_drawLabel() in the start() routine, imagine someone had copied and pasted the contents of nb_drawLabel() to that line. That's basically what it looks like in post #3. Using the first couple letters or an abbreviation of the file is part of the naming convention I prefer.



I went to find you a picture of a glorious cup of a coffee and got completely distracted.
http://wiihd.wdfiles.com/local--file...ve/megaman.gif



1....

pew pew.

anyways, i have no idea who did what parts, apart from what you just mentioned, but i don't really care... as long as it's not me i'm happy

i still say that the first loop through the sym array is redundant, and i still say the math to calc the average is totally busted. yes, it will probably look right most of the time if your account is in the quote currency (or if you only hold trades for short amounts of time), but there will be a drifting error in the calculation as the account currency changes if it's not the quote currency, PLUS the busted-ness of gold / silver marketinfo data. it's just all-round better to actually calculate the ACTUAL average price based on the opens and lot sizes. it's not difficult to do, is proper, and eliminates the bullshit errors this guy is getting on gold plus the unseen error in the math if/when the acct ccy isn't the quote ccy.

that code is broken yo!
Congratulations ScalaFX for coming out of the closet!
  • #19
  • Feb 22, 2013 2:06am Feb 22, 2013 2:06am
That mean I can't use this indicator for trading gold and silver? But it's ok if it is use for trading forex? thanks for your kind explanation
  • #20
  • Feb 22, 2013 5:21am Feb 22, 2013 5:21am
Quoting ronald_fsm
That mean I can't use this indicator for trading gold and silver? But it's ok if it is use for trading forex? thanks for your kind explanation
this means get someone to rewrite it properly and you then won't have to worry about where it works and won't work and whatever other special cases that occur.

i'll put it to you like this so you understand... the way i look at this code and what i see is happening is like when someone drives their car around with the oil warning light on. everything will basically seem to be working and the car will go, and go, and go, but then sooner or later shit will break on you all of a sudden without warning. instead, if someone was to re-code this properly you wouldn't have to worry about your 'car' suddenly breaking-down randomly out of nowhere and being stranded. it would 'just work', period.

bah, after all of the shit i've written about this one indicator i probably could have just gone and rewritten it for you already. i really don't want to, and won't, so someone else can come and rewrite it for you and do the math properly. i'm just going to shut up about it now and let it rest instead of rambling on.
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now