Daily Profit procedure

bool funcGetTodaysProfit()
{
int int DailyProfitPips=100;   
double dblReturnValue=0,dblDailyProfitPips=intDailyProfitPips*Point;
   for (int i=0; i<OrdersTotal(); i++)
   {//1 +cycle by orders search
      if (OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) break;
      if (OrderMagicNumber()!=intOrderMagicNumber) continue;
      if (TimeYear(Time[0])!=TimeYear(OrderOpenTime()) &&
          TimeDay(Time[0])!=TimeDay(OrderOpenTime()) &&
          TimeMonth(Time[0])!=TimeMonth(OrderOpenTime()))continue; //not todays profit.
      if (OrderType()==OP_BUY) {dblReturnValue=dblReturnValue+(OrderClosePrice()-OrderOpenPrice());}
      if (OrderType()==OP_SELL) {dblReturnValue=dblReturnValue+(OrderOpenPrice()-OrderClosePrice());}
   }
   Comment("Profit today so far: ",DoubleToStr(dblReturnValue,Digits),"\n","Profit target: ",DoubleToStr(dblDailyProfitPips,Digits));
   if (dblReturnValue>dblDailyProfitPips) {return(true);}
   return(false);
}

Quoting nondisclosure00

Disliked

I'm looking for a procedure, mql4, that will tell me true or false, when I've hit the daily profit limit for a pair. I've tried the folloowing code but it always returns false.
[code]bool funcGetTodaysProfit()
{
int int DailyProfitPips=100;
double dblReturnValue=0,dblDailyProfitPips=intDailyProfitPips*Point;
for (int i=0; i<OrdersTotal(); i++)
{//1 +cycle by orders search
if (OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) break;
if (OrderMagicNumber()!=intOrderMagicNumber) continue;
if (TimeYear(Time[0])!=TimeYear(OrderOpenTime())...

Ignored

bool funcGetTodaysProfit()
{
   int intDailyProfitPips=100;
   double dblReturnValue=0,dblDailyProfitPips=intDailyProfitPips*Point;
   for (int i=0; i<OrdersTotal(); i++)
   {//1 +cycle by orders search
      if (OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) break;
      if (OrderSymbol()!=Symbol() continue;
      if (TimeYear(Time[0])!=TimeYear(OrderOpenTime()) &&
          TimeDay(Time[0])!=TimeDay(OrderOpenTime()) &&
          TimeMonth(Time[0])!=TimeMonth(OrderOpenTime()))continue; //not todays profit.
      if (OrderType()==OP_BUY) {dblReturnValue=dblReturnValue+(OrderClosePrice()-OrderOpenPrice());}
      if (OrderType()==OP_SELL) {dblReturnValue=dblReturnValue+(OrderOpenPrice()-OrderClosePrice());}
   }
   Comment("Profit today so far: ",DoubleToStr(dblReturnValue,Digits),"n","Profit target: ",DoubleToStr(dblDailyProfitPips,Digits));
   if (dblReturnValue>dblDailyProfitPips) {return(true);}
   return(false);
}

Quoting cyber1

Disliked

nondisclosure00-
First thing I notice is you said you want to get the daily profit limit for a pair yet nowhere are you comparing symbols when looping through the orders.

Second is you have this:
int int DailyProfitPips=100;
which doesn't compile

As for the checking of the daily profit I was suggest using iBarShift().

Ignored

Quoting nondisclosure00 6452624

Disliked

Ok. made the change so it compiles and also took out the magic number that i use further in my code and now use symbol. But I'm still getting the same result.

How am I to use iBarShift() in looping through closed positions to find the profit for the day?

Inserted Code

bool funcGetTodaysProfit()
{
   int intDailyProfitPips=100;
   double dblReturnValue=0,dblDailyProfitPips=intDailyProfitPips*Point;
   for (int i=0; i<OrdersTotal(); i++)
   {//1 +cycle by orders search
      if (OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) break;
      if (OrderSymbol()!=Symbol() continue;
      if (TimeYear(Time[0])!=TimeYear(OrderOpenTime()) &&
          TimeDay(Time[0])!=TimeDay(OrderOpenTime()) &&
          TimeMonth(Time[0])!=TimeMonth(OrderOpenTime()))continue; //not todays profit.
      if (OrderType()==OP_BUY) {dblReturnValue=dblReturnValue+(OrderClosePrice()-OrderOpenPrice());}
      if (OrderType()==OP_SELL) {dblReturnValue=dblReturnValue+(OrderOpenPrice()-OrderClosePrice());}
   }
   Comment("Profit today so far: ",DoubleToStr(dblReturnValue,Digits),"n","Profit target: ",DoubleToStr(dblDailyProfitPips,Digits));
   if (dblReturnValue>dblDailyProfitPips) {return(true);}
   return(false);
}

Ignored

//+----------------------------------------------------------------------------+
//
//+----------------------------------------------------------------------------+
double GetTodaysProfit(){

  double TotProf=0;
  int total = HistoryTotal();
  for (int i=0;i<total;i++){
      OrderSelect(i, SELECT_BY_POS, MODE_HISTORY);
if(OrderSymbol()==Symbol() && OrderMagicNumber()==MagicNumber){
int BarsCnt=iBarShift(NULL,PERIOD_D1,OrderCloseTime());

if(BarsCnt<2){
  TotProf+=OrderProfit();
  }
  }
  }
  return(TotProf);
}

Quoting cyber1

Disliked

nondisclosure00-

You're going to need both. I didn't mean for you to remove one replaced with the other.
Anyways this is my idea of what you're trying to do. There's probably something that I missed but it should give you some ideas.
[code]
//+----------------------------------------------------------------------------+
//
//+----------------------------------------------------------------------------+
double GetTodaysProfit(){

double TotProf=0;
int total = HistoryTotal();
for (int i=0;i<total;i++){
OrderSelect(i, SELECT_BY_POS,...

Ignored

double daily_profit()
{
 double prof=0;
 int trade;
 int trades=OrdersHistoryTotal();
 
for(trade=0;trade<trades;trade++) {
  OrderSelect(trade,SELECT_BY_POS,MODE_HISTORY);  
  if(OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol()) {   
   if(OrderCloseTime() >= iTime(Symbol(),1440,0)) prof += OrderProfit() + OrderSwap() + OrderCommission(); }}
 
for(trade=0;trade<OrdersTotal();trade++) {
  OrderSelect(trade,SELECT_BY_POS,MODE_TRADES);  
  if(OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol()) {   
   if(OrderOpenTime() >= iTime(Symbol(),1440,0)) prof += OrderProfit() + OrderSwap() + OrderCommission(); }}
 return(prof);
}

Quoting FerruFx

Disliked

Below an example using the today total including the current opened trades:

[code]
double daily_profit()
{
double prof=0;
int trade;
int trades=OrdersHistoryTotal();

for(trade=0;trade<trades;trade++) {
OrderSelect(trade,SELECT_BY_POS,MODE_HISTORY);
if(OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol()) {
if(OrderCloseTime() >= iTime(Symbol(),1440,0)) prof += OrderProfit() + OrderSwap() + OrderCommission(); }}

for(trade=0;trade<OrdersTotal();trade++) {
OrderSelect(trade,SELECT_BY_POS,MODE_TRADES);
if(OrderMagicNumber()...

Ignored

Quoting nondisclosure00

Disliked

Thanks Ferru. Long time!

I'm getting the profit calculated correctly on the same day. But it still sees the last day's profit and adds it to the current days profit. Add to that, the result in my function is always false.

Any ideas.

Ignored

Quoting FerruFx

Disliked

At the beginning of the function, you must set the profit to 0 so the calculation will be valid only for this call.

This is also important to look only for orders opened/closed after the start of the day (as shown in my example).

Ignored

   string strCurrentDate=StringConcatenate(TimeYear(Time[0]),".",TimeMonth(Time[0]),".",TimeDay(Time[0]));
   datetime dtCurrentDate=StrToTime(strCurrentDate);

      if (TimeYear(OrderOpenTime())!=TimeYear(Time[0]) &&
          TimeDay(OrderOpenTime())!=TimeDay(Time[0]) &&
          TimeMonth(OrderOpenTime())!=TimeMonth(Time[0]))continue; //not todays profit.

      if (OrderOpenTime()<dtCurrentDate) continue;

Quoting FerruFx

Disliked

At the beginning of the function, you must set the profit to 0 so the calculation will be valid only for this call.

This is also important to look only for orders opened/closed after the start of the day (as shown in my example).

Ignored