Addition equation subtracts... WHY?

Quoting gspajon

Disliked

...can anyone explain why this is?

Ignored

 
     {
     sum = OrderOpenPrice()*OrderLots();
     sumtotal = sumtotal+sum;
     result = OrderLots();
     total = (total+result);
     Lots = total*multi; 
     avgprice = sumtotal/total;       //----Find Aggregate price
     }
    }
   }
  }
limit = avgprice+((100*10)*Point);   //----Calculate Limit
pl = (Bid-avgprice);//*mult;               //----calculate open position profit/loss in pips    //mult is 0//

Quoting gspajon

Disliked

Nubcake...thank you so much for responding...I have attached the entire code for your review...I would greatly appreciate an expert opinion...I've been banging my head against the wall on this project for about 3 months now...just as I "fix" one thing another completely different problem shows up.

I'm trying to get the program to calculate the weighted average price over multiple entries and then close a user percent of the total lots, at a given target.

I thought I had it...it correctly calculates the average price, but now, it is doing this...

Ignored

//redacted as not relevant.

 
//---
//---    
   double AveragePrice()
   {
   int    total  = OrdersTotal();
   double price  = 0;
   double count  = 0;
   for(int i=OrdersTotal()-1;i>=0;i--)
     {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderSymbol()!= Symbol())   continue;
      if(OrderType()   >  OP_SELL)   continue;
              
      if(OrderType()==OP_BUY || OrderType()==OP_SELL)
        {
        price  += OrderOpenPrice()*OrderLots();
        count  += OrderLots();
        }
     }
   if(count > 0)
      price = NormalizeDouble(price/count, Digits);
      else
      price = 0.0;
      
      return(price); 
      }
//---
//---

Quoting gspajon

Disliked

NubCake...Again thank you very much for your assistance...unfortunately I don't really understand a great deal of what you said. I understand about the naming and bracketing, but the rest was way over my head. Perhaps you would consider coding this ea for me as a paid project?

All I am looking for is an EA that will do the following:[list=1][*]Calculate the weighted average price of multiple entries[*]Have a user identified target (in pips) that is calculated from the weigted Avg. price[*]At the target close a user identified percent of the...

Ignored

//longs
if (SomeValueThatMightOrMightNotBeTrue) {
  //a section of code that may, or may not, run
  mult = <some value>;
}

SUPERIMPORTANTCALC = mult * <some other value>;

//shorts
if (SomeValueThatCouldBeTrueOrCouldBeFalse) {
  //a section of code that maybe, maybe not, gets run
  mult = <something or other>;
}

SUPERIMPORTANTCALC = mult * <yadda yadd>;

Quoting gspajon

Disliked

Judging from Nubcake's comments, I am sure that it is annoying to have an amateur trying to do something above his head...

Ignored

Quoting gspajon

Disliked

Nubcake...I think I see where you're headed with the "mult" variable. Question: Would it be better to run this in the init area or change the "mult" varible to a "global variable"? ie place it higher up in the code (before the init function.)? I will try that and see what happens in simulation...I was unaware that this would make such a difference. I have used this method to calculate digits in a currency pair for quite awhile and never had this kind of problem.

Again I appreciate the time you spent in going over this code...Thank...

Ignored

bool WantToDateKim;

if (Kim == Female) WantToDateKim =  true;
if (Kim < FiveFootTall) WantToDateKim = true;

if (WantToDateKim) AskKimOut();

bool WantToDateKim;

WantToDateKim = false; // <- IMPORTANT.  AT LEAST NOW WE HAVE A KNOWN STARTING SAFE CONDITION
if (Kim == Female) {
  if (Kim < FiveFootTall) {
    WantToDateKim = true;
  }
}

if (WantToDateKim) AskKimOut();

Quoting gspajon

Disliked

Nubcake...I understand more clearly what you are trying to say. I looked at the code once again and found that the lines I was referring to in the first post were the culprit.

The limit and PL calculations were occurring in both the Long side and the Short side as the code worked its way down. Thus the Long side showed negative numbers...while the short side worked correctly.

I have placed those calculations back inside the Long and short bools respectively, and the calculations are now showing correct.

I did NOT change the mult calculation...

Ignored

Quoting gspajon

Disliked

Yes indeed...I left the limit and pl calculation hanging out in the wind (so to speak) and so the later was free to over-ride the former...or the short side was recalculating the long side.

Ignored

 for (opo = OrdersTotal(); opo >=0; opo--)  //--look for open orders

Quoting m.m.m.

Disliked

...You forgot to subtract 1 from OrdersTotal().
This way first -supposed to be- iteration of the loop is skipped, and an previous avgprice (where Target*10*Point is subtracted) is used to calculate the limit..

Ignored