EA opens but won't close all trades | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Close all trades at preset price level 33 replies

Stop all and close all trades EA 23 replies

17:07 EST and Oanda won't let me close trades in profit 0 replies

Looking for EA to close all Buy Or all Sell trades when in profit 0 replies

Close all trades !!! 1 reply

EA opens but won't close all trades

  • #1
  • First Post: Jan 23, 2013 2:44pm Jan 23, 2013 2:44pm
My question is the following:

I have created an EA with a free EA-creator and it it working wonderfully.The only problem is that the EA opens a lot of trades in one direction and when it is time to close, the EA cant handle that in some way it does not close all the positions.Is it possible that there are to much open positions or is it because the EA cant handle that many orders to close the trade?
So actually the question should be howmany trades can a sigle EA handle?

Thank you for any reply
Hollandpippin
  • #2
  • Jan 23, 2013 2:53pm Jan 23, 2013 2:53pm
Quoting hollandpippin
My question is the following:

I have created an EA with a free EA-creator and it it working wonderfully.The only problem is that the EA opens a lot of trades in one direction and when it is time to close, the EA cant handle that in some way it does not close all the positions.Is it possible that there are to much open positions or is it because the EA cant handle that many orders to close the trade?
So actually the question should be howmany trades can a sigle EA handle?

Thank you for any reply
Hollandpippin
It's because EA creators are generally pretty rubbish . . . if you want to code learn to code.
20 pips a day isn't too much to ask . . .
  • #3
  • Jan 23, 2013 3:22pm Jan 23, 2013 3:22pm
I can't imagine an actual reasonable limit, but of course poor coding would introduce one as a side effect.

Does it trade single orders properly? Perhaps that is all it was designed to do.
  • #4
  • Jan 23, 2013 3:47pm Jan 23, 2013 3:47pm
Cant imagine the auto code stuff being all that good at error checking.

Still curious at its format etc. Can you post it.
It probably just needs a loop added in until all the trades are closed.

Do you always close (or try to close) all your trades together.

cheers scalpz
Target 2 : Stoploss in the green
  • #5
  • Jan 23, 2013 4:23pm Jan 23, 2013 4:23pm
Quoting scalpz
Cant imagine the auto code stuff being all that good at error checking.
You might be interested in this thread: http://forum.mql4.com/48594
20 pips a day isn't too much to ask . . .
  • #6
  • Edited 6:19pm Jan 23, 2013 6:07pm | Edited 6:19pm
Another thought occurred to me. Most problems with closing multiple trades at once have to do with incrementing the loop counter accessing current trades. The proper way is to decrement the loop counter. That guarantees that all trades needing to be closed get closed.

The other possibility is trying to do too much at once - ie running into an unhandled trade context busy situation.

Booth of these scenarios can be avoided with proper coding techniques.
  • #7
  • Jan 23, 2013 6:11pm Jan 23, 2013 6:11pm
Another thought - could this be some sort of FIFO problem? You didn't say whether the tades are in one pair or different. I think you implied a single pair.
  • #8
  • Jan 23, 2013 8:09pm Jan 23, 2013 8:09pm
Quoting CodeMeister
Another thought occurred to me. Most problems with closing multiple trades at once have to do with incrementing the loop counter accessing current trades. The proper way is to decrement the loop counter. That guarantees that all trades needing to be closed get closed.

The other possibility is trying to do too much at once - ie running into an unhandled trade context busy situation.

Booth of these scenarios can be avoided with proper coding techniques.
If you are in a FIFO jurisdiction you must close the orders starting at index 0 first or you will get a FIFO violation if the trades have an equal lot size. I decrement the loop but always close order 0. Based on the trade context check code I have in place I get no errors with this approach and all orders get closed in a single pass.
  • #9
  • Jan 24, 2013 7:29am Jan 24, 2013 7:29am
Quoting CodeMeister
Another thought - could this be some sort of FIFO problem? You didn't say whether the tades are in one pair or different. I think you implied a single pair.
Yes i have attached the EA to one single currency to perform a test of this EA
  • #10
  • Jan 24, 2013 8:07am Jan 24, 2013 8:07am
Today the EA seems not to have problems with opening and closing it might have been caused by multiple currencies opened at the same time.
The EA takes a trade every minute when my indicator tells the EA to do so.For instance from 4 am to 7 am i had open 53 trades and closed them all in profit.
  • #11
  • Jan 24, 2013 8:26am Jan 24, 2013 8:26am
What might cause the EA to have problems is that the EA is programmed like this======>the signals come and the EA takes the trades..for example a buy signal...now comes the signal to close the trade but at the same time the EA has to open a sell position.This way the EA is always in the market 24/7 could this be the problem?

Thanks

Hollandpippin
  • #12
  • Jan 24, 2013 11:08am Jan 24, 2013 11:08am
Quoting hollandpippin
What might cause the EA to have problems is that the EA is programmed like this======>the signals come and the EA takes the trades..for example a buy signal...now comes the signal to close the trade but at the same time the EA has to open a sell position.This way the EA is always in the market 24/7 could this be the problem?

Thanks

Hollandpippin

Possible, but not likely. Possible because poor coding can result in strange effects.

The way to identify problems is through a process of elimination. You haven't addressed my suggestions and I won't make any others until you do.
  • #13
  • Last Post: Jan 25, 2013 9:05am Jan 25, 2013 9:05am
ARRRRRGGGGGGG......next issue with the EA but not the fault of EA i guess coz it cant open trades anymore coz of maximum open trades reached.
0 traders viewing now