Some very basic MQL4 help for a newbie please

Quoting WideEyed

Disliked

On my demo account I'm trying out an EA that simultaneously opens multiple orders (in different currency pairs).

Each line is in the form of
OrderSend("AUDUSD",OP_SELL, Lot, MarketInfo("AUDUSD",MODE_BID), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("AUDJPY",OP_BUY, Lot, MarketInfo("AUDJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
etc

However, I've run into a little problem. The EA opens all orders and then opens all orders again and then opens all orders again and keeps doing it till the account has no free margin left....

Ignored

#property show_inputs
extern double Lot = 0.01;

int start()
  {

   OrderSend("AUDUSD",OP_SELL, Lot, MarketInfo("AUDUSD",MODE_BID), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
   OrderSend("AUDJPY",OP_BUY, Lot, MarketInfo("AUDJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
//etc (other pairs)

   return(0);
  }

Quoting WideEyed

Disliked

Thanks for your reply. There aren't any other EAs running on the account - no checks for existing orders prior to opening new ones.

Code:

Inserted Code

#property show_inputs
extern double Lot = 0.01;

int start()
  {

   OrderSend("AUDUSD",OP_SELL, Lot, MarketInfo("AUDUSD",MODE_BID), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
   OrderSend("AUDJPY",OP_BUY, Lot, MarketInfo("AUDJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
//etc (other pairs)

   return(0);
  }

Ignored

Quoting WideEyed

Disliked

On my demo account I'm trying out an EA that simultaneously opens multiple orders (in different currency pairs).

Each line is in the form of
OrderSend("AUDUSD",OP_SELL, Lot, MarketInfo("AUDUSD",MODE_BID), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("AUDJPY",OP_BUY, Lot, MarketInfo("AUDJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
etc

However, I've run into a little problem. The EA opens all orders and then opens all orders again and then opens all orders again and keeps doing it till the account has no free margin left....

Ignored

Quoting RaptorUK

Disliked

Run it as a Script not an EA . . . then it will run just once.

Ignored

Quoting WideEyed

Disliked

For academic reasons I'd still be interested in knowing what modifications the EA requires to run each instruction just once.

Ignored

Quoting Jack_Larkin

Disliked

If so, there's a lot of pre-written code that does this for you on the board. I could link it here if that's the case.

Ignored

Quoting WideEyed

Disliked

Xaphod, that's useful. I've come across this magic numbers term. I've done some digging around but can't figure out how to use magic numbers in this context. The magic numbers' main purpose seems to be to associate a trade with a particular EA. Is it the case that I've got to setup the magic numbers and then insert an IF statement prior to each OrderSend to see if the magicnumber order exists? If so that will solve the problem but the EA will keep looping till it's shut down.

Ignored

int start() {
   // Orders
   OrderSend(....);
   OrderSend(....);
   // Loop forever
   while (!IsStopped()) 
      Sleep(1000);
   return(0);
}

// Windows API functions
#import "user32.dll"
   int      PostMessageA(int hWnd,int Msg,int wParam,int lParam);
#import

// Windows API definitions
#define  WM_COMMAND 0x0111
// MT4_Messages
#define  MT4_WMCMD_REMOVE_EXPERT 33050

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init() {
  if (!IsDllsAllowed())
    Alert(Symbol()+", "+WindowExpertName()+", 'Allow Dll imports' is required for this EA to work. "); 
  return(0);
}

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() {
  if (!IsDllsAllowed())
    return(0);
  
  // Do stuff  
  Print("Run Once At "+TimeToStr(TimeLocal())); 
   
  // Remove EA from Chart
  if (!IsStopped())
    PostMessageA(WindowHandle(Symbol(),Period()), WM_COMMAND, MT4_WMCMD_REMOVE_EXPERT, 0);
 
  // Loop until EA is removed
  while (!IsStopped()) 
    Sleep(200);
  
  return(0);
}

Quoting WideEyed

Disliked

Jack_Larkin, yes, I wanted to try a modification of the basket technique at this post. Before trying any modification I wanted to use the code provided there exactly as-is to first make sure it works.
...

Ignored