Why is this stuck in a loop?

void ModifyThisOrder(int Ticket, double Price, double StopLoss, double TakeProfit, int MaxTry)
{
   string Commentary=" ";
   int TryCount=0;
   bool OrderLoop=false;
   color OrderColor=Black;
   if (OrderType()==OP_BUY) {OrderColor=Blue;}
   if (OrderType()==OP_SELL) {OrderColor=Red;}
   while( !OrderLoop )
   {
      RefreshRates();
      while( IsTradeContextBusy() ) { Sleep( 10 ); }
      if( OrderSelect( Ticket, SELECT_BY_TICKET ) )
      { OrderModify( Ticket, OrderOpenPrice(), StopLoss, TakeProfit, 0, OrderColor ); }
      int Err=GetLastError();
      switch (Err) 
      {
          //---- Success
          case               ERR_NO_ERROR: {OrderLoop = true; break;}
          //---- Retry Error     
          case          ERR_INVALID_STOPS: {Print("Invalid Stops"); Sleep(1000);}
          case            ERR_SERVER_BUSY: {Print("Server Busy"); Sleep(1000);}
          case          ERR_NO_CONNECTION: {Print("No Connection"); Sleep(1000);}
          case          ERR_INVALID_PRICE: {Print("Invalid Price"); Sleep(1000);}
          case             ERR_OFF_QUOTES: 
          case            ERR_BROKER_BUSY: Sleep(1000);
          case     ERR_TRADE_CONTEXT_BUSY: {TryCount++; break;}
          case          ERR_PRICE_CHANGED:
          case                ERR_REQUOTE: continue;
            
          //---- Fatal known Error 
          case   ERR_INVALID_TRADE_VOLUME: {OrderLoop = true; Print( Commentary + " Invalid Lots"     ); break;} 
          case          ERR_MARKET_CLOSED: {OrderLoop = true; Print( Commentary + " Market Close"     ); break;} 
          case         ERR_TRADE_DISABLED: {OrderLoop = true; Print( Commentary + " Trades Disabled"  ); break;} 
          case       ERR_NOT_ENOUGH_MONEY: {OrderLoop = true; Print( Commentary + " Not Enough Money" ); break;} 
          case  ERR_TRADE_TOO_MANY_ORDERS: {OrderLoop = true; Print( Commentary + " Too Many Orders"  ); break;} 
          case                        149: {OrderLoop = true; Print( Commentary + " Hedge is prohibited"  ); break;} 
            
          //---- Fatal Unknown Error
          case              ERR_NO_RESULT: {OrderLoop = true; Print( Commentary + "No Result"     ); break;}
          default                        : {OrderLoop = true; Print( "Unknown Error - " + Err ); break;}
          //----                         
      }// end switch 
      if( TryCount > MaxTry ) { OrderLoop = true; }
   }//end while  
   return(0); 
}

Quoting nondisclosure00

Disliked

OrderModify in this loop failes w/ ERR_NO_RESULT. But I can't break out of the while loop. It just keeps looping indefinately.


[code]void ModifyThisOrder(int Ticket, double Price, double StopLoss, double TakeProfit, int MaxTry)
{
bool OrderLoop=false;
color OrderColor=Black;
if (OrderType()==OP_BUY) {OrderColor=Blue;}
if (OrderType()==OP_SELL) {OrderColor=Red;}
while( !OrderLoop )
{
RefreshRates();
while( IsTradeContextBusy() ) { Sleep( 10 ); }...

Ignored

Quoting cyber1

Disliked

Try using an if condition instead of while loop to test IsTradeContextBusy(). Why does it have to be a while loop?

Ignored

Quoting nondisclosure00

Disliked

Because I want to try again X number of times on certain errors.

Ignored

Quoting cyber1

Disliked

So then shouldn't all those errors you're trying to trap be included in the while loop?

Ignored

Quoting nondisclosure00

Disliked

They are all in the while loop.

Ignored

Quoting cyber1

Disliked

Yes they're all in the first, but not in the second.

Ignored

Quoting nondisclosure00

Disliked

But I'm not looking to have them in the tradecontext while loop. Just the Orderloop while.

Ignored

Quoting cyber1

Disliked

Are you sure this is the correct usage of IsTradeContextBusy()?

Ignored

int ModifyThisOrder(int Ticket, double Price, double StopLoss, double TakeProfit, int MaxTry)
{
   string Commentary=" ";
   int TryCount=0;
   bool OrderLoop=false;
   color OrderColor=Black;
   if (OrderType()==OP_BUY) {OrderColor=Blue;}
   if (OrderType()==OP_SELL) {OrderColor=Red;}
   while( OrderLoop == false)
   {
      while( IsTradeContextBusy() ) { Sleep( 10 ); }
      RefreshRates();
      if( OrderSelect( Ticket, SELECT_BY_TICKET ) )
      { OrderModify( Ticket, OrderOpenPrice(), StopLoss, TakeProfit, 0, OrderColor ); }
      int Err=GetLastError();
      switch (Err) 
      {
          //---- Success
          case               ERR_NO_ERROR: {OrderLoop = true; break;}
          //---- Retry Error     
          case          ERR_INVALID_STOPS: {Print("Invalid Stops"); Sleep(1000);}
          case            ERR_SERVER_BUSY: {Print("Server Busy"); Sleep(1000);}
          case          ERR_NO_CONNECTION: {Print("No Connection"); Sleep(1000);}
          case          ERR_INVALID_PRICE: {Print("Invalid Price"); Sleep(1000);}
          case             ERR_OFF_QUOTES: 
          case            ERR_BROKER_BUSY: {Sleep(1000);}
          case     ERR_TRADE_CONTEXT_BUSY: {TryCount++; break;}
          case          ERR_PRICE_CHANGED:
          case                ERR_REQUOTE: {continue;}
            
          //---- Fatal known Error 
          case   ERR_INVALID_TRADE_VOLUME: {Print( Commentary + " Invalid Lots"     ); return(0);} 
          case          ERR_MARKET_CLOSED: {Print( Commentary + " Market Close"     ); return(0);} 
          case         ERR_TRADE_DISABLED: {Print( Commentary + " Trades Disabled"  ); return(0);} 
          case       ERR_NOT_ENOUGH_MONEY: {Print( Commentary + " Not Enough Money" ); return(0);} 
          case  ERR_TRADE_TOO_MANY_ORDERS: {Print( Commentary + " Too Many Orders"  ); return(0);} 
          case                        149: {Print( Commentary + " Hedge is prohibited"  ); return(0);} 
            
          //---- Fatal Unknown Error
          case              ERR_NO_RESULT: {Print( Commentary + "No Result"     ); return(0);}
          default                        : {Print( "Unknown Error - " + Err ); return(0);}
          //----                         
      }// end switch 
      if( TryCount > MaxTry ) { OrderLoop = true; }
   }//end while  
   return(0); 
}

Quoting nondisclosure00

Disliked

Changed the code and put return(0)'s in and it STILL loops!

Ignored

Quoting euclid

Disliked

Are you sure it's looping inside the function? Do you have another loop that calls this function?

Ignored

int i=0;
for (int j=0; i<OrdersTotal(); j++)