Need help to mod "Close All Pending Orders" script | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA/Script to close Trades and Pending orders? 12 replies

Need Scripts - close all open and pending orders 10 replies

Close all pending orders and open orders once they reach profit target 3 replies

script to "close open orders" and "open opposite orders" 3 replies

Orders & Pending Orders Script 0 replies

Attachments: Need help to mod "Close All Pending Orders" script
Exit Attachments

Need help to mod "Close All Pending Orders" script

  • #1
  • First Post: Sep 21, 2012 10:59pm Sep 21, 2012 10:59pm
Hi all,

Anybody help me to modify this EA http://www.forexfactory.com/images/attach/mq4.gif Close All PENDING Orders Specific Pair.mq4 to Close All PENDING Orders AFTER Close all open trades of Specific Pair?

I mean I need it just close all pending orders ASA the open trades hit TP/SL of Specific Pair.

Thank you in advance.
  • #2
  • Sep 23, 2012 4:50am Sep 23, 2012 4:50am
I would really appreciate if someone could help me...

Thank you in advance.
  • #3
  • Sep 23, 2012 5:22am Sep 23, 2012 5:22am
Find this part of the code:
Inserted Code
//Close pending orders
      case OP_BUYLIMIT  :
      case OP_BUYSTOP   :
      case OP_SELLLIMIT :
      case OP_SELLSTOP  : result = OrderDelete( OrderTicket() );
Modify it like this:
Inserted Code
//Close pending orders
      case OP_BUYLIMIT  : result = OrderDelete( OrderTicket() );
      case OP_BUYSTOP   : result = OrderDelete( OrderTicket() );
      case OP_SELLLIMIT : result = OrderDelete( OrderTicket() );
      case OP_SELLSTOP  : result = OrderDelete( OrderTicket() );
  • #4
  • Sep 23, 2012 5:26am Sep 23, 2012 5:26am
you aren't actually asking for 'help'. helping would suggest you have some steam behind you and just need some guidance in the correct direction.

you basically don't even have any code and just want someone to do it all for you. sorry, but that's not 'help'. also, your question is unclear at best for anyone who would do it all for you. i'm sure someone, somewhere, has already coded what you want anyway. either do some searching, or be clearer with what exactly you want to happen.

help others to help you by being straight, and most of all, being clear.
Congratulations ScalaFX for coming out of the closet!
  • #5
  • Sep 23, 2012 5:55am Sep 23, 2012 5:55am
nubcake,
yes, it is one of those foggy requests which give room for much speculation,
but he provided the code (click on the name of the EA and it will download)
and since the most simple solution required only a copy and paste,
I chose to help.

The only application of this EA would be to attach it on a pair where
the last open order just closed and he must be present to catch this
moment.

If he wants something else, he should express it clearly but here my help is ending.
  • #6
  • Sep 23, 2012 6:04am Sep 23, 2012 6:04am
Quoting fxtr51
nubcake,
yes, it is one of those foggy requests which give room for much speculation,
but he provided the code (click on the name of the EA and it will download)
and since the most simple solution required only a copy and paste,
I chose to help.

The only application of this EA would be to attach it on a pair where
the last open order just closed and he must be present to catch this
moment.

If he wants something else, he should express it clearly but here my help is ending.
you have greater patience than i. this i know to be true. i saw the 'source' and it was almost a blank new template. *exasperated look of great confusion*
Congratulations ScalaFX for coming out of the closet!
  • #7
  • Sep 23, 2012 6:55am Sep 23, 2012 6:55am
Quoting Jack0812
Anybody help me to modify this EA
hey jack..... seeming small point of reference, that is a script not an ea..... there is a difference.....

it's one of many from an excellent coder, Matias Romeo, from days gone by.... it's written without waste, so it may seem brief..... but in reality there is not a single character too many or too few...... it's an almost perfect example of perfect coding.......

//---

as for your request, you'll most likely need to monitor the pair with a true ea..... it should count open buys or sells and once there were none, close all remaining pending orders.....h
to trade and code, keep both simple... no call to impress....h
  • #8
  • Sep 23, 2012 9:57pm Sep 23, 2012 9:57pm
@fxtr51

Thanks for your effort but it's not works. I want it wait till open orders hit SL or TP than it start closing all pending orders not closing all pending orders as soon as it attach to the chart now.

Thank you.
  • #9
  • Sep 23, 2012 11:31pm Sep 23, 2012 11:31pm
Then as hayseed said, you need an EA, not a script.

Different animals altogether
No way I'll wreck this... It's a beer truck!
  • #10
  • Edited 5:21am Sep 24, 2012 12:52am | Edited 5:21am
I have removed my script, please use the updated one posted by fxtr51.
Trade what you see not what you hope
  • #11
  • Sep 24, 2012 4:16am Sep 24, 2012 4:16am
cja,
your script doesn´t work.

I modified it and now it works as it should.
Attached File(s)
File Type: mq4 Close All PENDING @ Zero trades.mq4   2 KB | 1,455 downloads
  • #12
  • Sep 24, 2012 5:13am Sep 24, 2012 5:13am
Quoting fxtr51
cja,
your script doesn´t work.

I modified it and now it works as it should.
Thanks for that I retested it and it worked most of the time however for some reason occasionally it would delete the pending orders while trades were still open when loading the script, probably not counting the open trades correctly. I guess that can be an issue when doing limited testing its very easy to miss something.

Regards CJA
Trade what you see not what you hope
  • #13
  • Last Post: Sep 24, 2012 9:57am Sep 24, 2012 9:57am
just a thought.....

it almost appears as that would max out the cpu...... have you checked.....

scripts are most often used for a one shot task..... if there is no end, they sometimes can lock things up......h

//----
//----

Inserted Code
 
 
 
//---- this would be an ea...... not a script......
 
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
 
  if(Count() == 0)  {ClosePendings();}
  return(0);
  }
//----
//----
int Count()
{
 int count=0;
 int i;
 int total=OrdersTotal();
 for(i=0;i<total;i++)
 {
  OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
 
  if(OrderSymbol() != Symbol() || OrderType() > OP_SELL) continue;
 
   count++;
 }
 return(count);
}
//----
//----
void ClosePendings()
  {
  int total = OrdersTotal();
  for(int i=total-1;i>=0;i--)
  {
    OrderSelect(i, SELECT_BY_POS);
    if(OrderSymbol() != Symbol()) continue;
    {
    int type   = OrderType();
    bool result = false;
 
    switch(type)
    {
      case OP_BUYLIMIT  :
      case OP_BUYSTOP   :
      case OP_SELLLIMIT :
      case OP_SELLSTOP  : result = OrderDelete( OrderTicket() );
    }
    }  
  }
  }
to trade and code, keep both simple... no call to impress....h
0 traders viewing now