How can I capture an indicator's max/min values? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Separating Count of Max Pending Orders and Max Open Trades 2 replies

Max and Min price reached in every trade Indicator / EA 4 replies

Indicator for max/min increasing and decreasing? 1 reply

15 min indicator on 5 min chart 3 replies

Previous day min and max lines 4 replies

How can I capture an indicator's max/min values?

  • #1
  • First Post: Sep 7, 2012 6:09am Sep 7, 2012 6:09am
Hi,

Suppose that I want to use WPR indicator whose output values that varies between 0 and 100 but I want to capture that max value and the min value within a predefined lookback of 300 blocks Eg max values achieved = -5 min value achieved = - 87

Now how could I do that ???
  • #2
  • Sep 7, 2012 7:53am Sep 7, 2012 7:53am
Quoting lucklogic
Hi,

Suppose that I want to use WPR indicator whose output values that varies between 0 and 100 but I want to capture that max value and the min value within a predefined lookback of 300 blocks Eg max values achieved = -5 min value achieved = - 87

Now how could I do that ???
There might be a better way but one way to do it would be to use an array. Put the values into an array then sort them, then you would have your minimum and maximum value within a given range of bars.
  • #3
  • Sep 7, 2012 8:05am Sep 7, 2012 8:05am
Quoting cyber1
There might be a better way but one way to do it would be to use an array. Put the values into an array then sort them, then you would have your minimum and maximum value within a given range of bars.
Yes, your right, I could do that but this may consume resources.

Is there not a more elegant way ?
  • #4
  • Sep 7, 2012 8:45am Sep 7, 2012 8:45am
huh?

why can't you just initially assign the min and max to the first item in your range of bars you care about and then change the min/max if you find a value somewhere else within the range of bars that exceeds your current min/max value?

store the bar position (bar time, or bars from the current bar, etc) that has the min or max value, as each new bar starts you check if the min/max bar position has been pushed outside of the range of bars you are tracking and if so you re-run the above test to re-find the min/max. or if a newly finished bar exceeds the currently known min/max vals then you just update your min/max val and bar position with this new value as you already know it is the new min or max in the range you are tracking.

most of the time nothing should be happening apart from just checking if your last found vals still sit within the range of bars you care about, and then occasionally one of the vals will fall out the back of your testing range and so you have to re-scan the range again to find its min or max, or a new bar will exceed the current vals and you are updating 2 vars.

the occasional times your min or max bar falls out the back of your bar range are the only times you get hit with having to re-scan the entire bar range.
Congratulations ScalaFX for coming out of the closet!
  • #5
  • Sep 7, 2012 9:38am Sep 7, 2012 9:38am
Actually while surfing.......... Thanks to geHeitMan


//--- input parameters
extern double = vv // Value that I am interested in, could be anything

extern int BarsBack=100;

int Min;

//only run on new bars
static datetime bar;
if (bar == Time[0])
return(0);
bar = Time[0];

//reset our counters
Min = 0;
Max =0;

//look back at our last BarsBack bars
for (int x=0;x<BarsBack;x++) {

if (Close[x+1] > Max){
Max = vv;
}

if (Close[x+1] < Min){
Max = vv;
}

And that's basically a solution incorporating the last two ideas using comparisons and arrays

Thank you
  • #6
  • Sep 7, 2012 9:52am Sep 7, 2012 9:52am
Quoting lucklogic
Actually while surfing.......... Thanks to geHeitMan


//--- input parameters
extern double = vv // Value that I am interested in, could be anything

extern int BarsBack=100;

int Min;

//only run on new bars
static datetime bar;
if (bar == Time[0])
return(0);
bar = Time[0];

//reset our counters
Min = 0;
Max =0;

//look back at our last BarsBack bars
for (int x=0;x<BarsBack;x++) {

if (Close[x+1] > Max){
Max = vv;
}

if (Close[x+1] < Min){
Max = vv;...
except that it's entirely inefficient which is what you seemed to be concerned about in the first place. this is just the basic searching of a high and low in a series of values every time a new bar forms when you can optimize it like i suggested.
Congratulations ScalaFX for coming out of the closet!
  • #7
  • Sep 8, 2012 3:49am Sep 8, 2012 3:49am
Thanks to NeoTrader ;

double MyMax, MyMin;
int LookBack = 100;
double WprArray[];

for ( i=0; i<=LookBack; i++) {
WprArray[i] = Call to your WPR Indicator shift = i;
MyMax = MathMax(MyMax, WprArray[i]);
MyMin = MathMin(MyMin, WprArray[i]);
}
  • #8
  • Sep 8, 2012 4:54pm Sep 8, 2012 4:54pm
Quoting lucklogic
Thanks to NeoTrader ;

double MyMax, MyMin;
int LookBack = 100;
double WprArray[];

for ( i=0; i<=LookBack; i++) {
WprArray[i] = Call to your WPR Indicator shift = i;
MyMax = MathMax(MyMax, WprArray[i]);
MyMin = MathMin(MyMin, WprArray[i]);
}
so that is totally wrong...

if you aren't a coder then you shouldn't come into the tech section asking coding questions without explaining that you have no idea what you are doing i.e. help others to help you. if you are a coder then it makes no sense that you would not see the problems with the solutions you have apparently found elsewhere.

your question is extremely basic but your 'solutions' so far are all anti-patterns / broken. anyway, you'll figure it out. fairly sure my answer was what you were after, but . i suspect your current 'solution' will sooner or later start producing erroneous results, despite also being an anti-pattern anyway in the first place.
Congratulations ScalaFX for coming out of the closet!
  • #9
  • Sep 9, 2012 2:21am Sep 9, 2012 2:21am
Quoting nubcake
so that is totally wrong...

if you aren't a coder then you shouldn't come into the tech section asking coding questions without explaining that you have no idea what you are doing i.e. help others to help you. if you are a coder then it makes no sense that you would not see the problems with the solutions you have apparently found elsewhere.

your question is extremely basic but your 'solutions' so far are all anti-patterns / broken. anyway, you'll figure it out. fairly sure my answer was what you were after, but . i suspect your...
Oh No the solution that I have posted works perfectlyn

I can see why so many others have a problem with you - you come across as a rude Know it all git ......................but I'd say all mouth and no trousers

Get a life you twat
  • #10
  • Sep 9, 2012 4:47am Sep 9, 2012 4:47am
Nubcake has never been one to suffer fools gladly. It is unfortunate that they do no appreciate his honesty.
  • #11
  • Last Post: Sep 9, 2012 1:19pm Sep 9, 2012 1:19pm
Quoting euclid
Nubcake has never been one to suffer fools gladly. It is unfortunate that they do no appreciate his honesty.
nailed it. thank you.

lucklogic, glad your solution 'works'... for now. you could have listened to some advice and maybe learned something pretty basic. i've only been doing this on and off for over 20 years now, but whatever. you clearly know what you are doing and i'm just some mental midget with no clue, right? i'm putting you on ignore and i suggest you do the same with myself. i don't like wasting time on those who can't even help themselves, and you are now all out of credit, buddy.

your slapped-together few lines of code is wrong. it is also broken. so few lines and yet it is totally busted. it is also the antithesis of what you bothered asking for in this thread. that takes talent. i think whoever gave you this 'solution' is trolling you, and doing a good job of it and they deserve a prize. it's actually amusing. if you give enough of a damn you'll look into it and figure it out, or you can just let it be and let it hopefully break on you someday.

all mouth no trousers... lol, that is cute. here, let me try.... how ironic, mr lucklogic, that your solution appears to be all luck and no logic.

gone.
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now