Can't find the logic error in this simple code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

help to reveal logic of ex4 code? 1 reply

How to code this logic? 7 replies

Logic Question on Trade Exit Code 4 replies

What's your basic logic/philosophy for trading in simple words? 6 replies

Code or Logic for identifying non retraced movement of X Pips 0 replies

Attachments: Can't find the logic error in this simple code
Exit Attachments

Can't find the logic error in this simple code

  • #1
  • First Post: Sep 7, 2012 2:47pm Sep 7, 2012 2:47pm
Inserted Code
datetime last_rvalue_routine = 0;

int rv[10][6];

int init()
{

        ArrayInitialize(rv, 2);

        return(0);

}

void RValueRoutine()
{
   int i, j;
   if (iTime(NULL, PERIOD_M1, 1) != last_rvalue_routine)
   {
      last_rvalue_routine = iTime(NULL, PERIOD_M1, 1);

      for (i = 9; i >= 1; i--)
      {
         for (j = 0; j <= 5; j++)
            rv[i][j] = rv[i-1][j];
      }

      rv[0][0] = RValue(PERIOD_M1);
      rv[0][1] = RValue(PERIOD_M5);
      rv[0][2] = RValue(PERIOD_M15);
      rv[0][3] = RValue(PERIOD_M30);
      rv[0][4] = RValue(PERIOD_H1);
      rv[0][5] = RValue(PERIOD_H4);
   }

   return;
}

The function RValueRoutine() is called from start(), and it's supposed to run every 1 minute bar (and it does).

This part below is supposed to copy the rows from 0 to 9 (row 0 goes to row 1, row 1 goes to row 2, etc, but in the inverse way, so that the 0th row doesn't override all the others), and so it always overrides the last row every time it's run.

Inserted Code
 for (i = 9; i >= 1; i--)
      {
         for (j = 0; j <= 5; j++)
            rv[i][j] = rv[i-1][j];
      }

This part below puts the values of the function RValue() for the given period in the first row of the 2-dimensional array rv.

Inserted Code
rv[0][0] = RValue(PERIOD_M1);
      rv[0][1] = RValue(PERIOD_M5);
      rv[0][2] = RValue(PERIOD_M15);
      rv[0][3] = RValue(PERIOD_M30);
      rv[0][4] = RValue(PERIOD_H1);
      rv[0][5] = RValue(PERIOD_H4);

So my goal with this was to gradually (1 time per minute bar) fill the 2-dimensional array rv with the values of the function RValue(). In the first time the function ran, only the first row would have values different from 2. On the 2nd time, both the 1st and 2nd row would have values different than 2, etc... But what happens is that the 0th row overrides all the others every time this code runs, so I get a matrix with equal rows... I seriously can't find the logic error here..
  • #2
  • Sep 7, 2012 4:50pm Sep 7, 2012 4:50pm
Quoting Jasus
But what happens is that the 0th row overrides all the others every time this code runs, so I get a matrix with equal rows... I seriously can't find the logic error here..
I wrote the following script, to prove the correctness of your shift routine:
Inserted Code
  int rv[10][6];
  ArrayInitialize(rv, 2);

  // dump array content to display string.....
  string d="";
  for (i=0; i<10; i++)
    for (j=0; j<6; j++)
      d=d+DoubleToStr(rv[i][j],0)+" ";

  // populate array with unique values to test the shift routine.....
  for (int i=0; i<10; i++)
    for (int j=0; j<6; j++)
      rv[i][j]=i*10+j;

  // dump array content, and append result to display string.....
  d=d+"n";
  for (i=0; i<10; i++)
    for (j=0; j<6; j++)
      d=d+DoubleToStr(rv[i][j],0)+" ";

  // your shift routine.....
  for (i = 9; i >= 1; i--)  {
     for (j = 0; j <= 5; j++)
        rv[i][j] = rv[i-1][j];
  }

  // dump array content, and append result to display string.....
  d=d+"n";
  for (i=0; i<10; i++)
    for (j=0; j<6; j++)
      d=d+DoubleToStr(rv[i][j],0)+" ";

  // display the display string......
  MessageBox(d);
The result tells me that it's shifting the values correctly (see screenshot), hence any problem must lie elsewhere. That's as far as I can take this test, given the code that you posted.

You might like to download the debugging tools offered by 7bit here, which allows registers in indicators to be easily dumped and viewed; a big improvement over using MQL4's Comment(), Print(), etc. Then simply insert log() statements at strategic points in your code. You'll soon find where any error is.
Attached Image (click to enlarge)
Click to Enlarge Name: 2012-09-08_0951.png Size: 11 KB
  • #3
  • Last Post: Sep 7, 2012 5:36pm Sep 7, 2012 5:36pm
Quoting hanover
I wrote the following script, to prove the correctness of your shift routine:
[code]
int rv[10][6];
ArrayInitialize(rv, 2);

// dump array content to display string.....
string d="";
for (i=0; i<10; i++)
for (j=0; j<6; j++)
d=d+DoubleToStr(rv[i][j],0)+" ";

// populate array with unique values to test the shift routine.....
for (int i=0; i<10; i++)
for (int j=0; j<6; j++)
rv[i][j]=i*10+j;

// dump array content, and append result to display string.....
d=d+"n";
for (i=0; i<10; i++)...
Nice, that confirms there is no problem in that loop... I'm gonna use those tools to try to find the problem out, thanks a lot for all the work
0 traders viewing now